Re: plasma-systemmonitor in kdereview

2020-11-04 Thread Arjen Hiemstra 
On Thursday, 1 October 2020 14:11:16 CET Harald Sitter wrote:
> 
> Cool stuff.
> 
> L10n is currently a bit incomplete.
> Notably
> - the pages files lack any localization at all and I'm also not sure how
> those could be best localized.

As an update to this, this should be fixed for 5.21. The pages are now treated 
as desktop files and include the translations once things have been extracted.

Since that was as far as I know the last major issue raised during review and 
we did the release yesterday it has now been moved to Plasma proper.

Thank you everyone who reviewed.

- Arjen

> 
> HS

D22846: Port KeyboardLayout component to use generated DBus interface

2020-11-04 Thread Andrey Butirsky 
bam added a comment.


  Does it mean we now have to manually synchronize DBus API here in .xml and on 
KWin side?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22846

To: davidedmundson, #plasma, broulik
Cc: bam, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22846: Port KeyboardLayout component to use generated DBus interface

2020-11-04 Thread Méven Car 
meven added a comment.


  In D22846#676700 , @bam wrote:
  
  > Does it mean we now have to manually synchronize DBus API here in .xml and 
on KWin side?
  
  
  Only if the API breaks (which is pretty much guaranteed not to happen) or we 
need a need field / function from the API.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22846

To: davidedmundson, #plasma, broulik
Cc: meven, bam, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.15 - Build # 479 - Failure!

2020-11-04 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.15/479/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Thu, 05 Nov 2020 07:10:20 +
 Build duration:
4 min 54 sec and counting
   CONSOLE OUTPUT
  [...truncated 2861 lines...][2020-11-05T07:14:59.960Z] [ 50%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwinscreenedgeconfigform.cpp.o[2020-11-05T07:15:00.220Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/atoms.cpp.o[2020-11-05T07:15:00.221Z] [ 51%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwin_effects_interface.cpp.o[2020-11-05T07:15:00.221Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/client_machine.cpp.o[2020-11-05T07:15:00.221Z] [ 51%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/desktopsmodel.cpp.o[2020-11-05T07:15:00.789Z] [ 51%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/kcm.cpp.o[2020-11-05T07:15:01.403Z] [ 51%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwinswitcheffectsettings.cpp.o[2020-11-05T07:15:01.403Z] [ 51%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kwinscreenedgedata.cpp.o[2020-11-05T07:15:01.715Z] [ 51%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/effectsfilterproxymodel.cpp.o[2020-11-05T07:15:01.715Z] [ 51%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwinpluginssettings.cpp.o[2020-11-05T07:15:01.715Z] [ 51%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/virtualdesktops.cpp.o[2020-11-05T07:15:01.715Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/clockskewnotifier.cpp.o[2020-11-05T07:15:02.010Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/clockskewnotifierengine.cpp.o[2020-11-05T07:15:02.304Z] [ 51%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/scripting/scripting_logging.cpp.o[2020-11-05T07:15:02.589Z] [ 51%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/scripting/scriptingutils.cpp.o[2020-11-05T07:15:02.854Z] [ 51%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwintouchscreendata.cpp.o[2020-11-05T07:15:02.854Z] [ 51%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwintouchscreensettings.cpp.o[2020-11-05T07:15:02.854Z] [ 51%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kwinscreenedgesettings.cpp.o[2020-11-05T07:15:02.854Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/colorcorrectdbusinterface.cpp.o[2020-11-05T07:15:03.145Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.15/colorcorrection/clockskewnotifierengine.cpp:15:67: warning: unused parameter 'parent' [-Wunused-parameter][2020-11-05T07:15:03.145Z] ClockSkewNotifierEngine *ClockSkewNotifierEngine::create(QObject *parent)[2020-11-05T07:15:03.145Z]   ^[2020-11-05T07:15:03.145Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/manager.cpp.o[2020-11-05T07:15:03.145Z] 1 warning generated.[2020-11-05T07:15:03.145Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/colorcorrection/suncalc.cpp.o[2020-11-05T07:15:03.145Z] [ 51%] Linking CXX shared module ../../bin/kcm_kwintabbox.so[2020-11-05T07:15:03.780Z] [ 51%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwintouchscreenscriptsettings.cpp.o[2020-11-05T07:15:03.780Z] [ 51%] Built target kcm_kwintabbox[2020-11-05T07:15:03.780Z] [ 51%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/kwinscreenedgescriptsettings.cpp.o[2020-11-05T07:15:03.780Z] [ 51%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_abstract_client.cpp.o[2020-11-05T07:15:05.254Z] [ 51%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_effectshandler.cpp.o[2020-11-05T07:15:05.254Z] [ 51%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/virtualdesktopssettings.cpp.o[2020-11-05T07:15:05.254Z] [ 51%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_screens.cpp.o[2020-11-05T07:15:05.549Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/composite.cpp.o[2020-11-05T07:15:05.549Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/cursor.cpp.o[2020-11-05T07:15:05.549Z] [ 51%] Linking CXX shared module ../../bin/kcm_kwin_effects.so[2020-11-05T07:15:05.826Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/dbusinterface.cpp.o[2020-11-05T07:15:05.826Z] [ 51%] Built target kcm_kwin_effects[2020-11-05T07:15:05.826Z] [ 51%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/mock_workspace.cpp.o[2020-11-05T07:15:06.114Z] [ 51%] Linking CXX shared module ../../bin/kcm_kwintouchscreen.so[2020-11-05T0

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.15 - Build # 455 - Failure!

2020-11-04 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.15/455/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Thu, 05 Nov 2020 07:10:20 +
 Build duration:
22 min and counting
   CONSOLE OUTPUT
  [...truncated 2863 lines...][2020-11-05T07:31:42.530Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxHandler.dir/__/__/tabbox/tabbox_logging.cpp.o[2020-11-05T07:31:44.471Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxHandler.dir/__/__/tabbox/tabboxconfig.cpp.o[2020-11-05T07:31:44.471Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxHandler.dir/__/__/tabbox/tabboxhandler.cpp.o[2020-11-05T07:31:44.471Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxClientModel.dir/__/__/tabbox/tabbox_logging.cpp.o[2020-11-05T07:31:44.746Z] [ 50%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/main.cpp.o[2020-11-05T07:31:44.746Z] [ 50%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/mock_effectshandler.cpp.o[2020-11-05T07:31:45.704Z] [ 50%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/thumbnailitem.cpp.o[2020-11-05T07:31:45.970Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxClientModel.dir/__/__/tabbox/tabboxconfig.cpp.o[2020-11-05T07:31:46.920Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxClientModel.dir/__/__/tabbox/tabboxhandler.cpp.o[2020-11-05T07:31:47.495Z] [ 50%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/test_plugin_effectloader.cpp.o[2020-11-05T07:31:48.438Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxHandler.dir/mock_tabboxclient.cpp.o[2020-11-05T07:31:48.438Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxHandler.dir/mock_tabboxhandler.cpp.o[2020-11-05T07:31:49.373Z] [ 50%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwintabboxconfigform.cpp.o[2020-11-05T07:31:50.332Z] [ 50%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwintabboxdata.cpp.o[2020-11-05T07:31:50.332Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxHandler.dir/test_tabbox_handler.cpp.o[2020-11-05T07:31:50.332Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxClientModel.dir/mock_tabboxclient.cpp.o[2020-11-05T07:31:52.352Z] [ 50%] Generating virtualdesktopssettings.h, virtualdesktopssettings.cpp[2020-11-05T07:31:52.352Z] [ 50%] Generating virtualdesktopssettings.moc[2020-11-05T07:31:52.352Z] [ 50%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwin_effects_interface.cpp.o[2020-11-05T07:31:52.352Z] Scanning dependencies of target kcm_kwin_virtualdesktops[2020-11-05T07:31:52.618Z] [ 50%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/kcm_kwin_virtualdesktops_autogen/mocs_compilation.cpp.o[2020-11-05T07:31:52.618Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxClientModel.dir/mock_tabboxhandler.cpp.o[2020-11-05T07:31:52.878Z] [ 50%] Linking CXX executable ../bin/testPluginEffectLoader[2020-11-05T07:31:53.826Z] [ 50%] Built target testPluginEffectLoader[2020-11-05T07:31:53.826Z] Scanning dependencies of target kcm_kwin_effects[2020-11-05T07:31:53.826Z] [ 50%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/kcm_kwin_effects_autogen/mocs_compilation.cpp.o[2020-11-05T07:31:54.776Z] [ 50%] Linking CXX executable ../../bin/testTabBoxHandler[2020-11-05T07:31:55.034Z] [ 50%] Building CXX object autotests/tabbox/CMakeFiles/testTabBoxClientModel.dir/test_tabbox_clientmodel.cpp.o[2020-11-05T07:31:55.600Z] [ 50%] Built target testTabBoxHandler[2020-11-05T07:31:55.600Z] [ 51%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/kcm.cpp.o[2020-11-05T07:31:55.600Z] [ 51%] Building C object CMakeFiles/kwin.dir/3rdparty/xcursor.c.o[2020-11-05T07:31:56.176Z] [ 51%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwintabboxsettings.cpp.o[2020-11-05T07:31:56.176Z] [ 51%] Building CXX object CMakeFiles/kwin.dir/abstract_client.cpp.o[2020-11-05T07:31:57.171Z] [ 51%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/__/__/virtualdesktopsdbustypes.cpp.o[2020-11-05T07:31:57.743Z] [ 51%] Building CXX object kcmkwin/kwindesktop/CMakeFiles/kcm_kwin_virtualdesktops.dir/animationsmodel.cpp.o[2020-11-05T07:31:58.682Z] [ 51%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwinswitcheffectsettings.cpp.o[2020-11-05T07:31:58.944Z] [ 51%] Linking CXX executable ../../bin/testTabBoxClientModel[2020-11-05T07:31:59.891Z] [ 51%] Built target testTabBoxClientModel[2020-11-05T07:31:59.891Z] [ 51%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kwinpluginssettings.cpp.o[2020-11-05T07:32:00.155Z] [ 51%] Building CXX object kcmkwin/kwineffects/CMakeFiles/kcm_kwin_effects.dir/effectsfilterproxymo

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.15 - Build # 480 - Still unstable!

2020-11-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.15/480/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Thu, 05 Nov 2020 07:15:17 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 15 test(s), Passed: 99 test(s), Skipped: 0 test(s), Total: 114 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testInputMethodFailed: projectroot.autotests.integration.kwin_testInputMethod_waylandonlyFailed: projectroot.autotests.integration.kwin_testKeyboardLayoutFailed: projectroot.autotests.integration.kwin_testKeyboardLayout_waylandonlyFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testPointerInputFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXdgShellClientFailed: projectroot.autotests.integration.kwin_testXdgShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 5 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimationFailed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimation_waylandonlyFailed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucency