[Differential] [Request, 13 lines] D3425: If we get a notification with no body, treat the subject line as the body
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 372112 TEST PLAN notify-send "This long title that goes on and on" - wrapped with no title notify-send "subject1" "msg1" notify-send "subject1" "msg2" - appeared as one message with two lines notify-send "subject2" "msg1" notify-send "subject3" "msg2" - appeared as two notifications REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3425 AFFECTED FILES dataengines/notifications/notificationsengine.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Review Request 129436: Check for metadata validty in settingsFileChanged
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129436/ --- Review request for Plasma. Repository: plasma-framework Description --- settingsFileChanged is called if the plugin metadata file changes, and reloads the theme if the version changes. However, if the metadata file now doesn't exist we need to check before calling .version() otherwise it will assert. If it doesn't exist, we want to reload the theme so that it will load the correct thing. BUG: 372651 Diffs - src/plasma/private/theme_p.cpp 0f3662e8f58c8cccdf9af2b8cf6878f5f0cef10b Diff: https://git.reviewboard.kde.org/r/129436/diff/ Testing --- Thanks, David Edmundson
