Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-04 Thread Antonio Rojas 


> On Sept. 2, 2016, 6:17 p.m., Fabian Vogt wrote:
> > IMO you should use the same method as sddm, which is hardcoded at configure 
> > time: "@DATA_INSTALL_DIR@/themes".
> 
> Wolfgang Bauer wrote:
> I agree.
> This change will still make it use ~/.local/share/sddm/themes/ if it 
> should exist for some reason, and ignore /usr/share/sddm/themes/ in that case.
> 
> Or use QStandardPaths::locateAll(), but sddm only looks in 
> "@DATA_INSTALL_DIR@/themes" anyway and will not load themes from 
> ~/.local/share or other $XDG_DATA_DIRS locations.

Wouldn't this break if plasma is installed in a custom prefix?


- Antonio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128815/#review98833
---


On Sept. 2, 2016, 5:51 p.m., Antonio Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128815/
> ---
> 
> (Updated Sept. 2, 2016, 5:51 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> ---
> 
> SDDM 0.14 apparently creates a ~/.local/share/sddm dir to store some logs, 
> which makes sddm-kcm look for themes there instead of /usr/share/sddm
> Additionally, fix the config key for themes dir in sddm.conf
> 
> 
> Diffs
> -
> 
>   src/themesmodel.cpp 5af9c54 
> 
> Diff: https://git.reviewboard.kde.org/r/128815/diff/
> 
> 
> Testing
> ---
> 
> Themes list works again with SDDM 0.14
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-04 Thread David Edmundson 


> On Sept. 2, 2016, 6:17 p.m., Fabian Vogt wrote:
> > IMO you should use the same method as sddm, which is hardcoded at configure 
> > time: "@DATA_INSTALL_DIR@/themes".
> 
> Wolfgang Bauer wrote:
> I agree.
> This change will still make it use ~/.local/share/sddm/themes/ if it 
> should exist for some reason, and ignore /usr/share/sddm/themes/ in that case.
> 
> Or use QStandardPaths::locateAll(), but sddm only looks in 
> "@DATA_INSTALL_DIR@/themes" anyway and will not load themes from 
> ~/.local/share or other $XDG_DATA_DIRS locations.
> 
> Antonio Rojas wrote:
> Wouldn't this break if plasma is installed in a custom prefix?

Effectively it's the exact same problem in two different ways.

Either kcm-sddm has to be *compiled* with the same setup as SDDM was installed 
or kcm-sddm has to be *run* with the same setup (XDG_DATA_DIRS) as SDDM was 
installed. 

In both cases the default matches SDDM, but can be different if SDDM/plasma has 
a different CMAKE_INSTALL_PREFIX.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128815/#review98833
---


On Sept. 2, 2016, 5:51 p.m., Antonio Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128815/
> ---
> 
> (Updated Sept. 2, 2016, 5:51 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> ---
> 
> SDDM 0.14 apparently creates a ~/.local/share/sddm dir to store some logs, 
> which makes sddm-kcm look for themes there instead of /usr/share/sddm
> Additionally, fix the config key for themes dir in sddm.conf
> 
> 
> Diffs
> -
> 
>   src/themesmodel.cpp 5af9c54 
> 
> Diff: https://git.reviewboard.kde.org/r/128815/diff/
> 
> 
> Testing
> ---
> 
> Themes list works again with SDDM 0.14
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

[Differential] [Commented On] D2645: make sure the vertical systary size hints are fixed

2016-09-04 Thread mart (Marco Martin) 
mart added a comment.


  In https://phabricator.kde.org/D2645#49198, @davidedmundson wrote:
  
  > Why is it needed?
  >
  > the panel containment is a layout - the system tray's current only size 
hint is minimum and it doesn't have a Layout.fillHeight - which means any other 
item which does have a fillHeight: true will force this system tray to it's 
minimum size. Effectively what this patch is doing.
  >
  > if no item with fillHeight exists, the panel will create a spacer 
(panel.qml checkLastSpacer) with Layout.fillHeight=true
  >  so we can always be sure (in theory) that something in that layout does 
have that.
  
  
  unfortunately seems to be needed in vertical panels.
  the taskbar should have fillHeight, and indeed scales correctly, without 
setting the maximum height, the systray gets stretched as well (i can reproduce 
the screenshot attached to https://bugs.kde.org/show_bug.cgi?id=368146) can you 
try locally if it reproduces for you?
  
  it tries to stretch the systray a bit (not huge, just a tad too much) never 
the less, hmm maybe preferredwidth defaults to too much?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2645

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Is it possible to know the panel's anchoring?

2016-09-04 Thread Marco Martin 
On Sat, Sep 3, 2016 at 1:28 PM, Michail Vourlakos  wrote:
> Kai, I dont think so...
> panel.location describes where the panel is placed,
> bottom, top, left, right. Not how it is anchored,
>
> for example a panel is placed at left but is anchored at
> bottom... The bottom value can not be accessed from
> panel.location. is it?



no, the panel alignment 9and position in pixels) are properties of the
view rather than the containment, so is not accepssible from there
(from a c++ component it could try to blindly read properties from its
view, but eew)

--
Marco Martin

[Differential] [Commented On] D2645: make sure the vertical systary size hints are fixed

2016-09-04 Thread davidedmundson (David Edmundson) 
davidedmundson added a comment.


  Yes I can reproduce the bug. And I even downloaded this and confirm that then 
i can't reproduce it.
  
  But that doesn't answer my question.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2645

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Re: Copy Activity - Create Activity by template?

2016-09-04 Thread Marco Martin 
On Sat, Sep 3, 2016 at 2:18 PM, Michail Vourlakos  wrote:
> Hello everyone,
>
> I received from one my users a question:
>
> "I like your plasmoid but I want to use it with many of my activities but I
> dont want its defaults, is there a way to set its defaults once and be kept
> in ordet to be used whenever I add your plasmoid?"


he could add a  default setup javascrpit file in the look and
feelpackage he's using.
a proper named javascript file is executed every time a plasmoid is
added, this is designed for distributions that want to have a
different default or the plasmoid.

(in look and feel package, plasmoidsetupscripts/plasmoidpluginname.js)
for instance 
~/.local/share/plasma/look-and-feel/org.kde.test/contents/plasmoidsetupscripts/org.kde.plasma.analogclock.js

--
Marco Martin

[Differential] [Request, 13 lines] D2648: [Runners KCM] Fix painting delegates in right-to-left layout

2016-09-04 Thread broulik (Kai Uwe Broulik) 
broulik created this revision.
broulik added reviewers: Plasma, safaalfulaij.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
kcmshell5 plasmasearch -reverse
  
  Text is no longer rendered ontop of the icons.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2648

AFFECTED FILES
  kcms/runners/kcm.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, safaalfulaij
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128819: grid layout for windowdecoration KCM

2016-09-04 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128819/#review98861
---



good direction, commenting on some QML code style issues


kcmkwin/kwindecoration/qml/Previews.qml (line 29)


remove whitespace



kcmkwin/kwindecoration/qml/Previews.qml (line 31)


don't call it listView if it's not a ListView anymore



kcmkwin/kwindecoration/qml/Previews.qml (line 42)


width and height shouldn't be needed at all in the highlight element



kcmkwin/kwindecoration/qml/Previews.qml (line 51)


this may lead to things lookng blurry as not being aligned to pixel grid 
anymore.
the delegate itself should be as big as cellWidth/height
then the contents inside may have a margin.
for instance using units.smallSpacing



kcmkwin/kwindecoration/qml/Previews.qml (line 110)


wrong indentation


- Marco Martin


On Sept. 3, 2016, 2:55 p.m., Andreas Kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128819/
> ---
> 
> (Updated Sept. 3, 2016, 2:55 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> change the list layout to a grid layout and move the config button to the 
> preview.
> 
> 
> Diffs
> -
> 
>   kcmkwin/kwindecoration/qml/Previews.qml a146f86 
> 
> Diff: https://git.reviewboard.kde.org/r/128819/diff/
> 
> 
> Testing
> ---
> 
> qml file was tested on my system.
> 
> 
> this is my first qml patch so be careful.
> 
> 
> File Attachments
> 
> 
> window decoration kcm update
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/03/91a3acab-b2c7-43d5-9f44-7ed71c1267fb__Screenshot_20160903_165718.png
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

[Differential] [Commented On] D2534: [Desktop View] Place Plasma sidebars at the right screen edge in right-to-left mode

2016-09-04 Thread broulik (Kai Uwe Broulik) 
broulik added a comment.


  The height of the dialog updates just fine (it's on the mainItem and not 
dialog itself) with the binding but indeed the X and Y binding just break at 
some point.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2534

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, safaalfulaij
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D2645: make sure the vertical systary size hints are fixed

2016-09-04 Thread mart (Marco Martin) 
mart added a comment.


  In https://phabricator.kde.org/D2645#49268, @davidedmundson wrote:
  
  > Yes I can reproduce the bug. And I even downloaded this and confirm that 
then i can't reproduce it.
  >
  > But that doesn't answer my question.
  
  
  the hints of the applet seems sane.
  minimumHeight is the proper size (114 px in my case) preferredHeight -1 (that 
should be ok) and maximumHeight infinity (that should be ok)
  but i guess as most applets have both min and max defined, the layout decides 
to stretch this one, as it's allowed (since maximum height it's infonite)
  i'm surprised that the only one that gets stretched isn't the taskbar as is 
the on.y one to be explicitly fillHeight

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2645

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2648: [Runners KCM] Fix painting delegates in right-to-left layout

2016-09-04 Thread mart (Marco Martin) 
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2648

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, safaalfulaij, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2645: make sure the vertical systary size hints are fixed

2016-09-04 Thread davidedmundson (David Edmundson) 
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  You don't need to guess, the code is open source...
  
  Here is the reason.
  
  panel/main.qml
  
  the container has:
  
Layout.preferredHeight: (!currentLayout.isLayoutHorizontal ? (applet && 
applet.Layout.preferredHeight > 0 ? applet.Layout.preferredHeight : root.width) 
: root.height)
  
  This means that even though the system tray has no preferredHeight, the 
container, which is what the layout sees does.  The layout will fit an item to 
fit it's preferred height before it will let another item fill height.
  
  basically making all trays square if they don't specify anything else.
  
  Put that in the commit message and use you can ship this; though setting the 
preferredHeight is probably more correct.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  phab/systrayvertical

REVISION DETAIL
  https://phabricator.kde.org/D2645

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 50 lines] D2534: [Desktop View] Place Plasma sidebars at the right screen edge in right-to-left mode

2016-09-04 Thread broulik (Kai Uwe Broulik) 
broulik updated this revision to Diff 6417.
broulik added a comment.


  Fix bindings and cleanup a bit

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2534?vs=6154&id=6417

REVISION DETAIL
  https://phabricator.kde.org/D2534

AFFECTED FILES
  desktoppackage/contents/views/Desktop.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, safaalfulaij
Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Powerdevil] [Bug 353032] Add ability to set screen brightness for non-laptop displays so I can adjust to the room's lighting

2016-09-04 Thread Kai Uwe Broulik via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=353032

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik  ---
Thanks for the tip with xrandr brightness, I only knew using DDC (which I made
an experimental backend for). However, PowerDevil (or Plasma in general) is
currently in no way equipped to handle multiple brightness controls.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Updated, 29 lines] D2033: Clear idle timeouts when session becomes inactive

2016-09-04 Thread broulik (Kai Uwe Broulik) 
broulik updated this revision to Diff 6418.
broulik added a comment.


  Cleanup patch a bit

REPOSITORY
  rPOWERDEVIL Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2033?vs=4822&id=6418

REVISION DETAIL
  https://phabricator.kde.org/D2033

AFFECTED FILES
  daemon/powerdevilcore.cpp
  daemon/powerdevilpolicyagent.cpp
  daemon/powerdevilpolicyagent.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, oliverhenshaw, sebas, #plasma
Cc: sebas, oliverhenshaw, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts

[Differential] [Request, 25 lines] D2652: Let the application control the menu further

2016-09-04 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Introduces a property so that triggering leaf categories doesn't change the
  state of the menu.
  Introduces a function so the application can reset the menu to its initial 
state

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2652

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel

[Differential] [Request, 21 lines] D2654: AppEntry: load icon on demand, to speed up plasma startup

2016-09-04 Thread dfaure (David Faure) 
dfaure created this revision.
dfaure added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Starting plasmashell. It still takes too long, but now it's in QML stuff ;)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2654

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appentry.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2016-09-04 Thread Emmanuel Pescosta via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=366795

Emmanuel Pescosta  changed:

   What|Removed |Added

 CC||germano.massu...@gmail.com

--- Comment #20 from Emmanuel Pescosta  ---
*** Bug 368237 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 128819: grid layout for windowdecoration KCM

2016-09-04 Thread Andreas Kainz 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128819/
---

(Updated Sept. 4, 2016, 6:37 nachm.)


Review request for kwin and Plasma.


Changes
---

thanks for the review marco I fixed the issues.


Repository: kwin


Description
---

change the list layout to a grid layout and move the config button to the 
preview.


Diffs (updated)
-

  kcmkwin/kwindecoration/qml/Previews.qml a146f86 

Diff: https://git.reviewboard.kde.org/r/128819/diff/


Testing
---

qml file was tested on my system.


this is my first qml patch so be careful.


File Attachments


window decoration kcm update
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/03/91a3acab-b2c7-43d5-9f44-7ed71c1267fb__Screenshot_20160903_165718.png


Thanks,

Andreas Kainz

[Differential] [Accepted] D2654: AppEntry: load icon on demand, to speed up plasma startup

2016-09-04 Thread broulik (Kai Uwe Broulik) 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2654

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 104 lines] D2656: [Kickoff] Lazy load more

2016-09-04 Thread broulik (Kai Uwe Broulik) 
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Neither the apps model nor favorites model is needed initially. Move them to 
the fullRepresentation so they're only loaded as needed.

TEST PLAN
  Favorites still show, adding/removing ones is persistent across reboots. The 
context menus of the apps model and krunner results reflect the favorites state 
correctly.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2656

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml
  applets/kickoff/package/contents/ui/Kickoff.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2652: Let the application control the menu further

2016-09-04 Thread colomar (Thomas Pfeiffer) 
colomar added a comment.


  To provide some context:
  Discover now switched to use the sidebar as a navigation menu, controlling 
which category of applications to show in the main window.
  If clicking a menu item went back to the top level, the menu would not 
correspond to what's shown anymore.
  
  The property is introduced because the default behavior for the menu global 
drawer / sidebar is still executing actions, in which case going back to the 
top menu afterwards makes sense.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2652

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel

[Differential] [Commented On] D2652: Let the application control the menu further

2016-09-04 Thread mart (Marco Martin) 
mart added inline comments.

INLINE COMMENTS

> GlobalDrawer.qml:184
> + */
> +property bool moveUpOnLeafAction: true
> +

resetMenuOnTriggered?
resetOnActionTriggered?

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2652

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: colomar, plasma-devel

[Differential] [Closed] D2645: make sure the vertical systary size hints are fixed

2016-09-04 Thread mart (Marco Martin) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE7b7c680f3a4a: make sure the vertical systary 
size hints are fixed (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2645?vs=6408&id=6430#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2645?vs=6408&id=6430

REVISION DETAIL
  https://phabricator.kde.org/D2645

AFFECTED FILES
  applets/systemtray/container/package/contents/ui/main.qml
  applets/systemtray/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D2654: AppEntry: load icon on demand, to speed up plasma startup

2016-09-04 Thread dfaure (David Faure) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPee2577125c5a: AppEntry: load icon on demand, to 
speed up plasma startup (authored by dfaure).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2654?vs=6426&id=6432

REVISION DETAIL
  https://phabricator.kde.org/D2654

AFFECTED FILES
  applets/kicker/plugin/appentry.cpp
  applets/kicker/plugin/appentry.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 297 - Still Unstable!

2016-09-04 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/297/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Sep 2016 21:36:15 +
Build duration: 7 min 41 sec

CHANGE SET
Revision ee2577125c5ac50ed21e828eb09e63bc6a523d68 by David Faure: (AppEntry: 
load icon on demand, to speed up plasma startup)
  change: edit applets/kicker/plugin/appentry.cpp
  change: edit applets/kicker/plugin/appentry.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2294/3386 
(68%)CONDITIONAL 1537/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 762/1511 
(50%)CONDITIONAL 605/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-04 Thread Antonio Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128815/
---

(Updated Sept. 4, 2016, 11:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Changes
---

Submitted with commit d4ca70001222c5b0a9f699c4639c891a6a5c0c05 by Antonio Rojas 
to branch Plasma/5.7.


Repository: sddm-kcm


Description
---

SDDM 0.14 apparently creates a ~/.local/share/sddm dir to store some logs, 
which makes sddm-kcm look for themes there instead of /usr/share/sddm
Additionally, fix the config key for themes dir in sddm.conf


Diffs
-

  src/themesmodel.cpp 5af9c54 

Diff: https://git.reviewboard.kde.org/r/128815/diff/


Testing
---

Themes list works again with SDDM 0.14


Thanks,

Antonio Rojas

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 193 - Unstable!

2016-09-04 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 04 Sep 2016 21:58:11 +
Build duration: 3 min 21 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

[Differential] [Request, 2 lines] D2658: Fix build failure introduced by the previous commit

2016-09-04 Thread Jan Kundrát 
jkt created this revision.
jkt added a reviewer: broulik.
jkt set the repository for this revision to rPOWERDEVIL Powerdevil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
My compiler complains about an attempted conversion from
QSet::iterator to
QList::iterator.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2658

AFFECTED FILES
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jkt, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 9 lines] D2660: Prefer an algorithm over an explicit for loop

2016-09-04 Thread Jan Kundrát 
jkt created this revision.
jkt added a reviewer: broulik.
jkt set the repository for this revision to rPOWERDEVIL Powerdevil.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2660

AFFECTED FILES
  daemon/powerdevilcore.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jkt, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2660: Prefer an algorithm over an explicit for loop

2016-09-04 Thread Jan Kundrát 
jkt added a dependency: D2658: Fix build failure introduced by the previous 
commit.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2660

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jkt, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2658: Fix build failure introduced by the previous commit

2016-09-04 Thread Jan Kundrát 
jkt added a dependent revision: D2660: Prefer an algorithm over an explicit for 
loop.

REPOSITORY
  rPOWERDEVIL Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D2658

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jkt, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2656: [Kickoff] Lazy load more

2016-09-04 Thread hein (Eike Hein) 
hein added a comment.


  Did you test Dashboard?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2656

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2656: [Kickoff] Lazy load more

2016-09-04 Thread broulik (Kai Uwe Broulik) 
broulik added a comment.


  Dashboard? This is Kickoff, not Kicker

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2656

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Copy Activity - Create Activity by template?

2016-09-04 Thread Michail Vourlakos 

thanks a lot Martin !


he could add a  default setup javascrpit file in the look and
feelpackage he's using.
a proper named javascript file is executed every time a plasmoid is
added, this is designed for distributions that want to have a
different default or the plasmoid.

(in look and feel package, plasmoidsetupscripts/plasmoidpluginname.js)
for instance 
~/.local/share/plasma/look-and-feel/org.kde.test/contents/plasmoidsetupscripts/org.kde.plasma.analogclock.js

--
Marco Martin

Re: Is it possible to know the panel's anchoring?

2016-09-04 Thread Michail Vourlakos 

I see... this is interesting

thanks Martin...



no, the panel alignment 9and position in pixels) are properties of the
view rather than the containment, so is not accepssible from there
(from a c++ component it could try to blindly read properties from its
view, but eew)

--
Marco Martin

[Differential] [Accepted] D2656: [Kickoff] Lazy load more

2016-09-04 Thread hein (Eike Hein) 
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Sorry, brain fart :)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2656

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas