Review Request: Fix orientation of the arrow indicating grouped tasks
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107608/ --- Review request for Plasma. Description --- The new arrow that indicates grouped tasks in the tasks applet has inverted orientation when the panel is in vertical position. I think it makes more sense for the arrow to point left when the panel is at the right edge of the screen and vice versa. Diffs - plasma/desktop/applets/tasks/abstracttaskitem.cpp edf4be7 Diff: http://git.reviewboard.kde.org/r/107608/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Confused on Activities' behaviour in concert with browsers
Hi Antonis, This sounds like a question about Rekonq rather than Plasma, in particular its implementation of activities. You will probably receive a better answer if you post a topic at http://forum.kde.org or ask the Rekonq developers directly. Here are some ways to contact them: http://userbase.kde.org/Rekonq/FAQs#I_have_more_questions.21. In general it's better to use the forums for user questions, the plasma-devel mailing list is mainly for discussions related to Plasma development. Hope that helps, Hans On Wed, Dec 5, 2012 at 8:34 PM, Antonis Kanouras wrote: > Hello, > > I originally asked in #plasma but, after receiving no answer, I took the > courage to post here. Feel free to flame me if it's not the right venue. > > I'm trying out Plasma Activities on KDE SC 4.9.3 (Kubuntu 12.10), and more > specifically, with rekonq. > > I've set it to restore the previously opened tabs at startup and have one > window for each activity, with different tabs open on each. Now, if I quit > rekonq (not just close the window) and start it up again, all its windows > appear on the current activity. > > Is this the expected behaviour? If not, how could I help implement it? > Perhaps > a kwin script? > > Thanks, > Antonis Kanouras > > PS: Please CC any replies to me as I'm not subscribed to the list. > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Change Battery Percentage step of battery plasmoid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107612/ --- Review request for Plasma, Marco Martin and Viranch Mehta. Description --- Current battery plasmoid icon is very confusing when showing the percentage. Currently, 96-100 -> looks like 100 81-95->looks like 80 (looks werid) 50-80->looks like 60 (looks werid) 20->49->looks like 40 10->19->looks like 20 When people see the icon shows as 60, they will expect that whey have lost nearly 40 percent, but actually 70-80 is also covered in this range. And range doesn't split evenly is also a problem. This patch change it to 90-100 looks like 100 70-89 looks like 80 50-69 looks like 60 30-49 looks like 40 10-29 looks like 20 Which IMHO is much better for visual. Diffs - plasma/generic/applets/batterymonitor/contents/ui/BatteryIcon.qml cfb50df Diff: http://git.reviewboard.kde.org/r/107612/diff/ Testing --- No problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasmate release plans?
Heya, since for KDE 4.10 all the Plasma development tools were moved to Plasmate, I wonder whether there are any plans to make an official release of Plasmate together with KDE 4.10. I believe that distributions will be interested in shipping Plasmate, so that KDE developers can keep using tools they were used to. :) Also, could someone please add LICENSE file to Plasmate root dir, so that we can properly package it anyway? ;) Cheers, Dan -- -- dvra...@redhat.com | Associate Software Engineer / BaseOS / KDE, Qt GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change Battery Percentage step of battery plasmoid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107612/#review23073 --- What I dislike about the 20% graphic is that it is red which means when I have 30% left, the icon will already be red indicating soon power outage - Kai Uwe Broulik On Dec. 6, 2012, 2:23 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107612/ > --- > > (Updated Dec. 6, 2012, 2:23 p.m.) > > > Review request for Plasma, Marco Martin and Viranch Mehta. > > > Description > --- > > Current battery plasmoid icon is very confusing when showing the percentage. > > Currently, > 96-100 -> looks like 100 > 81-95->looks like 80 (looks werid) > 50-80->looks like 60 (looks werid) > 20->49->looks like 40 > 10->19->looks like 20 > > When people see the icon shows as 60, they will expect that whey have lost > nearly 40 percent, but actually 70-80 is also covered in this range. > > And range doesn't split evenly is also a problem. > This patch change it to > 90-100 looks like 100 > 70-89 looks like 80 > 50-69 looks like 60 > 30-49 looks like 40 > 10-29 looks like 20 > > Which IMHO is much better for visual. > > > Diffs > - > > plasma/generic/applets/batterymonitor/contents/ui/BatteryIcon.qml cfb50df > > Diff: http://git.reviewboard.kde.org/r/107612/diff/ > > > Testing > --- > > No problem. > > > Thanks, > > Xuetian Weng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/#review23075 --- This review has been submitted with commit f0c019156bf0c21753a8e943fa8945c8841661a0 by Antonis Tsiapaliokas to branch master. - Commit Hook On Nov. 26, 2012, 10:36 a.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107470/ > --- > > (Updated Nov. 26, 2012, 10:36 a.m.) > > > Review request for Plasma. > > > Description > --- > > On this patch i am replace the QRegExp on SigningDialog::validateParams() > with KPIMUtils::isValidSimpleAddress > > > Diffs > - > > plasmate/CMakeLists.txt 111c402 > plasmate/publisher/signingdialog.cpp 395138d > > Diff: http://git.reviewboard.kde.org/r/107470/diff/ > > > Testing > --- > > > Thanks, > > Antonis Tsiapaliokas > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasmate:Remove cmake-install functionality from Publisher
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107512/#review23076 --- This review has been submitted with commit da91a06aa94f8aca5c5728a2ae6221134cd56d05 by Antonis Tsiapaliokas to branch master. - Commit Hook On Nov. 29, 2012, 1:56 p.m., Antonis Tsiapaliokas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107512/ > --- > > (Updated Nov. 29, 2012, 1:56 p.m.) > > > Review request for Plasma. > > > Description > --- > > In this patch the cmake-install functionality is being removed. > When plasmate, is installed under the "/usr", the cmake-install functionality > is causing some issues. > So for the 1.0 release, we are removing the cmake-install functionality. > > > Diffs > - > > plasmate/publisher/publisher.h de5d884 > plasmate/publisher/publisher.cpp 61930fc > plasmate/templates/CMakeLists.txt 64ae27c > plasmate/templates/cmakelists 5cb4dae > plasmate/templates/cmakelistsKWinEffect cd91838 > plasmate/templates/cmakelistsKWinScript 992d4c6 > plasmate/templates/cmakelistsWindowSwitcher 761d043 > > Diff: http://git.reviewboard.kde.org/r/107512/diff/ > > > Testing > --- > > > Thanks, > > Antonis Tsiapaliokas > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make sure ksmserver ignores excluded apps when saving session
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107276/#review23084 --- Sorry for the late reply, I'm not active in KDE anymore (and so I guess this means ksmserver is unmaintained). The patch looks ok, but it makes sense to support 4) as well, so please add || excludeApps.contains( program.toLower()) too and then it's ok. Supporting 3) is most probably a bad idea. - Luboš Luňák On Nov. 10, 2012, 12:45 p.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107276/ > --- > > (Updated Nov. 10, 2012, 12:45 p.m.) > > > Review request for kdelibs, Plasma and Luboš Luňák. > > > Description > --- > > It is easy to understand why the existing code (usually) fails: > > * Users are most likely to just specify short names, like > "dolphin,gwenview,okular,rekonq", instead of > "/usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq" > > * When ksmserver saves the session, it usually gets the full names, like > "/usr/bin/dolphin", unless you have started that dolphin instance by typing > "dolphin" exactly in a shell. > > > So there are four possible combinations : > > 1). config uses short name, runtime gets short name (this guy starts > everything from konsole, never using kio/krun) > 2). config uses short name, runtime gets long name (I think this is the > most common one) > 3). config uses long name, runtime gets short name > 4). config uses long name, runtime gets long name (I guess some users use > this combination because they find only that way works after trying various > workaround...) > > The existing code works with 1) and 4), this patch works with 1) and 2) . I > don't know whether it make senses to support all combinations > > > > > > This addresses bug 242760. > http://bugs.kde.org/show_bug.cgi?id=242760 > > > Diffs > - > > ksmserver/server.cpp eb3ac18 > > Diff: http://git.reviewboard.kde.org/r/107276/diff/ > > > Testing > --- > > > Thanks, > > Jekyll Wu > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
various org.freedesktop.ScreenSaver issues
Hi, Prompted by what seems to be a renewed focus on the org.freedesktop.ScreenSaver interface [1][2][3] I've noticed some problems with the KDE implementation, and have some ideas how to solve them: * ScreenSaver inhibit does not imply powerdevil ChangeScreenSettings (i.e. DPMS) inhibit, and vice versa, * Neither inhibit implies powerdevil InterruptSession (i.e system suspend) inibit, * The Solid::PowerManagement::*SuppressingScreenPowerManagement functions only use the ScreenSaver.Inhibit interface if the powerdevil PolicyAgent interface is present. The first problem is partly obscured by the fact that some third-party ScreenSaver.Inhibit users also turn off DPMS directly - albeit in a way that doesn't work in gnome but currently does in KDE. It seems the pre-4.10 screensaver did check the DPMS status before activating but I'm not sure whether porting over that code is the right solution - it's not a complete solution anyway. This may also mean that ScreenSaver inhibit doesn't prevent powerdevil dimming the screen. The second problem is strictly correct as far as the powerdevil API goes, it's just not very useful[4] - although it's possible to argue that suspending the computer changes screen settings. I can't think of any use case for keeping the screen awake but still auto-suspending the computer after an idle timeout. And it's probably not what users of the ScreenSaver interface want. The third problem simply prevents applications using these functions working as intended in versions of gnome that support the ScreenSaver inhibit interface. So, I propose the following as minimal fixes, hopefully suitable for 4.10: * Have the ksmserver screenlocker pass ScreenSaver inhibits on to powerdevil via the PolicyAgent interface * Possibly have the ksmserver screenlocker check DPMS activation status before activating, although maybe not in a straight port of the krunner screensaver code * Change the powerdevil PolicyAgent to always have ChangeScreenSettings imply InterruptSession (as an alternative, have just the ScreenSaver and Solid::PowerManagement::beginSuppressingScreenPowerManagement use the InterruptSession flag - as I understand it, applications shouldn't be using the kde-namespaced dbus interfaces directly, is that correct?) * Have Solid::PowerManagement::*SuppressingScreenPowerManagement unconditionally call org.freedesktop.ScreenSaver. Further to this, is there any benefit to trying org.kde.Solid.PowerManagement.PolicyAgent first? I'm not sure whether there's any tricky ABI issues in changing the Solid::PowerManagement implementation? I'll have review requests for these proposals, hopefully in the next day or so. Thoughts? Oliver [1] https://bugzilla.gnome.org/show_bug.cgi?id=689225 [2] https://trac.videolan.org/vlc/ticket/7824 [3] https://bugzilla.mozilla.org/show_bug.cgi?id=811261 [4] Very briefly discussed at http://drfav.wordpress.com/2012/01/18/some-news-and-improvements-in-inhibition/#comment-2420 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change Battery Percentage step of battery plasmoid
> On Dec. 6, 2012, 3:17 p.m., Kai Uwe Broulik wrote: > > What I dislike about the 20% graphic is that it is red which means when I > > have 30% left, the icon will already be red indicating soon power outage Yeah, sure, so change that bound to 20? 20 is KDE's default "low battery" threshold. So make it: 20-49 looks like 40 10-19 looks like 20? - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107612/#review23073 --- On Dec. 6, 2012, 2:23 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107612/ > --- > > (Updated Dec. 6, 2012, 2:23 p.m.) > > > Review request for Plasma, Marco Martin and Viranch Mehta. > > > Description > --- > > Current battery plasmoid icon is very confusing when showing the percentage. > > Currently, > 96-100 -> looks like 100 > 81-95->looks like 80 (looks werid) > 50-80->looks like 60 (looks werid) > 20->49->looks like 40 > 10->19->looks like 20 > > When people see the icon shows as 60, they will expect that whey have lost > nearly 40 percent, but actually 70-80 is also covered in this range. > > And range doesn't split evenly is also a problem. > This patch change it to > 90-100 looks like 100 > 70-89 looks like 80 > 50-69 looks like 60 > 30-49 looks like 40 > 10-29 looks like 20 > > Which IMHO is much better for visual. > > > Diffs > - > > plasma/generic/applets/batterymonitor/contents/ui/BatteryIcon.qml cfb50df > > Diff: http://git.reviewboard.kde.org/r/107612/diff/ > > > Testing > --- > > No problem. > > > Thanks, > > Xuetian Weng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Change Battery Percentage step of battery plasmoid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107612/ --- (Updated Dec. 6, 2012, 7:04 p.m.) Review request for Plasma, Marco Martin and Viranch Mehta. Changes --- change the Fill20 icon to show under 20, to align with KDE default "low battery" setting. Description --- Current battery plasmoid icon is very confusing when showing the percentage. Currently, 96-100 -> looks like 100 81-95->looks like 80 (looks werid) 50-80->looks like 60 (looks werid) 20->49->looks like 40 10->19->looks like 20 When people see the icon shows as 60, they will expect that whey have lost nearly 40 percent, but actually 70-80 is also covered in this range. And range doesn't split evenly is also a problem. This patch change it to 90-100 looks like 100 70-89 looks like 80 50-69 looks like 60 30-49 looks like 40 10-29 looks like 20 Which IMHO is much better for visual. Diffs (updated) - plasma/generic/applets/batterymonitor/contents/ui/BatteryIcon.qml cfb50df Diff: http://git.reviewboard.kde.org/r/107612/diff/ Testing --- No problem. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: enable 'Apply' button when clicking comic item checkbox in setting dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107577/#review23102 --- This review has been submitted with commit 7c1ae550c38e14c064d21eb34e0f68b83a12c1b6 by Reza Shah to branch master. - Commit Hook On Dec. 4, 2012, 1:21 p.m., Reza Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107577/ > --- > > (Updated Dec. 4, 2012, 1:21 p.m.) > > > Review request for Plasma. > > > Description > --- > > this patch, enable 'Apply'button when clicking comic item checkbox in setting > dialog. > > > Diffs > - > > applets/comic/configwidget.cpp 105d5ea > > Diff: http://git.reviewboard.kde.org/r/107577/diff/ > > > Testing > --- > > tested against master, worked for me. > > > Thanks, > > Reza Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
