[PHP-BUG] Bug #64989 [NEW]: more accurate return value for readdir()

2013-06-07 Thread vosa at binaryparadise dot com
From: vosa at binaryparadise dot com
Operating system: linux
PHP version:  Irrelevant
Package:  Filesystem function related
Bug Type: Bug
Bug description:more accurate return value for readdir()

Description:

---
>From manual page:
http://www.php.net/function.readdir#refsect1-function.readdir-examples
---

>From documentation: "Returns the entry name on success or FALSE on
failure." Function returns NULL instead of FALSE in case of bad
dir_handler. I think it should be mentioned in documentation at least.
If dir_handler is not exactly resource, then i.e.: "while(FALSE ===
readdir('definitely_not_handler'));" can end very badly.

Test script:
---
var_dump(readdir('definitely_not_handler'));

Expected result:

FALSE

Actual result:
--
NULL

-- 
Edit bug report at https://bugs.php.net/bug.php?id=64989&edit=1
-- 
Try a snapshot (PHP 5.4):   
https://bugs.php.net/fix.php?id=64989&r=trysnapshot54
Try a snapshot (PHP 5.3):   
https://bugs.php.net/fix.php?id=64989&r=trysnapshot53
Try a snapshot (trunk): 
https://bugs.php.net/fix.php?id=64989&r=trysnapshottrunk
Fixed in SVN:   https://bugs.php.net/fix.php?id=64989&r=fixed
Fixed in release:   https://bugs.php.net/fix.php?id=64989&r=alreadyfixed
Need backtrace: https://bugs.php.net/fix.php?id=64989&r=needtrace
Need Reproduce Script:  https://bugs.php.net/fix.php?id=64989&r=needscript
Try newer version:  https://bugs.php.net/fix.php?id=64989&r=oldversion
Not developer issue:https://bugs.php.net/fix.php?id=64989&r=support
Expected behavior:  https://bugs.php.net/fix.php?id=64989&r=notwrong
Not enough info:
https://bugs.php.net/fix.php?id=64989&r=notenoughinfo
Submitted twice:
https://bugs.php.net/fix.php?id=64989&r=submittedtwice
register_globals:   https://bugs.php.net/fix.php?id=64989&r=globals
PHP 4 support discontinued: https://bugs.php.net/fix.php?id=64989&r=php4
Daylight Savings:   https://bugs.php.net/fix.php?id=64989&r=dst
IIS Stability:  https://bugs.php.net/fix.php?id=64989&r=isapi
Install GNU Sed:https://bugs.php.net/fix.php?id=64989&r=gnused
Floating point limitations: https://bugs.php.net/fix.php?id=64989&r=float
No Zend Extensions: https://bugs.php.net/fix.php?id=64989&r=nozend
MySQL Configuration Error:  https://bugs.php.net/fix.php?id=64989&r=mysqlcfg



Bug #64989 [Opn]: more accurate return value for readdir()

2013-06-07 Thread vosa at binaryparadise dot com
Edit report at https://bugs.php.net/bug.php?id=64989&edit=1

 ID: 64989
 User updated by:vosa at binaryparadise dot com
 Reported by:vosa at binaryparadise dot com
 Summary:more accurate return value for readdir()
 Status: Open
 Type:   Bug
 Package:Filesystem function related
 Operating System:   linux
 PHP Version:Irrelevant
 Block user comment: N
 Private report: N

 New Comment:

Sorry for bad example in original message. Correct one:

while(FALSE !== readdir('definitely_not_handler'));


Previous Comments:

[2013-06-07 15:08:40] vosa at binaryparadise dot com

Description:

---
>From manual page: 
>http://www.php.net/function.readdir#refsect1-function.readdir-examples
---

>From documentation: "Returns the entry name on success or FALSE on failure." 
>Function returns NULL instead of FALSE in case of bad dir_handler. I think it 
>should be mentioned in documentation at least.
If dir_handler is not exactly resource, then i.e.: "while(FALSE === 
readdir('definitely_not_handler'));" can end very badly.

Test script:
---
var_dump(readdir('definitely_not_handler'));

Expected result:

FALSE

Actual result:
--
NULL






-- 
Edit this bug report at https://bugs.php.net/bug.php?id=64989&edit=1