[PHP-BUG] Bug #52407 [NEW]: FPM module compilation fails on ARM architecture
From: Operating system: Linux PHP version: 5.3.3 Package: Compile Failure Bug Type: Bug Bug description:FPM module compilation fails on ARM architecture Description: FPM module compilation fails on ARM architecture. Fix attached while approved by original code author (W-Mark Kubacki) Test script: --- configure with --enable-fpm and build on ARM machine Expected result: Compilation should pass and binary work. -- Edit bug report at http://bugs.php.net/bug.php?id=52407&edit=1 -- Try a snapshot (PHP 5.2): http://bugs.php.net/fix.php?id=52407&r=trysnapshot52 Try a snapshot (PHP 5.3): http://bugs.php.net/fix.php?id=52407&r=trysnapshot53 Try a snapshot (trunk): http://bugs.php.net/fix.php?id=52407&r=trysnapshottrunk Fixed in SVN: http://bugs.php.net/fix.php?id=52407&r=fixed Fixed in SVN and need be documented: http://bugs.php.net/fix.php?id=52407&r=needdocs Fixed in release: http://bugs.php.net/fix.php?id=52407&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=52407&r=needtrace Need Reproduce Script: http://bugs.php.net/fix.php?id=52407&r=needscript Try newer version: http://bugs.php.net/fix.php?id=52407&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=52407&r=support Expected behavior: http://bugs.php.net/fix.php?id=52407&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=52407&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=52407&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=52407&r=globals PHP 4 support discontinued: http://bugs.php.net/fix.php?id=52407&r=php4 Daylight Savings:http://bugs.php.net/fix.php?id=52407&r=dst IIS Stability: http://bugs.php.net/fix.php?id=52407&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=52407&r=gnused Floating point limitations: http://bugs.php.net/fix.php?id=52407&r=float No Zend Extensions: http://bugs.php.net/fix.php?id=52407&r=nozend MySQL Configuration Error: http://bugs.php.net/fix.php?id=52407&r=mysqlcfg
Bug #52407 [Com]: FPM module compilation fails on ARM architecture
Edit report at http://bugs.php.net/bug.php?id=52407&edit=1 ID: 52407 Comment by: eugenesan at gmail dot com Reported by: eugenesan at gmail dot com Summary: FPM module compilation fails on ARM architecture Status: Open Type: Bug Package: Compile Failure Operating System: Linux PHP Version: 5.3.3 New Comment: Patch passed heavy load test. Previous Comments: [2010-07-22 17:21:20] der...@php.net Never mind, it's there now :-) [2010-07-22 17:20:49] der...@php.net I see no attachment. [2010-07-22 17:16:27] eugenesan at gmail dot com Description: FPM module compilation fails on ARM architecture. Fix attached while approved by original code author (W-Mark Kubacki) Test script: --- configure with --enable-fpm and build on ARM machine Expected result: Compilation should pass and binary work. -- Edit this bug report at http://bugs.php.net/bug.php?id=52407&edit=1
Bug #52407 [Asn]: FPM module compilation fails on ARM architecture
Edit report at http://bugs.php.net/bug.php?id=52407&edit=1 ID: 52407 User updated by: eugenesan at gmail dot com Reported by: eugenesan at gmail dot com Summary: FPM module compilation fails on ARM architecture Status: Assigned Type: Bug Package: Compile Failure Operating System: Linux PHP Version: 5.3.3 Assigned To: fat New Comment: I wasn't aware of atomic functionality in libgcc. In older version of FPM (before W-Mark Kubacki provided current solution), I was copying atomic functions available in libc :-) Also, W-Mark Kubacki tried to propose libatomic as generic solution for all platforms, but due to stability reasons solution was declined. Anyways, provided patch is only for urgent fixing of FPM on ARM in PHP 5.3.3. Later, I would expect more serious treatment of the issue by maintainers. Previous Comments: [2010-07-24 02:00:20] geiss...@php.net As a matter of fact, why aren't the gcc atomic builtins used in all architectures if gcc > 4.1 is used? Otherwise it is going to be a pain to port the atomic code to many architectures. I've read that icc supports them too, but I don't know since when or anything else. For the Debian packages I'm going to do that, but I'd prefer to see the change happen here too (included a cleanup of the unused atomic_*_t types -- only atomic_t needs to be defined.) -------- [2010-07-22 17:30:10] eugenesan at gmail dot com Patch passed heavy load test. [2010-07-22 17:21:20] der...@php.net Never mind, it's there now :-) [2010-07-22 17:20:49] der...@php.net I see no attachment. -------- [2010-07-22 17:16:27] eugenesan at gmail dot com Description: FPM module compilation fails on ARM architecture. Fix attached while approved by original code author (W-Mark Kubacki) Test script: --- configure with --enable-fpm and build on ARM machine Expected result: Compilation should pass and binary work. -- Edit this bug report at http://bugs.php.net/bug.php?id=52407&edit=1
Bug #52407 [Com]: FPM module compilation fails on ARM architecture
Edit report at http://bugs.php.net/bug.php?id=52407&edit=1 ID: 52407 Comment by: eugenesan at gmail dot com Reported by:eugenesan at gmail dot com Summary:FPM module compilation fails on ARM architecture Status: Closed Type: Bug Package:Compile Failure Operating System: Linux PHP Version:5.3.3 Assigned To:fat Block user comment: N New Comment: Thanks all Previous Comments: [2010-08-21 08:46:43] f...@php.net This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. [2010-08-21 08:46:20] f...@php.net Automatic comment from SVN on behalf of fat Revision: http://svn.php.net/viewvc/?view=revision&revision=302600 Log: - Fix #52407 (use __sync_bool_compare_and_swap in fpm_atomic.h if gcc >= 4.1 is used - credit to geissert) [2010-07-28 23:34:31] geiss...@php.net I attached the patch that I'm going to use for the Debian packages until it is fixed here directly. Jérôme, could you consider it? [2010-07-28 23:31:05] geiss...@php.net The following patch has been added/updated: Patch Name: fpm-gcc-atomics.patch Revision: 1280352665 URL: http://bugs.php.net/patch-display.php?bug=52407&patch=fpm-gcc-atomics.patch&revision=1280352665 [2010-07-24 14:37:24] f...@php.net Can you please test & validate this patch on ARM arch ? I've added an #error if ARM && gcc <= 4.2 The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=52407 -- Edit this bug report at http://bugs.php.net/bug.php?id=52407&edit=1
