[opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-28 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/242/
---

Review request for Viewer, Oz Linden, Joshua Linden, and Brad Kittenbrink.


Summary
---

Enable Accept-Encoding: deflate, gzip in libcurl via setopt CURLOPT_ENCODING. 
I'm approaching this for Inventory, but it would apply to any HTTP request that 
goes through the LLURLRequest code path (vs. the LLCurl code path, which 
already does this).


Diffs
-

  indra/llmessage/llurlrequest.cpp 2ae060c0fa91 

Diff: http://codereview.secondlife.com/r/242/diff


Testing
---

Inventory loads, and I see the encoding options coming through on the backend 
apache logs.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-29 Thread Stone Linden 


> On March 28, 2011, 9:12 p.m., Monty Brandenberg wrote:
> > Before shipping, review the exploit history around CURLOPT_ENCODING.  There 
> > is a
> > known buffer overflow exploit, I believe in pre-7.20 releases but that 
> > should be
> > checked first for applicability.

Thank you, found it:
http://curl.haxx.se/docs/adv_20100209.html

The advisory applies to libcurl < 7.20. We are using libcurl 7.21.1.


- Stone


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/242/#review512
---


On March 28, 2011, 6:22 p.m., Stone Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/242/
> ---
> 
> (Updated March 28, 2011, 6:22 p.m.)
> 
> 
> Review request for Viewer, Oz Linden, Joshua Linden, and Brad Kittenbrink.
> 
> 
> Summary
> ---
> 
> Enable Accept-Encoding: deflate, gzip in libcurl via setopt CURLOPT_ENCODING. 
> I'm approaching this for Inventory, but it would apply to any HTTP request 
> that goes through the LLURLRequest code path (vs. the LLCurl code path, which 
> already does this).
> 
> 
> Diffs
> -
> 
>   indra/llmessage/llurlrequest.cpp 2ae060c0fa91 
> 
> Diff: http://codereview.secondlife.com/r/242/diff
> 
> 
> Testing
> ---
> 
> Inventory loads, and I see the encoding options coming through on the backend 
> apache logs.
> 
> 
> Thanks,
> 
> Stone
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-30 Thread Stone Linden 


> On March 29, 2011, 6:02 p.m., Merov Linden wrote:
> > Looks good.
> 
> Merov Linden wrote:
> BTW, what's the JIRA for this patch?

VWR-25286


- Stone


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/242/#review521
---


On March 28, 2011, 6:22 p.m., Stone Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/242/
> ---
> 
> (Updated March 28, 2011, 6:22 p.m.)
> 
> 
> Review request for Viewer, Oz Linden, Joshua Linden, and Brad Kittenbrink.
> 
> 
> Summary
> ---
> 
> Enable Accept-Encoding: deflate, gzip in libcurl via setopt CURLOPT_ENCODING. 
> I'm approaching this for Inventory, but it would apply to any HTTP request 
> that goes through the LLURLRequest code path (vs. the LLCurl code path, which 
> already does this).
> 
> 
> Diffs
> -
> 
>   indra/llmessage/llurlrequest.cpp 2ae060c0fa91 
> 
> Diff: http://codereview.secondlife.com/r/242/diff
> 
> 
> Testing
> ---
> 
> Inventory loads, and I see the encoding options coming through on the backend 
> apache logs.
> 
> 
> Thanks,
> 
> Stone
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-30 Thread Stone Linden 


> On March 29, 2011, 6:02 p.m., Merov Linden wrote:
> > Looks good.
> 
> Merov Linden wrote:
> BTW, what's the JIRA for this patch?
> 
> Stone Linden wrote:
> VWR-25286

Sorry, VWR-25376


- Stone


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/242/#review521
---


On March 28, 2011, 6:22 p.m., Stone Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/242/
> ---
> 
> (Updated March 28, 2011, 6:22 p.m.)
> 
> 
> Review request for Viewer, Oz Linden, Joshua Linden, and Brad Kittenbrink.
> 
> 
> Summary
> ---
> 
> Enable Accept-Encoding: deflate, gzip in libcurl via setopt CURLOPT_ENCODING. 
> I'm approaching this for Inventory, but it would apply to any HTTP request 
> that goes through the LLURLRequest code path (vs. the LLCurl code path, which 
> already does this).
> 
> 
> Diffs
> -
> 
>   indra/llmessage/llurlrequest.cpp 2ae060c0fa91 
> 
> Diff: http://codereview.secondlife.com/r/242/diff
> 
> 
> Testing
> ---
> 
> Inventory loads, and I see the encoding options coming through on the backend 
> apache logs.
> 
> 
> Thanks,
> 
> Stone
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects

2011-04-26 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/280/#review651
---

Ship it!


- Stone


On April 26, 2011, 5:36 p.m., Brad Kittenbrink wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/280/
> ---
> 
> (Updated April 26, 2011, 5:36 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Unnecessary copying was slowing down debugging of STORM-1141.
> 
> 
> This addresses bug VWR-25610.
> http://jira.secondlife.com/browse/VWR-25610
> 
> 
> Diffs
> -
> 
>   indra/llxml/llcontrol.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/280/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brad
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-26 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/278/#review652
---

Ship it!


hg rm llconfusingcode.cpp is better, but llmax() works here.

- Stone


On April 26, 2011, 5:31 p.m., Brad Kittenbrink wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/278/
> ---
> 
> (Updated April 26, 2011, 5:31 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fix for a minor buffer overrun on shutdown in LLVFS::audit.
> 
> 
> This addresses bug VWR-25608.
> http://jira.secondlife.com/browse/VWR-25608
> 
> 
> Diffs
> -
> 
>   indra/llvfs/llvfs.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/278/diff
> 
> 
> Testing
> ---
> 
> I tested using the Microsoft Debug Heap and confirmed that this allows the 
> Debug Heap to shut down without errors.
> 
> 
> Thanks,
> 
> Brad
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Python broken on Lion - autobuild doesn't work

2011-07-24 Thread Stone Linden 
On Sun, Jul 24, 2011 at 6:13 AM, Laurent Bechir
wrote:

>
> Hello,
>
> I've just upgraded to Lion and python seems to be broken. I can't use
> either autobuild and git. :
>
> autobuild
> Traceback (most recent call last):
>  File "/usr/local/bin/autobuild", line 5, in 
>from pkg_resources import load_entry_point
>  File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py",
> line 2603, in 
>working_set.require(__requires__)
>  File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py",
> line 666, in require
>needed = self.resolve(parse_requirements(requirements))
>  File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/pkg_resources.py",
> line 565, in resolve
>raise DistributionNotFound(req)  # XXX put more info here
> pkg_resources.DistributionNotFound: autobuild==0.8.5
>
>
Did you easy_install autobuild under Snow Leopard? Try easy_install-ing it
again; the autobuild components were probably installed under the Python 2.6
search paths and so cannot be found under the 2.7 search paths.


> And Xcode is suddenly half english, half eastern language...
>
>
> Perhaps installing the new version of Xcode would solve the problem ? But I
> don't know if I can still build Second Life viewer with Xcode 4.1.
>


We continue to use Xcode 3.2 at LL and haven't started testing under 4.1 or
4.2 yet. You're welcome to try, but you'll be on your own!

Cheers,
Stone
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] autobuild on linux?

2011-08-05 Thread Stone Linden 
On Fri, Aug 5, 2011 at 1:19 PM, Boroondas Gupte
wrote:

> **
> On 08/05/2011 08:41 PM, Ace Ace wrote:
>
> does anyone know how to set this up on linux
>
> No real setup needed, you can check it out from hg ...
>
> mkdir ~/sldevstuff
> hg clone ssh://h...@bitbucket.org/lindenlab/autobuild ~/sldevstuff/autobuild
>
>  ... and then run it in a viewer source checkout by specifying the absolute
> path to the command in autobuild's bin directory, e.g. ...
>
> hg clone ssh://h...@bitbucket.org/lindenlab/viewer-development 
> ~/sldevstuff/viewer-development
> cd ~/sldevstuff/viewer-development
> ~/sldevstuff/autobuild/bin/autobuild build -c ReleaseOS
>
>
> Note that invocation with a relative path (i.e., in the example above
> ../autobuild/bin/autobuild) won't always work, the path has to be
> absolute. Shortcuts and aliases like "~" and "$HOME" work fine, though. I
> guess something in the scripts is sometimes eating the ".." upon the
> recursive self-invocation autobuild does.
>
> If you want to be able to use autobuild just by typing autobuild rather
> than a path to it, add the autobuild/bin directory to your PATH or symlink
> the autobuild script to a place which is, e.g. /usr/local/bin.
>
> You might also install autobuild with easy_install or pip as suggested on 
> Autobuild
> Quick Start , but
> that makes updating python, updating autobuild and removing (uninstalling)
> autobuild more complicated. (Or maybe I just don't know it how to do that
> cleanly with easy_install and pip.) With the setup above, autobuild won't
> need any additional steps to keep working when you upgrade python (as long
> as the new version is still compatible with) and updating autobuild can be
> done by simply by updating the repository. If you want to get rid of
> autobuild, just delete ~/sldevstuff/autobuild and remove the symlink if you
> created one.
>
>
> the wiki has no info on how to do it on linux
>
> Yeah, the Linux build instructions really could need some update. :-\
>
> Cheers,
> Boroondas
>
> PS: Just tried now and can't repro invocation with relative command path
> not working. Maybe this has been fixed since I've noticed this. Does anyone
> know?
>

I use it with a relative path call often, and it Works For Me (TM) :)

Cheers - Stone


> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Respect --no-verify-ssl-cert option

2011-08-11 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/438/
---

Review request for Viewer.


Summary
---

The --no-verify-ssl-cert option is only used for XMLRPC communication. It 
should apply to all SSL verification. I needed this to log into a grid with an 
old SSL cert stuck somewhere in the bowels of login.


Diffs
-

  indra/newview/llsechandler_basic.cpp 2af4fbfc0c6e 

Diff: http://codereview.secondlife.com/r/438/diff


Testing
---

With this command line option, I can log into a grid with an expired 
certificate.
Without the option, trying to log into the same grid fails.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Respect --no-verify-ssl-cert option

2011-08-23 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/438/
---

(Updated Aug. 23, 2011, 2:57 p.m.)


Review request for Viewer.


Summary
---

The --no-verify-ssl-cert option is only used for XMLRPC communication. It 
should apply to all SSL verification. I needed this to log into a grid with an 
old SSL cert stuck somewhere in the bowels of login.


Diffs
-

  indra/newview/llsechandler_basic.cpp 2af4fbfc0c6e 

Diff: http://codereview.secondlife.com/r/438/diff


Testing
---

With this command line option, I can log into a grid with an expired 
certificate.
Without the option, trying to log into the same grid fails.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Respect --no-verify-ssl-cert option

2011-08-23 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/438/
---

(Updated Aug. 23, 2011, 2:58 p.m.)


Review request for Viewer.


Changes
---

Fix tests.


Summary
---

The --no-verify-ssl-cert option is only used for XMLRPC communication. It 
should apply to all SSL verification. I needed this to log into a grid with an 
old SSL cert stuck somewhere in the bowels of login.


Diffs (updated)
-

  indra/newview/llsechandler_basic.cpp 4ebbd04efd93 
  indra/newview/tests/llsechandler_basic_test.cpp 4ebbd04efd93 

Diff: http://codereview.secondlife.com/r/438/diff


Testing
---

With this command line option, I can log into a grid with an expired 
certificate.
Without the option, trying to log into the same grid fails.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Respect --no-verify-ssl-cert option

2011-08-23 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/438/
---

(Updated Aug. 23, 2011, 2:59 p.m.)


Review request for Viewer.


Summary
---

The --no-verify-ssl-cert option is only used for XMLRPC communication. It 
should apply to all SSL verification. I needed this to log into a grid with an 
old SSL cert stuck somewhere in the bowels of login.


This addresses bug STORM-1568.
http://jira.secondlife.com/browse/STORM-1568


Diffs
-

  indra/newview/llsechandler_basic.cpp 4ebbd04efd93 
  indra/newview/tests/llsechandler_basic_test.cpp 4ebbd04efd93 

Diff: http://codereview.secondlife.com/r/438/diff


Testing
---

With this command line option, I can log into a grid with an expired 
certificate.
Without the option, trying to log into the same grid fails.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: VWR-27090 Allow Calling Cards to carry the "(link)" suffix in the Inventory pane

2011-10-04 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/487/
---

Review request for Viewer.


Summary
---

Move the test for whether an item is a link outside of the test for whether an 
item is a calling card. This allows calling card links to carry the "(link)" 
suffix, but continues to deny them the "(nomod) (nocopy)" suffixes.


This addresses bug VWR-27090.
http://jira.secondlife.com/browse/VWR-27090


Diffs
-

  indra/newview/llinventorybridge.cpp 88cf7d9a9d31 

Diff: http://codereview.secondlife.com/r/487/diff


Testing
---

Compiles cleanly.
Shows Calling Card links with "(link)" suffix.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: EXP-625 New user remains a cloud for an extended period on first login in Advanced mode

2011-10-10 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/489/
---

Review request for Viewer, Oz Linden, Nyx Linden, Jenn, Richard Nelson, Aura 
Linden, and Brad Payne.


Summary
---

A new user logging in for the first time will remain a cloud for an unfortunate 
period of time. Turns out this is because we were failing to request the 
Library items corresponding to the user's desired initial outfit. The bug could 
be worked around by taking some other Inventory action, which would trigger a 
background fetch. This fix directly addresses the problem and allows the fetch 
of items to take place immediately.


This addresses bug EXP-625.
http://jira.secondlife.com/browse/EXP-625


Diffs
-

  indra/newview/llinventoryobserver.cpp 88cf7d9a9d31 

Diff: http://codereview.secondlife.com/r/489/diff


Testing
---

Compiles and reproduceably alleviates the bug. Tested with several 
newly-created accounts.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: EXP-625 Speed up initial avatar copy and bake by moving the initial gestures copy into LLApperanceMgr::onFirstFullyVisible()

2011-10-12 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/492/
---

Review request for Viewer, Oz Linden, Nyx Linden, Jenn, Richard Nelson, and 
Brad Payne.


Summary
---

Move copyLibraryGestures from llstartup.cpp to llappearancemgr.cpp, and call it 
from the onFirstFullyVisible() method. This gives the avatar initial outfit 
load and bake time to finish before going into the somewhat expensive gesture 
copy process.


This addresses bug EXP-625.
http://jira.secondlife.com/browse/EXP-625


Diffs
-

  indra/newview/llagentwearables.h 88cf7d9a9d31 
  indra/newview/llagentwearables.cpp 88cf7d9a9d31 
  indra/newview/llappearancemgr.h 88cf7d9a9d31 
  indra/newview/llappearancemgr.cpp 88cf7d9a9d31 
  indra/newview/llstartup.h 88cf7d9a9d31 
  indra/newview/llstartup.cpp 88cf7d9a9d31 

Diff: http://codereview.secondlife.com/r/492/diff


Testing
---

Fully loads and bakes my initial avatar in 20s from accepting ToS until visible 
in-world vs. 50s without this change. Time until Gestures are fully copies is 
about 45s, so slightly faster than trying to do it all at once, and a better 
experience to get the avatar first, then the gestures second.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: EXP-625 Speed up initial avatar copy and bake by moving the initial gestures copy into LLApperanceMgr::onFirstFullyVisible()

2011-10-12 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/492/
---

(Updated Oct. 12, 2011, 5:19 p.m.)


Review request for Viewer, Oz Linden, Nyx Linden, Jenn, Richard Nelson, and 
Brad Payne.


Changes
---

Fixing parent diff.


Summary
---

Move copyLibraryGestures from llstartup.cpp to llappearancemgr.cpp, and call it 
from the onFirstFullyVisible() method. This gives the avatar initial outfit 
load and bake time to finish before going into the somewhat expensive gesture 
copy process.


This addresses bug EXP-625.
http://jira.secondlife.com/browse/EXP-625


Diffs (updated)
-

  indra/newview/llagentwearables.h be1660e54fa8 
  indra/newview/llagentwearables.cpp be1660e54fa8 
  indra/newview/llappearancemgr.h be1660e54fa8 
  indra/newview/llappearancemgr.cpp be1660e54fa8 
  indra/newview/llstartup.h be1660e54fa8 
  indra/newview/llstartup.cpp be1660e54fa8 

Diff: http://codereview.secondlife.com/r/492/diff


Testing
---

Fully loads and bakes my initial avatar in 20s from accepting ToS until visible 
in-world vs. 50s without this change. Time until Gestures are fully copies is 
about 45s, so slightly faster than trying to do it all at once, and a better 
experience to get the avatar first, then the gestures second.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: EXP-625 Speed up initial avatar copy and bake by moving the initial gestures copy into LLApperanceMgr::onFirstFullyVisible()

2011-10-12 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/492/
---

(Updated Oct. 12, 2011, 5:23 p.m.)


Review request for Viewer, Oz Linden, Nyx Linden, Jenn, Richard Nelson, and 
Brad Payne.


Changes
---

Fixed llstartup.cpp parent diff:
$ hg diff -r be1660e54fa8:tip > exp-625-parent.diff


Summary
---

Move copyLibraryGestures from llstartup.cpp to llappearancemgr.cpp, and call it 
from the onFirstFullyVisible() method. This gives the avatar initial outfit 
load and bake time to finish before going into the somewhat expensive gesture 
copy process.


This addresses bug EXP-625.
http://jira.secondlife.com/browse/EXP-625


Diffs (updated)
-

  indra/newview/llagentwearables.h be1660e54fa8 
  indra/newview/llagentwearables.cpp be1660e54fa8 
  indra/newview/llappearancemgr.h be1660e54fa8 
  indra/newview/llappearancemgr.cpp be1660e54fa8 
  indra/newview/llstartup.h be1660e54fa8 
  indra/newview/llstartup.cpp be1660e54fa8 

Diff: http://codereview.secondlife.com/r/492/diff


Testing
---

Fully loads and bakes my initial avatar in 20s from accepting ToS until visible 
in-world vs. 50s without this change. Time until Gestures are fully copies is 
about 45s, so slightly faster than trying to do it all at once, and a better 
experience to get the avatar first, then the gestures second.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: EXP-625 Speed up initial avatar copy and bake by moving the initial gestures copy into LLApperanceMgr::onFirstFullyVisible()

2011-10-12 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/492/
---

(Updated Oct. 12, 2011, 5:24 p.m.)


Review request for Viewer, Oz Linden, Nyx Linden, Jenn, Richard Nelson, and 
Brad Payne.


Summary
---

Move copyLibraryGestures from llstartup.cpp to llappearancemgr.cpp, and call it 
from the onFirstFullyVisible() method. This gives the avatar initial outfit 
load and bake time to finish before going into the somewhat expensive gesture 
copy process.


This addresses bug EXP-625.
http://jira.secondlife.com/browse/EXP-625


Diffs
-

  indra/newview/llagentwearables.h be1660e54fa8 
  indra/newview/llagentwearables.cpp be1660e54fa8 
  indra/newview/llappearancemgr.h be1660e54fa8 
  indra/newview/llappearancemgr.cpp be1660e54fa8 
  indra/newview/llstartup.h be1660e54fa8 
  indra/newview/llstartup.cpp be1660e54fa8 

Diff: http://codereview.secondlife.com/r/492/diff


Testing (updated)
---

Fully loads and bakes my initial avatar in 20s from accepting ToS until visible 
in-world vs. 50s without this change. Time until Gestures are fully copied is 
about 45s.

Slightly faster than trying to do it all at once, and a better experience to 
get the avatar first, then the gestures second.


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Add experimental support for building with Xcode 4.2 on Mac OS X Lion

2011-10-18 Thread Stone Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/502/
---

Review request for Viewer.


Summary
---

Check the version of Xcode installed, and use that to set appropriate Mac OS X 
SDK and compiler versions.

Supports Xcode 3.2.x with Mac OS X SDK 10.5 with identical parameters as the 
code it replaces.
Adds parameters for Xcode 4.2 with Mac OS X 10.6 SDK.

Explicitly rejects with a message Xcode less than 3.2, and both 4.0 and 4.1.

Removes options for PPC builds, which we don't use, don't support, and don't 
work anyhow.


Diffs
-

  indra/cmake/Variables.cmake c42575f2cde8 

Diff: http://codereview.secondlife.com/r/502/diff


Testing
---

Builds On My Machine (TM).


Thanks,

Stone

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Build of the viewer with Xcode on Leopard

2011-11-12 Thread Stone Linden 
You can build with Xcode 3.2 on Lion right now. If you have Xcode 4.2 on
Lion, you'll need this patch to the Viewer's indra/cmake/Variables.cmake
config:

https://codereview.secondlife.com/r/502/

It compiles and runs for me, but all UI textures are marked missing with
messages like this:

2011-11-12T17:38:28Z WARNING: LLViewerTexture::setIsMissingAsset:
file:///Users/aaron/Code/Linden/viewer-development/indra/newview/skins/default/textures/icons/Progress_2.png:
Marking image as missing
2011-11-12T17:38:28Z WARNING: LLViewerTextureList::getImageFromFile: Failed
to find local image file: inv_folder_mesh.tga

I think once that texture issue is worked out, that patch above could be
proposed for mainline. (It behaves identically as the current cmake config
when running on Leopard/Snow Leopard with Xcode 3.2.)

Stone


On Sat, Nov 12, 2011 at 6:08 AM, Laurent Bechir
wrote:

>
> Hello,
>
> My Mac is on Lion and I don't have anymore Snow Leopard DVD. Will I be
> able to build the viewer with Xcode on Leopard ? When will we be able to
> build the viewer using Xcode on Lion ?
>
> Thank you
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges