Re: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION
> On Feb. 8, 2011, 9:37 a.m., Alain Linden wrote: > > I'm not sure AUTOBUILD_CONFIGURATION is a good name for this environment > > variable. I know this is long, but AUTOUBUILD_DEFAULT_BUILD_CONFIGURATIONS > > is more accurate and descriptive (and one could probably drop the AUTOBUILD > > if we aren't too worried about conflicts with other env variable names) > > Oz Linden wrote: > The name was chosen to match that of the long-form option that it > provides the default value for. Using the AUTOBUILD_ prefix is just good > practice, because collisions are a serious issue not to be ignored. > I note that 'default' is generally the name of one of the configurations in the config file (i.e. autobuild.xml). Given that and oz's pattern of naming environment variables after the option names, I'd go with the AUTOBUILD_CONFIGURATION nomenclature. I'd want to be a bit careful about populating the env var space much further than this, but what you've done here so far seems fine to me. - Jenn --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/#review342 --- On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/141/ > --- > > (Updated Feb. 6, 2011, 8:01 p.m.) > > > Review request for Viewer. > > > Summary > --- > > This patch adds support for specifying the configurations using the > AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be > specified using commas to separate the values). > > > This addresses bug open-8. > > > Diffs > - > > autobuild/autobuild_base.py 9ee2db08d677 > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/141/diff > > > Testing > --- > > Tested manually with and without the command line argument, and with and > without the environment variable set; the appropriate configuration values > were used. > > > Thanks, > > Oz > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/#review355 --- Ship it! - Jenn On Feb. 6, 2011, 8:01 p.m., Oz Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/141/ > --- > > (Updated Feb. 6, 2011, 8:01 p.m.) > > > Review request for Viewer. > > > Summary > --- > > This patch adds support for specifying the configurations using the > AUTOBUILD_CONFIGURATION environment variable (multiple configurations can be > specified using commas to separate the values). > > > This addresses bug open-8. > > > Diffs > - > > autobuild/autobuild_base.py 9ee2db08d677 > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/141/diff > > > Testing > --- > > Tested manually with and without the command line argument, and with and > without the environment variable set; the appropriate configuration values > were used. > > > Thanks, > > Oz > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/140/#review356 --- Ship it! - Jenn On Feb. 6, 2011, 5:39 p.m., Oz Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/140/ > --- > > (Updated Feb. 6, 2011, 5:39 p.m.) > > > Review request for Viewer. > > > Summary > --- > > This change allows the environment variable AUTOBUILD_CONFIG_FILE to specify > a default config-file, so that the precedence becomes: > >1. the --config-file command line option >2. the environment variable AUTOBUILD_CONFIG_FILE >3. "autobuild.xml" > > It also adds an info-level (--verbose) display of the config file name that > is being loaded, and a warning level display if the config file does not > exist. > > > This addresses bug open-7. > > > Diffs > - > > autobuild/autobuild_tool_build.py 9ee2db08d677 > autobuild/autobuild_tool_configure.py 9ee2db08d677 > autobuild/autobuild_tool_edit.py 9ee2db08d677 > autobuild/autobuild_tool_install.py 9ee2db08d677 > autobuild/autobuild_tool_installables.py 9ee2db08d677 > autobuild/autobuild_tool_manifest.py 9ee2db08d677 > autobuild/autobuild_tool_package.py 9ee2db08d677 > autobuild/autobuild_tool_print.py 9ee2db08d677 > autobuild/autobuild_tool_uninstall.py 9ee2db08d677 > autobuild/configfile.py 9ee2db08d677 > > Diff: http://codereview.secondlife.com/r/140/diff > > > Testing > --- > > Manually tested with and without the command line option, and with and > without the environment variable set: confirmed that the correct file name is > used per the precedence above. > > Confirmed that the new logging works correctly. > > > Thanks, > > Oz > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: Enable watchdog timer for Beta release crash hunting.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/337/ --- Review request for Viewer, Alain Linden, Richard Nelson, and Nat Goodspeed. Summary --- Enable watchdog timer for Beta release to get tracebacks for classes of crashes for which we currently have little data. Setting timer to 20 seconds. Will either disable or make longer for deployment to the Release channel. Diffs - indra/newview/app_settings/settings.xml a7c507c7e0f8 Diff: http://codereview.secondlife.com/r/337/diff Testing --- Thanks, Jenn ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Enable watchdog timer for Beta crash hunting.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/337/ --- (Updated June 14, 2011, 2:50 p.m.) Review request for Viewer, Alain Linden, Richard Nelson, and Nat Goodspeed. Summary (updated) --- Enable watchdog timer for Beta release to get tracebacks for classes of crashes for which we currently have little data. Setting timer to 20 seconds. Will either disable or make longer for deployment to the Release channel. Diffs - indra/newview/app_settings/settings.xml a7c507c7e0f8 Diff: http://codereview.secondlife.com/r/337/diff Testing --- Thanks, Jenn ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Enable watchdog timer for Beta crash hunting.
> On June 14, 2011, 2:50 p.m., Alain Linden wrote: > > indra/newview/app_settings/settings.xml, line 12409 > > <http://codereview.secondlife.com/r/337/diff/1/?file=2956#file2956line12409> > > > > I presume this means trigger the watchdog after 20 seconds of 'freeze'. :) yes - Jenn --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/337/#review743 --- On June 14, 2011, 2:50 p.m., Jenn wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/337/ > --- > > (Updated June 14, 2011, 2:50 p.m.) > > > Review request for Viewer, Alain Linden, Richard Nelson, and Nat Goodspeed. > > > Summary > --- > > Enable watchdog timer for Beta release to get tracebacks for classes of > crashes for which we currently have little data. > > Setting timer to 20 seconds. Will either disable or make longer for > deployment to the Release channel. > > > Diffs > - > > indra/newview/app_settings/settings.xml a7c507c7e0f8 > > Diff: http://codereview.secondlife.com/r/337/diff > > > Testing > --- > > > Thanks, > > Jenn > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Windows compiling problem
On my development machine I uninstalled the Windows SDK entirely, relying on the one that ships with VS2010, to resolve a similar conflict. If a similar tactic works for you, let us know! Thx, - Jenn On Fri, Apr 8, 2011 at 11:34 AM, Jonathan Welch wrote: > I've tried all the suggestions that people have suggested, but to no > avail. I still get messages like the one below. > > Anyone with more ideas? > > -- Build started: Project: llwindow, Configuration: Release Win32 > -- > llwindowwin32.cpp > lldxhardware.cpp > e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11280): error C2061: > syntax error : identifier '__RPC__out_xcount_part' > e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): error C2059: > syntax error : ')' > e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): fatal error > C1903: unable to recover from previous error(s); stopping compilation > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Inventory Patch you should integrate
I should add that we are also testing inventory routing changes on those sims on aditi as well. Items which are *newly* sent to your inventory should show up in the Received Items folder (e.g. someone gives you an item, you purchase an item etc. - these will show up in this new system folder). We plan to announce a public beta for testing these behavior changes in the next couple of weeks and have been performing primarily internal testing so far. We will be debugging and re-deploying throughout this week as we continue with internal testing, but these simulators should be essentially functional for testing Viewer changes. Thx! - Jenn On Fri, Feb 3, 2012 at 11:59 AM, Oz Linden (Scott Lawrence) < o...@lindenlab.com> wrote: > On 2012-01-28 14:13 , Henri Beauchamp wrote: > > On Fri, 27 Jan 2012 16:57:20 -0500, Oz Linden (Scott Lawrence) wrote: > > > >> Sorry for the delay letting you know - the inventory service on Aditi is > >> running the version this is needed for, so if you want to test a port, > >> do it there. > > The feature also depends on a sim capability, and as far as I could see > > (and in the sim I tested the feature in), that capability is not yet > > implemented/advertized... Could you please tell us which sims advertize > > the new "CreateInventoryCategory" capability on Aditi ? > > > > I didn't realize that it wasn't everywhere it should be enabled on > the Inventory Test regions on aditi. Info available here: > https://wiki.secondlife.com/wiki/InventoryBetaTest > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
