Re: [opensource-dev] Review Request: STORM-1546 Crash in LLSecAPIBasicHandler::getCertificateStore
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/435/#review960 --- Ship it! Looks good -- make sure to ask QA to do a performance A/B test to make sure this doesn't introduce frame stalls. - David On Aug. 9, 2011, 12:55 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/435/ > --- > > (Updated Aug. 9, 2011, 12:55 p.m.) > > > Review request for Viewer and David Parks. > > > Summary > --- > > Fixed a crash caused by a race condition in LLRefCount. > > Reason: > secapiSSLCertVerifyCallback() seems to be called simultaneously by multiple > threads, > which causes a race condition in LLRefCount::ref/unref() methods. > The reference counter in LLSecAPIBasicHandler::mStore goes to zero, and the > object gets destroyed. > > Fix: > Derive LLCertificateStore from LLThreadSafeRefCount instead of LLRefCount, > which should fix the race condition. > > Note: > The LLThreadSafeRefCount constructor is private, so we have to wrap instances > of the class with LLPointer. > > > This addresses bug STORM-1546. > http://jira.secondlife.com/browse/STORM-1546 > > > Diffs > - > > indra/newview/llsecapi.h 8f15e5a13e8f > indra/newview/llsechandler_basic.cpp 8f15e5a13e8f > > Diff: http://codereview.secondlife.com/r/435/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: storm-1602: GPU Table Updates
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/480/#review1033 --- Radeon X1xxx should be at least class 1, class 2 if X1550 or later Anything Radeon HD 5xxx or 6xxx is class 3 (including Mobility) Anything ASUS EAH6xxx is class 3 Radeon HD 3410 and 4100 should probably be at least class 1 GeForce 9600 GT should at least be class 2 The lines that say "ATI Technologies Inc. GeForce" make no sense -- GeForce is an NVIDIA product. - David On Sept. 19, 2011, 1:31 p.m., Oz Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/480/ > --- > > (Updated Sept. 19, 2011, 1:31 p.m.) > > > Review request for Viewer. > > > Summary > --- > > This displays just the gpus_results.txt file - the results of recognizing all > gpus seen in our recent and past logs as recognized by my current working > version of the gpu_table. > > I'd like review of whether or not the resulting class assignments are correct > (I strongly suspect many will not be) > > > This addresses bug storm-1602. > http://jira.secondlife.com/browse/storm-1602 > > > Diffs > - > > indra/newview/tests/gpus_results.txt 02efbb23b5cf > > Diff: http://codereview.secondlife.com/r/480/diff > > > Testing > --- > > > Thanks, > > Oz > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1878: Blocking an avatar does not derender worn lights
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/583/#review1230 --- No issues with the code so far, but from inspection I don't think this code will block lights for an avatar that is already muted -- it only blocks lights at the moment you mute another avatar. You'll need to add a check to LLPipeline::setLight that verifies the object is not on the mute list before inserting the object onto gPipeline.mLights. - David Parks On June 18, 2012, 11:04 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/583/ > --- > > (Updated June 18, 2012, 11:04 a.m.) > > > Review request for Viewer and David Parks. > > > Description > --- > > An avatar currently gets derendered/invisible when the user blocks it. > The local lights attached to that avatar have to become erased too. > Repository: https://bitbucket.org/MartinRJ/storm-1878 > > > This addresses bug STORM-1878. > https://jira.secondlife.com/browse/STORM-1878 > > > Diffs > - > > indra/newview/llmutelist.cpp 29143d1fc6fa > indra/newview/pipeline.h 29143d1fc6fa > indra/newview/pipeline.cpp 29143d1fc6fa > > Diff: http://codereview.secondlife.com/r/583/diff/diff > > > Testing > --- > > Tested with 1-6 local attached lights on the target avatar. > Blocking/muting the avatar also disabled the attached lights in all tests > successfully. > > > Thanks, > > MartinRJ Fayray > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1878: Blocking an avatar does not derender worn lights
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/583/#review1232 --- Ship it! In that case, ship it! - David Parks On June 18, 2012, 11:04 a.m., MartinRJ Fayray wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/583/ > --- > > (Updated June 18, 2012, 11:04 a.m.) > > > Review request for Viewer and David Parks. > > > Description > --- > > An avatar currently gets derendered/invisible when the user blocks it. > The local lights attached to that avatar have to become erased too. > Repository: https://bitbucket.org/MartinRJ/storm-1878 > > > This addresses bug STORM-1878. > https://jira.secondlife.com/browse/STORM-1878 > > > Diffs > - > > indra/newview/llmutelist.cpp 29143d1fc6fa > indra/newview/pipeline.h 29143d1fc6fa > indra/newview/pipeline.cpp 29143d1fc6fa > > Diff: http://codereview.secondlife.com/r/583/diff/diff > > > Testing > --- > > Tested with 1-6 local attached lights on the target avatar. > Blocking/muting the avatar also disabled the attached lights in all tests > successfully. > > > Thanks, > > MartinRJ Fayray > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
