Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/78/#review147 --- Tested your patch and after testing it works however you do not need to have label_selected at all it works as expected without to - Alexandrea On Jan. 12, 2011, 6:02 a.m., Jonathan Yap wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/78/ > --- > > (Updated Jan. 12, 2011, 6:02 a.m.) > > > Review request for Viewer. > > > Summary > --- > > "More" should be "Less" when Media Control is open > > This is a trivial text change in an xml file. The reason I am posting this > here is due to some confusion using label_selected. In this case having it > set to a different value than when label is set to seems to have no effect, > so I have made them identical. > > I scanned all the xml files and there are only about 5 places where > label_selected is different from the preceding label= value. > > Is there any reason to revert back to having them set to different values? > i.e. label="More" and label_selected="Less" > > > This addresses bug storm-844. > http://jira.secondlife.com/browse/storm-844 > > > Diffs > - > > doc/contributions.txt 179e0754a27d > indra/newview/skins/default/xui/en/panel_nearby_media.xml 179e0754a27d > > Diff: http://codereview.secondlife.com/r/78/diff > > > Testing > --- > > > Thanks, > > Jonathan > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.
> On Jan. 20, 2011, 10:45 a.m., Cron Stardust wrote: > > Looks like you are only preventing the button from drawing and working, but > > not actually /removing/ it from the tray. Have you hunted down the code > > that is used to remove tray buttons when the tray is right-clicked on and > > an item is checked/unchecked? I would think that that is the functionality > > that needs to be copied onto the speak button. > > > > Maybe, as a different JIRA entry and review, you might consider what it > > would take to add the speak button to that tray context menu. Once the > > ability to remove and add the speak button via the context menu is working, > > it would then seem to me that this entry (STORM-236) would be trivial to > > implement, as all the core functionality will have been resolved already. > > Even if the new entry for the context menu wasn't accepted, the core > > functionality can still be done here. > > Wolfpup Lowenhar wrote: > This Issue is for having the button hide(not be drawn) and free up the > space that it normally take in the bottom tray. The problem I'm having is > with the second part getting the space freed up right. Also the context menu > is functional so there are no problems there. > > Cron Stardust wrote: > As of 2.6.0.219259 the Speak button is not able to be removed from the > tray using the context menu. However, the point I was trying to make was > that the underlying functionality of what you are trying to accomplish here, > that of removing a button and freeing up the space, is currently accomplished > by the underlying functionality that the tray context menu taps into. > Whether a simple (hah!) study of that code's functionality will give you what > you need, or whether you do a complementary implementation of adding the > (de)activation of the Speak button to the context menu, is up to you. > > I simply was pointing out that the underlying task is accomplished at > another, potentially missed, location. If you have already studied and > implemented the button (de)activation code that the tray context menu uses, > then my suggestion is just noise. On the other hand, exploring what it would > take to make the Speak button go away or come back via the context menu > allows you to explore another code section that might result in two birds > being killed with one stone: making the button removable for those who only > use the keyboard or mouse toggle, and giving you the code to make the button > go away when Voice isn't active. > > Hope that clears up the situation. To me the problem here isn't the > tasks of "make the button hide" and then "free up the space" - it's about how > to properly remove and re-add the button, similar to how the tray context > menu works, just with a different trigger: the voice setting. > > Wolfpup Lowenhar wrote: > Cron, > I wonder if you have even looked at the diff as im working on adding all > the functionality that you say is not present. Yes there is some thing im > missing other wise I would not be receiving an error in my local repository. > this work is only in my local repository at present as it is not yet ready to > be posted for review but as Oz suggested i placed this here with the subject > "Help Needed" as i believe im missing some thing important in the code and > there for getting a error. This is ACTUALLY a request for ASSISTANCE from the > open source community and not a review request. > > Cron Stardust wrote: > Wolfpup, I am trying to give assistance. Just like I assist my fellow CS > students in the programming labs when I'm not familiar with the details of > what they are implementing. Yes, I have looked over the diff. Yet since I > have never gotten a build environment that worked for more than a day, I > didn't have the time (back when I did have the time) to learn the ins and > outs of the viewer codebase. Since then I've not had the time to do more > than glance over other people's code. Hopefully I will learn enough from > that to start working changes myself when I have time again. Since I don't > have a build env, I can't help with straight debugging. However, I believe > that my points and information may be valid and useful in helping direct your > mind to a solution, even though I cannot supply one. > > Often when I have a coding problem, I'll even go so far as to explain it > to an artist: their eyes may glaze over, but in their ignorance of how things > work in programming sometimes makes them able to point out areas to explore > or solutions that I never would have thought of. Such is what I'm trying to > do here: provide you with a way around the barrier. Not by going straight > through the barrier, as I don't have that solution, but by pointing out a > possible doorway further down the wall. > > However, to keep up the simile, if you've already tried that door and > found it
Re: [opensource-dev] Review Request: Help Needed to debug small problem with code for STORM-236.
that I never would have thought of. Such is what I'm trying to > do here: provide you with a way around the barrier. Not by going straight > through the barrier, as I don't have that solution, but by pointing out a > possible doorway further down the wall. > > However, to keep up the simile, if you've already tried that door and > found it locked, then let me know, and I'll either try to point out another > door, or shut up waiting for another person to find a way through. > > > Alexandrea Fride wrote: > Shouldend 'EnableVoiceChat' not also be defined in settings.xml? seeing > it use gSavedSettings? other then that dident tested this yet but did see you > miss that > > Greetings ignore that :) - Alexandrea --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/112/#review210 --- On Jan. 20, 2011, 9:29 a.m., Wolfpup Lowenhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/112/ > --- > > (Updated Jan. 20, 2011, 9:29 a.m.) > > > Review request for Viewer. > > > Summary > --- > > This is actually a request for for help to debug what I have done so far to > get this working. > 1. In the current diff the button dose actualy hide and show according to if > Voice is enabled or not. > 2. i have two problems at this point. >a. the space taken up by the speak button is not freed up >b. when the speak button is shown after being hidden there is an error > message saying no space avaiable > (I think this is related to the fact that the space is not freed to > begin with). > > > This addresses bug STORM-236. > http://jira.secondlife.com/browse/STORM-236 > > > Diffs > - > > doc/contributions.txt 40d0806e9800 > indra/newview/llbottomtray.cpp 40d0806e9800 > indra/newview/llspeakbutton.cpp 40d0806e9800 > indra/newview/skins/default/xui/en/menu_bottomtray.xml 40d0806e9800 > > Diff: http://codereview.secondlife.com/r/112/diff > > > Testing > --- > > > Thanks, > > Wolfpup > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-236 Actual Code Review
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/113/#review235 --- Perfect just the naming in menu should be better "Speak button (enables voice chat)" like boroondas sayd :) (and mayby the styling fixed or so but patch works as exspected) tested patch and test build both worked as exspected nice job - Alexandrea On Jan. 20, 2011, 6:37 p.m., Wolfpup Lowenhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/113/ > --- > > (Updated Jan. 20, 2011, 6:37 p.m.) > > > Review request for Viewer. > > > Summary > --- > > This allows the Speak Button to auto-hide for those that do not use Voice at > all. > > > This addresses bug STORM-236. > http://jira.secondlife.com/browse/STORM-236 > > > Diffs > - > > doc/contributions.txt 9c7d543fd15d > indra/newview/llbottomtray.h 9c7d543fd15d > indra/newview/llbottomtray.cpp 9c7d543fd15d > indra/newview/llspeakbutton.cpp 9c7d543fd15d > indra/newview/skins/default/xui/en/menu_bottomtray.xml 9c7d543fd15d > > Diff: http://codereview.secondlife.com/r/113/diff > > > Testing > --- > > Built locally and did the following: > 1 Verified that when Voice is toggled via the preference panel the Speak > Button auto hid/showed. > 2 Verified that drag and drop functionality of the Speak Button was not > affected. > 3 Went to a non-Voice area with Voice active and verified that button was > still there but grayed out. > > > Thanks, > > Wolfpup > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] attempting to compile a viewer
its is develop.py -G VC80 configure you forgot to but configure after after that you can use develop.py build or opening project files and build there From: Andromeda Quonset Sent: Sunday, January 30, 2011 10:35 AM To: opensource-dev@lists.secondlife.com Subject: Re: [opensource-dev] attempting to compile a viewer I have gotten a little farther, but I am still having an issue: E:\linden\indra>develop.py -G VC80 Running 'cmake -G "Visual Studio 8 2005" -DSTANDALONE:BOOL=OFF -DUNATTENDED:BOOL =OFF -DROOT_PROJECT_NAME:STRING=SecondLife "" "E:\\linden\\indra"' in 'build-VC8 0' -- Check for working C compiler using: Visual Studio 8 2005 -- Check for working C compiler using: Visual Studio 8 2005 -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler using: Visual Studio 8 2005 -- Check for working CXX compiler using: Visual Studio 8 2005 -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done Traceback (most recent call last): File "install.py", line 80, in ? from indra.base import llsd File "E:\linden\indra\lib\python\indra\base\llsd.py", line 37, in ? from indra.util.fastest_elementtree import ElementTreeError, fromstring File "E:\linden\indra\lib\python\indra\util\fastest_elementtree.py", line 62, in ? from xml.etree.ElementTree import * ImportError: No module named etree.ElementTree CMake Error at cmake/Prebuilt.cmake:39 (message): Failed to download or unpack prebuilt 'ogg-vorbis'. Process returned 1. Call Stack (most recent call first): cmake/Audio.cmake:11 (use_prebuilt_binary) llaudio/CMakeLists.txt:6 (include) -- Configuring incomplete, errors occurred! Cleaning 'build-VC80' Error: the command 'cmake' exited with status 1 E:\linden\indra> This is VS2005 Professional, not the express version. The system I am running on is Windows 7 x64, and I am not trying to produce a 64-bit viewer. I have gane back through the archives for this list, and I've found a few other instances of the same error message: Failed to download or unpack prebuilt 'ogg-vorbis'. Process returned 1. and one person solved it by manually downloading it, and saving it in a temp directory. That doesn't seem to have worked for me. Either the problem here is something else, or I am putting it in the wrong temp directory. I am using Python 2.5 and CMake 2.8.3 Should I be using other versions instead? Thanks in advance! Andro At 09:43 PM 1/29/2011, you wrote: some of this might help you. make sure you have Python Installed Good Luck, https://wiki.secondlife.com/wiki/Talk:Microsoft_Windows_Builds#VC.2B.2B_Express_2005_Settings_that_resulted_in_a__successful_build_of_snowglobe_2.0 . From: Andromeda Quonset To: opensource-dev@lists.secondlife.com Sent: Sat, January 29, 2011 9:06:16 PM Subject: [opensource-dev] attempting to compile a viewer I am using VS2005, attempting to compile viewer 1.22 (I wanted to start with 1.23.5, but the source seems unavailable). My problem ATM is with running develop.py I am getting the following error message: CMake Error at cmake/Python.cmake:47 (message): No Python interpreter found Call Stack (most recent call first): cmake/Prebuilt.cmake:3 (include) cmake/Audio.cmake:2 (include) llaudio/CMakeLists.txt:6 (include) -- Configuring incomplete, errors occurred! Cleaning 'build-vc80' Error: the command 'cmake' exited with status 1 There are some messages prior to this, but they seem to be warnings related to a lack of CMakeLists.txt in the Input directories, and I assume I can ignore them for now. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Malicious payloads in third-party viewers: is the policy worth anything?
Sure true but the differences is for a normal sl viewer to do this they need to specify their own login screen using url parameters or someting while with Emerald has there own custom login screenpage with users see evrytime they login into Emerald while what you say is true but that user count is WAY lesser then thousand of emerald users loging in continue it was stupid to do but this also proven the point is that Emerald (or anny other viewer) can do what they whant with SL's code it gives wrong view of what Third party viewer should be and to fix this so it never hapens again disalow custom login page's to be hosted on the viewers server but instead allow it so it can be hosted on secondlife servers (for a fee maybe idk) and everey time they wanna update the page, let LL control it to see if its user safe (could allow dynamic xml stats for custom news and stats but limited to basic html code with it) annyway my 2cents -- From: "Harold Brown" Sent: Tuesday, August 24, 2010 10:50 PM To: "David M Chess" Cc: Subject: Re: [opensource-dev] Malicious payloads in third-party viewers: is the policy worth anything? > What I find interesting is that people are neglecting to realize that > ANY viewer, even a LL viewer could have been used to do the same thing > by changing the WEBPAGE the login screen pointed to. Or for that > matter distributing a object using the new Media functions to load a > webpage with the exact same iframe set. > > > > On Mon, Aug 23, 2010 at 8:03 AM, David M Chess wrote: >> >> Could we move all this stuff to a new "emeraldgate" list, or something? >> >> That I could then carefully not subscribe to? >> >> __ >> ___ >> Policies and (un)subscribe information available here: >> http://wiki.secondlife.com/wiki/OpenSource-Dev >> Please read the policies before posting to keep unmoderated posting >> privileges >> > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Removal of the "MultipleAttachments" debug settings ?
The way emerald works and others is no good solution couse as you sayd you can only see it with those viewers AND it dosent even work for hud objects, how viewer 2 works now is it do works accross all viewers AND it works for hud objects and as for the radar thing, Kristens viewer already added sort of that to (and thats on viewer 2) and couse allot of people saying viewer 2 sucks couse they miss the things in emerald YET emerald refuses to work on viewer 2 (WHY) if evreyone dont like it start working on it! and make it bether thats what opensource should be, and not refuse to work on couse you dont like it. annyway sorry for hijacking this treath but get 100 of mails so one more dont mather -.- > On Mon, 30 Aug 2010 13:44:04 -0700 > Kadah wrote: > >> > If the point of this is to make people *want* 2.x a lot of >> > nice tags that say 'to see me properly, use viewer 2.x... I have >> > more attachments than you do' might be a good way to go. >> >> It worked for Emerald. > > Emerald use a "tweaked" code+xml, only an emerald see correctly another > emerald user... now there is a "standard", already used by a lot of > non-linden viewers (is why i'm staring EM blog waiting for the right > release than stop to see fuzzy attachments fly around sims XD) > > and "no", attachments are a bit feature of emerald, the most is the > radar, a lot of ppl can save lag using builtin radar in place of a > laggy hud... > > for sl2 cannot work, why if somebody say you "use [only_one_viewer]" ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)
Works fine on windows to however icons dont fit with viewer 2 style :) if not mistaken those are the icons from viewer 1 (and prefered if the icons where a bit smaller in weight & height and more easly to define what is what) @Kelley that was probly a alpha viewer 2 release since if you look at chatbar etc style its completly different then we are used to On Mon, Sep 6, 2010 at 7:50 AM, leliel wrote: > On Mon, Sep 6, 2010 at 10:37 AM, Marine Kelley > wrote: >> Err... color me stupid but... how does one show the friends list in this >> style on viewer 2 ? I can detach tabs from the sidebar, but I cannot find >> a >> way to show the permissions matrix. It would be so handy ! > > Hover the mouse over their name in the friends list and it will show > the permission icons. > > Works fine for me on Linux. Looks like it uses the 1.23 icons which > don't fit in with the theme on 2.x tho. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list)
llkdu.dll problem hapend to me to, replace the dll from the officialy viewer 2.1 or devenlopbuild that worked -- From: "Ardy Lay" Sent: Tuesday, September 07, 2010 4:18 PM To: Subject: Re: [opensource-dev] Code Review Request: VWR-21253 (Permissions icons in the friends list) > The provided build implodes 4 seconds after launch it on Windows 7. > I'll pick up the change set, build that and see what happens. ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Incomming group/im Toasts
As a user i would like to disable incoming group/im toasts from showing up in viewer 2, especially if a user is in busy groups this can be pretty annoyingly i made a jira http://jira.secondlife.com/browse/VWR-22915 and included a patch that easly can do it the path isent big so it could be done easly (or modifyd to use LL coding standards if someone whants to check that patch) Greetings Alexandrea Fride ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] display name userstory
Nice but on tiny problem IF the client when it hapens alredy cant get First and Last name how you suposte to get the username? username = first and last name and i would think that getting the Display Name is same way as getting username(first and last name), i would assume those info are together when fetching that data Greetings From: Rob Nelson Sent: Saturday, October 30, 2010 1:58 PM To: opensource-dev@lists.secondlife.com Subject: Re: [opensource-dev] display name userstory How about "username (Loading...)", in order to queue people in as to why their display names aren't showing up. Should relieve pressure on support staff. Rob On 10/29/2010 8:47 PM, Erin Mallory wrote: as a user, if there are network issues in SL I would like display name enabled clients to NOT report avatars as ???-??? but rather default to user name or ??? - username___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
