[opensource-dev] Review Request: OPEN-172 Combined changesets for Linux gcc 4.7, 2 build of viewer development

2013-04-11 Thread Nicky Perian 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/618/
---

Review request for Viewer.


Description
---

OPEN-172 Combined changesets for Linux gcc 4.7,2 build of viewer development  


This addresses bug OPEN-172.
http://jira.secondlife.com/browse/OPEN-172


Diffs
-

  indra/cmake/00-Common.cmake fc8c50bc74f5 
  indra/cmake/Copy3rdPartyLibs.cmake fc8c50bc74f5 
  indra/cmake/LLAddBuildTest.cmake fc8c50bc74f5 
  indra/linux_updater/linux_updater.cpp fc8c50bc74f5 
  indra/llappearance/llwearabletype.h fc8c50bc74f5 
  indra/llcommon/lldarray.h fc8c50bc74f5 
  indra/llcommon/lleventcoro.h fc8c50bc74f5 
  indra/llcommon/llinitparam.h fc8c50bc74f5 
  indra/llcommon/llrefcount.h fc8c50bc74f5 
  indra/llcorehttp/CMakeLists.txt fc8c50bc74f5 
  indra/llmath/lloctree.h fc8c50bc74f5 
  indra/llmessage/CMakeLists.txt fc8c50bc74f5 
  indra/llmessage/lliopipe.h fc8c50bc74f5 
  indra/llmessage/llregionpresenceverifier.cpp fc8c50bc74f5 
  indra/llui/llview.cpp fc8c50bc74f5 
  indra/media_plugins/gstreamer010/media_plugin_gstreamer010.cpp fc8c50bc74f5 
  indra/newview/llcommunicationchannel.cpp fc8c50bc74f5 
  indra/newview/llfloaterpathfindingobjects.cpp fc8c50bc74f5 
  indra/newview/llsurfacepatch.cpp fc8c50bc74f5 
  indra/newview/llviewertexture.cpp fc8c50bc74f5 
  indra/newview/llworld.cpp fc8c50bc74f5 
  indra/test/CMakeLists.txt fc8c50bc74f5 
  indra/test/test.cpp fc8c50bc74f5 

Diff: http://codereview.secondlife.com/r/618/diff/


Testing
---

Built on debia wheezy virtual box virtual machine. Logged on secondlife. 
Checked logs and found no spamming. Do not have a native machine to test with.
The change to llviewertexture.cpp around line 419 needs a close look.


Thanks,

Nicky Perian

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-172 Combined changesets for Linux gcc 4.7, 2 build of viewer development

2013-04-11 Thread Nicky Perian 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/618/
---

(Updated April 11, 2013, 8:26 p.m.)


Review request for Viewer.


Description
---

OPEN-172 Combined changesets for Linux gcc 4.7,2 build of viewer development  


This addresses bug OPEN-172.
http://jira.secondlife.com/browse/OPEN-172


Diffs
-

  indra/cmake/00-Common.cmake fc8c50bc74f5 
  indra/cmake/Copy3rdPartyLibs.cmake fc8c50bc74f5 
  indra/cmake/LLAddBuildTest.cmake fc8c50bc74f5 
  indra/linux_updater/linux_updater.cpp fc8c50bc74f5 
  indra/llappearance/llwearabletype.h fc8c50bc74f5 
  indra/llcommon/lldarray.h fc8c50bc74f5 
  indra/llcommon/lleventcoro.h fc8c50bc74f5 
  indra/llcommon/llinitparam.h fc8c50bc74f5 
  indra/llcommon/llrefcount.h fc8c50bc74f5 
  indra/llcorehttp/CMakeLists.txt fc8c50bc74f5 
  indra/llmath/lloctree.h fc8c50bc74f5 
  indra/llmessage/CMakeLists.txt fc8c50bc74f5 
  indra/llmessage/lliopipe.h fc8c50bc74f5 
  indra/llmessage/llregionpresenceverifier.cpp fc8c50bc74f5 
  indra/llui/llview.cpp fc8c50bc74f5 
  indra/media_plugins/gstreamer010/media_plugin_gstreamer010.cpp fc8c50bc74f5 
  indra/newview/llcommunicationchannel.cpp fc8c50bc74f5 
  indra/newview/llfloaterpathfindingobjects.cpp fc8c50bc74f5 
  indra/newview/llsurfacepatch.cpp fc8c50bc74f5 
  indra/newview/llviewertexture.cpp fc8c50bc74f5 
  indra/newview/llworld.cpp fc8c50bc74f5 
  indra/test/CMakeLists.txt fc8c50bc74f5 
  indra/test/test.cpp fc8c50bc74f5 

Diff: http://codereview.secondlife.com/r/618/diff/


Testing
---

Built on debia wheezy virtual box virtual machine. Logged on secondlife. 
Checked logs and found no spamming. Do not have a native machine to test with.
The change to llviewertexture.cpp around line 419 needs a close look.


Thanks,

Nicky Perian

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-172 Combined changesets for Linux gcc 4.7, 2 build of viewer development

2013-04-11 Thread Monty Brandenberg 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/618/#review1303
---



indra/newview/llviewertexture.cpp


Ugg, took me awhile to find this.  The fix is to declare a virtual 
destructor on LLTextureManagerBridge in lltexturemanagerbridge.h.  Looks like 
it can be pure virtual.


- Monty Brandenberg


On April 11, 2013, 8:26 p.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/618/
> ---
> 
> (Updated April 11, 2013, 8:26 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> OPEN-172 Combined changesets for Linux gcc 4.7,2 build of viewer development  
> 
> 
> This addresses bug OPEN-172.
> http://jira.secondlife.com/browse/OPEN-172
> 
> 
> Diffs
> -
> 
>   indra/cmake/00-Common.cmake fc8c50bc74f5 
>   indra/cmake/Copy3rdPartyLibs.cmake fc8c50bc74f5 
>   indra/cmake/LLAddBuildTest.cmake fc8c50bc74f5 
>   indra/linux_updater/linux_updater.cpp fc8c50bc74f5 
>   indra/llappearance/llwearabletype.h fc8c50bc74f5 
>   indra/llcommon/lldarray.h fc8c50bc74f5 
>   indra/llcommon/lleventcoro.h fc8c50bc74f5 
>   indra/llcommon/llinitparam.h fc8c50bc74f5 
>   indra/llcommon/llrefcount.h fc8c50bc74f5 
>   indra/llcorehttp/CMakeLists.txt fc8c50bc74f5 
>   indra/llmath/lloctree.h fc8c50bc74f5 
>   indra/llmessage/CMakeLists.txt fc8c50bc74f5 
>   indra/llmessage/lliopipe.h fc8c50bc74f5 
>   indra/llmessage/llregionpresenceverifier.cpp fc8c50bc74f5 
>   indra/llui/llview.cpp fc8c50bc74f5 
>   indra/media_plugins/gstreamer010/media_plugin_gstreamer010.cpp fc8c50bc74f5 
>   indra/newview/llcommunicationchannel.cpp fc8c50bc74f5 
>   indra/newview/llfloaterpathfindingobjects.cpp fc8c50bc74f5 
>   indra/newview/llsurfacepatch.cpp fc8c50bc74f5 
>   indra/newview/llviewertexture.cpp fc8c50bc74f5 
>   indra/newview/llworld.cpp fc8c50bc74f5 
>   indra/test/CMakeLists.txt fc8c50bc74f5 
>   indra/test/test.cpp fc8c50bc74f5 
> 
> Diff: http://codereview.secondlife.com/r/618/diff/
> 
> 
> Testing
> ---
> 
> Built on debia wheezy virtual box virtual machine. Logged on secondlife. 
> Checked logs and found no spamming. Do not have a native machine to test with.
> The change to llviewertexture.cpp around line 419 needs a close look.
> 
> 
> Thanks,
> 
> Nicky Perian
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges