Re: [opensource-dev] Review Request: Put the viewer version into marker files, and report errors only when the version matches

[Oz Linden (Scott Lawrence)]

On 2012-11-01 12:09 , Ricky wrote:
> Wouldn't it be better if the crash could be reported anyway - just 
> marking the correct version?  With this in place at least crashes 
> won't be misreported, but they also will be not reported to the 
> servers at all, causing statistical deviation - what I believe is the 
> core idea to be fixed.  More comments in the JIRA,

Unfortunately, because of the way the stats collection service works, 
that would be much more difficult.

My goal with this change is just to ensure that version A crashes are 
not counted as version B crashes, at the cost of possibly not counting 
all version A crashes.


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Formal Animation Set Replacer

[Oz Linden (Scott Lawrence)]

On 2012-11-02 11:01 , Adeon Writer wrote:
> A few months back there seemed to be interest on this mailing list in a 
> formal way to have custom animation sets for avatars without LSL scripts 
> (Animation Overriders)

Yes, this did kick off some interesting and fruitful discussions 
internally, but we've been consumed with other higher priority things 
since.  The issue is not forgotten, just not something we've got time 
for at the moment.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Materials

[Oz Linden (Scott Lawrence)]

On 2012-11-08 18:50 , Martin Fürholz wrote:

Nachricht
Hello,
Maestro Linden just announced that the materials project is live on Aditi,
is there a link for a project viewer to test the changes?

Large parts of the server side support for storing and retrieving the 
material data are running on a couple of Aditi regions, but we don't 
have a Project viewer yet.


Don't worry - when we do, we won't keep it a secret.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Materials

[Dahlia Trimble]

Are the protocol changes documented anywhere? Who might be able to provide
any information about them?

On Fri, Nov 9, 2012 at 12:36 PM, Oz Linden (Scott Lawrence) <
o...@lindenlab.com> wrote:

>  On 2012-11-08 18:50 , Martin Fürholz wrote:
>
> Hello,
> Maestro Linden just announced that the materials project is live on Aditi,
> is there a link for a project viewer to test the changes?
>
>  Large parts of the server side support for storing and retrieving the
> material data are running on a couple of Aditi regions, but we don't have a
> Project viewer yet.
>
> Don't worry - when we do, we won't keep it a secret.
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Materials

[Oz Linden (Scott Lawrence)]

On 2012-11-09 15:54 , Dahlia Trimble wrote:
> Are the protocol changes documented anywhere? Who might be able to 
> provide any information about them?

Not until we've got both sides implemented and tested, no.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Put the viewer version into marker files, and report errors only when the version matches

[Richard Nelson]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/607/#review1273
---

Ship it!


Functionally, it looks good...just one minor comment about structure


indra/newview/llappviewer.cpp


Structurally, it seems like this would be cleaner if opening the file, 
writing out the marke version, and closing it all happened in one function.  
Otherwise, you have this constraint that the file needs to be opened before 
being passed into recordMarkerVersion and closed afterwards.

Just picking a nit, sorry.


- Richard Nelson


On Nov. 2, 2012, 1:55 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/607/
> ---
> 
> (Updated Nov. 2, 2012, 1:55 p.m.)
> 
> 
> Review request for Viewer and Callum Prentice.
> 
> 
> Description
> ---
> 
> In all the marker files used to detect how the viewer run terminates, record 
> the version.  When checking the results, report errors only if the current 
> version matches the version in the file.  This prevents errors in one version 
> from being reported against the subsequent version.
> 
> 
> This addresses bug storm-1850.
> http://jira.secondlife.com/browse/storm-1850
> 
> 
> Diffs
> -
> 
>   indra/newview/llappviewer.h 3d35a13561fc 
>   indra/newview/llappviewer.cpp 3d35a13561fc 
> 
> Diff: http://codereview.secondlife.com/r/607/diff/
> 
> 
> Testing
> ---
> 
> Several simulated crashes both of the modified and unmodified viewers, and 
> some in which the marker file was modified manually to simulate different 
> viewers. Launched the new viewer after different crashes (and normal exits) 
> and confirmed (using logging temporarily added for that purpose) that the 
> reported last exec event was correct - and is always reported as Normal if 
> the previous version and the running version were not the same.
> 
> 
> Thanks,
> 
> Oz Linden
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Put the viewer version into marker files, and report errors only when the version matches

[Oz Linden]

> On Nov. 9, 2012, 2:05 p.m., Richard Nelson wrote:
> > indra/newview/llappviewer.cpp, line 3376
> > 
> >
> > Structurally, it seems like this would be cleaner if opening the file, 
> > writing out the marke version, and closing it all happened in one function. 
> >  Otherwise, you have this constraint that the file needs to be opened 
> > before being passed into recordMarkerVersion and closed afterwards.
> > 
> > Just picking a nit, sorry.

I didn't do that because the usage of the two marker files is so different: the 
exec marker file is locked, but the logout marker file is not; and there is at 
least one code path in which the logout marker file is (apparently 
deliberately) not closed at all.


- Oz


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/607/#review1273
---


On Nov. 2, 2012, 1:55 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/607/
> ---
> 
> (Updated Nov. 2, 2012, 1:55 p.m.)
> 
> 
> Review request for Viewer and Callum Prentice.
> 
> 
> Description
> ---
> 
> In all the marker files used to detect how the viewer run terminates, record 
> the version.  When checking the results, report errors only if the current 
> version matches the version in the file.  This prevents errors in one version 
> from being reported against the subsequent version.
> 
> 
> This addresses bug storm-1850.
> http://jira.secondlife.com/browse/storm-1850
> 
> 
> Diffs
> -
> 
>   indra/newview/llappviewer.h 3d35a13561fc 
>   indra/newview/llappviewer.cpp 3d35a13561fc 
> 
> Diff: http://codereview.secondlife.com/r/607/diff/
> 
> 
> Testing
> ---
> 
> Several simulated crashes both of the modified and unmodified viewers, and 
> some in which the marker file was modified manually to simulate different 
> viewers. Launched the new viewer after different crashes (and normal exits) 
> and confirmed (using logging temporarily added for that purpose) that the 
> reported last exec event was correct - and is always reported as Normal if 
> the previous version and the running version were not the same.
> 
> 
> Thanks,
> 
> Oz Linden
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Put the viewer version into marker files, and report errors only when the version matches

[Richard Nelson]

> On Nov. 9, 2012, 2:05 p.m., Richard Nelson wrote:
> > indra/newview/llappviewer.cpp, line 3376
> > 
> >
> > Structurally, it seems like this would be cleaner if opening the file, 
> > writing out the marke version, and closing it all happened in one function. 
> >  Otherwise, you have this constraint that the file needs to be opened 
> > before being passed into recordMarkerVersion and closed afterwards.
> > 
> > Just picking a nit, sorry.
> 
> Oz Linden wrote:
> I didn't do that because the usage of the two marker files is so 
> different: the exec marker file is locked, but the logout marker file is not; 
> and there is at least one code path in which the logout marker file is 
> (apparently deliberately) not closed at all.
>

Hmmm, ok.  Fair enough.


- Richard


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/607/#review1273
---


On Nov. 2, 2012, 1:55 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/607/
> ---
> 
> (Updated Nov. 2, 2012, 1:55 p.m.)
> 
> 
> Review request for Viewer and Callum Prentice.
> 
> 
> Description
> ---
> 
> In all the marker files used to detect how the viewer run terminates, record 
> the version.  When checking the results, report errors only if the current 
> version matches the version in the file.  This prevents errors in one version 
> from being reported against the subsequent version.
> 
> 
> This addresses bug storm-1850.
> http://jira.secondlife.com/browse/storm-1850
> 
> 
> Diffs
> -
> 
>   indra/newview/llappviewer.h 3d35a13561fc 
>   indra/newview/llappviewer.cpp 3d35a13561fc 
> 
> Diff: http://codereview.secondlife.com/r/607/diff/
> 
> 
> Testing
> ---
> 
> Several simulated crashes both of the modified and unmodified viewers, and 
> some in which the marker file was modified manually to simulate different 
> viewers. Launched the new viewer after different crashes (and normal exits) 
> and confirmed (using logging temporarily added for that purpose) that the 
> reported last exec event was correct - and is always reported as Normal if 
> the previous version and the running version were not the same.
> 
> 
> Thanks,
> 
> Oz Linden
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges