Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

(Updated Sept. 13, 2012, 5:52 a.m.)


Review request for Viewer.


Changes
---

Added the proposed changes(kelly and lance): jumping to the next match on 
commit (search-and-replace-floater); jump to the line and close on commit 
(goto-floater).


Description
---

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs (updated)
-

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/diff


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

(Updated Sept. 13, 2012, 6:20 a.m.)


Review request for Viewer.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs
-

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/diff


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

[MartinRJ Fayray]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
---

(Updated Sept. 13, 2012, 8:38 a.m.)


Review request for Viewer.


Changes
---

Fix: The current selection needs to be deselected before I can move the cursor 
to it's new position.


Description
---

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new 
file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' 
line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
https://jira.secondlife.com/browse/BUG-59


Diffs (updated)
-

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/


Testing
---

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go 
to line', enter a number less than 300 into the 'Go to' - field. Expected 
result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/598/#review1257
---



indra/newview/skins/default/xui/en/panel_people.xml


We think in would be clearer to use a message like:

You belong to [COUNT] groups, and can join [REMAINING] more.

where REMAINING is the maximum minus COUNT.


- Oz Linden


On Sept. 12, 2012, 1:29 p.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/598/
> ---
> 
> (Updated Sept. 12, 2012, 1:29 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> This patch adds the number of groups you're in to the bottom of the group 
> list.
> 
> 
> This addresses bug BUG-81.
> http://jira.secondlife.com/browse/BUG-81
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpeople.cpp 40296d1901e6 
>   indra/newview/skins/default/xui/en/panel_people.xml 40296d1901e6 
> 
> Diff: http://codereview.secondlife.com/r/598/diff/
> 
> 
> Testing
> ---
> 
> Testing done in the latest dolphin viewer beta, and in a recent 
> viewer-development fork. The actual implementation has been in Marine Kelleys 
> RLV for a while, and has been adapted with her permission.
> 
> 
> Thanks,
> 
> Lance Corrimal
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.

[Lance Corrimal]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/598/
---

(Updated Sept. 13, 2012, 2:04 p.m.)


Review request for Viewer.


Description
---

This patch adds the number of groups you're in to the bottom of the group list.


This addresses bug BUG-81.
http://jira.secondlife.com/browse/BUG-81


Diffs
-

  indra/newview/llpanelpeople.cpp 40296d1901e6 
  indra/newview/skins/default/xui/en/panel_people.xml 40296d1901e6 

Diff: http://codereview.secondlife.com/r/598/diff/


Testing
---

Testing done in the latest dolphin viewer beta, and in a recent 
viewer-development fork. The actual implementation has been in Marine Kelleys 
RLV for a while, and has been adapted with her permission.


Thanks,

Lance Corrimal

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.

[Lance Corrimal]

> On Sept. 13, 2012, 11:23 a.m., Oz Linden wrote:
> > indra/newview/skins/default/xui/en/panel_people.xml, line 451
> > 
> >
> > We think in would be clearer to use a message like:
> > 
> > You belong to [COUNT] groups, and can join [REMAINING] more.
> > 
> > where REMAINING is the maximum minus COUNT.

I have a new version in 
https://bitbucket.org/LanceCorrimal/storm-1910/changeset/275e5ab93bfa but for 
some reason CR does not let me upload a diff...


- Lance


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/598/#review1257
---


On Sept. 13, 2012, 2:04 p.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/598/
> ---
> 
> (Updated Sept. 13, 2012, 2:04 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> This patch adds the number of groups you're in to the bottom of the group 
> list.
> 
> 
> This addresses bug BUG-81.
> http://jira.secondlife.com/browse/BUG-81
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpeople.cpp 40296d1901e6 
>   indra/newview/skins/default/xui/en/panel_people.xml 40296d1901e6 
> 
> Diff: http://codereview.secondlife.com/r/598/diff/
> 
> 
> Testing
> ---
> 
> Testing done in the latest dolphin viewer beta, and in a recent 
> viewer-development fork. The actual implementation has been in Marine Kelleys 
> RLV for a while, and has been adapted with her permission.
> 
> 
> Thanks,
> 
> Lance Corrimal
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] New Release Viewer 3.4.0 being partially blocked by popular antivirus-software AVAST

[Martin Fürholz]

The latest release viewer 3.4.0 from
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-relea
se/rev/264700/arch/CYGWIN/installer/Second_Life_3-4-0-264700_Setup.exe is
being partially blocked by the popular antivirus-software AVAST.
The webkit plugin fails to load. Avast puts it into a sandbox by default
because it is: 'not wide-spread enough or has bad reviews'.
 
MartinRJ
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] New Release Viewer 3.4.0 being partially blocked by popular antivirus-software AVAST

[Liny Odell]

On Thu, Sep 13, 2012 at 7:47 PM, Martin Fürholz  wrote:
> The latest release viewer 3.4.0 from
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-release/rev/264700/arch/CYGWIN/installer/Second_Life_3-4-0-264700_Setup.exe
> is being partially blocked by the popular antivirus-software AVAST.
> The webkit plugin fails to load. Avast puts it into a sandbox by default
> because it is: 'not wide-spread enough or has bad reviews'.
>
> MartinRJ
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges

The avast sandbox is just that, its a sandbox thats used for testing
out a program to see if its safe, its not a blacklist or anything and
shouldnt affect the plugin's ability to run.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Added a UI field to display group count in the groups floater, plus code to update it. This adresses BUG-81.

[Lance Corrimal]

> On Sept. 13, 2012, 11:23 a.m., Oz Linden wrote:
> > indra/newview/skins/default/xui/en/panel_people.xml, line 451
> > 
> >
> > We think in would be clearer to use a message like:
> > 
> > You belong to [COUNT] groups, and can join [REMAINING] more.
> > 
> > where REMAINING is the maximum minus COUNT.
> 
> Lance Corrimal wrote:
> I have a new version in 
> https://bitbucket.org/LanceCorrimal/storm-1910/changeset/275e5ab93bfa but for 
> some reason CR does not let me upload a diff...

Latest version: 
http://dolphinsource.eregion.de/storm-1910/changeset/72f674a51acc/
Why can't I update the diff in this CR request anymore?


- Lance


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/598/#review1257
---


On Sept. 13, 2012, 2:04 p.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/598/
> ---
> 
> (Updated Sept. 13, 2012, 2:04 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> This patch adds the number of groups you're in to the bottom of the group 
> list.
> 
> 
> This addresses bug BUG-81.
> http://jira.secondlife.com/browse/BUG-81
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpeople.cpp 40296d1901e6 
>   indra/newview/skins/default/xui/en/panel_people.xml 40296d1901e6 
> 
> Diff: http://codereview.secondlife.com/r/598/diff/
> 
> 
> Testing
> ---
> 
> Testing done in the latest dolphin viewer beta, and in a recent 
> viewer-development fork. The actual implementation has been in Marine Kelleys 
> RLV for a while, and has been adapted with her permission.
> 
> 
> Thanks,
> 
> Lance Corrimal
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges