Re: [opensource-dev] Review Request: STORM-1908 - Can not put more than one item of certain kinds into a prim's content

2012-09-05 Thread Lance Corrimal

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/595/
---

(Updated Sept. 5, 2012, 3:02 a.m.)


Review request for Viewer.


Changes
---

jira issue has been moved to STORM


Summary (updated)
-

STORM-1908 - Can not put more than one item of certain kinds into a prim's 
content 


Description
---

Due to a merging mistake a already fixed bug has snuck back into 
viewer-development. This patch fixes that.


This addresses bug STORM-1908.
http://jira.secondlife.com/browse/STORM-1908


Diffs
-

  doc/contributions.txt 34dbbe2b00af 
  indra/newview/llviewerobject.cpp 34dbbe2b00af 

Diff: http://codereview.secondlife.com/r/595/diff/diff


Testing
---

I've build a test build based on latest viewer-development plus this patch, and 
the misbehaviour described in the jira is gone. I also have this patch in my 
latest beta dolphin viewer, and it works just fine.


Thanks,

Lance Corrimal

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1908 - Can not put more than one item of certain kinds into a prim's content

2012-09-05 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/595/#review1248
---


can you provide a pointer to the previous fix?

- Oz Linden


On Sept. 5, 2012, 3:02 a.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/595/
> ---
> 
> (Updated Sept. 5, 2012, 3:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Due to a merging mistake a already fixed bug has snuck back into 
> viewer-development. This patch fixes that.
> 
> 
> This addresses bug STORM-1908.
> http://jira.secondlife.com/browse/STORM-1908
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 34dbbe2b00af 
>   indra/newview/llviewerobject.cpp 34dbbe2b00af 
> 
> Diff: http://codereview.secondlife.com/r/595/diff/diff
> 
> 
> Testing
> ---
> 
> I've build a test build based on latest viewer-development plus this patch, 
> and the misbehaviour described in the jira is gone. I also have this patch in 
> my latest beta dolphin viewer, and it works just fine.
> 
> 
> Thanks,
> 
> Lance Corrimal
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1908 - Can not put more than one item of certain kinds into a prim's content

2012-09-05 Thread Lance Corrimal


> On Sept. 5, 2012, 6:29 a.m., Oz Linden wrote:
> > can you provide a pointer to the previous fix?

it was part of this commit: 
http://hg.secondlife.com/viewer-development/changeset/eb539c65e6ee26eea2bf373af2d0f4b52dc91289
and it got lost in this merge later: 
http://hg.secondlife.com/viewer-development/changeset/5411efe770c6b88bef7ce0491ee0f2ab5b57b682


- Lance


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/595/#review1248
---


On Sept. 5, 2012, 3:02 a.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/595/
> ---
> 
> (Updated Sept. 5, 2012, 3:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Due to a merging mistake a already fixed bug has snuck back into 
> viewer-development. This patch fixes that.
> 
> 
> This addresses bug STORM-1908.
> http://jira.secondlife.com/browse/STORM-1908
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 34dbbe2b00af 
>   indra/newview/llviewerobject.cpp 34dbbe2b00af 
> 
> Diff: http://codereview.secondlife.com/r/595/diff/diff
> 
> 
> Testing
> ---
> 
> I've build a test build based on latest viewer-development plus this patch, 
> and the misbehaviour described in the jira is gone. I also have this patch in 
> my latest beta dolphin viewer, and it works just fine.
> 
> 
> Thanks,
> 
> Lance Corrimal
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges