Re: [opensource-dev] Review Request: STORM-1898 Add "Copy SLURL" to context menu when right clicking Landmarks in Inventory

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/591/#review1244
---

Ship it!


Ship It!

- Oz Linden


On July 11, 2012, 4:01 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/591/
> ---
> 
> (Updated July 11, 2012, 4:01 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> SLURLs get passed around frequently in SL and on websites, etc. There should 
> be an easier way to copy the SLURL from a Landmark in inventory.
> 
> Currently you must go through several steps to copy a SLURL from a landmark 
> in inventory:
> 1)right click LM
> 2)Click "About Landmark"
> 3)Click "Map"
> 4)Click "Copy SLurl"
> 
> It would be much more efficient if you could just:
> 1)right click LM
> 2)click "Copy SLurl"
> 
> 
> This addresses bug STORM-1898.
> https://jira.secondlife.com/browse/STORM-1898
> 
> 
> Diffs
> -
> 
>   indra/newview/llinventorybridge.h 4d9106153407 
>   indra/newview/llinventorybridge.cpp 4d9106153407 
>   indra/newview/skins/default/xui/en/menu_inventory.xml 4d9106153407 
> 
> Diff: http://codereview.secondlife.com/r/591/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in jira.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1893: 'share' function (in friends-list) doesn't bring up the residents' IM window when it's minimized

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/589/#review1245
---



indra/newview/llavataractions.cpp


Shouldn't this check for a null return?


- Oz Linden


On July 2, 2012, 3:59 p.m., MartinRJ Fayray wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/589/
> ---
> 
> (Updated July 2, 2012, 3:59 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Repository is here: https://bitbucket.org/MartinRJ/storm-1893
> 
> I just added two calls to show() and setVisible() in LLAvatarActions::share 
> to bring the IM window to front even when it's minimized.
> 
> 
> This addresses bug STORM-1893.
> https://jira.secondlife.com/browse/STORM-1893
> 
> 
> Diffs
> -
> 
>   indra/newview/llavataractions.cpp 4d9106153407 
> 
> Diff: http://codereview.secondlife.com/r/589/diff/diff
> 
> 
> Testing
> ---
> 
> Please see the test plan in the Jira.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1879: Inventory gear menu remains on screen after floater is closed

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/588/#review1246
---

Ship it!


Ship It!

- Oz Linden


On June 25, 2012, 5:45 a.m., MartinRJ Fayray wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/588/
> ---
> 
> (Updated June 25, 2012, 5:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Hide menus when the closed floater has focus.
> Added a check whether a "VisibilityChange"-action was triggered via shortcut.
> 
> Repository: https://bitbucket.org/MartinRJ/storm-1879
> 
> 
> This addresses bug STORM-1879.
> https://jira.secondlife.com/browse/STORM-1879
> 
> 
> Diffs
> -
> 
>   indra/llui/llfloater.cpp 4d9106153407 
>   indra/llui/lltoggleablemenu.cpp 4d9106153407 
> 
> Diff: http://codereview.secondlife.com/r/588/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in JIRA: https://jira.secondlife.com/browse/STORM-1879
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges