Re: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

2012-04-06 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review910
---



indra/newview/llpanelpermissions.cpp


make the comments match the code


- Oz Linden


On July 22, 2011, 11:47 a.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated July 22, 2011, 11:47 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/storm-1453
> 
> 
> This addresses bug STORM-1453.
> http://jira.secondlife.com/browse/STORM-1453
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
>   indra/newview/llsidepaneltaskinfo.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah Coba
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] GTX680 Compatibility

2012-04-06 Thread Ann Otoole
Will SL run on the new nVidia GTX680? If not are there any plans to advance 
Secondlife with the way Video card technology is moving?___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] GTX680 Compatibility

2012-04-06 Thread Geenz
It *should* run, provided Nvidia hasn't done anything funky with their drivers. 

-- 
Geenz
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Friday, April 6, 2012 at 1:43 PM, Ann Otoole wrote:

> Will SL run on the new nVidia GTX680? If not are there any plans to advance 
> Secondlife with the way Video card technology is moving?
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
> 
> 


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

2012-04-06 Thread Kadah Coba


> On April 6, 2012, 9:03 a.m., Oz Linden wrote:
> > indra/newview/llpanelpermissions.cpp, lines 486-487
> > 
> >
> > make the comments match the code

For what its worth, I've made the comments more verbose.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review910
---


On July 22, 2011, 11:47 a.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated July 22, 2011, 11:47 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/storm-1453
> 
> 
> This addresses bug STORM-1453.
> http://jira.secondlife.com/browse/STORM-1453
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
>   indra/newview/llsidepaneltaskinfo.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah Coba
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] GTX680 Compatibility

2012-04-06 Thread Ann Otoole
I know there are some interesting changes in respect to shaders. Also some 
possible disinformation going around about no shaders but that looks to be 
bogus. Maybe we will have to wait and see what happens to the first lucky 
person into the pool with a 680.




 From: Geenz 
To: Ann Otoole  
Cc: Viewer  
Sent: Friday, April 6, 2012 2:12 PM
Subject: Re: [opensource-dev] GTX680 Compatibility
 

It *should* run, provided Nvidia hasn't done anything funky with their drivers. 


-- 
Geenz
Sent with Sparrow

On Friday, April 6, 2012 at 1:43 PM, Ann Otoole wrote:
Will SL run on the new nVidia GTX680? If not are there any plans to advance 
Secondlife with the way Video card technology is moving?
>
>
>___
>Policies and (un)subscribe information available here:
>http://wiki.secondlife.com/wiki/OpenSource-Dev
>Please read the policies before posting to keep unmoderated posting privileges ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] GTX680 Compatibility

2012-04-06 Thread Celierra Darling
That might refer to the fact that the new nvidia cards don't have a
separate shader *clock*.  That is, they still have shader hardware, but you
can't speed up or slow down the shaders separately from the rest of the gpu
anymore.  That shouldn't do much in terms of compatibility.
Celi
On Apr 6, 2012 2:23 PM, "Ann Otoole"  wrote:

> I know there are some interesting changes in respect to shaders. Also some
> possible disinformation going around about no shaders but that looks to be
> bogus. Maybe we will have to wait and see what happens to the first lucky
> person into the pool with a 680.
>
>   --
> *From:* Geenz 
> *To:* Ann Otoole 
> *Cc:* Viewer 
> *Sent:* Friday, April 6, 2012 2:12 PM
> *Subject:* Re: [opensource-dev] GTX680 Compatibility
>
>  It *should* run, provided Nvidia hasn't done anything funky with their
> drivers.
>
> --
> Geenz
> Sent with Sparrow 
>
> On Friday, April 6, 2012 at 1:43 PM, Ann Otoole wrote:
>
> Will SL run on the new nVidia GTX680? If not are there any plans to
> advance Secondlife with the way Video card technology is moving?
>
>  ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
>
>
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges