Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 3.0 implementation.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/566/ --- (Updated April 3, 2012, 1:22 p.m.) Review request for Viewer, Callum Linden and Richard Nelson. Changes --- STORM-64: fix for crash under STORM-1837, added a warn on invalid/unreadable bitmap, and changed a bool to enum. Description --- Local Bitmaps is a mechanism to locally load images into the viewer, track them and optionally (per each image) have it check if the image has been overwritten locally and if so - update it in the viewer and inworld. This change affects the texture picker - adding radio checks that let the user choose between the "Inventory" (regular inventory) and "Local" tabs (list of locally added files). *** DO NOT USE THIS YET *** do not implement for live viewers until fully reviewed. This addresses bug STORM-64. http://jira.secondlife.com/browse/STORM-64 Diffs (updated) - doc/contributions.txt 96a53bafcd1c indra/newview/CMakeLists.txt 96a53bafcd1c indra/newview/lllocalbitmaps.h PRE-CREATION indra/newview/lllocalbitmaps.cpp PRE-CREATION indra/newview/lltexturectrl.h 96a53bafcd1c indra/newview/lltexturectrl.cpp 96a53bafcd1c indra/newview/llviewertexturelist.h 96a53bafcd1c indra/newview/llwearable.h 96a53bafcd1c indra/newview/llwearable.cpp 96a53bafcd1c indra/newview/skins/default/xui/en/floater_texture_ctrl.xml 96a53bafcd1c Diff: http://codereview.secondlife.com/r/566/diff/diff Testing --- Thanks, Vaalith Jinn ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1828 Sometimes the file character/new archetype.xml is not produced. Sometimes it is present after the viewer is closed. Sometimes it is present and can't be
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/570/ --- (Updated April 3, 2012, 6:37 p.m.) Review request for Viewer and Oz Linden. Description --- Sometimes the file character/new archetype.xml is not produced. Sometimes it is present after the viewer is closed. Sometimes it is present and can't be made to fail. Intermittent write to character/new archetype.xml from Develop->Avatar-> Character Tests->Apperance To XML. Add explicit outfile.close() method before returning to caller. Add llinfos for file location as a troubleshooting aid. This addresses bug STORM-1828. http://jira.secondlife.com/browse/STORM-1828 Diffs (updated) - doc/contributions.txt 6943d3e9deb7 indra/newview/llvoavatar.cpp 6943d3e9deb7 Diff: http://codereview.secondlife.com/r/570/diff/diff Testing (updated) --- First checked that the patch did no harm. Second seems more stable after running with the patch applied. * Tested the file write in a development and installed configurations. Repeated Develop->Avatar-> Character Tests->Apperance To XML several times while watching the time file time stamp. No failures were noted. Thanks, Nicky Perian ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
