Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

[Lance Corrimal]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/543/#review1170
---

Ship it!


Testing done: this tool has been in dolphin viewer for over a year now, to 
great benefit of the users, and has shown no problems.

- Lance Corrimal


On March 2, 2012, 12:30 a.m., Tobias Roth wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/543/
> ---
> 
> (Updated March 2, 2012, 12:30 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Qarls Aligning tool ported over from Nirans Viewer for code review
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloatertools.cpp b91d07f8fad9 
>   indra/newview/qtoolalign.h PRE-CREATION 
>   indra/newview/qtoolalign.cpp PRE-CREATION 
>   indra/newview/skins/default/xui/de/floater_tools.xml b91d07f8fad9 
>   indra/newview/skins/default/xui/en/floater_tools.xml b91d07f8fad9 
> 
> Diff: http://codereview.secondlife.com/r/543/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tobias Roth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

[Liny Odell]

Please see https://jira.secondlife.com/browse/STORM-468

On Fri, Mar 2, 2012 at 1:45 AM, Lance Corrimal wrote:

>This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/543/
>
> Ship it!
>
> Testing done: this tool has been in dolphin viewer for over a year now, to 
> great benefit of the users, and has shown no problems.
>
>
> - Lance
>
> On March 2nd, 2012, 12:30 a.m., Tobias Roth wrote:
>   Review request for Viewer.
> By Tobias Roth.
>
> *Updated March 2, 2012, 12:30 a.m.*
> Description
>
> Qarls Aligning tool ported over from Nirans Viewer for code review
>
>   Diffs
>
>- indra/newview/llfloatertools.cpp (b91d07f8fad9)
>- indra/newview/qtoolalign.h (PRE-CREATION)
>- indra/newview/qtoolalign.cpp (PRE-CREATION)
>- indra/newview/skins/default/xui/de/floater_tools.xml (b91d07f8fad9)
>- indra/newview/skins/default/xui/en/floater_tools.xml (b91d07f8fad9)
>
> View Diff 
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/543/#review1171
---


Do qtoolsalign.cpp aand qtoolsalign.h need to added to 
/indra/newview/CMakeLists.txt?


- Nicky Perian


On March 2, 2012, 12:30 a.m., Tobias Roth wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/543/
> ---
> 
> (Updated March 2, 2012, 12:30 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Qarls Aligning tool ported over from Nirans Viewer for code review
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloatertools.cpp b91d07f8fad9 
>   indra/newview/qtoolalign.h PRE-CREATION 
>   indra/newview/qtoolalign.cpp PRE-CREATION 
>   indra/newview/skins/default/xui/de/floater_tools.xml b91d07f8fad9 
>   indra/newview/skins/default/xui/en/floater_tools.xml b91d07f8fad9 
> 
> Diff: http://codereview.secondlife.com/r/543/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tobias Roth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

[Lance Corrimal]

You do know that that jira links to this CR request, right?


bye,
LC

Am Freitag, 2. März 2012, 10:36:25 schrieb Liny Odell:
> Please see https://jira.secondlife.com/browse/STORM-468
> 
> On Fri, Mar 2, 2012 at 1:45 AM, Lance Corrimal 
wrote:
> >This is an automatically generated e-mail. To reply, visit:
> > http://codereview.secondlife.com/r/543/
> > 
> > Ship it!
> > 
> > Testing done: this tool has been in dolphin viewer for over a year now, to
> > great benefit of the users, and has shown no problems.
> > 
> > 
> > - Lance
> > 
> > On March 2nd, 2012, 12:30 a.m., Tobias Roth wrote:
> >   Review request for Viewer.
> > 
> > By Tobias Roth.
> > 
> > *Updated March 2, 2012, 12:30 a.m.*
> > Description
> > 
> > Qarls Aligning tool ported over from Nirans Viewer for code review
> > 
> >   Diffs
> >   
> >- indra/newview/llfloatertools.cpp (b91d07f8fad9)
> >- indra/newview/qtoolalign.h (PRE-CREATION)
> >- indra/newview/qtoolalign.cpp (PRE-CREATION)
> >- indra/newview/skins/default/xui/de/floater_tools.xml (b91d07f8fad9)
> >- indra/newview/skins/default/xui/en/floater_tools.xml (b91d07f8fad9)
> > 
> > View Diff 
> > 
> > ___
> > Policies and (un)subscribe information available here:
> > http://wiki.secondlife.com/wiki/OpenSource-Dev
> > Please read the policies before posting to keep unmoderated posting
> > privileges
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

[Tankmaster Finesmith]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/543/#review1172
---


I would suggest using "size *= 1.25;" instead of "size *= 2.0;" to better 
conform with existing hover over edit arrows behavior (normal edit arrows).  
This is what we use in Firestorm currently.
This is in qtoolalign.cpp line 330

- Tankmaster Finesmith


On March 2, 2012, 12:30 a.m., Tobias Roth wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/543/
> ---
> 
> (Updated March 2, 2012, 12:30 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Qarls Aligning tool ported over from Nirans Viewer for code review
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloatertools.cpp b91d07f8fad9 
>   indra/newview/qtoolalign.h PRE-CREATION 
>   indra/newview/qtoolalign.cpp PRE-CREATION 
>   indra/newview/skins/default/xui/de/floater_tools.xml b91d07f8fad9 
>   indra/newview/skins/default/xui/en/floater_tools.xml b91d07f8fad9 
> 
> Diff: http://codereview.secondlife.com/r/543/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tobias Roth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

[Nicky Perian]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/543/#review1173
---


qtoolalign not qtools

- Nicky Perian


On March 2, 2012, 12:30 a.m., Tobias Roth wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/543/
> ---
> 
> (Updated March 2, 2012, 12:30 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Qarls Aligning tool ported over from Nirans Viewer for code review
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloatertools.cpp b91d07f8fad9 
>   indra/newview/qtoolalign.h PRE-CREATION 
>   indra/newview/qtoolalign.cpp PRE-CREATION 
>   indra/newview/skins/default/xui/de/floater_tools.xml b91d07f8fad9 
>   indra/newview/skins/default/xui/en/floater_tools.xml b91d07f8fad9 
> 
> Diff: http://codereview.secondlife.com/r/543/diff/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tobias Roth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Implement Qarls Aligning tool into Tools floater

[Liny Odell]

Yea, I noticed that as read more into the comments on that jira, but
it may be useful for others to have a link in both directions (into
and out of the code review)

On Fri, Mar 2, 2012 at 10:48 AM, Lance Corrimal
 wrote:
> You do know that that jira links to this CR request, right?
>
>
> bye,
> LC
>
> Am Freitag, 2. März 2012, 10:36:25 schrieb Liny Odell:
>> Please see https://jira.secondlife.com/browse/STORM-468
>>
>> On Fri, Mar 2, 2012 at 1:45 AM, Lance Corrimal
> wrote:
>> >    This is an automatically generated e-mail. To reply, visit:
>> > http://codereview.secondlife.com/r/543/
>> >
>> > Ship it!
>> >
>> > Testing done: this tool has been in dolphin viewer for over a year now, to
>> > great benefit of the users, and has shown no problems.
>> >
>> >
>> > - Lance
>> >
>> > On March 2nd, 2012, 12:30 a.m., Tobias Roth wrote:
>> >   Review request for Viewer.
>> >
>> > By Tobias Roth.
>> >
>> > *Updated March 2, 2012, 12:30 a.m.*
>> > Description
>> >
>> > Qarls Aligning tool ported over from Nirans Viewer for code review
>> >
>> >   Diffs
>> >
>> >    - indra/newview/llfloatertools.cpp (b91d07f8fad9)
>> >    - indra/newview/qtoolalign.h (PRE-CREATION)
>> >    - indra/newview/qtoolalign.cpp (PRE-CREATION)
>> >    - indra/newview/skins/default/xui/de/floater_tools.xml (b91d07f8fad9)
>> >    - indra/newview/skins/default/xui/en/floater_tools.xml (b91d07f8fad9)
>> >
>> > View Diff 
>> >
>> > ___
>> > Policies and (un)subscribe information available here:
>> > http://wiki.secondlife.com/wiki/OpenSource-Dev
>> > Please read the policies before posting to keep unmoderated posting
>> > privileges
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges