Re: [opensource-dev] Review Request: STORM-1808 Indicate ability to build

2012-02-22 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/553/#review1165
---

Ship it!


Ship It!

- Oz Linden


On Feb. 19, 2012, 1:22 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/553/
> ---
> 
> (Updated Feb. 19, 2012, 1:22 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> When standing in a parcel it would be helpful to have a graphical indication 
> in the UI if you are able to build/rez.
> 
> The icon in the (mini) location bar shows parcel properties, not what is 
> available to you as parcel owner or as a member of a group that has rezzing 
> enabled as one of your group roles.
> 
> Suggested solution: Gray out the build button if it is present on the 
> toolbar, just like the Speak button is grayed out if voice is not available.
> 
> 
> This addresses bug STORM-1808.
> http://jira.secondlife.com/browse/STORM-1808
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 0a41a8750048 
>   indra/newview/app_settings/commands.xml 0a41a8750048 
>   indra/newview/llagent.cpp 0a41a8750048 
>   indra/newview/lltoolmgr.h 0a41a8750048 
>   indra/newview/lltoolmgr.cpp 0a41a8750048 
> 
> Diff: http://codereview.secondlife.com/r/553/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in jira.
> 
> I also searched the xml files to be sure no other calls to 
> LLAgent::isActionAllowed were being made.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1793 1) Treat all mini-map altitudes above 1020 m as the same height 2) Improve z-level accuracy

2012-02-22 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/545/#review1166
---

Ship it!


Ship It!

- Oz Linden


On Feb. 7, 2012, 6:28 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/545/
> ---
> 
> (Updated Feb. 7, 2012, 6:28 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> The SL simulator has recently been fixed so that the CoarseLocationUpdate 
> message properly returns 255 for all altitudes above 1020 meters.
> 
> The code for the mini-map, in drawing the agent locations for equal, above or 
> below needs to take this into account. It currently does not.
> 
> The routine that returns who is nearby can be enhanced to scan the character 
> list and use that position data.  This gives an accurate z-level value, even 
> when above 1020m.
> 
> In the case where the relative Z value between you and another avatar is 
> unknown display an X on the mini-map.
> 
> 
> This addresses bug STORM-1793.
> http://jira.secondlife.com/browse/STORM-1793
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 0010858de5a1 
>   indra/newview/llnetmap.cpp 0010858de5a1 
>   indra/newview/llworld.cpp 0010858de5a1 
>   indra/newview/llworldmapview.h 0010858de5a1 
>   indra/newview/llworldmapview.cpp 0010858de5a1 
> 
> Diff: http://codereview.secondlife.com/r/545/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in jira
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1809 The word "Multiple" does NOT show in the edit window when editing prims or linksets with mixed textures in LL V3

2012-02-22 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/551/#review1167
---

Ship it!


Ship It!

- Oz Linden


On Feb. 8, 2012, 11:31 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/551/
> ---
> 
> (Updated Feb. 8, 2012, 11:31 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> When building, a creator has always been able to look at the texture window 
> to see if a prim or linkset is mixed textures or one complete texture by 
> seeing the word "multiple" over the texture. This no longer happens in Viewer 
> 3.
> 
> 
> This addresses bug STORM-1809.
> http://jira.secondlife.com/browse/STORM-1809
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 767757e005e3 
>   indra/newview/lltexturectrl.cpp 767757e005e3 
>   indra/newview/skins/default/xui/en/strings.xml 767757e005e3 
> 
> Diff: http://codereview.secondlife.com/r/551/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in jira.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1807 Play animation floater 2nd play button active while animation is playing

2012-02-22 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/552/#review1168
---

Ship it!


Ship It!

- Oz Linden


On Feb. 18, 2012, 5:24 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/552/
> ---
> 
> (Updated Feb. 18, 2012, 5:24 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Part 1
> Open your inventory's Animations folder
> Double click on an animation
> Click on Play Inworld: Play Inworld is replaced by a Stop button
> 
> Observed behavior: It is still possible to click on Play Locally, which also 
> is replaced by a Stop button. Clicking on either Stop works and resets the 
> floater back to having both Play buttons showing.
> 
> Expected behavior: When one of the play buttons is clicked the other should 
> be disabled.
> 
> 
> Part 2
> 1 .To reproduce, get any non looping animation. ie, one that plays once and 
> then stops.
> 2. Right click in inventory and select play in world.
> 3. The animation dialog appears with play locally and play in world buttons.
> 4. When the animation is playing, the play in world button changes to a stop 
> button, which makes it stop playing.
> Now here's the problem:
> 5. When the animation finishes of it's own accord, the button still says 
> stop. To play it again, you have to click the redundant stop button to make 
> it change back to Play in World, then click that to play again.
> 
> Expected behaviour, is that when an animation finishes, the stop button 
> should change back of it's own accord. 
> 
> 
> This addresses bug STORM-1807.
> http://jira.secondlife.com/browse/STORM-1807
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 0a41a8750048 
>   indra/newview/llinventorybridge.cpp 0a41a8750048 
>   indra/newview/llpreviewanim.h 0a41a8750048 
>   indra/newview/llpreviewanim.cpp 0a41a8750048 
>   indra/newview/skins/default/xui/en/floater_preview_animation.xml 
> 0a41a8750048 
> 
> Diff: http://codereview.secondlife.com/r/552/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in jira.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] ETA on Agni Pathfinding?

2012-02-22 Thread malachi
Anyone have any idea of and ETA for pathfinding to go Agni? Any rumors 
of such a time frame?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] ETA on Agni Pathfinding?

2012-02-22 Thread Jonathan Welch
I asked this at the Server meeting yesterday; no release date has been
established yet.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges