Re: [opensource-dev] Review Request: STORM-1803 Adding raw anim file upload support

2012-02-06 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/546/#review1161
---

Ship it!


Ship It!

- Oz Linden


On Jan. 31, 2012, 2:07 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/546/
> ---
> 
> (Updated Jan. 31, 2012, 2:07 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Adds support for uploading .anim files as part of Upload->Animation or as a 
> Bulk Upload.
> 
> For naming consistency and clearness some bvh-related files were renamed to 
> reflect their function.
> 
> 
> This addresses bug STORM-1803.
> http://jira.secondlife.com/browse/STORM-1803
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b91d07f8fad9 
>   indra/newview/CMakeLists.txt b91d07f8fad9 
>   indra/newview/llfilepicker.cpp b91d07f8fad9 
>   indra/newview/llfloateranimpreview.h b91d07f8fad9 
>   indra/newview/llfloateranimpreview.cpp b91d07f8fad9 
>   indra/newview/llfloaterbvhpreview.h PRE-CREATION 
>   indra/newview/llfloaterbvhpreview.cpp PRE-CREATION 
>   indra/newview/llfloaternamedesc.h b91d07f8fad9 
>   indra/newview/llfloaternamedesc.cpp b91d07f8fad9 
>   indra/newview/llviewerfloaterreg.cpp b91d07f8fad9 
>   indra/newview/llviewermenufile.cpp b91d07f8fad9 
>   indra/newview/skins/default/xui/en/floater_animation_anim_preview.xml 
> PRE-CREATION 
>   indra/newview/skins/default/xui/en/floater_animation_bvh_preview.xml 
> PRE-CREATION 
>   indra/newview/skins/default/xui/en/floater_animation_preview.xml 
> b91d07f8fad9 
>   indra/newview/skins/default/xui/en/notifications.xml b91d07f8fad9 
> 
> Diff: http://codereview.secondlife.com/r/546/diff/diff
> 
> 
> Testing
> ---
> 
> See Test Plan in jira
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1804 Details... button on PERMISSION_DEBIT dialog triggers run_time_permissions() with a deny action

2012-02-06 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/544/#review1162
---

Ship it!



indra/newview/llviewermessage.cpp


No ... leave it


- Oz Linden


On Jan. 25, 2012, 4:47 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/544/
> ---
> 
> (Updated Jan. 25, 2012, 4:47 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> When an object requests DEBIT permissions a large, yellow dialog appears. 
> This dialog has three buttons: "Grant", "Deny", and "Details..." When you 
> select "Details..." Additional information about DEBIT permission is 
> displayed.
> 
> The bug is that when "Details..." is selected PERMISSION_DEBIT is denied and 
> the run_time_permissions() event handler is triggered. There is also a system 
> message in the Local Chat pane of the communicate window that informs the 
> user that permission has been denied. Further, if "Grant" or "Deny" are 
> pressed AFTER details the run_time_permissions() event handler is NOT 
> triggered, yet there is a system message saying that permissions have been 
> granted or denied.
> 
> What should happen when "Details..." is pressed is no run_time_permissions 
> event should be triggered and the "Grant" and "Deny" buttons should operate 
> normally and trigger the run_time_permissions event afterwards.
> 
> 
> This addresses bug STORM-1804.
> http://jira.secondlife.com/browse/STORM-1804
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3f2162768b29 
>   indra/newview/llviewermessage.cpp 3f2162768b29 
> 
> Diff: http://codereview.secondlife.com/r/544/diff/diff
> 
> 
> Testing
> ---
> 
> See test script in jira.
> 
> Click on Details: additional information is shown, click on Ok to dismiss 
> that, then you can go back and click on Grant or Deny.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1793 1) Treat all mini-map altitudes above 1020 m as the same height 2) Improve z-level accuracy

2012-02-06 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/545/#review1163
---

Ship it!



indra/newview/llworld.cpp


When wrapping conditions across lines, I find it more clear to put the 
operators on the left:

if (   condition1
&& condition2
...




- Oz Linden


On Feb. 3, 2012, 8:51 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/545/
> ---
> 
> (Updated Feb. 3, 2012, 8:51 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> The SL simulator has recently been fixed so that the CoarseLocationUpdate 
> message properly returns 255 for all altitudes above 1020 meters.
> 
> The code for the mini-map, in drawing the agent locations for equal, above or 
> below needs to take this into account. It currently does not.
> 
> The routine that returns who is nearby can be enhanced to scan the character 
> list and use that position data.  This gives an accurate z-level value, even 
> when above 1020m.
> 
> In the case where the relative Z value between you and another avatar is 
> unknown display an X on the mini-map.
> 
> 
> This addresses bug STORM-1793.
> http://jira.secondlife.com/browse/STORM-1793
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 0010858de5a1 
>   indra/newview/llnetmap.cpp 0010858de5a1 
>   indra/newview/llworld.cpp 0010858de5a1 
>   indra/newview/llworldmapview.h 0010858de5a1 
>   indra/newview/llworldmapview.cpp 0010858de5a1 
> 
> Diff: http://codereview.secondlife.com/r/545/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in jira
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Inventory Patch you should integrate

2012-02-06 Thread Jenn Leech 
I should add that we are also testing inventory routing changes on those
sims on aditi as well. Items which are *newly* sent to your inventory
should show up in the Received Items folder (e.g. someone gives you an
item, you purchase an item etc. - these will show up in this new system
folder).

We plan to announce a public beta for testing these behavior changes in the
next couple of weeks and have been performing primarily internal testing so
far.

We will be debugging and re-deploying throughout this week as we continue
with internal testing, but these simulators should be essentially
functional for testing Viewer changes.

Thx!
- Jenn

On Fri, Feb 3, 2012 at 11:59 AM, Oz Linden (Scott Lawrence) <
o...@lindenlab.com> wrote:

> On 2012-01-28 14:13 , Henri Beauchamp wrote:
> > On Fri, 27 Jan 2012 16:57:20 -0500, Oz Linden (Scott Lawrence) wrote:
> >
> >> Sorry for the delay letting you know - the inventory service on Aditi is
> >> running the version this is needed for, so if you want to test a port,
> >> do it there.
> > The feature also depends on a sim capability, and as far as I could see
> > (and in the sim I tested the feature in), that capability is not yet
> > implemented/advertized... Could you please tell us which sims advertize
> > the new "CreateInventoryCategory" capability on Aditi ?
> >
>
> I didn't realize that it wasn't everywhere it should be enabled on
> the Inventory Test regions on aditi. Info available here:
> https://wiki.secondlife.com/wiki/InventoryBetaTest
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges