Re: [opensource-dev] Review Request: STORM-1795 Ad-hoc messages are received even when "Only friends and groups can call or IM me"

2012-01-24 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/536/#review1156
---

Ship it!


Ship It!

- Oz Linden


On Jan. 23, 2012, 2:45 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/536/
> ---
> 
> (Updated Jan. 23, 2012, 2:45 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> With avatar A: check on Preferences->Privacy->Only friends and groups can 
> call or IM me
> 
> Get together with:
> Avatar B (not a friend of A)
> Avatar C (a friend of A)
> 
> Using avatar B establish an ad-hoc chat with A and C and write a message
> 
> Observed result: Avatar A and C receive the message
> Expected result: Only avatar C receives the message
> 
> 
> This addresses bug STORM-1795.
> http://jira.secondlife.com/browse/STORM-1795
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 4982ab91ef6a 
>   indra/newview/llimview.cpp 4982ab91ef6a 
> 
> Diff: http://codereview.secondlife.com/r/536/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in jira
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] mesh upload crash in recent builds...

2012-01-24 Thread Dave Booth
Somewhere between the branch for the current beta and the tip is a 
mistake leading to an instant crash when selecting "upload -> model" 
from the inventory floaters "+" menu. It's a 0xc5 exception, the 
windows equivalent of your garden-variety segfault, pulling up the dmp 
file in vs2010 looks like the viewer is passing a null pointer into a 
call to strstr somewhere.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] mesh upload crash in recent builds...

2012-01-24 Thread Jonathan Welch
It sounds like you are running a self-compiled viewer, in which case
OPEN-113 probably applies (Build > Upload > Model is not disabled in
OS built viewers)

https://jira.secondlife.com/browse/OPEN-113
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] mesh upload crash in recent builds...

2012-01-24 Thread Jonathan Welch
Do you get the same result/crash when trying to upload via a different
menu entry point?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] mesh upload crash in recent builds...

2012-01-24 Thread Dave Booth
On 1/24/2012 4:20 PM, Jonathan Welch wrote:
> Do you get the same result/crash when trying to upload via a different
> menu entry point?
>
Yep, Build > Upload > Model produces the same result as Inventory 
Floater > + > Upload > Model. Immediate crash with the same exception 
before the dialog to select a .dae is displayed.

Its mesh-specific, no crash trying to upload any other kind of asset. 
It's relatively recent, whichever changeset caused it, a little while 
ago I was able to upload meshes no problem and the problem is not 
present in the current beta download.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


Re: [opensource-dev] mesh upload crash in recent builds...

2012-01-24 Thread Nicky Perian
Here is a mesh up load test viewer (hours old) using hacd. Please keep in mind 
that this is in no way a production viewer and is not supported by linden lab. 
Best try with an alt and on aditi. It worked for me just a few minutes ago.
http://bitbucket.org/NickyP/viewer-development-os-mesh-upload/downloads/Second_Life_3-2-8-0_LindenDeveloper_Setup.exe





 From: Jonathan Welch 
To: Dave Booth  
Cc: Viewer  
Sent: Tuesday, January 24, 2012 4:20 PM
Subject: Re: [opensource-dev] mesh upload crash in recent builds...
 
Do you get the same result/crash when trying to upload via a different
menu entry point?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] mesh upload crash in recent builds...

2012-01-24 Thread Dave Booth
Clarifying "relatively recent" - my last successful mesh uploads on the 
dev snapshot builds were on Jan 2nd, using 3.2.6.246889 from Dec 20th (I 
only update my download when the commits list gets a note) so whatever 
introduced this was in the 31 changesets on 1/6, the 41 on 1/8, the 6 
(in two merges) on 1/9, the 15 on 1/17 or the 11 on 1/23. Obviously any 
of those merges predating the branch for the current beta can be 
excluded, which makes me look exceptionally suspiciously at the two 
builds since the version was updated to 3.2.8, namely 247796 on 1/22 and 
248202 on 1/23 - but that dont stop me suspecting every build since I 
last successfully used it to upload a mesh :P

Spending 30 years as a sysadmin makes me VERY willing to believe that a 
developer can break stuff in ways that defy logic :)

On 1/24/2012 4:32 PM, Dave Booth wrote:
> On 1/24/2012 4:20 PM, Jonathan Welch wrote:
>> Do you get the same result/crash when trying to upload via a different
>> menu entry point?
>>
> Yep, Build>  Upload>  Model produces the same result as Inventory
> Floater>  +>  Upload>  Model. Immediate crash with the same exception
> before the dialog to select a .dae is displayed.
>
> Its mesh-specific, no crash trying to upload any other kind of asset.
> It's relatively recent, whichever changeset caused it, a little while
> ago I was able to upload meshes no problem and the problem is not
> present in the current beta download.


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges