[opensource-dev] Review Request: VWR-28087: When I upload a texture, the "preview as" dropdown in the preview window is hidden under the texture

[Lance Corrimal]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/532/
---

Review request for Viewer.


Description
---

At some point in the last 8 months the height of image previews in the upload 
preview floater was increased by 20, without adapting the actual floater, 
leading to VWR-28087.
This small patch fixes that by adapting the preview floater to the new height.


This addresses bug VWR-28087.
http://jira.secondlife.com/browse/VWR-28087


Diffs
-

  indra/newview/skins/default/xui/en/floater_image_preview.xml 4982ab91ef6a 

Diff: http://codereview.secondlife.com/r/532/diff/diff


Testing
---

tested with release viewer 3.2.5 and my own TPV, works fine.


Thanks,

Lance Corrimal

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-28087: When I upload a texture, the "preview as" dropdown in the preview window is hidden under the texture

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/532/#review1137
---



indra/newview/skins/default/xui/en/floater_image_preview.xml


Why are you changing this by 25 when in the other two locations you are 
only increasing by 20?


- Jonathan Yap


On Jan. 12, 2012, 12:23 a.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/532/
> ---
> 
> (Updated Jan. 12, 2012, 12:23 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> At some point in the last 8 months the height of image previews in the upload 
> preview floater was increased by 20, without adapting the actual floater, 
> leading to VWR-28087.
> This small patch fixes that by adapting the preview floater to the new height.
> 
> 
> This addresses bug VWR-28087.
> http://jira.secondlife.com/browse/VWR-28087
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/en/floater_image_preview.xml 4982ab91ef6a 
> 
> Diff: http://codereview.secondlife.com/r/532/diff/diff
> 
> 
> Testing
> ---
> 
> tested with release viewer 3.2.5 and my own TPV, works fine.
> 
> 
> Thanks,
> 
> Lance Corrimal
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-28087: When I upload a texture, the "preview as" dropdown in the preview window is hidden under the texture

[Lance Corrimal]

> On Jan. 12, 2012, 1:31 a.m., Jonathan Yap wrote:
> > indra/newview/skins/default/xui/en/floater_image_preview.xml, line 111
> > 
> >
> > Why are you changing this by 25 when in the other two locations you are 
> > only increasing by 20?

it looks better that way :)


- Lance


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/532/#review1137
---


On Jan. 12, 2012, 12:23 a.m., Lance Corrimal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/532/
> ---
> 
> (Updated Jan. 12, 2012, 12:23 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> At some point in the last 8 months the height of image previews in the upload 
> preview floater was increased by 20, without adapting the actual floater, 
> leading to VWR-28087.
> This small patch fixes that by adapting the preview floater to the new height.
> 
> 
> This addresses bug VWR-28087.
> http://jira.secondlife.com/browse/VWR-28087
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/en/floater_image_preview.xml 4982ab91ef6a 
> 
> Diff: http://codereview.secondlife.com/r/532/diff/diff
> 
> 
> Testing
> ---
> 
> tested with release viewer 3.2.5 and my own TPV, works fine.
> 
> 
> Thanks,
> 
> Lance Corrimal
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-28087: When I upload a texture, the "preview as" dropdown in the preview window is hidden under the texture

[Lance Corrimal]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/532/
---

(Updated Jan. 12, 2012, 2:06 a.m.)


Review request for Viewer.


Changes
---

on second thought the additional 5 pixels are not really necessary.


Description
---

At some point in the last 8 months the height of image previews in the upload 
preview floater was increased by 20, without adapting the actual floater, 
leading to VWR-28087.
This small patch fixes that by adapting the preview floater to the new height.


This addresses bug VWR-28087.
http://jira.secondlife.com/browse/VWR-28087


Diffs (updated)
-

  indra/newview/skins/default/xui/en/floater_image_preview.xml 4982ab91ef6a 

Diff: http://codereview.secondlife.com/r/532/diff/diff


Testing
---

tested with release viewer 3.2.5 and my own TPV, works fine.


Thanks,

Lance Corrimal

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1798 'Block' menuitem title isn't changed after blocking item in object inspector

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/533/
---

Review request for Viewer.


Description
---

1. Open object inspector on an object
2. Click 'Gear' button>'Block'
3. Open object inspector again
4. Click 'Gear' button

Actual: Menu item is still 'Block' (although item is already blocked)

Expected: Menu item is changed to 'Unblock'


This addresses bug STORM-1798.
http://jira.secondlife.com/browse/STORM-1798


Diffs
-

  indra/newview/llviewermenu.cpp 3a521e980fbf 
  indra/newview/skins/default/xui/en/menu_inspect_object_gear.xml 3a521e980fbf 

Diff: http://codereview.secondlife.com/r/533/diff/diff


Testing
---

See test plan in jira.


Thanks,

Jonathan Yap

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges