Re: [opensource-dev] Review Request: STORM-1790 Provide a Develop sub-menu to change the default logging level

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/530/#review1132
---

Ship it!


Ship It!

- Oz Linden


On Dec. 23, 2011, 9:15 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/530/
> ---
> 
> (Updated Dec. 23, 2011, 9:15 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Provide a 1) login screen Debug and 2) Develop sub-menu to change the default 
> logging level
> 
> 
> This addresses bug STORM-1790.
> http://jira.secondlife.com/browse/STORM-1790
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3a521e980fbf 
>   indra/llcommon/llerror.cpp 3a521e980fbf 
>   indra/llcommon/llerrorcontrol.h 3a521e980fbf 
>   indra/newview/llviewermenu.cpp 3a521e980fbf 
>   indra/newview/skins/default/xui/en/menu_login.xml 3a521e980fbf 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 3a521e980fbf 
> 
> Diff: http://codereview.secondlife.com/r/530/diff/diff
> 
> 
> Testing
> ---
> 
> Opened debug log on screen and adjusted setting via the menu.  Noted that 
> logging adjusted to what the level was set to, at least for Debug (which also 
> is All), Info, Warning, and None.  I did not test Error, which probably is a 
> bit of a moot point, as it is supposed to cause a crash.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/516/#review1133
---



indra/newview/llpreviewscript.cpp


Why not take the '!' off that test, and put the following code inside the 
'then' block - then you don't need an early and deeply nested return



indra/newview/llpreviewscript.cpp


Use braces per coding standard, or even better, just use a conditional 
expression in the return statement:

return (self && self->mEditor) ? self->mEditor->canLoadOrSaveToFile() : 
FALSE;



- Oz Linden


On Dec. 25, 2011, 3:17 p.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/516/
> ---
> 
> (Updated Dec. 25, 2011, 3:17 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Changes to allow opened script window to save/load to/from files on the users 
> computer.
> 
> 
> This addresses bug storm-1708.
> http://jira.secondlife.com/browse/storm-1708
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a1319d553db9 
>   indra/llui/lltexteditor.h a1319d553db9 
>   indra/llui/lltexteditor.cpp a1319d553db9 
>   indra/newview/llfilepicker.h a1319d553db9 
>   indra/newview/llfilepicker.cpp a1319d553db9 
>   indra/newview/llfloaternamedesc.h a1319d553db9 
>   indra/newview/llfloaternamedesc.cpp a1319d553db9 
>   indra/newview/llpreviewscript.h a1319d553db9 
>   indra/newview/llpreviewscript.cpp a1319d553db9 
>   indra/newview/llviewerfloaterreg.cpp a1319d553db9 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 
>   indra/newview/skins/default/xui/en/strings.xml a1319d553db9 
> 
> Diff: http://codereview.secondlife.com/r/516/diff/diff
> 
> 
> Testing
> ---
> 
> Successfully opened and saved scripts from/to local files.
> 
> 
> Thanks,
> 
> Ima Mechanique
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

[Ima Mechanique]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/516/
---

(Updated Jan. 4, 2012, 7:20 a.m.)


Review request for Viewer.


Changes
---

Changes per Oz's comments


Description
---

Changes to allow opened script window to save/load to/from files on the users 
computer.


This addresses bug storm-1708.
http://jira.secondlife.com/browse/storm-1708


Diffs (updated)
-

  doc/contributions.txt a1319d553db9 
  indra/llui/lltexteditor.h a1319d553db9 
  indra/llui/lltexteditor.cpp a1319d553db9 
  indra/newview/llfilepicker.h a1319d553db9 
  indra/newview/llfilepicker.cpp a1319d553db9 
  indra/newview/llfloaternamedesc.h a1319d553db9 
  indra/newview/llfloaternamedesc.cpp a1319d553db9 
  indra/newview/llpreviewscript.h a1319d553db9 
  indra/newview/llpreviewscript.cpp a1319d553db9 
  indra/newview/llviewerfloaterreg.cpp a1319d553db9 
  indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 
  indra/newview/skins/default/xui/en/strings.xml a1319d553db9 

Diff: http://codereview.secondlife.com/r/516/diff/diff


Testing
---

Successfully opened and saved scripts from/to local files.


Thanks,

Ima Mechanique

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1790 Provide a Develop sub-menu to change the default logging level

[Lance Corrimal]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/530/#review1134
---


works for me, but unless the default log level is set to something less verbose 
than "INFO" this is nice to have but almost useless... alternatively, the 
selected log level could be saved in settings.

- Lance Corrimal


On Dec. 23, 2011, 9:15 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/530/
> ---
> 
> (Updated Dec. 23, 2011, 9:15 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Provide a 1) login screen Debug and 2) Develop sub-menu to change the default 
> logging level
> 
> 
> This addresses bug STORM-1790.
> http://jira.secondlife.com/browse/STORM-1790
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3a521e980fbf 
>   indra/llcommon/llerror.cpp 3a521e980fbf 
>   indra/llcommon/llerrorcontrol.h 3a521e980fbf 
>   indra/newview/llviewermenu.cpp 3a521e980fbf 
>   indra/newview/skins/default/xui/en/menu_login.xml 3a521e980fbf 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 3a521e980fbf 
> 
> Diff: http://codereview.secondlife.com/r/530/diff/diff
> 
> 
> Testing
> ---
> 
> Opened debug log on screen and adjusted setting via the menu.  Noted that 
> logging adjusted to what the level was set to, at least for Debug (which also 
> is All), Info, Warning, and None.  I did not test Error, which probably is a 
> bit of a moot point, as it is supposed to cause a crash.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1790 Provide a Develop sub-menu to change the default logging level

[Lance Corrimal]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/530/#review1135
---

Ship it!


Ship It!

- Lance Corrimal


On Dec. 23, 2011, 9:15 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/530/
> ---
> 
> (Updated Dec. 23, 2011, 9:15 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Provide a 1) login screen Debug and 2) Develop sub-menu to change the default 
> logging level
> 
> 
> This addresses bug STORM-1790.
> http://jira.secondlife.com/browse/STORM-1790
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3a521e980fbf 
>   indra/llcommon/llerror.cpp 3a521e980fbf 
>   indra/llcommon/llerrorcontrol.h 3a521e980fbf 
>   indra/newview/llviewermenu.cpp 3a521e980fbf 
>   indra/newview/skins/default/xui/en/menu_login.xml 3a521e980fbf 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 3a521e980fbf 
> 
> Diff: http://codereview.secondlife.com/r/530/diff/diff
> 
> 
> Testing
> ---
> 
> Opened debug log on screen and adjusted setting via the menu.  Noted that 
> logging adjusted to what the level was set to, at least for Debug (which also 
> is All), Info, Warning, and None.  I did not test Error, which probably is a 
> bit of a moot point, as it is supposed to cause a crash.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1790 Provide a Develop sub-menu to change the default logging level

[Lance Corrimal]

> On Jan. 4, 2012, 9:34 a.m., Lance Corrimal wrote:
> > Ship It!

it actually works exactly as expected and described in the jira... 


- Lance


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/530/#review1135
---


On Dec. 23, 2011, 9:15 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/530/
> ---
> 
> (Updated Dec. 23, 2011, 9:15 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Provide a 1) login screen Debug and 2) Develop sub-menu to change the default 
> logging level
> 
> 
> This addresses bug STORM-1790.
> http://jira.secondlife.com/browse/STORM-1790
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3a521e980fbf 
>   indra/llcommon/llerror.cpp 3a521e980fbf 
>   indra/llcommon/llerrorcontrol.h 3a521e980fbf 
>   indra/newview/llviewermenu.cpp 3a521e980fbf 
>   indra/newview/skins/default/xui/en/menu_login.xml 3a521e980fbf 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 3a521e980fbf 
> 
> Diff: http://codereview.secondlife.com/r/530/diff/diff
> 
> 
> Testing
> ---
> 
> Opened debug log on screen and adjusted setting via the menu.  Noted that 
> logging adjusted to what the level was set to, at least for Debug (which also 
> is All), Info, Warning, and None.  I did not test Error, which probably is a 
> bit of a moot point, as it is supposed to cause a crash.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges