[opensource-dev] Review Request: STORM-1737 panel_edit_skin.xml uses confusing historical terminology

2011-12-18 Thread Jonathan Yap

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/528/
---

Review request for Viewer.


Description
---

In the appearance editor / skin editor the three textures are still labeled as 
"Lower Tattoos", "Head Tattoos" and "Upper Tattoos".  Changes to how tattoos 
are processed has made these names misleading.  They should be labeled Head, 
Upper body, and Lower body.


This addresses bug STORM-1737.
http://jira.secondlife.com/browse/STORM-1737


Diffs
-

  doc/contributions.txt 3f2162768b29 
  indra/newview/llpaneleditwearable.cpp 3f2162768b29 
  indra/newview/skins/default/xui/en/panel_edit_skin.xml 3f2162768b29 

Diff: http://codereview.secondlife.com/r/528/diff/diff


Testing
---

See test plan in jira.


Thanks,

Jonathan Yap

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1737 panel_edit_skin.xml uses confusing historical terminology

2011-12-18 Thread Nicky Perian

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/528/#review1128
---

Ship it!


Ship It!

- Nicky Perian


On Dec. 18, 2011, 7:36 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/528/
> ---
> 
> (Updated Dec. 18, 2011, 7:36 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> In the appearance editor / skin editor the three textures are still labeled 
> as "Lower Tattoos", "Head Tattoos" and "Upper Tattoos".  Changes to how 
> tattoos are processed has made these names misleading.  They should be 
> labeled Head, Upper body, and Lower body.
> 
> 
> This addresses bug STORM-1737.
> http://jira.secondlife.com/browse/STORM-1737
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 3f2162768b29 
>   indra/newview/llpaneleditwearable.cpp 3f2162768b29 
>   indra/newview/skins/default/xui/en/panel_edit_skin.xml 3f2162768b29 
> 
> Diff: http://codereview.secondlife.com/r/528/diff/diff
> 
> 
> Testing
> ---
> 
> See test plan in jira.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges