Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

[Jonathan Yap]

> On Dec. 1, 2011, 3:58 p.m., Callum Prentice wrote:
> > indra/newview/llvieweraudio.cpp, line 213
> > 
> >
> > Minor point - maybe a warning where you define the fade in/out times 
> > that they should not be zero, even for testing.

Good catch!  In code that is now removed I was not letting this value go below 
zero.  I've added a bit of code to prevent it from dropping below 0.01 as a 
preventative measure against future changes or TPVs who pick this up and add 
back the two debug settings.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/520/#review1104
---


On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/520/
> ---
> 
> (Updated Nov. 23, 2011, 5:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Audio fading in has been added for when a music stream starts.  Audio fading 
> out has been added for when there is a change in the music stream that is 
> playing.
> 
> Two dead files have been eliminated.
> 
> An existing bug in how music was not being paused correctly has been fixed.
> 
> When you are teleporting you will hear the music stream from the place you 
> are leaving.  This is a change in behavior; previously the music stream was 
> stopped when the teleport progress bar was being displayed.
> 
> This code change affects several areas where music is started or stopped.  
> The new code has evolved significantly, so please look for things that might 
> not "make sense."
> 
> 
> This addresses bug STORM-591.
> http://jira.secondlife.com/browse/STORM-591
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 8b455c1b7a5e 
>   indra/newview/lloverlaybar.h 8b455c1b7a5e 
>   indra/newview/lloverlaybar.cpp 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.h 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e 
>   indra/newview/llvieweraudio.h 8b455c1b7a5e 
>   indra/newview/llvieweraudio.cpp 8b455c1b7a5e 
>   indra/newview/llviewermedia.cpp 8b455c1b7a5e 
>   indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 
> 
> Diff: http://codereview.secondlife.com/r/520/diff/diff
> 
> 
> Testing
> ---
> 
> See the massive test plan in the jira.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Anyone played with the Mac Network Link Conditioner?

[Brian McGroarty]

In a former life as a game developer, we'd run networked games through a
Linux box, configured to simulate various forms of network degradation. It
was a nuisance to set up, but it always turned up some opportunities for
small changes that improved players' experiences.

An ex-Linden pointed out this tool for OS X, which accomplishes the same
thing without a separate machine, and which is very simple to use. I didn't
know about, and I don't know if our QA guys use something similar. Has
anyone on this list seen and played with it?

http://mattgemmell.com/2011/07/25/network-link-conditioner-in-lion/

http://osxdaily.com/2011/08/10/simulate-internet-connectivity-bandwidth-speeds-network-link-conditioner/

We don't officially support wifi networks. But if anyone turns up something
that consistently fails with the lossy wifi profiles, IMHO it's still worth
attention. Any failures this would turn up would probably affect overseas
users as well.

Don't burn any calories trying the Edge or 3G settings, unless it's out of
morbid curiosity. :)

-- 
Brian McGroarty | Linden Lab
Sent from my Newton MP2100 via acoustic coupler
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

[Jonathan Yap]

> On Nov. 23, 2011, 7:32 a.m., Oz Linden wrote:
> > indra/newview/llpanelnearbymedia.cpp, lines 811-812
> > 
> >
> > Please fix (and in the else below) to match the coding standard; add 
> > the braces.
> > https://wiki.secondlife.com/wiki/Coding_Standard#Braces

Done.


> On Nov. 23, 2011, 7:32 a.m., Oz Linden wrote:
> > indra/newview/llvieweraudio.cpp, lines 77-106
> > 
> >
> > I think this would be clearer if it were written as a switch statement 
> > without the early returns.

Done.


> On Nov. 23, 2011, 7:32 a.m., Oz Linden wrote:
> > indra/newview/llvieweraudio.cpp, line 123
> > 
> >
> > If you add an 'else' here, you can replace all the early returns in 
> > this method with assignments to a 'bool fadeIsFinished = false;' variable 
> > and return that at the bottom.

Done, but not by adding an else.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/520/#review1088
---


On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/520/
> ---
> 
> (Updated Nov. 23, 2011, 5:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Audio fading in has been added for when a music stream starts.  Audio fading 
> out has been added for when there is a change in the music stream that is 
> playing.
> 
> Two dead files have been eliminated.
> 
> An existing bug in how music was not being paused correctly has been fixed.
> 
> When you are teleporting you will hear the music stream from the place you 
> are leaving.  This is a change in behavior; previously the music stream was 
> stopped when the teleport progress bar was being displayed.
> 
> This code change affects several areas where music is started or stopped.  
> The new code has evolved significantly, so please look for things that might 
> not "make sense."
> 
> 
> This addresses bug STORM-591.
> http://jira.secondlife.com/browse/STORM-591
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 8b455c1b7a5e 
>   indra/newview/lloverlaybar.h 8b455c1b7a5e 
>   indra/newview/lloverlaybar.cpp 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.h 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e 
>   indra/newview/llvieweraudio.h 8b455c1b7a5e 
>   indra/newview/llvieweraudio.cpp 8b455c1b7a5e 
>   indra/newview/llviewermedia.cpp 8b455c1b7a5e 
>   indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 
> 
> Diff: http://codereview.secondlife.com/r/520/diff/diff
> 
> 
> Testing
> ---
> 
> See the massive test plan in the jira.
> 
> 
> Thanks,
> 
> Jonathan Yap
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/520/
---

(Updated Dec. 2, 2011, 7:55 a.m.)


Review request for Viewer.


Changes
---

New diff based on requested code review changes.


Description
---

Audio fading in has been added for when a music stream starts.  Audio fading 
out has been added for when there is a change in the music stream that is 
playing.

Two dead files have been eliminated.

An existing bug in how music was not being paused correctly has been fixed.

When you are teleporting you will hear the music stream from the place you are 
leaving.  This is a change in behavior; previously the music stream was stopped 
when the teleport progress bar was being displayed.

This code change affects several areas where music is started or stopped.  The 
new code has evolved significantly, so please look for things that might not 
"make sense."


This addresses bug STORM-591.
http://jira.secondlife.com/browse/STORM-591


Diffs (updated)
-

  doc/contributions.txt 8b455c1b7a5e 
  indra/newview/lloverlaybar.h 8b455c1b7a5e 
  indra/newview/lloverlaybar.cpp 8b455c1b7a5e 
  indra/newview/llpanelnearbymedia.h 8b455c1b7a5e 
  indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e 
  indra/newview/llvieweraudio.h 8b455c1b7a5e 
  indra/newview/llvieweraudio.cpp 8b455c1b7a5e 
  indra/newview/llviewermedia.cpp 8b455c1b7a5e 
  indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 

Diff: http://codereview.secondlife.com/r/520/diff/diff


Testing
---

See the massive test plan in the jira.


Thanks,

Jonathan Yap

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] LLSingleton class question.

[Oz Linden (Scott Lawrence)]

On 2011-11-19 23:48, lists.secondlife@trap.wereanimal.net wrote:
> Hi all.
>
> In the LLSingleton header, there is a comment:
>
> // Reference version of getInstance()
> // Preferred over getInstance() as it disallows checking for NULL
>
> My question is, is there a difference between
> MyClass::instance()->someFunction(); and
> MyClass::getInstance()->someFunction(); ?
>
> If not, is there a preference of using one over the other?
>
> Linden Lab viewer code has about 35% ::instance use vs.
> 65% ::getInstance use.

instance() is preferred, but newer, and we haven't spent the time to 
convert all existing code.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges