[opensource-dev] Review Request: Enable legacy viewer C++ tests in indra/test.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/479/ --- Review request for Viewer and Nat Goodspeed. Summary --- As part of the Linden Lab automation hackathon, I finally had time to re-enable the tests located in the indra/test directory. These tests are currently not being built or run as part of a standard viewer build and haven't at least since we switched over from subversion. I copied over a few tests from the corresponding server test repository and also fixed some tests that had been rendered unbuildable by various code changes to the viewer. These tests can be disabled from running (but not building) by disabling the standard LL_TESTS cmake configuration variable. llevents_tut.cpp proved to be an interesting challenge to get to pass on our Linux build servers. With the Debian Lenny version of the gcc build toolchain, if an exception is located in a different dynamic library (.so) file as the code that is causing the exception, the exception will not be caught. My workaround was borrowed from the llmessage unit tests and expanded upon to allow the monitoring of the string from the caught exception. Diffs - indra/test/llevents_tut.cpp 656d988266e8 indra/test/llapp_tut.cpp PRE-CREATION indra/CMakeLists.txt 656d988266e8 indra/test/CMakeLists.txt 656d988266e8 indra/test/io.cpp 656d988266e8 indra/test/llhttpclient_tut.cpp 656d988266e8 indra/test/lliohttpserver_tut.cpp 656d988266e8 indra/test/llsd_new_tut.cpp 656d988266e8 indra/test/llsdmessagebuilder_tut.cpp 656d988266e8 indra/test/lltemplatemessagebuilder_tut.cpp 656d988266e8 Diff: http://codereview.secondlife.com/r/479/diff Testing --- I built and ran this code on recent versions of all three platforms with no error. When it failed to build in teamcity, I also built it on a lenny system by hand until I had fixed the exception handling issue, then ran all of the tests 100 times in a row on the same lenny machine with no test failures. The tests have run successfully in Teamcity for each revision since the fix for the exception handling code. Thanks, Log ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: storm-1602: GPU Table Updates
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/480/ --- Review request for Viewer. Summary --- This displays just the gpus_results.txt file - the results of recognizing all gpus seen in our recent and past logs as recognized by my current working version of the gpu_table. I'd like review of whether or not the resulting class assignments are correct (I strongly suspect many will not be) This addresses bug storm-1602. http://jira.secondlife.com/browse/storm-1602 Diffs - indra/newview/tests/gpus_results.txt 02efbb23b5cf Diff: http://codereview.secondlife.com/r/480/diff Testing --- Thanks, Oz ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: storm-1602: GPU Table Updates
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/480/#review1033 --- Radeon X1xxx should be at least class 1, class 2 if X1550 or later Anything Radeon HD 5xxx or 6xxx is class 3 (including Mobility) Anything ASUS EAH6xxx is class 3 Radeon HD 3410 and 4100 should probably be at least class 1 GeForce 9600 GT should at least be class 2 The lines that say "ATI Technologies Inc. GeForce" make no sense -- GeForce is an NVIDIA product. - David On Sept. 19, 2011, 1:31 p.m., Oz Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/480/ > --- > > (Updated Sept. 19, 2011, 1:31 p.m.) > > > Review request for Viewer. > > > Summary > --- > > This displays just the gpus_results.txt file - the results of recognizing all > gpus seen in our recent and past logs as recognized by my current working > version of the gpu_table. > > I'd like review of whether or not the resulting class assignments are correct > (I strongly suspect many will not be) > > > This addresses bug storm-1602. > http://jira.secondlife.com/browse/storm-1602 > > > Diffs > - > > indra/newview/tests/gpus_results.txt 02efbb23b5cf > > Diff: http://codereview.secondlife.com/r/480/diff > > > Testing > --- > > > Thanks, > > Oz > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
