Re: [opensource-dev] Review Request: /me emote doubles name in chat history

[ardylay]

> On Aug. 11, 2011, 11:47 a.m., Vadim ProductEngine wrote:
> > indra/newview/llchathistory.cpp, line 929
> > 
> >
> > Agree with Boroondas that replacing /me with the sender name and then 
> > stripping it looks weird.

I don't know how I missed that problem in IMs.  All I was trying to do was fix 
it in nearby chat history without breaking anything else.  I find that 
reverting one changeset gets me pretty close so I think I shall probably close 
and discard my own attempt here and ask for eyes on:
 (741e44af9f02) ER-949:  Chat using '/me' style text displayed incorrectly.  
Reviewed by Kelly
I backed that out and now I only see the local chat toasts displaying /me 
emotes incorrectly. What do you see?


- ardy.lay


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review962
---


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> ---
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> As a resident of Second Life I find the displaying an emoter's name twice in 
> nearby chat history rather unnecessary.  Please lay eyes on this proposed 
> code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
> http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> ---
> 
> Tell a crowd what you are testing and many will start talking to you prefixed 
> with /me, if they are good sports.  I have been using this change for 3 days 
> now and have not noticed any ill effects.  Please note: This changest is not 
> intended to affect nearby chat toasts, nearby chat log files, IM history, IM 
> toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] [re:] Snowglobe Startup Failure

[aklo]

Boroondas,

thanks for the response!

i figured out a way to get SL going again by backing up to Snowglobe 1.4 
Nicky Perian (Thanks Nicky!) helped me some last weekend.  i found this
sorta official stuff:

"Sysinternals Suite"
http://technet.microsoft.com/en-us/sysinternals/bb842062

on a Microsoft website that you probably already know about.  It's a whole
bunch of tools for Windows originally developed by an old school DOS pro
back in the 90s, but updated for modern Windows.  The tools are really
great!  i don't understand even 0.05% of what they have to say, but they
make for lots of cool looking information, that's for sure!  Anyway, the
procmon showed me a Snowglobe DLL was having a buffer overflow.  i know
that isn't good, and since i'd already managed to find my Snowglobe 1.5
installation software and reinstall Snowglobe, i figured something must be
wrong with Windows, so i tried Snowglobe 1.4.  That worked.

i was thinking about reinstalling Windows, but that's a lot of work, i
have a freaky environment because of the VM i have to use, and if i screw
it up i don't get any help fixing it.  That would make my school & side
job really hard, so i'm happy to live with Snowglobe 1.4  Maybe i'll try
one of the newer viewers that has the v1 "look 'n feel," but not right
now.  i think i really wanna see what mesh is all about, but i think i
need to have like a whole weekend or something just to get a new viewer
going, so i'll wait.

What i really, really wanna do is do a viewer build myself, but the build
instructions keep scaring me, and i don't think my build environment is
right like it is now, anyway.  That's a whole nother weekend (or two...).

Thanks Again!  Y'all are Great!!  i hope if anyone looks at the
Sysinternals tools that they're really useful!  They sure look like they
oughta be!

- AK
--

On 08/07/2011 11:47 PM, a...@skyhighway.com wrote:
> somewhere during installing a buncha junk i need for stuff i actually earn
> money for, i made it so Snowglobe wouldn't start anymore.
Ew.

> [...]  i thought maybe it had something to do
> with Python, but i think i'm sure now that none of that changed.
We only use python at build time, not at runtime. (Otherwise you'd see it
in the system requirements.)

> Can someone please tell me where Snowglobe might be logging what it does
> during start-up so i can see if i can figure out what to do to fix it?
The location depends on your operating system, but is documented on the
wiki on 'Finding Log Files' and 'Debug Help > Where do I find my
SecondLife.log file?'. (I don't know why we have that same info twice.)

> [...]  i don't wanna change viewers, i just want
> Snowglobe to start, and i especially don't wanna get the latest (or any)
> version 2 viewer.  Even more, i don't wanna have to never use SL again!
Please do consider using a more recent viewer. Snowglobe hasn't gotten
security updates for a long time. (Still better than SL Viewer 1.23,
though.) There are third party viewers that preserved the look and feel of
Snowglobe while keeping up-to-date with relation to the Second Life
protocols and security concerns.

> [...] i thought of just reinstalling Snowglobe, but i have v1.5 & i can't
> find a place to download that version, and i either didn't save (typical)
> or can't find (even more typical) the installation package i used to begin
> with.  :-(
I don't think Snowglobe 1.5 has ever been released: There were probably
only ever development snapshots with that version number. Links can be
found in the history of the 'Snowglobe' wiki page. They've been removed
from the current page to avoid new Residents stumbling across them and
using Snowglobe without knowing that it is outdated software.

On 08/08/2011 12:23 AM, a...@skyhighway.com wrote:
> [...] re-installing didn't help.  i've done everything i can think of to
figure
> out where Snowglobe could be writing  useful stuff about why it won't
> start, but no luck.
Your idea to look at the logs is good, so do that before you do anything
else. Other things that you might want to try are re-installing graphics
drivers or re-installing/repair-installing the operating system. (Backup
your data before doing the latter!)

Cheers,
Boroondas


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting
privileges



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

[Vadim ProductEngine]

> On Aug. 11, 2011, 11:47 a.m., Vadim ProductEngine wrote:
> > indra/newview/llchathistory.cpp, line 929
> > 
> >
> > Agree with Boroondas that replacing /me with the sender name and then 
> > stripping it looks weird.
> 
> ardy.lay wrote:
> I don't know how I missed that problem in IMs.  All I was trying to do 
> was fix it in nearby chat history without breaking anything else.  I find 
> that reverting one changeset gets me pretty close so I think I shall probably 
> close and discard my own attempt here and ask for eyes on:
>  (741e44af9f02) ER-949:  Chat using '/me' style text displayed 
> incorrectly.  Reviewed by Kelly
> I backed that out and now I only see the local chat toasts displaying /me 
> emotes incorrectly. What do you see?

Ardy, if you want my opinion, please provide a clean repo with single relevant 
changeset (so that there is no need to backout or strip anything) and post a 
review request.
Thank you.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/419/#review962
---


On July 27, 2011, 8:52 p.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/419/
> ---
> 
> (Updated July 27, 2011, 8:52 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> As a resident of Second Life I find the displaying an emoter's name twice in 
> nearby chat history rather unnecessary.  Please lay eyes on this proposed 
> code change and let me know what you think.
> 
> I took care to remove the unlinked sender name instead of the linked one.
> 
> 
> This addresses bug VWR-26393.
> http://jira.secondlife.com/browse/VWR-26393
> 
> 
> Diffs
> -
> 
>   indra/newview/llchathistory.cpp 2f9a87538ca1 
> 
> Diff: http://codereview.secondlife.com/r/419/diff
> 
> 
> Testing
> ---
> 
> Tell a crowd what you are testing and many will start talking to you prefixed 
> with /me, if they are good sports.  I have been using this change for 3 days 
> now and have not noticed any ill effects.  Please note: This changest is not 
> intended to affect nearby chat toasts, nearby chat log files, IM history, IM 
> toasts or IM log files.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges