Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-03 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/427/
---

(Updated Aug. 3, 2011, 5:56 a.m.)


Review request for Viewer.


Changes
---

Restored the list of Lindens, which for the time being will have to be 
maintained by hand.

Screen shot updated on Jira


Summary
---

In the Help>About Second Life dialog, there are lists of users who have 
contributed to the viewer and provided translations.  Prior to this change, 
those lists had to be updated manually (and had not been updated in quite some 
time).

Since we have a separate file (doc/contributions.txt) to track contributions, 
and it is in an easily parseable format, this change modifies the viewer build 
to construct a file (app_settings/contributors.txt) containing those names, and 
another for the translators (app_settings/translators.txt) from a new 
doc/translations.txt file (the contents of which are not complete in this 
patch, but are sufficient for review and testing purposes).

I also removed the list of Lindens from the dialog, as it too had not been 
updated in a long time and replaced it with a more generic statement.


This addresses bug storm-1534.
http://jira.secondlife.com/browse/storm-1534


Diffs (updated)
-

  indra/newview/skins/default/xui/en/floater_about.xml abd84f85d848 

Diff: http://codereview.secondlife.com/r/427/diff


Testing
---

So far built and tested only locally on my Mac... will set up a TeamCity build 
for other platforms shortly and add a pointer here.  See screenshot on the jira 
issue.


Thanks,

Oz

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-03 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/427/
---

(Updated Aug. 3, 2011, 5:59 a.m.)


Review request for Viewer.


Changes
---

fix diff upload


Summary
---

In the Help>About Second Life dialog, there are lists of users who have 
contributed to the viewer and provided translations.  Prior to this change, 
those lists had to be updated manually (and had not been updated in quite some 
time).

Since we have a separate file (doc/contributions.txt) to track contributions, 
and it is in an easily parseable format, this change modifies the viewer build 
to construct a file (app_settings/contributors.txt) containing those names, and 
another for the translators (app_settings/translators.txt) from a new 
doc/translations.txt file (the contents of which are not complete in this 
patch, but are sufficient for review and testing purposes).

I also removed the list of Lindens from the dialog, as it too had not been 
updated in a long time and replaced it with a more generic statement.


This addresses bug storm-1534.
http://jira.secondlife.com/browse/storm-1534


Diffs (updated)
-

  doc/contributions.txt 3b734a58e7a6 
  doc/translations.txt PRE-CREATION 
  indra/newview/llfloaterabout.cpp 3b734a58e7a6 
  indra/newview/skins/default/xui/en/floater_about.xml 3b734a58e7a6 
  indra/newview/viewer_manifest.py 3b734a58e7a6 

Diff: http://codereview.secondlife.com/r/427/diff


Testing
---

So far built and tested only locally on my Mac... will set up a TeamCity build 
for other platforms shortly and add a pointer here.  See screenshot on the jira 
issue.


Thanks,

Oz

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-03 Thread Jonathan Yap 


> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/lltoolplacer.cpp, lines 391-393
> > 
> >
> > Remove the empty line.

Done


> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/lltoolplacer.cpp, lines 394-404
> > 
> >
> > Where are these numbers coming from? Are they used elsewhere in the 
> > code?

These numbers are copied from another place in the code dealing with converting 
an object to the sculpt type.  In file \newview\llpanelobject.cpp see the end 
of getVolumeParams.


> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerobjectlist.h, lines 252-255
> > 
> >
> > Please re-introduce the empty line before
> > // Inlines

Done.


> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerobjectlist.cpp, line 96
> > 
> >
> > Is a global variable really the way to go here? Also, please add a 
> > short comment explaining the semantics of this variable.

Comment added.  Robin Cornelius suggested using a global variable.  If you can 
think of a better way please let me know.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/317/#review895
---


On June 2, 2011, 2:03 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/317/
> ---
> 
> (Updated June 2, 2011, 2:03 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> As a Content Creator, I have to select a regular prim type and than choose 
> sculpt from a drop-down menu in order to create a sculpted prim.
> 
> I have added a new Sculpt icon to the list of available object types that can 
> be selected on the build menu.  You can now rez a sculpt the same way you do 
> a cube.
> 
> Possible issue: I made up a new Pcode used only by the viewer.
> 
> 
> This addresses bug STORM-49.
> http://jira.secondlife.com/browse/STORM-49
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a36a329e77cc 
>   indra/llmath/llvolume.h a36a329e77cc 
>   indra/llprimitive/llprimitive.cpp a36a329e77cc 
>   indra/newview/llfloatertools.cpp a36a329e77cc 
>   indra/newview/lltoolplacer.cpp a36a329e77cc 
>   indra/newview/llviewerobjectlist.h a36a329e77cc 
>   indra/newview/llviewerobjectlist.cpp a36a329e77cc 
>   indra/newview/skins/default/textures/build/Object_Sculpt.png a36a329e77cc 
>   indra/newview/skins/default/textures/build/Object_Sculpt_Selected.png 
> a36a329e77cc 
>   indra/newview/skins/default/textures/textures.xml a36a329e77cc 
>   indra/newview/skins/default/xui/en/floater_tools.xml a36a329e77cc 
> 
> Diff: http://codereview.secondlife.com/r/317/diff
> 
> 
> Testing
> ---
> 
> Rezzed a sculpt both alone and with someone watching.
> 
> Rezzed sculpts as fast as I could click (poor mans load test).
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-03 Thread Jonathan Yap 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/317/
---

(Updated Aug. 3, 2011, 11:21 a.m.)


Review request for Viewer.


Changes
---

Made changes per RB suggestions by Boroondas.


Summary
---

As a Content Creator, I have to select a regular prim type and than choose 
sculpt from a drop-down menu in order to create a sculpted prim.

I have added a new Sculpt icon to the list of available object types that can 
be selected on the build menu.  You can now rez a sculpt the same way you do a 
cube.

Possible issue: I made up a new Pcode used only by the viewer.


This addresses bug STORM-49.
http://jira.secondlife.com/browse/STORM-49


Diffs (updated)
-

  doc/contributions.txt a36a329e77cc 
  indra/llmath/llvolume.h a36a329e77cc 
  indra/llprimitive/llprimitive.cpp a36a329e77cc 
  indra/newview/llfloatertools.cpp a36a329e77cc 
  indra/newview/lltoolplacer.cpp a36a329e77cc 
  indra/newview/llviewerobjectlist.h a36a329e77cc 
  indra/newview/llviewerobjectlist.cpp a36a329e77cc 
  indra/newview/skins/default/textures/build/Object_Sculpt.png a36a329e77cc 
  indra/newview/skins/default/textures/build/Object_Sculpt_Selected.png 
a36a329e77cc 
  indra/newview/skins/default/textures/textures.xml a36a329e77cc 
  indra/newview/skins/default/xui/en/floater_tools.xml a36a329e77cc 

Diff: http://codereview.secondlife.com/r/317/diff


Testing
---

Rezzed a sculpt both alone and with someone watching.

Rezzed sculpts as fast as I could click (poor mans load test).


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-03 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/427/
---

(Updated Aug. 3, 2011, 2:58 p.m.)


Review request for Viewer.


Changes
---

Modified code to load dynamic Lindens list provided at build time if available, 
and use the static value from the xui if not.

Further build changes needed to fetch that Linden list at build time.


Summary
---

In the Help>About Second Life dialog, there are lists of users who have 
contributed to the viewer and provided translations.  Prior to this change, 
those lists had to be updated manually (and had not been updated in quite some 
time).

Since we have a separate file (doc/contributions.txt) to track contributions, 
and it is in an easily parseable format, this change modifies the viewer build 
to construct a file (app_settings/contributors.txt) containing those names, and 
another for the translators (app_settings/translators.txt) from a new 
doc/translations.txt file (the contents of which are not complete in this 
patch, but are sufficient for review and testing purposes).

I also removed the list of Lindens from the dialog, as it too had not been 
updated in a long time and replaced it with a more generic statement.


This addresses bug storm-1534.
http://jira.secondlife.com/browse/storm-1534


Diffs (updated)
-

  doc/contributions.txt 3b734a58e7a6 
  doc/translations.txt PRE-CREATION 
  indra/newview/llfloaterabout.cpp 3b734a58e7a6 
  indra/newview/skins/default/xui/en/floater_about.xml 3b734a58e7a6 
  indra/newview/viewer_manifest.py 3b734a58e7a6 

Diff: http://codereview.secondlife.com/r/427/diff


Testing
---

So far built and tested only locally on my Mac... will set up a TeamCity build 
for other platforms shortly and add a pointer here.  See screenshot on the jira 
issue.


Thanks,

Oz

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges