[opensource-dev] Review Request: STORM-1502 Disable "Delete Water/Sky/Day Preset" dialogs if no user presets exist
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/392/ --- Review request for Viewer. Summary --- This patch disables the corresponding menu items when no user-created WL presets exist. This addresses bug STORM-1502. http://jira.secondlife.com/browse/STORM-1502 Diffs - indra/newview/llviewermenu.cpp UNKNOWN indra/newview/skins/default/xui/en/menu_viewer.xml UNKNOWN Diff: http://codereview.secondlife.com/r/392/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/ --- Review request for Viewer. Summary --- Just added tab_stop to the browser. This addresses bug storm-1503. http://jira.secondlife.com/browse/storm-1503 Diffs - indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 Diff: http://codereview.secondlife.com/r/393/diff Testing --- Thanks, Paul ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1503 (Find floater doesn't set focus to its browser)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/393/#review870 --- Ship it! Looks like this is what Richard suggested. - Vadim On July 13, 2011, 8:48 a.m., Paul ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/393/ > --- > > (Updated July 13, 2011, 8:48 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Just added tab_stop to the browser. > > > This addresses bug storm-1503. > http://jira.secondlife.com/browse/storm-1503 > > > Diffs > - > > indra/newview/skins/default/xui/en/floater_search.xml 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/393/diff > > > Testing > --- > > > Thanks, > > Paul > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1502 Disable "Delete Water/Sky/Day Preset" dialogs if no user presets exist
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/392/#review871 --- Ship it! Looks pretty straightforward. - Seth On July 13, 2011, 2:06 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/392/ > --- > > (Updated July 13, 2011, 2:06 a.m.) > > > Review request for Viewer. > > > Summary > --- > > This patch disables the corresponding menu items when no user-created WL > presets exist. > > > This addresses bug STORM-1502. > http://jira.secondlife.com/browse/STORM-1502 > > > Diffs > - > > indra/newview/llviewermenu.cpp UNKNOWN > indra/newview/skins/default/xui/en/menu_viewer.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/392/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-1234) In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/394/ --- Review request for Viewer and Richard Nelson. Summary --- Fixed text editor selection which was skipping the last character in line. Added handling of the wrapped lines case when calculating the starting position for selection. The bug is a regression caused by the fix of STORM-320 which was dealing with calculating the position of the input cursor while navigating through the lines of text with word wrapping enabled. This addresses bug STORM-1234. http://jira.secondlife.com/browse/STORM-1234 Diffs - indra/llui/lltextbase.cpp 68ad362920c1 Diff: http://codereview.secondlife.com/r/394/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-1234) In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/394/#review872 --- Ship it! once again all the -1's start creeping back in :) At least it's clearly documented here. - Richard On July 13, 2011, 9:06 a.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/394/ > --- > > (Updated July 13, 2011, 9:06 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Fixed text editor selection which was skipping the last character in line. > > Added handling of the wrapped lines case when calculating the starting > position for selection. > > The bug is a regression caused by the fix of STORM-320 which was dealing with > calculating the position of the input cursor while navigating through the > lines of text with word wrapping enabled. > > > This addresses bug STORM-1234. > http://jira.secondlife.com/browse/STORM-1234 > > > Diffs > - > > indra/llui/lltextbase.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/394/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/ --- (Updated July 13, 2011, 1:50 p.m.) Review request for Viewer, Oz Linden, Monty Brandenberg, and Stone Linden. Changes --- Implemented changes to address Monty's first group of comments, as well of some of the trivial comments in the second group. Working on more fixes for the second group.. Summary --- This is a continuation of Robin Cornelius's SOCKS 5 contribution, shown in https://codereview.secondlife.com/r/232/ . I have tried to address all of the comments on that code review and do as much cleanup as possible. The diff includes everything that was submitted by Robin, as well as my work. Major changes since I started working: * Changed SOCKS 5 proxy control channel to use the existing LLSocket class, which is a thin wrapper around APR sockets. * Worked with the Linden Lab UX team to revamp the proxy controls. * Proxy credentials are now stored in the LLSecAPI password storage, which is the same that is used for users' Second Life Credentials instead of as being stored in the clear as a preference. This addresses bug STORM-1112. http://jira.secondlife.com/browse/STORM-1112 Diffs (updated) - indra/llmessage/CMakeLists.txt 7c7d01be2310 indra/llmessage/llcurl.cpp 7c7d01be2310 indra/llmessage/lliosocket.h 7c7d01be2310 indra/llmessage/lliosocket.cpp 7c7d01be2310 indra/llmessage/llpacketring.h 7c7d01be2310 indra/llmessage/llpacketring.cpp 7c7d01be2310 indra/llmessage/llproxy.h PRE-CREATION indra/llmessage/llproxy.cpp PRE-CREATION indra/llmessage/net.h 7c7d01be2310 indra/llmessage/net.cpp 7c7d01be2310 indra/llui/llfunctorregistry.h 7c7d01be2310 indra/newview/app_settings/settings.xml 7c7d01be2310 indra/newview/llappviewer.cpp 7c7d01be2310 indra/newview/llfloaterpreference.h 7c7d01be2310 indra/newview/llfloaterpreference.cpp 7c7d01be2310 indra/newview/llloginhandler.cpp 7c7d01be2310 indra/newview/llpanellogin.h 7c7d01be2310 indra/newview/llsecapi.h 7c7d01be2310 indra/newview/llstartup.h 7c7d01be2310 indra/newview/llstartup.cpp 7c7d01be2310 indra/newview/llviewerfloaterreg.cpp 7c7d01be2310 indra/newview/llxmlrpctransaction.cpp 7c7d01be2310 indra/newview/skins/default/xui/en/floater_preferences_proxy.xml PRE-CREATION indra/newview/skins/default/xui/en/notifications.xml 7c7d01be2310 indra/newview/skins/default/xui/en/panel_cof_wearables.xml 7c7d01be2310 indra/newview/skins/default/xui/en/panel_preferences_privacy.xml 7c7d01be2310 indra/newview/skins/default/xui/en/panel_preferences_setup.xml 7c7d01be2310 Diff: http://codereview.secondlife.com/r/374/diff Testing --- I've tested exclusively on Linux so far. I'm working on a more extensive test plan that includes setting up a gateway with a restrictive firewall to verify that all traffic is going through the proxy. Test builds and screenshots of the changed UI elements are available from the project page, located here: https://wiki.secondlife.com/wiki/User:Log_Linden/Socks5Viewer Thanks, Log ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
