Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Stickman 
>   This is a direct adaptation of Aimee Trescothick's contributed patch from 
> STORM-1315 for v-d. Adjustments were made where needed to make it work with 
> the newer boost and llui code. Some changes were made to the variable names 
> it uses on build; ie "PX" for x position instead of just "X".
>
>
Will there be a tooltip that explains this? At the very least, will it be
documented somewhere (like on the wiki)?

This sounds useful, and like something I would want to use. But if I forget
the "magic letters," even though they seem very straightforward, the feature
disappears.

Stickman
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/#review836
---

Ship it!


Looks good code-wise.


indra/llmath/llcalc.cpp


Why allocate dynamically?



indra/llui/llspinctrl.cpp


I'd add a note that we don't prevalidate because of the calculator.



indra/llui/llspinctrl.cpp


dead code


- Vadim


On July 2, 2011, 10:21 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/377/
> ---
> 
> (Updated July 2, 2011, 10:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a direct adaptation of Aimee Trescothick's contributed patch from 
> STORM-1315 for v-d. Adjustments were made where needed to make it work with 
> the newer boost and llui code. Some changes were made to the variable names 
> it uses on build; ie "PX" for x position instead of just "X".
> 
> Patch allows for imputing simple math equations in to the spinner controls. 
> On the build floater a series of variable names are available for using the 
> objects current values in equations, like "sx+3" will take the current X 
> scale and add 3.
> 
> Repo: https://bitbucket.org/Kadah_Coba/storm-1315
> Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370
> 
> 
> This addresses bug STORM-1315.
> http://jira.secondlife.com/browse/STORM-1315
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelobject.cpp 353807ed6a69 
>   indra/newview/llpanelface.cpp 353807ed6a69 
>   indra/newview/llappviewer.cpp 353807ed6a69 
>   indra/llui/llspinctrl.cpp 353807ed6a69 
>   indra/llui/lllineeditor.cpp 353807ed6a69 
>   indra/llmath/llcalcparser.cpp PRE-CREATION 
>   indra/llui/lllineeditor.h 353807ed6a69 
>   doc/contributions.txt 353807ed6a69 
>   indra/llmath/CMakeLists.txt 353807ed6a69 
>   indra/llmath/llcalc.h PRE-CREATION 
>   indra/llmath/llcalc.cpp PRE-CREATION 
>   indra/llmath/llcalcparser.h PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/377/diff
> 
> 
> Testing
> ---
> 
> Built and ran. Some testing done with simple equations on the build tools 
> floater to edit an object, no issues were observed.
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Vadim ProductEngine 


> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llui/llspinctrl.cpp, line 127
> > 
> >
> > I'd add a note that we don't prevalidate because of the calculator.

Oops. Ignore this comment.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/#review836
---


On July 2, 2011, 10:21 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/377/
> ---
> 
> (Updated July 2, 2011, 10:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a direct adaptation of Aimee Trescothick's contributed patch from 
> STORM-1315 for v-d. Adjustments were made where needed to make it work with 
> the newer boost and llui code. Some changes were made to the variable names 
> it uses on build; ie "PX" for x position instead of just "X".
> 
> Patch allows for imputing simple math equations in to the spinner controls. 
> On the build floater a series of variable names are available for using the 
> objects current values in equations, like "sx+3" will take the current X 
> scale and add 3.
> 
> Repo: https://bitbucket.org/Kadah_Coba/storm-1315
> Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370
> 
> 
> This addresses bug STORM-1315.
> http://jira.secondlife.com/browse/STORM-1315
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelobject.cpp 353807ed6a69 
>   indra/newview/llpanelface.cpp 353807ed6a69 
>   indra/newview/llappviewer.cpp 353807ed6a69 
>   indra/llui/llspinctrl.cpp 353807ed6a69 
>   indra/llui/lllineeditor.cpp 353807ed6a69 
>   indra/llmath/llcalcparser.cpp PRE-CREATION 
>   indra/llui/lllineeditor.h 353807ed6a69 
>   doc/contributions.txt 353807ed6a69 
>   indra/llmath/CMakeLists.txt 353807ed6a69 
>   indra/llmath/llcalc.h PRE-CREATION 
>   indra/llmath/llcalc.cpp PRE-CREATION 
>   indra/llmath/llcalcparser.h PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/377/diff
> 
> 
> Testing
> ---
> 
> Built and ran. Some testing done with simple equations on the build tools 
> floater to edit an object, no issues were observed.
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Kadah Coba 


> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llmath/llcalc.cpp, lines 58-59
> > 
> >
> > Why allocate dynamically?

I'm not sure, there's a lot of c++ voodoo going on in the original patch.


> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llui/llspinctrl.cpp, lines 128-135
> > 
> >
> > dead code

Remove?


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/#review836
---


On July 2, 2011, 10:21 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/377/
> ---
> 
> (Updated July 2, 2011, 10:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a direct adaptation of Aimee Trescothick's contributed patch from 
> STORM-1315 for v-d. Adjustments were made where needed to make it work with 
> the newer boost and llui code. Some changes were made to the variable names 
> it uses on build; ie "PX" for x position instead of just "X".
> 
> Patch allows for imputing simple math equations in to the spinner controls. 
> On the build floater a series of variable names are available for using the 
> objects current values in equations, like "sx+3" will take the current X 
> scale and add 3.
> 
> Repo: https://bitbucket.org/Kadah_Coba/storm-1315
> Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370
> 
> 
> This addresses bug STORM-1315.
> http://jira.secondlife.com/browse/STORM-1315
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelobject.cpp 353807ed6a69 
>   indra/newview/llpanelface.cpp 353807ed6a69 
>   indra/newview/llappviewer.cpp 353807ed6a69 
>   indra/llui/llspinctrl.cpp 353807ed6a69 
>   indra/llui/lllineeditor.cpp 353807ed6a69 
>   indra/llmath/llcalcparser.cpp PRE-CREATION 
>   indra/llui/lllineeditor.h 353807ed6a69 
>   doc/contributions.txt 353807ed6a69 
>   indra/llmath/CMakeLists.txt 353807ed6a69 
>   indra/llmath/llcalc.h PRE-CREATION 
>   indra/llmath/llcalc.cpp PRE-CREATION 
>   indra/llmath/llcalcparser.h PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/377/diff
> 
> 
> Testing
> ---
> 
> Built and ran. Some testing done with simple equations on the build tools 
> floater to edit an object, no issues were observed.
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Vadim ProductEngine 


> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llui/llspinctrl.cpp, lines 128-135
> > 
> >
> > dead code
> 
> Kadah Coba wrote:
> Remove?

Yes, our coding standard explicitly requires not to leave dead code.


> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llmath/llcalc.cpp, lines 58-59
> > 
> >
> > Why allocate dynamically?
> 
> Kadah Coba wrote:
> I'm not sure, there's a lot of c++ voodoo going on in the original patch.

I think dynamic allocation is redundant here, i.e. I'd convert the members to 
non-pointers and pass their addresses to the parser.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/#review836
---


On July 2, 2011, 10:21 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/377/
> ---
> 
> (Updated July 2, 2011, 10:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a direct adaptation of Aimee Trescothick's contributed patch from 
> STORM-1315 for v-d. Adjustments were made where needed to make it work with 
> the newer boost and llui code. Some changes were made to the variable names 
> it uses on build; ie "PX" for x position instead of just "X".
> 
> Patch allows for imputing simple math equations in to the spinner controls. 
> On the build floater a series of variable names are available for using the 
> objects current values in equations, like "sx+3" will take the current X 
> scale and add 3.
> 
> Repo: https://bitbucket.org/Kadah_Coba/storm-1315
> Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370
> 
> 
> This addresses bug STORM-1315.
> http://jira.secondlife.com/browse/STORM-1315
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelobject.cpp 353807ed6a69 
>   indra/newview/llpanelface.cpp 353807ed6a69 
>   indra/newview/llappviewer.cpp 353807ed6a69 
>   indra/llui/llspinctrl.cpp 353807ed6a69 
>   indra/llui/lllineeditor.cpp 353807ed6a69 
>   indra/llmath/llcalcparser.cpp PRE-CREATION 
>   indra/llui/lllineeditor.h 353807ed6a69 
>   doc/contributions.txt 353807ed6a69 
>   indra/llmath/CMakeLists.txt 353807ed6a69 
>   indra/llmath/llcalc.h PRE-CREATION 
>   indra/llmath/llcalc.cpp PRE-CREATION 
>   indra/llmath/llcalcparser.h PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/377/diff
> 
> 
> Testing
> ---
> 
> Built and ran. Some testing done with simple equations on the build tools 
> floater to edit an object, no issues were observed.
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Searching in the world map clears the destination arrow but not the destination beacon

2011-07-04 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/379/#review840
---

Ship it!


- Vadim


On July 1, 2011, 5:25 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/379/
> ---
> 
> (Updated July 1, 2011, 5:25 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> A single line change to more completely clear the tracking beacon when text 
> is entered in to the world map's search field.
> 
> https://bitbucket.org/Kadah_Coba/vwr-25753
> 
> 
> This addresses bug VWR-25753.
> http://jira.secondlife.com/browse/VWR-25753
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloaterworldmap.cpp c7a4b7a24e05 
> 
> Diff: http://codereview.secondlife.com/r/379/diff
> 
> 
> Testing
> ---
> 
> Built and ran, world map's search field fallowed the expected behavior 
> described in VWR-25753.
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Kadah Coba 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated July 4, 2011, 2:22 p.m.)


Review request for Viewer.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  indra/newview/llpanelobject.cpp 353807ed6a69 
  indra/newview/llpanelface.cpp 353807ed6a69 
  indra/newview/llappviewer.cpp 353807ed6a69 
  indra/llui/llspinctrl.cpp 353807ed6a69 
  indra/llui/lllineeditor.cpp 353807ed6a69 
  indra/llmath/llcalcparser.cpp PRE-CREATION 
  indra/llui/lllineeditor.h 353807ed6a69 
  indra/llmath/llcalc.cpp PRE-CREATION 
  indra/llmath/llcalcparser.h PRE-CREATION 
  indra/llmath/llcalc.h PRE-CREATION 
  indra/llmath/CMakeLists.txt 353807ed6a69 
  doc/contributions.txt 353807ed6a69 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-07-04 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/#review841
---

Ship it!


Thanks.

- Vadim


On July 4, 2011, 2:22 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/377/
> ---
> 
> (Updated July 4, 2011, 2:22 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a direct adaptation of Aimee Trescothick's contributed patch from 
> STORM-1315 for v-d. Adjustments were made where needed to make it work with 
> the newer boost and llui code. Some changes were made to the variable names 
> it uses on build; ie "PX" for x position instead of just "X".
> 
> Patch allows for imputing simple math equations in to the spinner controls. 
> On the build floater a series of variable names are available for using the 
> objects current values in equations, like "sx+3" will take the current X 
> scale and add 3.
> 
> Repo: https://bitbucket.org/Kadah_Coba/storm-1315
> Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370
> 
> 
> This addresses bug STORM-1315.
> http://jira.secondlife.com/browse/STORM-1315
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelobject.cpp 353807ed6a69 
>   indra/newview/llpanelface.cpp 353807ed6a69 
>   indra/newview/llappviewer.cpp 353807ed6a69 
>   indra/llui/llspinctrl.cpp 353807ed6a69 
>   indra/llui/lllineeditor.cpp 353807ed6a69 
>   indra/llmath/llcalcparser.cpp PRE-CREATION 
>   indra/llui/lllineeditor.h 353807ed6a69 
>   indra/llmath/llcalc.cpp PRE-CREATION 
>   indra/llmath/llcalcparser.h PRE-CREATION 
>   indra/llmath/llcalc.h PRE-CREATION 
>   indra/llmath/CMakeLists.txt 353807ed6a69 
>   doc/contributions.txt 353807ed6a69 
> 
> Diff: http://codereview.secondlife.com/r/377/diff
> 
> 
> Testing
> ---
> 
> Built and ran. Some testing done with simple equations on the build tools 
> floater to edit an object, no issues were observed.
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges