Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[ArminWeatherHax Resident]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review813
---


I pushed a new version of the patch to https://bitbucket.org/ArminW/vwr-25923
Its 2 commits: 
* first Vadims patch
* then my patch addressing the reviews here

- ArminWeatherHax


On June 9, 2011, 9:56 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> ---
> 
> (Updated June 9, 2011, 9:56 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed 
> this fix along in the system.
> 
> 
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and 
> Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
> capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
> boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that 
> rezzes in, but the avatar, so do the request for the capability not earlier 
> than the agents region signals capabilitiesReceived() true. After that you 
> are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not 
> much data transmitted, though its a pretty big number of people doing it over 
> and over per second (no matter if they have voice on or off).
> 
> 
> 
> 
> going once again through llviewerregion I see its fortunately not each time a 
> HTTP GET, just once when the agent connects to the region. Though the patch 
> still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
> http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a36a329e77cc 
>   indra/newview/llvoicevivox.h a36a329e77cc 
>   indra/newview/llvoicevivox.cpp a36a329e77cc 
> 
> Diff: http://codereview.secondlife.com/r/333/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/
---

(Updated June 24, 2011, 4:45 a.m.)


Review request for Viewer.


Summary
---

This is a patch by ArminWeatherHax.  I am creating the request to help speed 
this fix along in the system.



Ways to reproduce: log into a simulator.
Reproduces: always
Affects: any version supported, probably all 3rd party viewers but Kokua (and 
Imprudence, soon).

What happens:
In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
capability, thats each time a HTTP GET.
See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
boundary crossing

Expected:
On parcel/region change request the capability once. It's not the region that 
rezzes in, but the avatar, so do the request for the capability not earlier 
than the agents region signals capabilitiesReceived() true. After that you are 
sure if the region returns an empty url you can give up for that region.

Not sure about the impact on lag - requesting and returning an url is not much 
data transmitted, though its a pretty big number of people doing it over and 
over per second (no matter if they have voice on or off).




going once again through llviewerregion I see its fortunately not each time a 
HTTP GET, just once when the agent connects to the region. Though the patch 
still saves all the lookup if the cap is there while it can't be possibly.


This addresses bug VWR-25923.
http://jira.secondlife.com/browse/VWR-25923


Diffs (updated)
-

  doc/contributions.txt 04e2a3ddca51 
  indra/newview/llviewerregion.h 04e2a3ddca51 
  indra/newview/llviewerregion.cpp 04e2a3ddca51 
  indra/newview/llvoicevivox.h 04e2a3ddca51 
  indra/newview/llvoicevivox.cpp 04e2a3ddca51 

Diff: http://codereview.secondlife.com/r/333/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review814
---



indra/newview/llvoicevivox.h


Very good idea to explain the semantics of this field in detail, as the 
name alone doesn't give it away fully. :-)



indra/newview/llvoicevivox.cpp


These are two sentences. Use a period instead of a comma.



indra/newview/llvoicevivox.cpp


requestParcelInfo() might be a more natural name than using 'do'.



indra/newview/llvoicevivox.h


Not a native speaker myself, but I don't think 'keep s.th. staying in ' is proper English. Maybe either write
// Setting mRegionHasVoiceCaps to false makes the voice client stay in 
stateDisabled.
or simply
// Setting mRegionHasVoiceCaps to false keeps the voice client in 
stateDisabled.



indra/newview/llvoicevivox.h


This sentence confused me for some reason. I guess 'allows to leave' would 
be clearer than 'allows escaping'.



indra/newview/llvoicevivox.cpp


I think this should be "changed region before the region cap response for 
the previous region arrived" to be clear.



indra/newview/llvoicevivox.cpp


https://wiki.secondlife.com/wiki/Coding_standard#Naming_Convention says 
local variables should be lower_case, not camelCase so make this 
parcel_local_ID.



indra/newview/llvoicevivox.cpp


What does the first 'it' refer to? "ID with" what?



indra/newview/llvoicevivox.cpp


Why not directly
mCurrentRegion = gAgent.getRegion();
and then use mCurrentRegion in the rest of this method?



indra/newview/llvoicevivox.cpp


Here, too, either just 'keeps' without 'staying' or 'makes [...] stay', I 
think.


- Boroondas


On June 24, 2011, 4:45 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> ---
> 
> (Updated June 24, 2011, 4:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed 
> this fix along in the system.
> 
> 
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and 
> Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
> capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
> boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that 
> rezzes in, but the avatar, so do the request for the capability not earlier 
> than the agents region signals capabilitiesReceived() true. After that you 
> are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not 
> much data transmitted, though its a pretty big number of people doing it over 
> and over per second (no matter if they have voice on or off).
> 
> 
> 
> 
> going once again through llviewerregion I see its fortunately not each time a 
> HTTP GET, just once when the agent connects to the region. Though the patch 
> still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
> http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 04e2a3ddca51 
>   indra/newview/llviewerregion.h 04e2a3ddca51 
>   indra/newview/llviewerregion.cpp 04e2a3ddca51 
>   indra/newview/llvoicevivox.h 04e2a3ddca51 
>   indra/newview/llvoicevivox.cpp 04e2a3ddca51 
> 
> Diff: http://codereview.secondlife.com/r/333/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Great article on SCALE in SL.

[Lee ponzu]

There are a few things in here directly relevant to the viewer.  See for
example Camera Placement.

Can someone send a copy to Rodvik Linden 8-)

http://community.secondlife.com/t5/Building-and-Texturing-Forum/A-Matter-of-Scale-How-scale-affects-content-creation-and-land/td-p/943101
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] A question/comment about the behavior of auto-pilot camera.

[Lee ponzu]

  I use auto-pilot a lot, because for me arrow keys to move are problematic.
  I find it convenient to double-click on a spot, and then not have to worry
until I get there.

If the camera is in its default state, then the camera moves along following
my head.  This is fine.  However, if I alt-click on some point off to the
side, and then double click to auto-pilot, the camera focus moves along with
my avatar.  I think it would be better (for me) if the alt-click point was
more sticky, so the camera stayed focused on it while my avatar does it's
auto-pilot.

Does that make sense to people?  Maybe it would make auto-pilot more
popular.

Anyway, just babbling.  Thanks for listening.

Ponzu
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review815
---

Ship it!


No major objections now, thanks.

- Vadim


On June 24, 2011, 4:45 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> ---
> 
> (Updated June 24, 2011, 4:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed 
> this fix along in the system.
> 
> 
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and 
> Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
> capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
> boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that 
> rezzes in, but the avatar, so do the request for the capability not earlier 
> than the agents region signals capabilitiesReceived() true. After that you 
> are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not 
> much data transmitted, though its a pretty big number of people doing it over 
> and over per second (no matter if they have voice on or off).
> 
> 
> 
> 
> going once again through llviewerregion I see its fortunately not each time a 
> HTTP GET, just once when the agent connects to the region. Though the patch 
> still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
> http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 04e2a3ddca51 
>   indra/newview/llviewerregion.h 04e2a3ddca51 
>   indra/newview/llviewerregion.cpp 04e2a3ddca51 
>   indra/newview/llvoicevivox.h 04e2a3ddca51 
>   indra/newview/llvoicevivox.cpp 04e2a3ddca51 
> 
> Diff: http://codereview.secondlife.com/r/333/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Highlight Transparent Broken?

[Latif Khalifa]

Transparency was broken for me when Fast Alpha was enabled somewhere
in the debug menus. I don't know where the current location of that
setting is.

On Fri, Jun 24, 2011 at 6:17 AM, holydoughnuts  wrote:
> On 6/23/2011 5:31 AM, Jonathan Welch wrote:
>> Could you also check glow (cts-644/cts-656) and windlight clouds
>> (storm-1314) to see if either of those are non-functional for you?  I
>> have a feeling that some of these are related to each other.
> Those are OK here. I have to disable them to make Ctrl-Alt-T work but
> otherwise they're fine.
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Highlight Transparent Broken?

[Jonathan Welch]

If no one files a jira on highlight transparent malfunctioning it
won't be fixed.  Would someone take care of this?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Highlight Transparent Broken?

[Lee ponzu]

Will do.


On Fri, Jun 24, 2011 at 6:35 PM, Jonathan Welch  wrote:

> If no one files a jira on highlight transparent malfunctioning it
> won't be fixed.  Would someone take care of this?
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Highlight Transparent Broken?

[Lee ponzu]

Or maybe not.  I just tested them so that I could write a good Jira, and
both worked )on my 3 year old iMac.

Second Life 2.7.4 (232938) Jun 15 2011 12:44:34 (Second Life Development)
Release Notes

You are at 306321.0, 233077.0, 44.0 in Hitaki located at
sim9595.agni.lindenlab.com (216.82.44.52:12035)
Second Life Server 11.06.14.232746
Release Notes

CPU: Intel(R) Core(TM)2 Duo CPU T7700  @ 2.40GHz (2400 MHz)
Memory: 3072 MB
OS Version: Mac OS X 10.6.7 Darwin 10.7.0 Darwin Kernel Version 10.7.0: Sat
Jan 29 15:17:16 PST 2011; root:xnu-1504.9.37~1/RELEASE_I386 i386
Graphics Card Vendor: ATI Technologies Inc.
Graphics Card: ATI Radeon HD 2600 PRO OpenGL Engine

OpenGL Version: 2.1 ATI-1.6.26

libcurl Version: libcurl/7.21.1 OpenSSL/0.9.8q zlib/1.2.5 c-ares/1.7.1
J2C Decoder Version: KDU v6.4.1
Audio Driver Version: FMOD version 3.75
Qt Webkit Version: 4.7.1 (version number hard-coded)
Voice Server Version: Vivox 3.2.0002.9361

Built with GCC version 40001
Packets Lost: 12/15577 (0.1%)


On Fri, Jun 24, 2011 at 6:56 PM, Lee ponzu  wrote:

> Will do.
>
>
> On Fri, Jun 24, 2011 at 6:35 PM, Jonathan Welch  wrote:
>
>> If no one files a jira on highlight transparent malfunctioning it
>> won't be fixed.  Would someone take care of this?
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting
>> privileges
>>
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Highlight Transparent Broken?

[Lee ponzu]

OK.  I created a really unsatisfactory Jira...


   - Second Life Viewer - VWR 
   - VWR-26115 



On Fri, Jun 24, 2011 at 6:35 PM, Jonathan Welch  wrote:

> If no one files a jira on highlight transparent malfunctioning it
> won't be fixed.  Would someone take care of this?
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] A question/comment about the behavior of auto-pilot camera.

[Nexii Malthus]

I agree with this. Stealing the users' camera leaves the user with a sense
that they feel they lost control -- which is very bad for interaction. This
goes for pretty much everywhere that involves stealing the users' camera
where the user didn't intend to do so. (ugh, here comes bad memories of edit
appearance)

 - Nexii

On Fri, Jun 24, 2011 at 4:08 PM, Lee ponzu  wrote:

>   I use auto-pilot a lot, because for me arrow keys to move are
> problematic.   I find it convenient to double-click on a spot, and then not
> have to worry until I get there.
>
> If the camera is in its default state, then the camera moves along
> following my head.  This is fine.  However, if I alt-click on some point off
> to the side, and then double click to auto-pilot, the camera focus moves
> along with my avatar.  I think it would be better (for me) if the alt-click
> point was more sticky, so the camera stayed focused on it while my avatar
> does it's auto-pilot.
>
> Does that make sense to people?  Maybe it would make auto-pilot more
> popular.
>
> Anyway, just babbling.  Thanks for listening.
>
> Ponzu
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges