[opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/
---

Review request for Viewer.


Summary
---

This is a patch by ArminWeatherHax.  I am creating the request to help speed 
this fix along in the system.



Ways to reproduce: log into a simulator.
Reproduces: always
Affects: any version supported, probably all 3rd party viewers but Kokua (and 
Imprudence, soon).

What happens:
In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
capability, thats each time a HTTP GET.
See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
boundary crossing

Expected:
On parcel/region change request the capability once. It's not the region that 
rezzes in, but the avatar, so do the request for the capability not earlier 
than the agents region signals capabilitiesReceived() true. After that you are 
sure if the region returns an empty url you can give up for that region.

Not sure about the impact on lag - requesting and returning an url is not much 
data transmitted, though its a pretty big number of people doing it over and 
over per second (no matter if they have voice on or off).




going once again through llviewerregion I see its fortunately not each time a 
HTTP GET, just once when the agent connects to the region. Though the patch 
still saves all the lookup if the cap is there while it can't be possibly.


This addresses bug VWR-25923.
http://jira.secondlife.com/browse/VWR-25923


Diffs
-

  doc/contributions.txt a36a329e77cc 
  indra/newview/llvoicevivox.h a36a329e77cc 
  indra/newview/llvoicevivox.cpp a36a329e77cc 

Diff: http://codereview.secondlife.com/r/333/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Minimum draw distance

[Oz Linden (Scott Lawrence)]

On 2011-06-08 13:55, Trilo Byte wrote:
I agree, I love having a slider.  But I think this one's going to be a 
vertical slider, behaving something like the way the volume control 
does.  Hopefully we'll get to take a peek soon :-)


here's the review viewer:

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-3/rev/232119/index.html
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

[Altair Memo]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/333/#review738
---



indra/newview/llvoicevivox.h


I think is better put a comment (generic too) here about the meaning and 
usage of mRegionHasVoice



indra/newview/llvoicevivox.cpp


not sure is a nice choice remove the warn, a resident lose the only way to 
know if all work fine


- Altair


On June 9, 2011, 9:56 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/333/
> ---
> 
> (Updated June 9, 2011, 9:56 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a patch by ArminWeatherHax.  I am creating the request to help speed 
> this fix along in the system.
> 
> 
> 
> Ways to reproduce: log into a simulator.
> Reproduces: always
> Affects: any version supported, probably all 3rd party viewers but Kokua (and 
> Imprudence, soon).
> 
> What happens:
> In each idle cycle the voice client requests the "ParcelVoiceInfoRequest" 
> capability, thats each time a HTTP GET.
> See LLVivoxVoiceClient::stateMachine() after comment // Check for parcel 
> boundary crossing
> 
> Expected:
> On parcel/region change request the capability once. It's not the region that 
> rezzes in, but the avatar, so do the request for the capability not earlier 
> than the agents region signals capabilitiesReceived() true. After that you 
> are sure if the region returns an empty url you can give up for that region.
> 
> Not sure about the impact on lag - requesting and returning an url is not 
> much data transmitted, though its a pretty big number of people doing it over 
> and over per second (no matter if they have voice on or off).
> 
> 
> 
> 
> going once again through llviewerregion I see its fortunately not each time a 
> HTTP GET, just once when the agent connects to the region. Though the patch 
> still saves all the lookup if the cap is there while it can't be possibly.
> 
> 
> This addresses bug VWR-25923.
> http://jira.secondlife.com/browse/VWR-25923
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a36a329e77cc 
>   indra/newview/llvoicevivox.h a36a329e77cc 
>   indra/newview/llvoicevivox.cpp a36a329e77cc 
> 
> Diff: http://codereview.secondlife.com/r/333/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Minimum draw distance

[Trilo Byte]

Awesome slider!  Works great on the mac client.  Two things:

1) Needs a better icon (black on the dark gray UI is extremely difficult to 
make out)
2) PLEASE for the sake of all those poor class 0 machines, allow the minimum to 
be set to 32 or at least 48m

This is going to make things easier for a lot of people :)

On Jun 9, 2011, at 12:00 PM, Oz Linden (Scott Lawrence) wrote:

> On 2011-06-08 13:55, Trilo Byte wrote:
>> 
>> I agree, I love having a slider.  But I think this one's going to be a 
>> vertical slider, behaving something like the way the volume control does.  
>> Hopefully we'll get to take a peek soon :-)
> 
> here's the review viewer:
> 
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_project-3/rev/232119/index.html
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges