Re: [opensource-dev] tcmalloc

2011-05-21 Thread Kiptic ‌

> After configuring, try

> cmake -L build-*/

> or, if you also want the help strings

> cmake -LH build-*/
...

Perfect, just what I needed! 

/Kip

  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

2011-05-21 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/302/
---

(Updated May 21, 2011, 4:06 a.m.)


Review request for Viewer and Richard Nelson.


Changes
---

removing the 'Branch', since I think that causes the diff engine to try to find 
that in the repository as the branch on which your diff is based.


Summary
---

Started moving panel and floater classes into a new static library project in 
an effort to start promoting better insulation between model and view sections 
of the viewer codebase.  This is in preparation for further work breaking 
header dependencies along the lines of CHOP-624


This addresses bug CHOP-658.
http://jira.secondlife.com/browse/CHOP-658


Diffs
-

  indra/cmake/LLViewerUI.cmake PRE-CREATION 
  indra/newview/CMakeLists.txt UNKNOWN 
  indra/newview/llfloaterabout.h UNKNOWN 
  indra/newview/llfloaterabout.cpp UNKNOWN 
  indra/newview/llfloateranimpreview.h UNKNOWN 
  indra/newview/llfloateranimpreview.cpp UNKNOWN 
  indra/newview/llfloaterauction.h UNKNOWN 
  indra/newview/llfloaterauction.cpp UNKNOWN 
  indra/newview/llfloateravatarpicker.h UNKNOWN 
  indra/newview/llfloateravatarpicker.cpp UNKNOWN 
  indra/newview/llfloateravatartextures.h UNKNOWN 
  indra/newview/llfloateravatartextures.cpp UNKNOWN 
  indra/newview/llfloaterbeacons.h UNKNOWN 
  indra/newview/llfloaterbeacons.cpp UNKNOWN 
  indra/newview/llfloaterbuildoptions.h UNKNOWN 
  indra/newview/llfloaterbuildoptions.cpp UNKNOWN 
  indra/newview/llfloaterbulkpermission.h UNKNOWN 
  indra/newview/llfloaterbulkpermission.cpp UNKNOWN 
  indra/newview/llfloaterbump.h UNKNOWN 
  indra/newview/llfloaterbump.cpp UNKNOWN 
  indra/newview/llfloaterbuy.h UNKNOWN 
  indra/newview/llfloaterbuy.cpp UNKNOWN 
  indra/newview/llfloaterbuycontents.h UNKNOWN 
  indra/newview/llfloaterbuycontents.cpp UNKNOWN 
  indra/newview/llfloaterbuycurrency.h UNKNOWN 
  indra/newview/llfloaterbuycurrency.cpp UNKNOWN 
  indra/newview/llfloaterbuycurrencyhtml.h UNKNOWN 
  indra/newview/llfloaterbuycurrencyhtml.cpp UNKNOWN 
  indra/newview/llfloaterbuyland.h UNKNOWN 
  indra/newview/llfloaterbuyland.cpp UNKNOWN 
  indra/newview/llfloatercamera.h UNKNOWN 
  indra/newview/llfloatercamera.cpp UNKNOWN 
  indra/newview/llfloaterchat.h UNKNOWN 
  indra/newview/llfloaterchat.cpp UNKNOWN 
  indra/newview/llfloaterchatterbox.h UNKNOWN 
  indra/newview/llfloaterchatterbox.cpp UNKNOWN 
  indra/newview/llfloatercolorpicker.h UNKNOWN 
  indra/newview/llfloatercolorpicker.cpp UNKNOWN 
  indra/newview/llfloaterdaycycle.h UNKNOWN 
  indra/newview/llfloaterdaycycle.cpp UNKNOWN 
  indra/newview/llfloaterdisplayname.h UNKNOWN 
  indra/newview/llfloaterdisplayname.cpp UNKNOWN 
  indra/newview/llfloaterenvsettings.h UNKNOWN 
  indra/newview/llfloaterenvsettings.cpp UNKNOWN 
  indra/newview/llfloaterevent.h UNKNOWN 
  indra/newview/llfloaterevent.cpp UNKNOWN 
  indra/newview/llfloaterfonttest.h UNKNOWN 
  indra/newview/llfloaterfonttest.cpp UNKNOWN 
  indra/newview/llfloaterfriends.h UNKNOWN 
  indra/newview/llfloaterfriends.cpp UNKNOWN 
  indra/newview/llfloatergesture.h UNKNOWN 
  indra/newview/llfloatergesture.cpp UNKNOWN 
  indra/newview/llfloatergodtools.h UNKNOWN 
  indra/newview/llfloatergodtools.cpp UNKNOWN 
  indra/newview/llfloatergroupinvite.h UNKNOWN 
  indra/newview/llfloatergroupinvite.cpp UNKNOWN 
  indra/newview/llfloatergroups.h UNKNOWN 
  indra/newview/llfloatergroups.cpp UNKNOWN 
  indra/newview/llfloaterhandler.h UNKNOWN 
  indra/newview/llfloaterhandler.cpp UNKNOWN 
  indra/newview/llfloaterhardwaresettings.h UNKNOWN 
  indra/newview/llfloaterhardwaresettings.cpp UNKNOWN 
  indra/newview/llfloaterhelpbrowser.h UNKNOWN 
  indra/newview/llfloaterhelpbrowser.cpp UNKNOWN 
  indra/newview/llfloaterhud.h UNKNOWN 
  indra/newview/llfloaterhud.cpp UNKNOWN 
  indra/newview/llfloaterimagepreview.h UNKNOWN 
  indra/newview/llfloaterimagepreview.cpp UNKNOWN 
  indra/newview/llfloaterinspect.h UNKNOWN 
  indra/newview/llfloaterinspect.cpp UNKNOWN 
  indra/newview/llfloaterinventory.h UNKNOWN 
  indra/newview/llfloaterinventory.cpp UNKNOWN 
  indra/newview/llfloaterjoystick.h UNKNOWN 
  indra/newview/llfloaterjoystick.cpp UNKNOWN 
  indra/newview/llfloaterlagmeter.h UNKNOWN 
  indra/newview/llfloaterlagmeter.cpp UNKNOWN 
  indra/newview/llfloaterland.h UNKNOWN 
  indra/newview/llfloaterland.cpp UNKNOWN 
  indra/newview/llfloaterlandholdings.h UNKNOWN 
  indra/newview/llfloaterlandholdings.cpp UNKNOWN 
  indra/newview/llfloatermap.h UNKNOWN 
  indra/newview/llfloatermap.cpp UNKNOWN 
  indra/newview/llfloatermediabrowser.h UNKNOWN 
  indra/newview/llfloatermediabrowser.cpp UNKNOWN 
  indra/newview/llfloatermediasettings.h UNKNOWN 
  indra/newview/llfloatermediasettings.cpp UNKNOWN 
  indra/newview/llfloatermemleak.h UNKNOWN 
  indra/newview/llfloatermemleak.cpp UNKNOWN 
  indra/newview/llfloaterm

Re: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

2011-05-21 Thread Oz Linden

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/302/#review711
---


The diff file you uploaded does not contain mercurial changeset ids (or at 
least the version that's downloaded doesn't); that may be why it is not 
generating the diffs correctly. 

- Oz


On May 21, 2011, 4:06 a.m., Brad Kittenbrink wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/302/
> ---
> 
> (Updated May 21, 2011, 4:06 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> ---
> 
> Started moving panel and floater classes into a new static library project in 
> an effort to start promoting better insulation between model and view 
> sections of the viewer codebase.  This is in preparation for further work 
> breaking header dependencies along the lines of CHOP-624
> 
> 
> This addresses bug CHOP-658.
> http://jira.secondlife.com/browse/CHOP-658
> 
> 
> Diffs
> -
> 
>   indra/cmake/LLViewerUI.cmake PRE-CREATION 
>   indra/newview/CMakeLists.txt UNKNOWN 
>   indra/newview/llfloaterabout.h UNKNOWN 
>   indra/newview/llfloaterabout.cpp UNKNOWN 
>   indra/newview/llfloateranimpreview.h UNKNOWN 
>   indra/newview/llfloateranimpreview.cpp UNKNOWN 
>   indra/newview/llfloaterauction.h UNKNOWN 
>   indra/newview/llfloaterauction.cpp UNKNOWN 
>   indra/newview/llfloateravatarpicker.h UNKNOWN 
>   indra/newview/llfloateravatarpicker.cpp UNKNOWN 
>   indra/newview/llfloateravatartextures.h UNKNOWN 
>   indra/newview/llfloateravatartextures.cpp UNKNOWN 
>   indra/newview/llfloaterbeacons.h UNKNOWN 
>   indra/newview/llfloaterbeacons.cpp UNKNOWN 
>   indra/newview/llfloaterbuildoptions.h UNKNOWN 
>   indra/newview/llfloaterbuildoptions.cpp UNKNOWN 
>   indra/newview/llfloaterbulkpermission.h UNKNOWN 
>   indra/newview/llfloaterbulkpermission.cpp UNKNOWN 
>   indra/newview/llfloaterbump.h UNKNOWN 
>   indra/newview/llfloaterbump.cpp UNKNOWN 
>   indra/newview/llfloaterbuy.h UNKNOWN 
>   indra/newview/llfloaterbuy.cpp UNKNOWN 
>   indra/newview/llfloaterbuycontents.h UNKNOWN 
>   indra/newview/llfloaterbuycontents.cpp UNKNOWN 
>   indra/newview/llfloaterbuycurrency.h UNKNOWN 
>   indra/newview/llfloaterbuycurrency.cpp UNKNOWN 
>   indra/newview/llfloaterbuycurrencyhtml.h UNKNOWN 
>   indra/newview/llfloaterbuycurrencyhtml.cpp UNKNOWN 
>   indra/newview/llfloaterbuyland.h UNKNOWN 
>   indra/newview/llfloaterbuyland.cpp UNKNOWN 
>   indra/newview/llfloatercamera.h UNKNOWN 
>   indra/newview/llfloatercamera.cpp UNKNOWN 
>   indra/newview/llfloaterchat.h UNKNOWN 
>   indra/newview/llfloaterchat.cpp UNKNOWN 
>   indra/newview/llfloaterchatterbox.h UNKNOWN 
>   indra/newview/llfloaterchatterbox.cpp UNKNOWN 
>   indra/newview/llfloatercolorpicker.h UNKNOWN 
>   indra/newview/llfloatercolorpicker.cpp UNKNOWN 
>   indra/newview/llfloaterdaycycle.h UNKNOWN 
>   indra/newview/llfloaterdaycycle.cpp UNKNOWN 
>   indra/newview/llfloaterdisplayname.h UNKNOWN 
>   indra/newview/llfloaterdisplayname.cpp UNKNOWN 
>   indra/newview/llfloaterenvsettings.h UNKNOWN 
>   indra/newview/llfloaterenvsettings.cpp UNKNOWN 
>   indra/newview/llfloaterevent.h UNKNOWN 
>   indra/newview/llfloaterevent.cpp UNKNOWN 
>   indra/newview/llfloaterfonttest.h UNKNOWN 
>   indra/newview/llfloaterfonttest.cpp UNKNOWN 
>   indra/newview/llfloaterfriends.h UNKNOWN 
>   indra/newview/llfloaterfriends.cpp UNKNOWN 
>   indra/newview/llfloatergesture.h UNKNOWN 
>   indra/newview/llfloatergesture.cpp UNKNOWN 
>   indra/newview/llfloatergodtools.h UNKNOWN 
>   indra/newview/llfloatergodtools.cpp UNKNOWN 
>   indra/newview/llfloatergroupinvite.h UNKNOWN 
>   indra/newview/llfloatergroupinvite.cpp UNKNOWN 
>   indra/newview/llfloatergroups.h UNKNOWN 
>   indra/newview/llfloatergroups.cpp UNKNOWN 
>   indra/newview/llfloaterhandler.h UNKNOWN 
>   indra/newview/llfloaterhandler.cpp UNKNOWN 
>   indra/newview/llfloaterhardwaresettings.h UNKNOWN 
>   indra/newview/llfloaterhardwaresettings.cpp UNKNOWN 
>   indra/newview/llfloaterhelpbrowser.h UNKNOWN 
>   indra/newview/llfloaterhelpbrowser.cpp UNKNOWN 
>   indra/newview/llfloaterhud.h UNKNOWN 
>   indra/newview/llfloaterhud.cpp UNKNOWN 
>   indra/newview/llfloaterimagepreview.h UNKNOWN 
>   indra/newview/llfloaterimagepreview.cpp UNKNOWN 
>   indra/newview/llfloaterinspect.h UNKNOWN 
>   indra/newview/llfloaterinspect.cpp UNKNOWN 
>   indra/newview/llfloaterinventory.h UNKNOWN 
>   indra/newview/llfloaterinventory.cpp UNKNOWN 
>   indra/newview/llfloaterjoystick.h UNKNOWN 
>   indra/newview/llfloaterjoystick.cpp UNKNOWN 
>   indra/newview/llfloaterlagmeter.h UNKNOWN 
>   indra/newview/llfloaterlagmeter.cpp UNKNOWN 
>   indra/newview/llfloaterland.h UNKNOWN 
>   indra/newview/llfloa

Re: [opensource-dev] Mesh branch merged to viewer-development

2011-05-21 Thread Nicky D.
>
> Some of the changes may cause problems with using the Debug (and
> DebugOS) configurations.  If you have problems, please bring them up on
> the list.  Don't file a jira yet unless you believe you have diagnosed a
> specific issue well enough that a fix is possible.  If it turns out that
> these configurations are not working well, getting them fixed will be a
> high priority this week.

I pulled and merged yesterday.

Got a viewer running and working as a 64 bit binary compiled under Linux.
I obviously had to roll my own fix for SH-1616. Other than that is seems to
work mostly ok.

The only other issue I have is with textures. Some seem to have something
like a rainbow effect on them. For some the alpha seems to be bad. Some
use the wrong colors when far away, zooming closer changes to color to a better
value. Zooming even closer changes to worse colors again.

Not really sure what this is. For sure it looks a bit odd and annoying :)

Cheers,
   Nicky
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges