Re: [opensource-dev] Review Request: Convert autobuild library builds to use msbuild.exe instead of devenv.com.

2011-05-18 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/312/#review705
---



autobuild/autobuild_tool_source_environment.py


Add a space between 'solution' and the opening brace, too.



autobuild/autobuild_tool_source_environment.py


Remove trailing whitespace, please.



autobuild/autobuild_tool_source_environment.py


Wait, wait, wait ... I didn't notice this before, but ...



autobuild/autobuild_tool_source_environment.py


... are you really doing the exact same in both, the if and the else case? 
What testing is then needed to eliminate the conditioning? (Note that [ -z ... 
] only tests whether the string is empty, and doesn't modify anything.)


- Boroondas


On May 17, 2011, 3:42 p.m., Nicky Perian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/312/
> ---
> 
> (Updated May 17, 2011, 3:42 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Convert autobuild library builds to use msbuild.exe instead of devenv.com. 
> Includes Ima Mechanique change from http://codereview.secondlife.com/r/305/
> 
> 
> This addresses bug OPEN-69.
> http://jira.secondlife.com/browse/OPEN-69
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 
> 
> Diff: http://codereview.secondlife.com/r/312/diff
> 
> 
> Testing
> ---
> 
> Made calling script 3p-ogvoribs/build-cmd.sh changes, which will be published 
> later, to use msbuild parameters and successfully built and packaged library. 
> Compared files in the package to those from LL prebuilt download and they 
> match by name and size.
> TODO: Build the viewer with the local package. 
> 
> Built and packaged 3p-ogvorbis with added parameters.
> 
> 
> Thanks,
> 
> Nicky
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Convert autobuild library builds to use msbuild.exe instead of devenv.com.

2011-05-18 Thread Nicky Perian 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/312/
---

(Updated May 18, 2011, 4:01 a.m.)


Review request for Viewer.


Changes
---

Added a space and removed trailing white space.
... are you really doing the exact same in both, the if and the else case? What 
testing is then needed to eliminate the conditioning?
I couldn't get into the head of the original writer of the code. So, as a 
precaution kept logic in place.  I am waiting for LL to run this and say no 
problems encountered.
Or, another windows developer to pipe in and say this s how solutions and 
projects are called together when using msbuild.exe. That would allow the 
calling build-cmd.sh
to keep the same calling logic Namely, this run is a solution without a project 
or this run is a project within a solution. Please look at OPEN-70 to see 
changes to a calling build-cmd.sh.


Summary
---

Convert autobuild library builds to use msbuild.exe instead of devenv.com. 
Includes Ima Mechanique change from http://codereview.secondlife.com/r/305/


This addresses bug OPEN-69.
http://jira.secondlife.com/browse/OPEN-69


Diffs (updated)
-

  autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 

Diff: http://codereview.secondlife.com/r/312/diff


Testing (updated)
---

Made calling script 3p-ogvoribs/build-cmd.sh changes, which will be published 
later, to use msbuild parameters and successfully built and packaged library. 
Compared files in the package to those from LL prebuilt download and they match 
by name and size.
TODO: Build the viewer with the local package. DONE: Built viewer (16169) prior 
to mesh and logged to agni and played audio streams with no problems. 

Built and packaged 3p-ogvorbis with added parameters. 


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Convert autobuild library builds to use msbuild.exe instead of devenv.com.

2011-05-18 Thread Nicky Perian 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/312/
---

(Updated May 18, 2011, 5:01 a.m.)


Review request for Viewer.


Changes
---

Removed comments and unused if else check.


Summary
---

Convert autobuild library builds to use msbuild.exe instead of devenv.com. 
Includes Ima Mechanique change from http://codereview.secondlife.com/r/305/


This addresses bug OPEN-69.
http://jira.secondlife.com/browse/OPEN-69


Diffs (updated)
-

  autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 

Diff: http://codereview.secondlife.com/r/312/diff


Testing
---

Made calling script 3p-ogvoribs/build-cmd.sh changes, which will be published 
later, to use msbuild parameters and successfully built and packaged library. 
Compared files in the package to those from LL prebuilt download and they match 
by name and size.
TODO: Build the viewer with the local package. DONE: Built viewer (16169) prior 
to mesh and logged to agni and played audio streams with no problems. 

Built and packaged 3p-ogvorbis with added parameters. 


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Convert autobuild library builds to use msbuild.exe instead of devenv.com.

2011-05-18 Thread Nicky Perian 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/312/
---

(Updated May 18, 2011, 5:13 a.m.)


Review request for Viewer.


Changes
---

Sorry, forgot to commit last change.


Summary
---

Convert autobuild library builds to use msbuild.exe instead of devenv.com. 
Includes Ima Mechanique change from http://codereview.secondlife.com/r/305/


This addresses bug OPEN-69.
http://jira.secondlife.com/browse/OPEN-69


Diffs (updated)
-

  autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 

Diff: http://codereview.secondlife.com/r/312/diff


Testing
---

Made calling script 3p-ogvoribs/build-cmd.sh changes, which will be published 
later, to use msbuild parameters and successfully built and packaged library. 
Compared files in the package to those from LL prebuilt download and they match 
by name and size.
TODO: Build the viewer with the local package. DONE: Built viewer (16169) prior 
to mesh and logged to agni and played audio streams with no problems. 

Built and packaged 3p-ogvorbis with added parameters. 


Thanks,

Nicky

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Mesh branch merged to viewer-development

2011-05-18 Thread Vadim Savchuk 
On 05/18/2011 01:05 AM, Sergey Litovchuk wrote:
> Running the latest viewer-development build for me causes the viewer to
> crash on start up with an error:
>
> 2011-05-17T21:41:18Z newview/llviewertexturelist.cpp(492) : error
> 2011-05-17T21:41:18Z ERROR: LLViewerTextureList::addImageToList: ASSERT
> (mInitialized)
I get  another crash on each startup:


Program terminated with signal 11, Segmentation fault.
#0  0x088bb265 in LLPhysicsDecomp::run (this=0xb1970a0) at 
viewer-development/indra/newview/llmeshrepository.cpp:3664
3664num_stages = decomp->getStages(&stages);
(gdb) bt
#0  0x088bb265 in LLPhysicsDecomp::run (this=0xb1970a0) at 
viewer-development/indra/newview/llmeshrepository.cpp:3664
#1  0xb735ffe0 in LLThread::staticRun (apr_threadp=0xb231058, 
datap=0xb1970a0) at viewer-development/indra/llcommon/llthread.cpp:86
#2  0xb662aa80 in dummy_worker () from 
/media/gutsyviewer-development/build-linux-i686/newview/packaged/lib/libapr-1.so.0
#3  0xb77cc80e in start_thread (arg=0xb2a0bb70) at pthread_create.c:300
#4  0xb6435a0e in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:130
(gdb) fr 0
#0  0x088bb265 in LLPhysicsDecomp::run (this=0xb1970a0) at 
viewer-development/indra/newview/llmeshrepository.cpp:3664
3664num_stages = decomp->getStages(&stages);
(gdb) print decomp
$1 = (struct LLConvexDecomposition *) 0x0
(gdb)


Apparently, LLConvexDecomposition::getInstance() returns 0;

-- 
Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Build Error 2.6.9.(0?) llviewermessage.cpp

2011-05-18 Thread Mysty Saunders 
Ubuntu 11.04 32 GCC 4.5 (tested 4.4 as well) using -ReleaseOS to build

/home/mysty/slm/viewer-development/indra/newview/llviewermessage.cpp: In
function ‘void process_improved_im(LLMessageSystem*, void**)’:
/home/mysty/slm/viewer-development/indra/newview/llviewermessage.cpp:2805:8:
error: ‘region_access’ may be used uninitialized in this function
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] PO review build

2011-05-18 Thread Oz Linden (Scott Lawrence) 

STORM-941 
   IM log naming should go by SL name, not DN. 
STORM-1032 
   Artwork update for Appearance Editor "Edit" icon 
STORM-1175 

   'Close' button doesn't work after setting Custom port in Preferences
> Setup > Network 
STORM-1259 

   Sculpt dimension meta-data view missing from 2.x, was possible to
   see in 1.23 



http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/230190/index.html
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] PO review build

2011-05-18 Thread Opensource Obscure 
On Wed, May 18, 2011 at 17:55, Oz Linden (Scott Lawrence)
wrote:

>  STORM-941  IM log naming
> should go by SL name, not DN. 
> STORM-1032 Artwork
> update for Appearance Editor "Edit" icon 
> STORM-1175 'Close'
> button doesn't work after setting Custom port in Preferences > Setup >
> Network STORM-1259  Sculpt
> dimension meta-data view missing from 2.x, was possible to see in 1.23
>

Tested on Linux build: these are all fixed and working as expected.

Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
discuss Second Life Viewer 2: http://j.mp/slv2group
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Mesh branch merged to viewer-development

2011-05-18 Thread Trilo Byte 
I'm also experiencing some issues with bulk image uploads not adhering to the 
default upload permissions (Mac client, build 230167).

Click + -> Upload -> Set Default Permissions and then check the set next owner 
perms to modify, copy, resell/giveaway

Click + -> Upload -> Bulk  and then select a range of image files.

Upload completes normally, but images don't have correct perms.


On May 17, 2011, at 11:22 AM, Oz Linden (Scott Lawrence) wrote:

> 
> The mesh team development branch has been merged to viewer-development 
> (with the actual mesh support disabled, but with many rendering and 
> other fixes active).
> 
> Your next pull of the tip of viewer-development will bring you ~2250 
> changesets; pay careful attention to any merges of your local changes.
> 
> Some of the changes may cause problems with using the Debug (and 
> DebugOS) configurations.  If you have problems, please bring them up on 
> the list.  Don't file a jira yet unless you believe you have diagnosed a 
> specific issue well enough that a fix is possible.  If it turns out that 
> these configurations are not working well, getting them fixed will be a 
> high priority this week.
> 
> If you would like to update your repository to the latest possible 
> change _before_ the mesh branch move (and let the rest of us sort out 
> any problems that arise), then you can pull the tag '2.6.9-start'; the 
> mesh merge is the next revision after that tag.
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

2011-05-18 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/307/
---

(Updated May 18, 2011, 1:13 p.m.)


Review request for Viewer.


Changes
---

* renamed the newly introduced method to convertFilenameToString
* moved implementations out of class body
* declared the (pre-existing) temporary string constant


Summary
---

Some trickery needed to make this forward compatible to newer Boost versions 
while keeping compatibility to the currently used Boost version.


This addresses bug OPEN-67.
http://jira.secondlife.com/browse/OPEN-67


Diffs (updated)
-

  doc/contributions.txt 959f9340da92 
  indra/llvfs/lldiriterator.cpp 959f9340da92 

Diff: http://codereview.secondlife.com/r/307/diff


Testing
---

* Compiled Viewer (standalone) with Boost 1.46
* Started Viewer
* Logged in

Not tested:
* non-standalone
* other boost versions (At least one version <= 1.43 should be tested! 
Preferably the one LL currently uses.)


Thanks,

Boroondas

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] PO review build

2011-05-18 Thread Ima Mechanique 
Hi

> STORM-941 
> IM log naming should go by SL name, not DN. 

Tested with one person, but worked fine.

> STORM-1032 
> Artwork update for Appearance Editor "Edit" icon 

Looks good.

> STORM-1175 
> 'Close' button doesn't work after setting Custom port in Preferences
>  > Setup > Network 

yay it works \o/

> STORM-1259 
> Sculpt dimension meta-data view missing from 2.x, was possible to
> see in 1.23 

Works fine.

--
Ima Mechanique
ima.mechanique(at)blueyonder.co.uk

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] PO review build

2011-05-18 Thread Erin Mallory 

all looks good on win xp and 7 

> Date: Wed, 18 May 2011 21:27:16 +0100
> From: ima.mechani...@blueyonder.co.uk
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] PO review build
> 
> Hi
> 
> > STORM-941 
> > IM log naming should go by SL name, not DN. 
> 
> Tested with one person, but worked fine.
> 
> > STORM-1032 
> > Artwork update for Appearance Editor "Edit" icon 
> 
> Looks good.
> 
> > STORM-1175 
> > 'Close' button doesn't work after setting Custom port in Preferences
> >  > Setup > Network 
> 
> yay it works \o/
> 
> > STORM-1259 
> > Sculpt dimension meta-data view missing from 2.x, was possible to
> > see in 1.23 
> 
> Works fine.
> 
> --
> Ima Mechanique
> ima.mechanique(at)blueyonder.co.uk
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Subject: Re: Mesh branch merged to viewer-development

2011-05-18 Thread Daniel 
Project viewer Mesh build 2.6.9-230227 crashes on startup (before login 
screen)
Second Life Development build 2.6.9-230088 completes login, but reports 
it can't find notifications.xml and refuses to do anything else

System:

Intel i7-920, 6 GB memory, Nvidia GTX 260, 270.61 driver
Window 7 Ultimate x64, SP1

> --
>
> Message: 3
> Date: Wed, 18 May 2011 16:45:29 +0300
> From: Vadim Savchuk
> Subject: Re: [opensource-dev] Mesh branch merged to viewer-development
> To: Sergey Litovchuk
> Cc: opensource-dev
> Message-ID:<4dd3cd79.7090...@productengine.com>
> Content-Type: text/plain; charset=ISO-8859-1; format=flowed
>
> On 05/18/2011 01:05 AM, Sergey Litovchuk wrote:
>> Running the latest viewer-development build for me causes the viewer to
>> crash on start up with an error:
>>
>> 2011-05-17T21:41:18Z newview/llviewertexturelist.cpp(492) : error
>> 2011-05-17T21:41:18Z ERROR: LLViewerTextureList::addImageToList: ASSERT
>> (mInitialized)
> I get  another crash on each startup:
>
> 
> Program terminated with signal 11, Segmentation fault.
> #0  0x088bb265 in LLPhysicsDecomp::run (this=0xb1970a0) at
> viewer-development/indra/newview/llmeshrepository.cpp:3664
> 3664num_stages = decomp->getStages(&stages);
> (gdb) bt
> #0  0x088bb265 in LLPhysicsDecomp::run (this=0xb1970a0) at
> viewer-development/indra/newview/llmeshrepository.cpp:3664
> #1  0xb735ffe0 in LLThread::staticRun (apr_threadp=0xb231058,
> datap=0xb1970a0) at viewer-development/indra/llcommon/llthread.cpp:86
> #2  0xb662aa80 in dummy_worker () from
> /media/gutsyviewer-development/build-linux-i686/newview/packaged/lib/libapr-1.so.0
> #3  0xb77cc80e in start_thread (arg=0xb2a0bb70) at pthread_create.c:300
> #4  0xb6435a0e in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:130
> (gdb) fr 0
> #0  0x088bb265 in LLPhysicsDecomp::run (this=0xb1970a0) at
> viewer-development/indra/newview/llmeshrepository.cpp:3664
> 3664num_stages = decomp->getStages(&stages);
> (gdb) print decomp
> $1 = (struct LLConvexDecomposition *) 0x0
> (gdb)
> 
>
> Apparently, LLConvexDecomposition::getInstance() returns 0;
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Repeated entries in settings.xml

2011-05-18 Thread Jonathan Welch 
Five months ago I went through a drawn out process to eliminate
duplicate and triplicate entries in settings.xml.  Today I found two
new duplicates.  For a few reasons having a clean file is a good idea.

Oz has suggested that this file be scanned by a unit test as part of
compiling the viewer.  If there are newly introduced duplicates the
compile would fail and the problem addressed immediately.

I am looking for (ideally) someone to take on this (little?) project,
but if you have any ideas of how this job could be done I would like
to hear them.

-Jonathan
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges