Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Ima Mechanique]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/
---

(Updated May 12, 2011, 12:26 a.m.)


Review request for Viewer.


Changes
---

Fixed the contributions entry, that sneaked in from my local repo, because it's 
missing in v-d.

Thanks Boroondas.


Summary
---

Applying Kitty Barnett's patch against current code base.


This addresses bug STORM-1175.
http://jira.secondlife.com/browse/STORM-1175


Diffs (updated)
-

  doc/contributions.txt 5e349dbe9cc8 
  indra/llui/llnotifications.cpp 5e349dbe9cc8 

Diff: http://codereview.secondlife.com/r/271/diff


Testing
---

Release build. tested preferences both in world and on the log in screen.


Thanks,

Ima

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review696
---

Ship it!



indra/llui/llnotifications.cpp


Sorry, another change request ... Didn't see this at first:
Please remove the trailing whitespace.


No other objections, so ship it!

(Not quite seeing through that forest of add methods and Param constructors, so 
I just have to trust Vadim picked the right function call here.)

- Boroondas


On May 12, 2011, 12:26 a.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> ---
> 
> (Updated May 12, 2011, 12:26 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Applying Kitty Barnett's patch against current code base.
> 
> 
> This addresses bug STORM-1175.
> http://jira.secondlife.com/browse/STORM-1175
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 5e349dbe9cc8 
>   indra/llui/llnotifications.cpp 5e349dbe9cc8 
> 
> Diff: http://codereview.secondlife.com/r/271/diff
> 
> 
> Testing
> ---
> 
> Release build. tested preferences both in world and on the log in screen.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Ima Mechanique]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/
---

(Updated May 12, 2011, 3:45 a.m.)


Review request for Viewer.


Changes
---

Removed trailing whitespace per Boroondas' request.


Summary
---

Applying Kitty Barnett's patch against current code base.


This addresses bug STORM-1175.
http://jira.secondlife.com/browse/STORM-1175


Diffs (updated)
-

  doc/contributions.txt 5e349dbe9cc8 
  indra/llui/llnotifications.cpp 5e349dbe9cc8 

Diff: http://codereview.secondlife.com/r/271/diff


Testing
---

Release build. tested preferences both in world and on the log in screen.


Thanks,

Ima

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review697
---

Ship it!


Yay, 4 RB revisions for a one-liner :-P

- Boroondas


On May 12, 2011, 3:45 a.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> ---
> 
> (Updated May 12, 2011, 3:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Applying Kitty Barnett's patch against current code base.
> 
> 
> This addresses bug STORM-1175.
> http://jira.secondlife.com/browse/STORM-1175
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 5e349dbe9cc8 
>   indra/llui/llnotifications.cpp 5e349dbe9cc8 
> 
> Diff: http://codereview.secondlife.com/r/271/diff
> 
> 
> Testing
> ---
> 
> Release build. tested preferences both in world and on the log in screen.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Wednesday, May 11

[Anya Kanevsky]

 Sprint 15, ends 05.16.11 Wednesday, May 11 Team Status
--
 Oz Linden
--

*PAST*

   - Several merges to viewer-development
   - Extensive meetings over two days with UX team lead
   - PO Review build (notice coming shortly)

*FUTURE*

   - Rewrite GPU table regression test (STORM-1100) in python
   - Code reviews
   - Open Development User Group
   - Update windlight project branch from viewer-development

*IMPEDIMENTS*

   - none

Wolf Linden
--

*PAST*

   - Completed evaluation of windows/floaters

*FUTURE*

   - Finalizing recommendations for windows/floaters; Need to set up time
   with team to review (includes customizable UI)

*IMPEDIMENTS*

   - none

Grumpity ProductEngine
--

*PAST*

   - crashhunters
   - jira-wrangling

*FUTURE*

   - vwr triage
   - WLRS project viewer?
   - reports
   - chop-662

*IMPEDIMENTS*

   - need PO build

Paul ProductEngine
--

*PAST*

   - TASK STORM-1202 (Time spin control)
  - Hope to finish today

*FUTURE*

   - STORM-1205 (Add "Environment" tab to the "Region/Estate" floater)

*IMPEDIMENTS*

   - none

Seth ProductEngine
--

*PAST*

   - STORY (STORM-477) Re-implement LLDir::getNextFileInDir() as an iterator
   object
  - Restored backed out changesets, resolved merge conflicts.
   - Getting familiar with WLRS spec.

*FUTURE*

   - Work on Edit Water Preset floater.

*IMPEDIMENTS*

   - none

Vadim ProductEngine
--

*PAST*

   - Closed some submitted review requests.
   - Working on WLRS implementation.

*FUTURE*

   - Proceed with WLRS implementation, hoping to have something to show by
   Monday.

*IMPEDIMENTS*

   - none

Andrey ProductEngine
--

*PAST*

   - tested CHOP-663 on all platforms using the build referenced in the
   ticket
   - finished testing in scope of IQA-162
  - also has been run additional regression testing on r229289

*FUTURE*

   - run smoke & integrity on 2.6.8 build#2
   - pickup v-d latest build and verify integrated tickets

*IMPEDIMENTS*

   - none

Wolfpup Lowenhar
--

*PAST*
This is going to need to be looked at by a dev with more UI experience for
Linux OS.

*FUTURE*

   - Looking for some thing to work on.
   - See Impediments.

*IMPEDIMENTS*

   - Getting Autobuild system and security software to play nicely on my
   system.
   - Windows system down till i can get a new new video card for it.
   -
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges