[opensource-dev] Daily Scrum Summary - Monday, April 25
Sprint 14, ends 04.25.11 Monday, April 25 General Notes -- - Sprint planning today - PE OOO today - short standup! - Seth on vacation this week Team Status -- Oz Linden -- *PAST* - Reviewed and merged many issues to viewer-development - Cleaned up some old reviews on codereview - Some more work on contributor build farm *FUTURE* - Sprint Planning - More GPU table updates (STORM-1100) - Work on TeamCity build farm for contributors *IMPEDIMENTS* - none Wolf Linden -- *PAST* - out on friday *FUTURE* - Storm-2 *IMPEDIMENTS* - none Grumpity ProductEngine -- *PAST* - sprint review and retrospective *FUTURE* - sprint planning *IMPEDIMENTS* - reopened issues keep value for approvals. - sick ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/#review650 --- Ship it! - Vadim On April 25, 2011, 4:40 p.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/277/ > --- > > (Updated April 25, 2011, 4:40 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review > request's diff) and applied analogous changes to lldir_mac.cpp, in hope that > this would fix the same issue on Mac, too: > * renamed indra_pos to build_dir_pose (just for consistency. This should not > have any effect.) > * search for "/build-darwin-" rather than "/indra" within mExecutableDir (The > new build dir prefix is taken from .hgignore, in the hope that is up to date.) > > > This addresses bug STORM-1182. > http://jira.secondlife.com/browse/STORM-1182 > > > Diffs > - > > doc/contributions.txt 9c0506d10226 > indra/llvfs/lldir_linux.cpp 9c0506d10226 > indra/llvfs/lldir_mac.cpp 9c0506d10226 > > Diff: http://codereview.secondlife.com/r/277/diff > > > Testing > --- > > None, as I don't have a mac. > > > Thanks, > > Boroondas > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/ --- Review request for Viewer. Summary --- Fix for a minor buffer overrun on shutdown in LLVFS::audit. This addresses bug VWR-25608. http://jira.secondlife.com/browse/VWR-25608 Diffs - indra/llvfs/llvfs.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/278/diff Testing --- I tested using the Microsoft Debug Heap and confirmed that this allows the Debug Heap to shut down without errors. Thanks, Brad ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: VWR-25609 crash on shutdown in LLGLNamePool::sInstances destructor
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/279/ --- Review request for Viewer. Summary --- The error is due to the fact that the instances of subclasses of LLGLNamePool (e.g. LLVertexBuffer::sStreamVBOPool) were having their destructors run after the destructor for LLGLNamePool::sInstances, yet accessing the members of the already destructed vector, causing a crash. This addresses bug VWR-25609. http://jira.secondlife.com/browse/VWR-25609 Diffs - indra/llrender/llgl.h UNKNOWN indra/llrender/llgl.cpp UNKNOWN indra/llrender/llvertexbuffer.cpp UNKNOWN indra/newview/llspatialpartition.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/279/diff Testing --- Tested in debug builds with the Microsoft Debug heap and confirmed that this patch allows shutdown to complete without error. Thanks, Brad ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/280/ --- Review request for Viewer. Summary --- Unnecessary copying was slowing down debugging of STORM-1141. This addresses bug VWR-25610. http://jira.secondlife.com/browse/VWR-25610 Diffs - indra/llxml/llcontrol.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/280/diff Testing --- Thanks, Brad ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/280/#review651 --- Ship it! - Stone On April 26, 2011, 5:36 p.m., Brad Kittenbrink wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/280/ > --- > > (Updated April 26, 2011, 5:36 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Unnecessary copying was slowing down debugging of STORM-1141. > > > This addresses bug VWR-25610. > http://jira.secondlife.com/browse/VWR-25610 > > > Diffs > - > > indra/llxml/llcontrol.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/280/diff > > > Testing > --- > > > Thanks, > > Brad > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-25609 crash on shutdown in LLGLNamePool::sInstances destructor
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/279/ --- (Updated April 26, 2011, 5:40 p.m.) Review request for Viewer. Summary (updated) --- The error is due to the fact that the instances of subclasses of LLGLNamePool (e.g. LLVertexBuffer::sStreamVBOPool) were having their destructors run after the destructor for LLGLNamePool::sInstances, yet accessing the members of the already destructed vector, causing a crash. The fix is to use the LLInstanceTracker class which has already solved this problem in a general way, rather than hand-rolling our own custom solution in LLGLNamePool. This addresses bug VWR-25609. http://jira.secondlife.com/browse/VWR-25609 Diffs - indra/llrender/llgl.h UNKNOWN indra/llrender/llgl.cpp UNKNOWN indra/llrender/llvertexbuffer.cpp UNKNOWN indra/newview/llspatialpartition.cpp UNKNOWN Diff: http://codereview.secondlife.com/r/279/diff Testing --- Tested in debug builds with the Microsoft Debug heap and confirmed that this patch allows shutdown to complete without error. Thanks, Brad ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/281/ --- Review request for Viewer. Summary --- Somewhere in the VS2010 transition, the default conventions changed for how .pdb files get generated on shared library targets. This fix explicitly sets the /DEBUG flag for the linker on the llcommon target. This addresses bug CHOP-629. http://jira.secondlife.com/browse/CHOP-629 Diffs - indra/llcommon/CMakeLists.txt UNKNOWN Diff: http://codereview.secondlife.com/r/281/diff Testing --- I tested locally in the debugger, but I did not test crash reports. We should find a way to test that once my TC build completes. Thanks, Brad ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review652 --- Ship it! hg rm llconfusingcode.cpp is better, but llmax() works here. - Stone On April 26, 2011, 5:31 p.m., Brad Kittenbrink wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/278/ > --- > > (Updated April 26, 2011, 5:31 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Fix for a minor buffer overrun on shutdown in LLVFS::audit. > > > This addresses bug VWR-25608. > http://jira.secondlife.com/browse/VWR-25608 > > > Diffs > - > > indra/llvfs/llvfs.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/278/diff > > > Testing > --- > > I tested using the Microsoft Debug Heap and confirmed that this allows the > Debug Heap to shut down without errors. > > > Thanks, > > Brad > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
