Re: [opensource-dev] IM/Group chat icons?

2011-04-25 Thread Opensource Obscure 
On Mon, Apr 25, 2011 at 00:19, Trilo Byte  wrote:
> I can't tell if this is a bug or not (since a fair number of jira's 
> referenced in recent builds are issues we don't have permission to view), but 
> in build 227447 (Mac client), it appears there's been a change to the way 
> IM's and group chat icons appear on the bottom of the screen.
(...)

Thanks for reporting VWR-25595 - I just commented there that
other icons are missing as well:

- 'x' in inventory search
- object creator and owner in Edit window
- up and down arrows in all scroll bars
- private IM icons in bottom bar
- group and IM icons in conversations panel

https://jira.secondlife.com/browse/VWR-25595

Adding voice/no-voice status in Edit window or
removing arrows from scrollbars couldn't be useful
in any way - so I'm sure this was an error, not a feature.

Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
Discuss Viewer 2 in-world (if chat works): http://j.mp/slv2group
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] PO Review

2011-04-25 Thread Oz Linden (Scott Lawrence) 

On 2011-04-22 14:09, Oz Linden (Scott Lawrence) wrote:

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/227402/index.html

STORM-320 
Script Editor in Viewer 2.0+ "tabs" incorrectly 



Approved


STORM-595 
Viewer should stop spamming AgentThrottle messages as the slider
is dragged 



Approved



STORM-640 
URL-name of object is shown as a hyperlink in the Buy Contents
floater 



Approved



STORM-891 
[HARDCODED] - ALL LANGS - Message showing up after setting your
home is in English (French viewer) 



Approved



STORM-898 
Filter settings do not reset after unchecking 'Since Logoff' checkbox 



Approved



STORM-918 
Changes in Group Role Titles or Assignments Not Reflected in Title
Dropdown 



Rejected - at least one variant of the bug is still there.



STORM-941 
IM log naming should go by SL name, not DN. 



Not tested.



STORM-1028 
Speak button label not displaying at default window size 



Waiting for QA to do full bottom bar regression testing.



STORM-1039 
Bad iterator access in llavatarnamecache.cpp:564 



Approved



STORM- 
Blocks of chat log are being read in from then rewritten with new
timestamps. 



Approved



STORM-1182 
[Linux] XUI Preview Tool fails to load XMLs from indra/newview/skins 



Rejected - fix only addressed Linux

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/277/
---

Review request for Viewer.


Summary
---

Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review 
request's diff) and applied analogous changes to lldir_mac.cpp, in hope that 
this would fix the same issue on Mac, too:
* renamed indra_pos to build_dir_pose (just for consistency. This should not 
have any effect.)
* search for "/build-darwin-" rather than "/indra" within mExecutableDir (The 
new build dir prefix is taken from .hgignore, in the hope that is up to date.)


This addresses bug STORM-1182.
http://jira.secondlife.com/browse/STORM-1182


Diffs
-

  doc/contributions.txt 9c0506d10226 
  indra/llvfs/lldir_linux.cpp 9c0506d10226 
  indra/llvfs/lldir_mac.cpp 9c0506d10226 

Diff: http://codereview.secondlife.com/r/277/diff


Testing
---

None, as I don't have a mac.


Thanks,

Boroondas

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] PO Review

2011-04-25 Thread Opensource Obscure 
On Mon, Apr 25, 2011 at 13:13, Oz Linden (Scott Lawrence)
 wrote:
> On 2011-04-22 14:09, Oz Linden (Scott Lawrence) wrote:
>
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/227402/index.html

After installing this I tried to upload a texture and the viewer crashed.
I tried again a dozen of times and I got multiple crashes - but it didn't
happen all the time. Viewer crashes before uploading the file: sometimes
it freezes on the file selection window, sometimes it just crashes down.

I suppose this could be a good reason for me to try compiling a
ReleaseWithDbg or Debug build.

I'm going to file this issue later - just gathering details now.

Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
discuss Second Life Viewer 2: http://j.mp/slv2group
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/277/#review647
---

Ship it!


Looks good, thanks.

One note that applies to my patch as well: rfind() seems to fit better than 
find() in this case.

- Vadim


On April 25, 2011, 5:09 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/277/
> ---
> 
> (Updated April 25, 2011, 5:09 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review 
> request's diff) and applied analogous changes to lldir_mac.cpp, in hope that 
> this would fix the same issue on Mac, too:
> * renamed indra_pos to build_dir_pose (just for consistency. This should not 
> have any effect.)
> * search for "/build-darwin-" rather than "/indra" within mExecutableDir (The 
> new build dir prefix is taken from .hgignore, in the hope that is up to date.)
> 
> 
> This addresses bug STORM-1182.
> http://jira.secondlife.com/browse/STORM-1182
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 9c0506d10226 
>   indra/llvfs/lldir_linux.cpp 9c0506d10226 
>   indra/llvfs/lldir_mac.cpp 9c0506d10226 
> 
> Diff: http://codereview.secondlife.com/r/277/diff
> 
> 
> Testing
> ---
> 
> None, as I don't have a mac.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] IM/Group chat icons?

2011-04-25 Thread Anya Kanevsky 
Definitely is a bug, and thank you for bringing it up. Social team is on it.

2011/4/25 Opensource Obscure 

> On Mon, Apr 25, 2011 at 00:19, Trilo Byte  wrote:
> > I can't tell if this is a bug or not (since a fair number of jira's
> referenced in recent builds are issues we don't have permission to view),
> but in build 227447 (Mac client), it appears there's been a change to the
> way IM's and group chat icons appear on the bottom of the screen.
> (...)
>
> Thanks for reporting VWR-25595 - I just commented there that
> other icons are missing as well:
>
> - 'x' in inventory search
> - object creator and owner in Edit window
> - up and down arrows in all scroll bars
> - private IM icons in bottom bar
> - group and IM icons in conversations panel
>
> https://jira.secondlife.com/browse/VWR-25595
>
> Adding voice/no-voice status in Edit window or
> removing arrows from scrollbars couldn't be useful
> in any way - so I'm sure this was an error, not a feature.
>
> Opensource Obscure
> --
> http://twitter.com/oobscure - http://opensourceobscure.com/lol
> Discuss Viewer 2 in-world (if chat works): http://j.mp/slv2group
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Boroondas Gupte 


> On April 25, 2011, 10:27 a.m., Vadim ProductEngine wrote:
> > Looks good, thanks.
> > 
> > One note that applies to my patch as well: rfind() seems to fit better than 
> > find() in this case.

Using string::rfind instead of string::find would avoid problems if someone 
checks out the source to a path already containing "/build-darwin-" or 
"/build-linux-", I guess?


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/277/#review647
---


On April 25, 2011, 5:09 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/277/
> ---
> 
> (Updated April 25, 2011, 5:09 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review 
> request's diff) and applied analogous changes to lldir_mac.cpp, in hope that 
> this would fix the same issue on Mac, too:
> * renamed indra_pos to build_dir_pose (just for consistency. This should not 
> have any effect.)
> * search for "/build-darwin-" rather than "/indra" within mExecutableDir (The 
> new build dir prefix is taken from .hgignore, in the hope that is up to date.)
> 
> 
> This addresses bug STORM-1182.
> http://jira.secondlife.com/browse/STORM-1182
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 9c0506d10226 
>   indra/llvfs/lldir_linux.cpp 9c0506d10226 
>   indra/llvfs/lldir_mac.cpp 9c0506d10226 
> 
> Diff: http://codereview.secondlife.com/r/277/diff
> 
> 
> Testing
> ---
> 
> None, as I don't have a mac.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Vadim ProductEngine 


> On April 25, 2011, 10:27 a.m., Vadim ProductEngine wrote:
> > Looks good, thanks.
> > 
> > One note that applies to my patch as well: rfind() seems to fit better than 
> > find() in this case.
> 
> Boroondas Gupte wrote:
> Using string::rfind instead of string::find would avoid problems if 
> someone checks out the source to a path already containing "/build-darwin-" 
> or "/build-linux-", I guess?

Yep, that's what I meant.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/277/#review647
---


On April 25, 2011, 5:09 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/277/
> ---
> 
> (Updated April 25, 2011, 5:09 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review 
> request's diff) and applied analogous changes to lldir_mac.cpp, in hope that 
> this would fix the same issue on Mac, too:
> * renamed indra_pos to build_dir_pose (just for consistency. This should not 
> have any effect.)
> * search for "/build-darwin-" rather than "/indra" within mExecutableDir (The 
> new build dir prefix is taken from .hgignore, in the hope that is up to date.)
> 
> 
> This addresses bug STORM-1182.
> http://jira.secondlife.com/browse/STORM-1182
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 9c0506d10226 
>   indra/llvfs/lldir_linux.cpp 9c0506d10226 
>   indra/llvfs/lldir_mac.cpp 9c0506d10226 
> 
> Diff: http://codereview.secondlife.com/r/277/diff
> 
> 
> Testing
> ---
> 
> None, as I don't have a mac.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/277/
---

(Updated April 25, 2011, 4:40 p.m.)


Review request for Viewer.


Changes
---

Use string::rfind instead of string::find, so last occurrence of build dir 
prefix will be matched.


Summary
---

Just looked at Vadim's fix for Linux in lldir_linux.cpp (also in this review 
request's diff) and applied analogous changes to lldir_mac.cpp, in hope that 
this would fix the same issue on Mac, too:
* renamed indra_pos to build_dir_pose (just for consistency. This should not 
have any effect.)
* search for "/build-darwin-" rather than "/indra" within mExecutableDir (The 
new build dir prefix is taken from .hgignore, in the hope that is up to date.)


This addresses bug STORM-1182.
http://jira.secondlife.com/browse/STORM-1182


Diffs (updated)
-

  doc/contributions.txt 9c0506d10226 
  indra/llvfs/lldir_linux.cpp 9c0506d10226 
  indra/llvfs/lldir_mac.cpp 9c0506d10226 

Diff: http://codereview.secondlife.com/r/277/diff


Testing
---

None, as I don't have a mac.


Thanks,

Boroondas

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges