Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

[Boroondas Gupte]

> On April 1, 2011, 4:22 a.m., Boroondas Gupte wrote:
> > indra/newview/llgesturemgr.h, lines 168-170
> > 
> >
> > Shouldn't this be a (non-static) method of LLMulitGesture taking no 
> > argument, rather than a static member of LLGestureMgr taking a pointer to a 
> > gesture?
> > 
> > Also, the gesture should not be changed by that, should it? If 
> > possible, make the argument type pointer-to-const (or, if you make it a 
> > method of LLMultiGesture as suggested, make it a const method).
> 
> Seth ProductEngine wrote:
> It could be a non-static method of LLMulitGesture if a gesture would be 
> an observer of its own pending assets, or if a gesture would check pending 
> assets from the list stored at LLGestureMgr. In this case the LLMulitGesture 
> class becomes more complicated without any gain in performance because this 
> is the same check that LLGestureMgr::hasLoadingAssets() does.

OK. Could you still consider to pass a pointer-to-const?


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/#review531
---


On March 31, 2011, 10:18 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/231/
> ---
> 
> (Updated March 31, 2011, 10:18 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Added syncing animations and sounds before the gesture starts playing.
> The actual playing of animations and sounds of a gesture starts only when all 
> needed animations and sound files are loaded into viewer cache. This reduces 
> the delay between animations and sounds meant to be played simultaneously but 
> may increase the delay between the moment a gesture is triggered and the 
> moment it starts playing.
> 
> Fixed calling assets callback to clean up the void pointer in getAssetData() 
> and avoid potential memory leaks.
> 
> 
> This addresses bug STORM-380.
> http://jira.secondlife.com/browse/STORM-380
> 
> 
> Diffs
> -
> 
>   indra/llmessage/llassetstorage.cpp d30636c2a83a 
>   indra/newview/llgesturemgr.h d30636c2a83a 
>   indra/newview/llgesturemgr.cpp d30636c2a83a 
> 
> Diff: http://codereview.secondlife.com/r/231/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] New Build Result Pages

[Opensource Obscure]

> On Wed, Apr 20, 2011 at 8:09 AM, CG Linden  wrote:
>> Ideas/suggestions/bug reports welcome.

It seems to be hard to read for some people / in some settings.
Please - a bit more contrast between text and background.

Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] New Build Result Pages

[Ardy Lay]

New Build Result Pages are not "running" for me, in IE8, on Windows 7.
They do "run" in the web browser built in to Viewer 2.
I also find the current trend to reduce contrast in all things "web" 
annoying and wish 80/20 to fall off the face of the Earth for 
propagating the trend.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Higher contrast for build result pages. (was: New Build Result Pages)

[Boroondas Gupte]

On 04/22/2011 11:28 AM, Opensource Obscure wrote:
> Please - a bit more contrast between text and background.
On 04/22/2011 01:58 PM, Ardy Lay wrote:
> I also find the current trend to reduce contrast in all things "web" 
> annoying

Please find attached a user style  (can be used
with Firefox' or Chrome's Stylish
 add-on
)
which should improve contrast and give the "OK" fields some padding.
Feel free to tweak it further.

@CG: Are you interested in a diff that incorporates these changes (or
just some of them) into your stylesheet
?

Cheers,
Boroondas
/*
  Higher contrast and some minor layout fixes for Second Life Viewer build result pages

  (K) 2011 Boroondas Gupte
  All rites reversed -- re-use what you like

  Roughly based on and meant for use in combination with http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/cg_viewer-development/rev/227100/index.css?v=2 [hereafter "index.css"].
*/

@namespace url(http://www.w3.org/1999/xhtml);

@-moz-document domain("automated-builds-secondlife-com.s3.amazonaws.com") {

  /* Elements with light teal (#becec9) background */
  #container ul#content li{
/* #444 might look good on white, but on #becec9 it's a bit low contrast */
color: #222 !important;
  }

  /* Contrast between link texts and background is more important than contrast between hovered and not hovered links */
  a, a:active, a:visited {
color: #30557B !important;
  }

  /* The above overrides a:hover, so restore it. (Same as in index.css) */
  a:hover { color: #036 !important; }

  /* These seem to be broken in index.css  */
  span.good_build, span.bad_build{
padding: 2px !important; /* I guess index.css is missing a semicolon for this, causing some syntax error. */
-moz-border-radius: 4px !important;/* index.css only rounds the lower corners. I don't */
-webkit-border-radius: 4px !important; /* know why, I think it looks good to round all four. */
  }
}

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1093 "Dock" icon is still shown after a side panel has been docked with Ctrl+Shift+W

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/276/
---

Review request for Viewer and Richard Nelson.


Summary
---

Reason:
When an undocked side tray tab floater got closed with Ctrl+Shift+W,
LLSideTray::setTabDocked() was called. It docked the floater but didn't update
the dock/undock icon.

Fix:
Made setTabDocked() a general purpose method, not a hack suitable for using
only as a floater close callback in the basic viewer mode.
It now updates the dock/undock icon.

Other changes:
* Replaced numerous calls to toggleTabDocked with setDocked(),
  that is safer because does exactly what you want.
* Got rid of a duplicated floater close callback.


This addresses bug STORM-1093.
http://jira.secondlife.com/browse/STORM-1093


Diffs
-

  indra/newview/llfloatersidetraytab.cpp UNKNOWN 
  indra/newview/llsidetray.h UNKNOWN 
  indra/newview/llsidetray.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/276/diff


Testing
---

Testing (un)docking side tray tabs in Basic and Advanced viewer modes.


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] New Build Result Pages

[CG Linden]

The ie8 issue is interesting... see
http://forum.jquery.com/topic/unexpected-call-to-method-or-property-access-in-ie8

I'll have a fix out shortly. I'll simply leave the title element alone and
instead make the heading in the body contain that info.

I'll also make the font darker. I think that should help the readability.
--
cg

On Fri, Apr 22, 2011 at 4:58 AM, Ardy Lay  wrote:

> New Build Result Pages are not "running" for me, in IE8, on Windows 7.
> They do "run" in the web browser built in to Viewer 2.
> I also find the current trend to reduce contrast in all things "web"
> annoying and wish 80/20 to fall off the face of the Earth for
> propagating the trend.
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] New Build Result Pages

[Ardy Lay]

On 4/22/2011 11:51 AM, CG Linden wrote:
> The ie8 issue is interesting... see 
> http://forum.jquery.com/topic/unexpected-call-to-method-or-property-access-in-ie8
>
> I'll have a fix out shortly. I'll simply leave the title element alone 
> and instead make the heading in the body contain that info.
>
> I'll also make the font darker. I think that should help the readability.
I will appreciate the contrast increase.  IE 8 seems to have a few other 
little oddities and MS is pushing IE 9 at me now.  Maybe check it with IE 9?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] PO Review

[Oz Linden (Scott Lawrence)]

http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/227402/index.html

STORM-320 
   Script Editor in Viewer 2.0+ "tabs" incorrectly 
STORM-595 

   Viewer should stop spamming AgentThrottle messages as the slider is
   dragged 
STORM-640 
   URL-name of object is shown as a hyperlink in the Buy Contents floater 
STORM-891 

   [HARDCODED] - ALL LANGS - Message showing up after setting your home
   is in English (French viewer) 
STORM-898 
   Filter settings do not reset after unchecking 'Since Logoff' checkbox 
STORM-918 

   Changes in Group Role Titles or Assignments Not Reflected in Title
   Dropdown 
STORM-941 
   IM log naming should go by SL name, not DN. 
STORM-1028 
   Speak button label not displaying at default window size 
STORM-1039 
   Bad iterator access in llavatarnamecache.cpp:564 
STORM- 

   Blocks of chat log are being read in from then rewritten with new
   timestamps. 
STORM-1182 
   [Linux] XUI Preview Tool fails to load XMLs from indra/newview/skins 



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Higher contrast for build result pages. (was: New Build Result Pages)

[CG Linden]

Thanks, I'll incorporate it.
--
cg

On Fri, Apr 22, 2011 at 6:53 AM, Boroondas Gupte  wrote:

>  On 04/22/2011 11:28 AM, Opensource Obscure wrote:
>
> Please - a bit more contrast between text and background.
>
>  On 04/22/2011 01:58 PM, Ardy Lay wrote:
>
> I also find the current trend to reduce contrast in all things "web"
> annoying
>
>
> Please find attached a user style  (can be used
> with Firefox' or Chrome's 
> Stylish
> add-on)
> which should improve contrast and give the "OK" fields some padding. Feel
> free to tweak it further.
>
> @CG: Are you interested in a diff that incorporates these changes (or just
> some of them) into your 
> stylesheet
> ?
>
> Cheers,
> Boroondas
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Higher contrast for build result pages. (was: New Build Result Pages)

[CG Linden]

Try this on for size:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/viewer-pre-release/rev/227447/index.html

On Fri, Apr 22, 2011 at 11:14 AM, CG Linden  wrote:

> Thanks, I'll incorporate it.
> --
> cg
>
> On Fri, Apr 22, 2011 at 6:53 AM, Boroondas Gupte <
> slli...@boroon.dasgupta.ch> wrote:
>
>>  On 04/22/2011 11:28 AM, Opensource Obscure wrote:
>>
>> Please - a bit more contrast between text and background.
>>
>>  On 04/22/2011 01:58 PM, Ardy Lay wrote:
>>
>> I also find the current trend to reduce contrast in all things "web"
>> annoying
>>
>>
>> Please find attached a user style  (can be used
>> with Firefox' or Chrome's 
>> Stylish
>> add-on)
>> which should improve contrast and give the "OK" fields some padding. Feel
>> free to tweak it further.
>>
>> @CG: Are you interested in a diff that incorporates these changes (or just
>> some of them) into your 
>> stylesheet
>> ?
>>
>> Cheers,
>> Boroondas
>>
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Build 227442 - Freeze On Exit

[Trilo Byte]

I'm experiencing a system freeze of 3-5 seconds in build 227442, Mac client.  
Mouse cursor can move, but all other application windows frozen and 
unresponsive between the time I click to confirm Quit and application has fully 
shut down.  Anyone else experiencing this, on Mac or elsewhere?

TriloByte Zanzibar
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges