[opensource-dev] OPEN-50 (aka STORM-1149) merged - configuration name changes

[Oz Linden (Scott Lawrence)]

I've merged the changes to support open source configurations building 
with the VS Express edition.  Many people have been using these for 
quite some time, so I don't expect any big surprises (famous last words).

Note:  This changes the configuration names from OpenSource 
to OS for ={Debug,RelWithDebInfo,Release}.

I did not take in the last change that Ima posted, which made open 
source builds disable the tests by default.   If you want to turn them 
off, you can, but it should not be the default.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] OPEN-50 (aka STORM-1149) merged - configuration name changes

[Mike Chase]

On Wed, 2011-04-20 at 07:03 -0400, Oz Linden (Scott Lawrence) wrote: 
> I've merged the changes to support open source configurations building 
> with the VS Express edition.  Many people have been using these for 
> quite some time, so I don't expect any big surprises (famous last words).
> 
> Note:  This changes the configuration names from OpenSource 
> to OS for ={Debug,RelWithDebInfo,Release}.

So just to clarify, we should use the new config names across all
platforms or just for VS Express?  If I build on Linux ReleaseOS should
work?

Mike

> I did not take in the last change that Ima posted, which made open 
> source builds disable the tests by default.   If you want to turn them 
> off, you can, but it should not be the default.
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] OPEN-50 (aka STORM-1149) merged - configuration name changes

[Oz Linden (Scott Lawrence)]

On 2011-04-20 9:40, Mike Chase wrote:
> On Wed, 2011-04-20 at 07:03 -0400, Oz Linden (Scott Lawrence) wrote:
>> I've merged the changes to support open source configurations building
>> with the VS Express edition.  Many people have been using these for
>> quite some time, so I don't expect any big surprises (famous last words).
>>
>> Note:  This changes the configuration names from OpenSource
>> toOS for={Debug,RelWithDebInfo,Release}.
> So just to clarify, we should use the new config names across all
> platforms or just for VS Express?  If I build on Linux ReleaseOS should
> work?

Yes, it should and I'm sure we'll hear about it if it doesn't :-)

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Windows compiling problem

[Celierra Darling]

Okay, my problem was that I'd forgotten to uninstall the December 2006
version of the DirectX SDK prior to installing the June 2010 one, and the
2006 version ended up leaving behind many vestigial traces.  Had to
reinstall the 2006 version, then uninstall it.  (I also had to manually tell
the installer to uninstall, i.e. msiexec /X
%temp%/Microsoft_DirectX_SDK.msi, but I'm not sure if that's normal.)

Celi


On Tue, Apr 12, 2011 at 5:59 PM, Celierra Darling wrote:

> I'm getting the same problem (either with 7.1 or 7.0a in the message,
> depending on which order of includes I'm trying at the moment).  I've tried
> fiddling with include paths, updating DirectX and UNSIS, building without
> the 7.1 SDK update so far, without success.  But I can't find where to
> download the 7.0a version of the SDK, only 7.0 and 7.1. :(  I did notice
> that VS 2010 installed a 32-bit-host version of the 7.0a SDK instead of the
> 64-bit-host versions that the SDK installers picked for me, though I don't
> know if that's causing this particular problem.
>
> I haven't tried building from command consoles yet, just the GUI IDE.
>
> From
> http://social.msdn.microsoft.com/Forums/en/Vsexpressinstall/thread/9ec96544-0b7d-4b0b-8eca-dffb30a385be#d79e6ab7-6976-430b-98c7-976f035263fdthere's
>  some instructions regarding a Platform Toolset setting that's
> supposed to be for an entire solution. I don't see that, but I do see one
> such setting on each individual project, and it's set to "v100" (7.0a, I
> would guess?) instead of "Windows7.1SDK".  That seems a bit suspicious; I
> presume we want it to be using 7.1 if it's installed?
>
> Celi
>
>
> On Fri, Apr 8, 2011 at 2:34 PM, Jonathan Welch  wrote:
>
>> I've tried all the suggestions that people have suggested, but to no
>> avail.  I still get messages like the one below.
>>
>> Anyone with more ideas?
>>
>> -- Build started: Project: llwindow, Configuration: Release Win32
>> --
>>  llwindowwin32.cpp
>>  lldxhardware.cpp
>> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11280): error C2061:
>> syntax error : identifier '__RPC__out_xcount_part'
>> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): error C2059:
>> syntax error : ')'
>> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): fatal error
>> C1903: unable to recover from previous error(s); stopping compilation
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting
>> privileges
>>
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] New Build Result Pages

[CG Linden]

I've been working on redoing the build results.

Check out a sample at:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/cg_viewer-development/rev/227100/index.html

They are completely self-contained. The data is actually stored in a JSON
file at:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/cg_viewer-development/rev/227100/index.json

Note that the "changes since last good build" will include changes made to
third party libs and other dependencies, including autobuild and our build
system.

Some links are not public (e.g. links to our internal hg repos).

Note that Jira ids may not match the comments whenever the jira issue was
moved.

The HTML page is just a skeleton, and javascript will read the JSON file and
render it on the result page.

Ideas/suggestions/bug reports welcome.
--
cg
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Vadim ProductEngine]

> On April 19, 2011, 8:02 a.m., Vadim ProductEngine wrote:
> > Could you please provide the patch description? I.e what the problem was 
> > and how you fixed it.
> 
> Ima Mechanique wrote:
> I'm not sure what you want here.
> If you're asking what I did? I updated Kitty's two line patch to apply 
> against the current code, then tested that it fixed the problem.
> If you're asking what Kitty's thinking was behind the solution? I can't 
> answer that.

Each commit (and the corresponding review request) should have a meaningful 
description, so that developers can [later] find out what the purpose of the 
code change was.
In this case it should have been something like "Fixed passing notification 
functor".


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review631
---


On April 19, 2011, 7:57 a.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> ---
> 
> (Updated April 19, 2011, 7:57 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Applying Kitty Barnett's patch against current code base.
> 
> 
> This addresses bug STORM-1175.
> http://jira.secondlife.com/browse/STORM-1175
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 584211e99147 
>   indra/llui/llnotifications.cpp 584211e99147 
> 
> Diff: http://codereview.secondlife.com/r/271/diff
> 
> 
> Testing
> ---
> 
> Release build. tested preferences both in world and on the log in screen.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review637
---



indra/llui/llnotifications.cpp


LLNotificationsUtil is a wrapper around LLNotifications. Calling a wrapper 
from the class it wraps doesn't look very nice to me.

So I'd change this line to do the following:

add(name.asString(), LLSD(), LLSD());

and remove the include.

Both approaches trigger a run-time warning though. I'll address that in a 
separate review request (coming soon).


- Vadim


On April 19, 2011, 7:57 a.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> ---
> 
> (Updated April 19, 2011, 7:57 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Applying Kitty Barnett's patch against current code base.
> 
> 
> This addresses bug STORM-1175.
> http://jira.secondlife.com/browse/STORM-1175
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 584211e99147 
>   indra/llui/llnotifications.cpp 584211e99147 
> 
> Diff: http://codereview.secondlife.com/r/271/diff
> 
> 
> Testing
> ---
> 
> Release build. tested preferences both in world and on the log in screen.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] OPEN-50 (aka STORM-1149) merged - configuration name changes

[Mike Chase]

On Wed, 2011-04-20 at 10:52 -0400, Oz Linden (Scott Lawrence) wrote: 
> On 2011-04-20 9:40, Mike Chase wrote:
> > On Wed, 2011-04-20 at 07:03 -0400, Oz Linden (Scott Lawrence) wrote:
> >> I've merged the changes to support open source configurations building
> >> with the VS Express edition.  Many people have been using these for
> >> quite some time, so I don't expect any big surprises (famous last words).
> >>
> >> Note:  This changes the configuration names from OpenSource
> >> toOS for={Debug,RelWithDebInfo,Release}.
> > So just to clarify, we should use the new config names across all
> > platforms or just for VS Express?  If I build on Linux ReleaseOS should
> > work?
> 
> Yes, it should and I'm sure we'll hear about it if it doesn't :-)
> 

I got a clean build on fedora 14 x86_64.  I haven't done any serious use
but the tests all passed.   One issue, autobuild didn't automatically
kick off the make. I had to chdir into the build directory and start it
manually but the build worked fine from there.

Mike

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] New Build Result Pages

[Oz Linden (Scott Lawrence)]

On 2011-04-20 11:09, CG Linden wrote:
> I've been working on redoing the build results.
>
> Check out a sample at:
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/cg_viewer-development/rev/227100/index.html

That's really nice, CG!
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] New Build Result Pages

[Ricky]

Only spent a few minutes browsing the source code (good work in there,
I love to see HTML5 in use!) but I'd suggest that you make .body_arch
clickable to expand sections as well as .head_arch - that way we don't
have to click so small a target to get the results we want.  While, of
course, keeping the links embedded in them sanely clickable... :P

Good job!

On Wed, Apr 20, 2011 at 8:09 AM, CG Linden  wrote:
> I've been working on redoing the build results.
>
> Check out a sample at:
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/cg_viewer-development/rev/227100/index.html
>
> They are completely self-contained. The data is actually stored in a JSON
> file at:
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/cg_viewer-development/rev/227100/index.json
>
> Note that the "changes since last good build" will include changes made to
> third party libs and other dependencies, including autobuild and our build
> system.
>
> Some links are not public (e.g. links to our internal hg repos).
>
> Note that Jira ids may not match the comments whenever the jira issue was
> moved.
>
> The HTML page is just a skeleton, and javascript will read the JSON file and
> render it on the result page.
>
> Ideas/suggestions/bug reports welcome.
> --
> cg
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Windows compiling problem

[Jonathan Welch]

One thing I discovered is that entries in your local
Microsoft.Cpp.Win32.user.props file superseed what you may have set in
an environment variable. In my case I was changing INCLUDE but only
was able to compile once I had modified the user.props file so it
could pick up winres.h under a Samples directory.

-Jonathan
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-956 Ability to mute dialogs by muting object (or object owner)

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/275/
---

Review request for Viewer.


Summary
---

>From the jira Description:
Griefers are still able to spam you with dialogs, such as dialogs, web site 
popups, and avatar animation requests even after you mute the owner of the 
object. Muting does not stop these at all. This is an ideal path for griefers 
to attack and they have been doing so for as long as I've been on Second Life. 
I believe that muting the object or it's owner should stop dialogs of all types 
from appearing from the object.

Note:
The changes to message_template.msg are not mine; that file was pushed from the 
server source into viewer-development.  I have no control over what goes into 
that file or how it is formatted, etc.


This addresses bug Storm-956.
http://jira.secondlife.com/browse/Storm-956


Diffs
-

  doc/contributions.txt ec4ad7e3ecca 
  indra/newview/llviewermessage.cpp ec4ad7e3ecca 
  scripts/messages/message_template.msg ec4ad7e3ecca 

Diff: http://codereview.secondlife.com/r/275/diff


Testing
---

See lengthy Test Plan in the jira.


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1088: bundled winmm.dll shim crashes on start-up on some systems.

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/272/#review639
---

Ship it!


- Oz


On April 18, 2011, 6:04 a.m., Siana Gearz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/272/
> ---
> 
> (Updated April 18, 2011, 6:04 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> STORM-1088: bundled winmm.dll shim crashes on start-up on some systems.
> 
> This patch tests the theory that according to MSDN, calls to LoadLibrary, 
> GetProcAddress in DllMain are likely to create a race condition.
> 
> 
> This addresses bug storm-1088.
> http://jira.secondlife.com/browse/storm-1088
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt f632f87bb71b 
>   indra/media_plugins/winmmshim/forwarding_api.h f632f87bb71b 
>   indra/media_plugins/winmmshim/forwarding_api.cpp f632f87bb71b 
>   indra/media_plugins/winmmshim/winmm_shim.cpp f632f87bb71b 
> 
> Diff: http://codereview.secondlife.com/r/272/diff
> 
> 
> Testing
> ---
> 
> winmm.dll from Second Life 2.6.3 (226640) Apr 14 2011 12:32:01 (Second Life 
> Beta Viewer) causes this viewer, and a number of prior versions, to crash at 
> startup for me.
> winmm.dll built by me from viewer-development source code also does, tested 
> against the same viewer binary.
> 
> The version of winmm.dll with my patch, built by me and substituted into the 
> installed viewer, causes the above mentioned viewer to start up without issue 
> and function apparently properly - sound works (FMOD), media_plugin_webkit 
> works, voice is audible, windows_volume_catcher of llqtwebkit is functional.
> Same applies to Second Life 2.6.3 (226792) Apr 17 2011 07:01:06 (Second Life 
> Developer), built by Oz Linden with a prior version of my patch.
> 
> media_plugin_quicktime functionality untested, voice capture untested.
> 
> The patch contains debug output, which causes the following messages in 
> debugger:
> 
> INFO: LLAudioEngine::init: LLAudioEngine::init() AudioEngine successfully 
> initialized
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\winmm.dll', Cannot find 
> or open the PDB file
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\myokent.dll', Cannot 
> find or open the PDB file
> WINMM_SHIM.DLL: real winmm.dll initialized successfully
> WINMM_SHIM.DLL: real winmm.dll initialized successfully
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\wdmaud.drv', Cannot 
> find or open the PDB file
> 'SecondLifeBetaViewer.exe': Unloaded 'C:\WINXP\system32\wdmaud.drv'
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\wdmaud.drv', Cannot 
> find or open the PDB file
> 'SecondLifeBetaViewer.exe': Unloaded 'C:\WINXP\system32\wdmaud.drv'
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\wdmaud.drv', Cannot 
> find or open the PDB file
> 'SecondLifeBetaViewer.exe': Unloaded 'C:\WINXP\system32\wdmaud.drv'
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\wdmaud.drv', Cannot 
> find or open the PDB file
> 'SecondLifeBetaViewer.exe': Unloaded 'C:\WINXP\system32\wdmaud.drv'
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\wdmaud.drv', Cannot 
> find or open the PDB file
> 'SecondLifeBetaViewer.exe': Unloaded 'C:\WINXP\system32\wdmaud.drv'
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\wdmaud.drv', Cannot 
> find or open the PDB file
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\msacm32.drv', Cannot 
> find or open the PDB file
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\midimap.dll', Cannot 
> find or open the PDB file
> 'SecondLifeBetaViewer.exe': Loaded 'C:\WINXP\system32\ksuser.dll', Cannot 
> find or open the PDB file
> INFO: idle_startup: Audio Engine Initialized.
> 
> This is very puzzling to me, why the success message is being output twice. 
> Perhaps if the reason of that is found, the real reason for the failure of 
> failure of upstream winmm shim would become evident, or perhaps it's a bug in 
> my patch. I'd like everyone to check whether they see the same thing.
> 
> ...
> 
> After some testing, it turns out myokent.dll (MIDI Yoke, a software loop-back 
> cable for musicians) seems to be the culprit on my system, causing a trivial 
> circular dependency, not a race condition. It tries to use a number of 
> winmm.dll functions (first of them being GetDriverModuleHandle) right from 
> its DllMain, which is invoked by LoadLibrary. Now it turns out, that if we 
> try to load real winmm.dll from DllMain, which in turn loads myokent.dll from 
> its DllMain, which in turn from its DllMain uses winmm.dll's functions, 
> calling the ones in OUR winmm.dll, which simply aren't initialized at that 
> point yet because we need LoadLibrary (and DllMains of used DLLs) to

Re: [opensource-dev] Any possibility of playing animation b y uuid?

[Dave Booth]

On 4/17/2011 2:02 PM, Brian McGroarty wrote:
> On Sun, Apr 17, 2011 at 9:39 AM, Brandon Husbands  wrote:
>> We cal already play sounds, do textures why cant we play a animation by uuid
>> via lsl / viewer.
>
> Repeating what was done with textures and sounds is a non-starter;

agreed - thats a matter of basic protection for the hardworking 
animation creators.



> If reference by asset ID is important enough that you'd want to work
> on it, lay out a proposal detailing what permissions could be baked
> into an asset at upload time, and how the permissions could be honored
> by all viewers.



> Any proposal should maintain current restrictions against raw use of
> existing animation assets, which don't have extra permissions metadata
> attached.



Trying to think outside the box here, and not a fully thought out 
proposal, but are there possibilities for a lsl function something like 
llStartAnimByUUID(key agent, key animKey) that can only access an anim 
by uuid if the creator of the script and the anim are the same, and the 
script is nomod and one of nocopy or notransfer? If not the function 
call would just silently fail. I can see holes in that protection right 
off the bat, but most of them are avoidable by a creator taking care. 
Just a thought.

Dave.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges