Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Jonathan Yap]

> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, lines 99-101
> > 
> >
> > Why do you make this a functor rather than a plain normal function? 
> > It's not like we have to keep any internal state or something.
> 
> Jonathan Yap wrote:
> Moved to inside of routine.
> 
> Boroondas Gupte wrote:
> That's a good idea, too, but not what I meant. I was wondering why you 
> are using a class (or struct) with an operator() instead of just a function. 
> std::sort can take either a functor (i.e. a callable object like you're using 
> here) or a function pointer.
> 
> Jonathan Yap wrote:
> Nothing else in this class would make use of this  function so it seemed 
> to make sense to go the struct route (plus when I was trying to figure out 
> how to code this initially the example I found elsewhere in the code was done 
> this way).
> 
> Boroondas Gupte wrote:
> Ah, right. I forgot local function aren't allowed in C++. Otherwise one 
> could have done something like
>   inline bool sortRegionNames(std::pair & _left, 
> std::pair & _right)
>   {
>   
> return(LLStringUtil::compareInsensitive(_left.second->getName(),_right.second->getName())
>  < 0);
>   }
> 
>   std::vector > 
> sim_info_vec(LLWorldMap::getInstance()->getRegionMap().begin(), 
> LLWorldMap::getInstance()->getRegionMap().end());
>   std::sort(sim_info_vec.begin(), sim_info_vec.end(), &sortRegionNames);
> 
> So we probably have to either stick to your struct or make 
> sortRegionNames a method or free function.

After fixing the >> to > > issues are you able to compile if the struct I moved 
from the top of the code into this routine is moved back to the top again?  The 
other example I found had it that way, and now I am wondering if it was like 
that to allow linux to compile.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review595
---


On April 15, 2011, 11:33 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> ---
> 
> (Updated April 15, 2011, 11:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
> http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/
---

(Updated April 16, 2011, 6:24 a.m.)


Review request for Viewer.


Changes
---

To fix some issues with gcc made some formatting changes and moved the compare 
routine back to the top of the code.


Summary
---

The results of using the World Map search option are sorted.


This addresses bug Storm-1128.
http://jira.secondlife.com/browse/Storm-1128


Diffs (updated)
-

  doc/contributions.txt a8f868007986 
  indra/newview/llfloaterworldmap.cpp a8f868007986 

Diff: http://codereview.secondlife.com/r/262/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] GPU detection improvements

[Oz Linden (Scott Lawrence)]

https://jira.secondlife.com/browse/STORM-1100 tracks making a bunch of 
updates to the GPU recognition in the viewer.  Many thanks to the 
several people who have been checking and contributing updated entries.

A test viewer for this issue can be download from the wiki at
https://wiki.secondlife.com/wiki/Downloading_test_builds#Developer_Builds

If you have been having trouble with your GPU being recognized or you 
believe it has been incorrectly classified, then please download that 
viewer and report by adding a comment STORM-1100

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Boroondas Gupte]

> On April 13, 2011, 2:31 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, lines 99-101
> > 
> >
> > Why do you make this a functor rather than a plain normal function? 
> > It's not like we have to keep any internal state or something.
> 
> Jonathan Yap wrote:
> Moved to inside of routine.
> 
> Boroondas Gupte wrote:
> That's a good idea, too, but not what I meant. I was wondering why you 
> are using a class (or struct) with an operator() instead of just a function. 
> std::sort can take either a functor (i.e. a callable object like you're using 
> here) or a function pointer.
> 
> Jonathan Yap wrote:
> Nothing else in this class would make use of this  function so it seemed 
> to make sense to go the struct route (plus when I was trying to figure out 
> how to code this initially the example I found elsewhere in the code was done 
> this way).
> 
> Boroondas Gupte wrote:
> Ah, right. I forgot local function aren't allowed in C++. Otherwise one 
> could have done something like
>   inline bool sortRegionNames(std::pair & _left, 
> std::pair & _right)
>   {
>   
> return(LLStringUtil::compareInsensitive(_left.second->getName(),_right.second->getName())
>  < 0);
>   }
> 
>   std::vector > 
> sim_info_vec(LLWorldMap::getInstance()->getRegionMap().begin(), 
> LLWorldMap::getInstance()->getRegionMap().end());
>   std::sort(sim_info_vec.begin(), sim_info_vec.end(), &sortRegionNames);
> 
> So we probably have to either stick to your struct or make 
> sortRegionNames a method or free function.
> 
> Jonathan Yap wrote:
> After fixing the >> to > > issues are you able to compile if the struct I 
> moved from the top of the code into this routine is moved back to the top 
> again?  The other example I found had it that way, and now I am wondering if 
> it was like that to allow linux to compile.

With storm-1128c.diff (r3 of this review request) the viewer compiles fine, but 
only because it also changes the arguments of the comparison function to const 
references. (We discussed this on IRC.) See also 
http://stackoverflow.com/questions/4084035/stl-sort-issue-with-gcc

I still got some comments about the code, will post them in a review of the r3 
diff.


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review595
---


On April 16, 2011, 6:24 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> ---
> 
> (Updated April 16, 2011, 6:24 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
> http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Mesh support current status???

[Robert Martin]

Does anybody have a WORKING link to what the current state of mesh is?
Im particularly interested in what work has been done on Mesh based
avatars. Bonus if somebody has an idea as to if we will have mesh on
the main grid before say third quarter this year.

-- 
Robert L Martin
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review629
---



indra/newview/llfloaterworldmap.cpp


remove trailing whitespace



indra/newview/llfloaterworldmap.cpp


If this has to be outside of LLFloaterWorldMap::updateSims to make GCC 
happy, we could as well simplify it to ...

inline bool sort_region_names(std::pair  const& _left, 
std::pair  const& _right)
{
return 
(LLStringUtil::compareInsensitive(_left.second->getName(),_right.second->getName())
 < 0);
}

... and then call std::sort in LLFloaterWorldMap::updateSims with ...
std::sort(sim_info_vec.begin(), sim_info_vec.end(), &sort_region_names);

... i.e. have a function rather than a functor. I guess the only reason for 
wrapping the function into a struct would be to workaround the lack of 
method-local functions in C++. (Compare 
http://www.flipcode.com/archives/Local_Functions_In_C.shtml . Comments on 
http://stackoverflow.com/questions/2202731/is-there-support-in-c-stl-for-sorting-objects-by-attribute/2202846#2202846
 indicate that functors might sometimes/often perform better, but doesn't 
explain when or why.)

Jonathan Yap said on IRC he prefers the functor (i.e. the variant with the 
struct) for consistency reasons. (Apparently it's used elsewhere in the code in 
similar situations.)

If someone knows how to call std::sort so that the functor can be 
method-local, please speak up. (In that case I'd prefer that and thus keep the 
struct.) Lambda functions (e.g. from BOOST) would be another idea, but let's 
not go there unless someone comes up with ready-to-use code.



indra/newview/llfloaterworldmap.cpp


Consider replacing the type notation
const std::pair &
be the (equivalent!) notation
std::pair  const&
which, although less 'traditional', is IMO easier to understand. (See 
http://www.xs4all.nl/~carlo17/cpp/const.qualifier.html )



indra/newview/llfloaterworldmap.cpp


If we use std::sort, we really should directly #include  in this 
file, even if it already gets included indirectly (via other includes). The 
only exception I'd make would be if  was already (directly) included 
by the corresponding header file, indra/newview/llfloaterworldmap.h, but that 
isn't the case here.


- Boroondas


On April 16, 2011, 6:24 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> ---
> 
> (Updated April 16, 2011, 6:24 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
> http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Mesh support current status???

[Trilo Byte]

Mesh User Group (ideal place to ask such questions).  There's also an archive 
of past meeting agendas/notes.
http://wiki.secondlife.com/wiki/Content_Creation/Mesh_Import/Scripting_User_Group

Mesh Community Forums, should be a fair bit of information there about avatars 
and other forms of mesh object creation.
http://community.secondlife.com/t5/Mesh/bd-p/Mesh

I don't believe a firm date has been announced or even hinted at, but the Mesh 
team User Groups (on Mondays at 11am SLT) or a blog post is where that 
information is likely going to be communicated.

TriloByte Zanzibar

On Apr 16, 2011, at 12:29 PM, Robert Martin wrote:

> Does anybody have a WORKING link to what the current state of mesh is?
> Im particularly interested in what work has been done on Mesh based
> avatars. Bonus if somebody has an idea as to if we will have mesh on
> the main grid before say third quarter this year.
> 
> -- 
> Robert L Martin
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Mesh support current status???

[Opensource Obscure]

An excellent, unofficial place where to find information and updates
about Meshes and other technical SL development is
http://blog.nalates.net

On Sat, Apr 16, 2011 at 22:07, Trilo Byte  wrote:
> Mesh User Group (ideal place to ask such questions).  There's also an archive 
> of past meeting agendas/notes.
> http://wiki.secondlife.com/wiki/Content_Creation/Mesh_Import/Scripting_User_Group
>
> Mesh Community Forums, should be a fair bit of information there about 
> avatars and other forms of mesh object creation.
> http://community.secondlife.com/t5/Mesh/bd-p/Mesh
>
> I don't believe a firm date has been announced or even hinted at, but the 
> Mesh team User Groups (on Mondays at 11am SLT) or a blog post is where that 
> information is likely going to be communicated.
>
> TriloByte Zanzibar
>
> On Apr 16, 2011, at 12:29 PM, Robert Martin wrote:
>
>> Does anybody have a WORKING link to what the current state of mesh is?
>> Im particularly interested in what work has been done on Mesh based
>> avatars. Bonus if somebody has an idea as to if we will have mesh on
>> the main grid before say third quarter this year.
>>
>> --
>> Robert L Martin
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting 
>> privileges
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>



-- 
Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Jonathan Yap]

> On April 16, 2011, 12:37 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, line 92
> > 
> >
> > Consider replacing the type notation
> > const std::pair &
> > be the (equivalent!) notation
> > std::pair  const&
> > which, although less 'traditional', is IMO easier to understand. (See 
> > http://www.xs4all.nl/~carlo17/cpp/const.qualifier.html )

Changed.


> On April 16, 2011, 12:37 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, line 1500
> > 
> >
> > If we use std::sort, we really should directly #include  in 
> > this file, even if it already gets included indirectly (via other 
> > includes). The only exception I'd make would be if  was already 
> > (directly) included by the corresponding header file, 
> > indra/newview/llfloaterworldmap.h, but that isn't the case here.

Good observation.  Changed.


> On April 16, 2011, 12:37 p.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterworldmap.cpp, line 88
> > 
> >
> > remove trailing whitespace

Changed.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review629
---


On April 16, 2011, 6:24 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> ---
> 
> (Updated April 16, 2011, 6:24 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
> http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/
---

(Updated April 16, 2011, 1:52 p.m.)


Review request for Viewer.


Changes
---

New diff uploaded.  Made a few changes suggested in Boroondas' comments.


Summary
---

The results of using the World Map search option are sorted.


This addresses bug Storm-1128.
http://jira.secondlife.com/browse/Storm-1128


Diffs (updated)
-

  doc/contributions.txt a8f868007986 
  indra/newview/llfloaterworldmap.cpp a8f868007986 

Diff: http://codereview.secondlife.com/r/262/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Mesh support current status???

[Daniel]

The official answer continues to be mesh will go live "when it's 
ready".  As far as official links, there is latest mesh viewer
build at:   
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/mesh-development/latest.html
It can only be tested on mesh enabled regions of the beta grid (aditi), 
most of which are named Mesh Sandbox nn, where nn = 1 to about 36.  You 
can also look at the JIRA Mesh Beta project: 
https://jira.secondlife.com/browse/CTS for status.

 From personal experience importing models, the state is "basic mesh 
import works in most cases given a "clean" model to upload".  What is 
left to do is reduce the frequency of bad uploads, some of which is not 
LL's fault, it's due to bad source models.  Also things like the upload 
cost and prim equivalence need to be determined.  I have made a full 
body mesh avatar:
https://marketplace.secondlife.com/p/Experimental-Mesh-Avatar-Female-Boxed/2059187
 
with custom skin weights and UV maps.  Some of the joints could move 
better, but that's more due to my limited experience than anything 
else.  On the whole it moves and looks pretty well, showing that nice 
replacement avatars are quite possible in the hands of experienced creators.

I have no better idea than anyone else on when beta will be complete, 
but my best guess is a couple of months.  It's basically working right 
now, but I think they want the UI and costs done, and an acceptably low 
level of failures before going to Agni with it.  There are other nice 
features tied to the Mesh project besides mesh objects: shadows and 
projected lights, and 64 meter prims.  I think they very much want the 
package to get out, but not in a buggy form.  There are future 
improvements to mesh that are not part of the first release, too.  
Server side support for mesh has to be done also, but I have less 
visibility on that than the client software.

> From: Robert Martin
> Subject: [opensource-dev] Mesh support current status???
>
> Does anybody have a WORKING link to what the current state of mesh is?
> Im particularly interested in what work has been done on Mesh based
> avatars. Bonus if somebody has an idea as to if we will have mesh on
> the main grid before say third quarter this year.
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges