[opensource-dev] Latest Snowstorm build details seem broken

[Hitomi Tiponi]

I've been trying to click on my favourite'Details for these builds' link from 
the Snowstorm wiki page for the last twelve hours (well not every minute 
obviously, even I'm not that sad), but all I am getting now is '
Build Results Pending...
Architectures being built: CYGWIN Linux Darwin'

I presume this means that something is broken.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Latest Snowstorm build details seem broken

[Opensource Obscure]

On Wed, Apr 13, 2011 at 12:43, Hitomi Tiponi  wrote:
> I've been trying to click on my favourite 'Details for these builds' link
> from the Snowstorm wiki page for the last twelve hours (well not every
> minute obviously, even I'm not that sad), but all I am getting now is '
>
> Build Results Pending...

me too; I note that the other links work
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/arch/Linux/quicklink.html
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/snowstorm_viewer-development/arch/CYGWIN/quicklink.html


Opensource Obscure
--
http://twitter.com/oobscure - http://opensourceobscure.com/lol
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/
---

(Updated April 13, 2011, 6:40 a.m.)


Review request for Viewer.


Summary
---

 Chat preferences > font size should increase size of input text in the chat box


This addresses bug STORM-1095.
http://jira.secondlife.com/browse/STORM-1095


Diffs (updated)
-

  doc/contributions.txt a8f868007986 
  indra/llui/lllineeditor.h a8f868007986 
  indra/llui/lllineeditor.cpp a8f868007986 
  indra/newview/llbottomtray.cpp a8f868007986 
  indra/newview/llfloaterpreference.cpp a8f868007986 
  indra/newview/llnearbychatbar.h a8f868007986 
  indra/newview/llnearbychatbar.cpp a8f868007986 
  indra/newview/llviewerchat.h a8f868007986 
  indra/newview/llviewerchat.cpp a8f868007986 

Diff: http://codereview.secondlife.com/r/244/diff


Testing
---

Change font size in preferences and see
1) Font size in chat input box changes to new size immediately
2) Font size is set to selected size when viewer is restarted


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review589
---

Ship it!


Looks good.

Some minor stuff still:


indra/newview/llviewerchat.h


Why repeat the 'public:' ?



indra/newview/llviewerchat.h


Indented with 4 spaces instead of 1 tab like the other lines.



doc/contributions.txt






doc/contributions.txt


I guess the STORM-1077 and STORM-1019 entries were added in error? Or why 
are you replacing them, rather than just adding STORM-1095?


- Boroondas


On April 13, 2011, 6:40 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated April 13, 2011, 6:40 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Latest Snowstorm build details seem broken

[Oz Linden (Scott Lawrence)]

On 2011-04-13 6:43, Hitomi Tiponi wrote:
I've been trying to click on my favourite'Details for these builds 
' 
link from the Snowstorm wiki page for the last twelve hours (well not 
every minute obviously, even I'm not that sad), but all I am getting 
now is '


Build Results Pending...

Architectures being built: CYGWIN Linux Darwin'


I presume this means that something is broken.



We've been having some problems with some of the systems being added to 
the internal build farm, causing some builds to hang or fail.   When 
that happens, the final step that rewrites the details page never 
happens.  In the case above, the separate build that does the Windows 
Debug build had failed.



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/249/
---

(Updated April 13, 2011, 8:11 a.m.)


Review request for Viewer.


Changes
---

Removed asynchronous writes to temporary IM log file depending on name cache 
responses. Looks like there is no need for requesting names from cache or the 
name is already in cache in some cases, so no need for a callback.


Summary (updated)
---

Fixed IM history to use the resident's user name for the log file name.
Added conversions from legacy names or SLURLs with avatar id to the user names 
in cases of logging P2P sessions and inventory offers.
Removed asynchronous writes to temporary IM log file depending on name cache 
responses.


This addresses bug STORM-941.
http://jira.secondlife.com/browse/STORM-941


Diffs (updated)
-

  indra/newview/llgiveinventory.cpp 4b5d458c03e8 
  indra/newview/llimview.h 4b5d458c03e8 
  indra/newview/llimview.cpp 4b5d458c03e8 
  indra/newview/llnotificationhandlerutil.cpp 4b5d458c03e8 
  indra/newview/llviewermessage.cpp 4b5d458c03e8 

Diff: http://codereview.secondlife.com/r/249/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

> On April 13, 2011, 7:19 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerchat.h, lines 37-39
> > 
> >
> > Why repeat the 'public:' ?

Vadim's RB comments and other LL code implied this was the way to go.  I've 
just eliminated the extra public: line as it's only for one item.


> On April 13, 2011, 7:19 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerchat.h, line 38
> > 
> >
> > Indented with 4 spaces instead of 1 tab like the other lines.

Fixed.


> On April 13, 2011, 7:19 a.m., Boroondas Gupte wrote:
> > doc/contributions.txt, line 646
> > 
> >
> > I guess the STORM-1077 and STORM-1019 entries were added in error? Or 
> > why are you replacing them, rather than just adding STORM-1095?

I am not the best Merge Monkey and must have made an error when merging these 
changesets into viewer-development when the MM sent this back.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review589
---


On April 13, 2011, 6:40 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated April 13, 2011, 6:40 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review591
---


Thanks, Jonathan. No major issues this time.

I've got a few comments though, in addition to what Boroondas said:


indra/newview/llbottomtray.cpp


Any reason not to move this to LLNearbyChatBar::postBuild() ?



indra/newview/llnearbychatbar.h


again the redundant change



indra/newview/llnearbychatbar.cpp


RB seems to be set up to ignore whitespace changes and thus doesn't show 
this... but you've removed the leading tab here.

Please avoid irrelevant changes.



indra/newview/llviewerchat.h


Replace the redundant "public:" marker with an empty line.



indra/newview/llviewerchat.h


CS: remove spaces near parenthesis.



indra/newview/llviewerchat.cpp


CS: extra spaces near parenthesis


- Vadim


On April 13, 2011, 6:40 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated April 13, 2011, 6:40 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/249/#review593
---

Ship it!


Looks plausible.

- Vadim


On April 13, 2011, 8:11 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/249/
> ---
> 
> (Updated April 13, 2011, 8:11 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed IM history to use the resident's user name for the log file name.
> Added conversions from legacy names or SLURLs with avatar id to the user 
> names in cases of logging P2P sessions and inventory offers.
> Removed asynchronous writes to temporary IM log file depending on name cache 
> responses.
> 
> 
> This addresses bug STORM-941.
> http://jira.secondlife.com/browse/STORM-941
> 
> 
> Diffs
> -
> 
>   indra/newview/llgiveinventory.cpp 4b5d458c03e8 
>   indra/newview/llimview.h 4b5d458c03e8 
>   indra/newview/llimview.cpp 4b5d458c03e8 
>   indra/newview/llnotificationhandlerutil.cpp 4b5d458c03e8 
>   indra/newview/llviewermessage.cpp 4b5d458c03e8 
> 
> Diff: http://codereview.secondlife.com/r/249/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] PO Review Build

[Oz Linden (Scott Lawrence)]

   
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/226501/index.html


STORM-413  The presentation 
of IM sessions in message well depends on method that was used for 
opening IM window
STORM-721  Information 
about resident is displayed incorrectly in mini-inspector if there are 
any resident or group SLURLs
STORM-842  "Start at" list 
isn't populated with favorites if user name is typed in fashion 
"firstname.lastname"
STORM-1028  Speak button 
label not displaying at default window size
STORM-1042  Disabled 
'Save' button at the 'Create Landmark' panel
STORM-1083  Using -login 
client parameter always results in a last location unavailable error 
message
STORM-1136  LLDateUtil 
class defines March having 21 days, causing wrong avatar age calculation 
(Patch with bugfix attached)
STORM-1139  "Apply Changes 
to Region" works for water but not for sky
STORM-1145  Changes to 
Favorites are not reflected on the login locations menu


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/
---

Review request for Viewer.


Summary
---

The results of using the World Map search option are sorted.


This addresses bug Storm-1128.
http://jira.secondlife.com/browse/Storm-1128


Diffs
-

  doc/contributions.txt a8f868007986 
  indra/newview/llfloaterworldmap.cpp a8f868007986 

Diff: http://codereview.secondlife.com/r/262/diff


Testing
---


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/
---

(Updated April 13, 2011, 12:32 p.m.)


Review request for Viewer.


Changes
---

Apply some formatting changes suggested in the RB comments.


Summary
---

 Chat preferences > font size should increase size of input text in the chat box


This addresses bug STORM-1095.
http://jira.secondlife.com/browse/STORM-1095


Diffs (updated)
-

  doc/contributions.txt a8f868007986 
  indra/llui/lllineeditor.h a8f868007986 
  indra/llui/lllineeditor.cpp a8f868007986 
  indra/newview/llbottomtray.cpp a8f868007986 
  indra/newview/llfloaterpreference.cpp a8f868007986 
  indra/newview/llnearbychatbar.h a8f868007986 
  indra/newview/llnearbychatbar.cpp a8f868007986 
  indra/newview/llviewerchat.h a8f868007986 
  indra/newview/llviewerchat.cpp a8f868007986 

Diff: http://codereview.secondlife.com/r/244/diff


Testing
---

Change font size in preferences and see
1) Font size in chat input box changes to new size immediately
2) Font size is set to selected size when viewer is restarted


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote:
> > indra/newview/llbottomtray.cpp, lines 560-561
> > 
> >
> > Any reason not to move this to LLNearbyChatBar::postBuild() ?

Yes, there is a reason, though not necessarily a good one -- the same change 
was made for Storm-1094 which would probably have the merge monkey send it back 
for me to re-merge.  Since I cannot compile with autobuild I  would not be able 
to test this change and thus it would languish for a month+ until I have time 
to work on getting my autobuild issue resolved.


> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote:
> > indra/newview/llnearbychatbar.h, line 39
> > 
> >
> > again the redundant change

I don't know why hg diff is picking up this blank line.


> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote:
> > indra/newview/llnearbychatbar.cpp, line 444
> > 
> >
> > RB seems to be set up to ignore whitespace changes and thus doesn't 
> > show this... but you've removed the leading tab here.
> > 
> > Please avoid irrelevant changes.

Fixed.  Thanks for catching this.


> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote:
> > indra/newview/llviewerchat.h, line 39
> > 
> >
> > Replace the redundant "public:" marker with an empty line.

Also fixed, though in other LL code, where there are larger blocks to organize, 
multiple public: lines are found. 


> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote:
> > indra/newview/llviewerchat.h, line 47
> > 
> >
> > CS: remove spaces near parenthesis.

Done.


> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote:
> > indra/newview/llviewerchat.cpp, line 261
> > 
> >
> > CS: extra spaces near parenthesis

Done.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review591
---


On April 13, 2011, 12:32 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated April 13, 2011, 12:32 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review596
---

Ship it!



doc/contributions.txt


fix this before committing



doc/contributions.txt


ditto



indra/newview/llviewerchat.cpp


ditto


- Vadim


On April 13, 2011, 12:32 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated April 13, 2011, 12:32 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Vadim ProductEngine]

> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote:
> > indra/newview/llbottomtray.cpp, lines 560-561
> > 
> >
> > Any reason not to move this to LLNearbyChatBar::postBuild() ?
> 
> Jonathan Yap wrote:
> Yes, there is a reason, though not necessarily a good one -- the same 
> change was made for Storm-1094 which would probably have the merge monkey 
> send it back for me to re-merge.  Since I cannot compile with autobuild I  
> would not be able to test this change and thus it would languish for a month+ 
> until I have time to work on getting my autobuild issue resolved.

I could do the merge for you.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review591
---


On April 13, 2011, 12:32 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated April 13, 2011, 12:32 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

> On April 13, 2011, 1:13 p.m., Vadim ProductEngine wrote:
> > doc/contributions.txt, line 416
> > 
> >
> > fix this before committing

Fixed


> On April 13, 2011, 1:13 p.m., Vadim ProductEngine wrote:
> > doc/contributions.txt, line 646
> > 
> >
> > ditto

Fixed


> On April 13, 2011, 1:13 p.m., Vadim ProductEngine wrote:
> > indra/newview/llviewerchat.cpp, line 38
> > 
> >
> > ditto

Fixed.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review596
---


On April 13, 2011, 12:32 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated April 13, 2011, 12:32 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

[Jonathan Yap]

> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote:
> > indra/newview/llbottomtray.cpp, lines 560-561
> > 
> >
> > Any reason not to move this to LLNearbyChatBar::postBuild() ?
> 
> Jonathan Yap wrote:
> Yes, there is a reason, though not necessarily a good one -- the same 
> change was made for Storm-1094 which would probably have the merge monkey 
> send it back for me to re-merge.  Since I cannot compile with autobuild I  
> would not be able to test this change and thus it would languish for a month+ 
> until I have time to work on getting my autobuild issue resolved.
> 
> Vadim ProductEngine wrote:
> I could do the merge for you.

The bitbucket repo for this is current -- if you want to make this change and 
test it that would be wonderful.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/244/#review591
---


On April 13, 2011, 12:32 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/244/
> ---
> 
> (Updated April 13, 2011, 12:32 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
>  Chat preferences > font size should increase size of input text in the chat 
> box
> 
> 
> This addresses bug STORM-1095.
> http://jira.secondlife.com/browse/STORM-1095
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/llui/lllineeditor.h a8f868007986 
>   indra/llui/lllineeditor.cpp a8f868007986 
>   indra/newview/llbottomtray.cpp a8f868007986 
>   indra/newview/llfloaterpreference.cpp a8f868007986 
>   indra/newview/llnearbychatbar.h a8f868007986 
>   indra/newview/llnearbychatbar.cpp a8f868007986 
>   indra/newview/llviewerchat.h a8f868007986 
>   indra/newview/llviewerchat.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/244/diff
> 
> 
> Testing
> ---
> 
> Change font size in preferences and see
> 1) Font size in chat input box changes to new size immediately
> 2) Font size is set to selected size when viewer is restarted
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review598
---

Ship it!


No major objections.


indra/newview/llfloaterworldmap.cpp


CS: sim_info_vec



indra/newview/llfloaterworldmap.cpp


I'd move the iterator declaration inside the "for" clause to limit its 
scope.


- Vadim


On April 13, 2011, 12:16 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> ---
> 
> (Updated April 13, 2011, 12:16 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
> http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/262/#review595
---



indra/newview/llfloaterworldmap.cpp


Why do you make this a functor rather than a plain normal function? It's 
not like we have to keep any internal state or something.



indra/newview/llfloaterworldmap.cpp


Wow, long line. Might want to put the arguments on separate lines.


- Boroondas


On April 13, 2011, 12:16 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/262/
> ---
> 
> (Updated April 13, 2011, 12:16 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The results of using the World Map search option are sorted.
> 
> 
> This addresses bug Storm-1128.
> http://jira.secondlife.com/browse/Storm-1128
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a8f868007986 
>   indra/newview/llfloaterworldmap.cpp a8f868007986 
> 
> Diff: http://codereview.secondlife.com/r/262/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] PO Review Build

[Trilo Byte]

I was able to check a few of these, Mac client.

> STORM-842 "Start at" list isn't populated with favorites if user name is 
> typed in fashion "firstname.lastname" 
OK

> STORM-1139 "Apply Changes to Region" works for water but not for sky 
Untestable with this viewer (it doesn't have estate-level windlight support)

> STORM-1145 Changes to Favorites are not reflected on the login locations menu 
OK___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges