Re: [opensource-dev] 3p-quicktime license and use

[Oz Linden (Scott Lawrence)]

On 2011-04-11 22:40, Nicky Perian wrote:


Quicktime SDK is an INSTALL_PROPRIETARY=TRUE archive download. The LL 
archive is modified to work with VS2010. The Apple Quicktime SDK has 
not been modified and fails compile.




Can you expand on that last statement?


I cloned 3p-quicktime and with autobuild build and package have the 
libraries. The procedure worked extremely well.




Yay!


Then, I modified autobuild.xml to point to the local copy. Now the 
catch, since QuickTimePlugin.cmake has:


if (INSTALL_PROPRIETARY)

include(Prebuilt)

use_prebuilt_binary(quicktime)

endif(INSTALL_PROPRIETARY)


What autobuild setup or command line switch do I use to access the 
local copy?


I commented out the if(INSTALL_PROPRIETARY) and then it pulled from 
the local copy with autobuild.xml set to the location and md5sum 
printed as output of autobuild package command.


What are the planned methods to use local copies of what at one time 
were proprietary or license restricted packages and now can be cloned 
and built on a local computer and used?


Also, does INSTALL_PROPRIETARY make sense when the end result is the 
library is on the local computer and can be used?




This is a good general issue.

My feeling is that we should add a switch for each of these optional 
packages.  The per-package switch (in this case, perhaps 
INSTALL_PKG_QUICKTIME) would replace INSTALL_PROPRIETARY everywhere it 
is used to make a package-specific decision now, and in one of the 
common cmake files we add a block that provides default values for all 
the INSTALL_PKG_* switches based on INSTALL_PROPRIETARY.


We don't need to do this for every package - it's not worth the trouble 
to do it for things that everyone has access to, but having a pattern to 
use for the ones that have some distribution limitations seems useful.


Sound workable?

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] 3p-quicktime license and use

[Nicky Perian]

From: Oz Linden (Scott Lawrence) 
To: Nicky Perian 
Cc: opensource-dev@lists.secondlife.com
Sent: Tue, April 12, 2011 6:11:59 AM
Subject: Re: 3p-quicktime license and use

 On 2011-04-11 22:40, Nicky Perian wrote: 
Quicktime SDK is an INSTALL_PROPRIETARY=TRUE archive download. The 
LL archive is modified to work with VS2010. The Apple 
Quicktime SDK has not been modified and fails compile.
>>Can you expand on that last statement?

https://bitbucket.org/lindenlab/3p-quicktime/changeset/5bd12aeb9f53
Fixes compile errors in LL copy of Quicktime. Not in the Apple download 
version. 
Problem source is VS2010 delivers stdint.h which clashes with the one from 
Quicktime.



I cloned 3p-quicktime and with autobuild build and package have the 
libraries. The procedure worked extremely well. 

Yay!



Then, I modified autobuild.xml to point to the local 
copy. Now the catch, since QuickTimePlugin.cmake has:
>if (INSTALL_PROPRIETARY)
>include(Prebuilt)
>use_prebuilt_binary(quicktime)
>endif(INSTALL_PROPRIETARY) 
>
>
>What autobuild setup or command line switch do I use 
>to 
>access the local copy?
I commented out the if(INSTALL_PROPRIETARY) and then it pulled from 
the local copy with autobuild.xml set to the location 
and md5sum printed as output of autobuild package 
command.
>What are the planned methods to use local copies of 
>what 
>at one time were proprietary or license restricted packages and 
>now 
>can be cloned and built on a local computer and used?
>Also, does INSTALL_PROPRIETARY make sense when the end 
>result is the library is on the local computer and can 
>be used?
This is a good general issue.

My feeling is that we should add a switch for each of these optional 
packages.  The per-package switch (in this case, perhaps 
INSTALL_PKG_QUICKTIME) would replace INSTALL_PROPRIETARY everywhere it is 
used to make a package-specific decision now, and in one of the common 
cmake 
files we add a block that provides default values for all the INSTALL_PKG_* 
switches based on INSTALL_PROPRIETARY.

We don't need to do this for every package - it's not worth the trouble to 
do it for things that everyone has access to, but having a pattern to use 
for the ones that have some distribution limitations seems useful.

>>Sound workable?

Yes.___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Windows compiling problem

[Jenn Leech]

On my development machine I uninstalled the Windows SDK entirely, relying on
the one that ships with VS2010, to resolve a similar conflict. If a similar
tactic works for you, let us know!

Thx,
- Jenn

On Fri, Apr 8, 2011 at 11:34 AM, Jonathan Welch  wrote:

> I've tried all the suggestions that people have suggested, but to no
> avail.  I still get messages like the one below.
>
> Anyone with more ideas?
>
> -- Build started: Project: llwindow, Configuration: Release Win32
> --
>  llwindowwin32.cpp
>  lldxhardware.cpp
> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11280): error C2061:
> syntax error : identifier '__RPC__out_xcount_part'
> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): error C2059:
> syntax error : ')'
> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): fatal error
> C1903: unable to recover from previous error(s); stopping compilation
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header

[Vadim ProductEngine]

> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote:
> > indra/llimage/llimagedimensionsinfo.cpp, line 97
> > 
> >
> > Magic number. (I guess it's BMP header (14) + DIB header - current 
> > position (File begin + 2)?)
> 
> Vadim ProductEngine wrote:
> Yep, pretty obvious. If I start documenting every line, code will 
> eventually look even worse than without comments.
> 
> Boroondas Gupte wrote:
> Is it? Took me some while to figure this out, and even then I wasn't 
> sure. An alternative to comments: Instead of a constant for DATA_LEN, have 
> constants for its components, and re-use those constants here.

Ok, if it's not clear I'll add a comment.


> On April 8, 2011, 4:51 p.m., Boroondas Gupte wrote:
> > indra/llimage/llimagedimensionsinfo.cpp, lines 217-219
> > 
> >
> > Wouldn't a seek be a "cheaper" way to determine size than reading into 
> > an actual buffer? (According to indra/llcommon/llapr.h, it returns -1 on 
> > failure.)
> > 
> > There's also a static method LLAPRFile::size, but that seems to operate 
> > on not-yet-opened files given by filename.
> 
> Vadim ProductEngine wrote:
> seek() may go beyond the file end, so we can't use it to check whether 
> the file contains the needed header.
> Well, we could seek to the end of file, but accessing the whole file just 
> to find out that it's of wrong type looks like overkill.
> I agree that reading into a dynamically allocated buffer doesn't look 
> nice, but I think we can live with it as long as we only read small chunks 
> this way.
> 
> Boroondas Gupte wrote:
> There's no pointer equivalent of /dev/null that could be used here 
> instead of an actual buffer, is there?

No. Well, there is NULL, but you'll get a crash if you use it as a buffer 
address. :-)


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/255/#review580
---


On April 7, 2011, 4:20 p.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/255/
> ---
> 
> (Updated April 7, 2011, 4:20 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> * Added checks for image file contents not matching the file extension (e.g. 
> a bitmap named file.jpg).
> * Added checks for abnormally short files to avoid crashes when parsing them.
> 
> 
> This addresses bug STORM-1118.
> http://jira.secondlife.com/browse/STORM-1118
> 
> 
> Diffs
> -
> 
>   indra/llimage/llimagedimensionsinfo.h 33ca961b0870 
>   indra/llimage/llimagedimensionsinfo.cpp 33ca961b0870 
> 
> Diff: http://codereview.secondlife.com/r/255/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] C++ Need help to resolve stdint.h typedef conflicts between Quicktime and VS2010

[Kiptic ‌]

  Ohh! I never got your idea working 
and I had my little fix anyway so I stuck to that, but it's nice to know at 
least it wasn't some mess I did that prevented it from working :)

Thanks for letting me know!

/Kip



  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Windows compiling problem

[Celierra Darling]

I'm getting the same problem (either with 7.1 or 7.0a in the message,
depending on which order of includes I'm trying at the moment).  I've tried
fiddling with include paths, updating DirectX and UNSIS, building without
the 7.1 SDK update so far, without success.  But I can't find where to
download the 7.0a version of the SDK, only 7.0 and 7.1. :(  I did notice
that VS 2010 installed a 32-bit-host version of the 7.0a SDK instead of the
64-bit-host versions that the SDK installers picked for me, though I don't
know if that's causing this particular problem.

I haven't tried building from command consoles yet, just the GUI IDE.

From
http://social.msdn.microsoft.com/Forums/en/Vsexpressinstall/thread/9ec96544-0b7d-4b0b-8eca-dffb30a385be#d79e6ab7-6976-430b-98c7-976f035263fdthere's
some instructions regarding a Platform Toolset setting that's
supposed to be for an entire solution. I don't see that, but I do see one
such setting on each individual project, and it's set to "v100" (7.0a, I
would guess?) instead of "Windows7.1SDK".  That seems a bit suspicious; I
presume we want it to be using 7.1 if it's installed?

Celi

On Fri, Apr 8, 2011 at 2:34 PM, Jonathan Welch  wrote:

> I've tried all the suggestions that people have suggested, but to no
> avail.  I still get messages like the one below.
>
> Anyone with more ideas?
>
> -- Build started: Project: llwindow, Configuration: Release Win32
> --
>  llwindowwin32.cpp
>  lldxhardware.cpp
> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11280): error C2061:
> syntax error : identifier '__RPC__out_xcount_part'
> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): error C2059:
> syntax error : ')'
> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): fatal error
> C1903: unable to recover from previous error(s); stopping compilation
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Windows compiling problem

[Joshua Bell]

I was running into that exact objidl.h issue until I updated my DirectX SDK.
I had a 2008 SDK, I needed to uninstall and reinstall the June 2010 SDK
linked from
http://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds

(IMHO it
was probably less about the SDK version than the install order.)

On Tue, Apr 12, 2011 at 11:10 AM, Jenn Leech  wrote:

> On my development machine I uninstalled the Windows SDK entirely, relying
> on the one that ships with VS2010, to resolve a similar conflict. If a
> similar tactic works for you, let us know!
>
> Thx,
> - Jenn
>
> On Fri, Apr 8, 2011 at 11:34 AM, Jonathan Welch  wrote:
>
>> I've tried all the suggestions that people have suggested, but to no
>> avail.  I still get messages like the one below.
>>
>> Anyone with more ideas?
>>
>> -- Build started: Project: llwindow, Configuration: Release Win32
>> --
>>  llwindowwin32.cpp
>>  lldxhardware.cpp
>> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11280): error C2061:
>> syntax error : identifier '__RPC__out_xcount_part'
>> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): error C2059:
>> syntax error : ')'
>> e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): fatal error
>> C1903: unable to recover from previous error(s); stopping compilation
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting
>> privileges
>>
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Windows compiling problem

[Nicky Perian]

Dont' want to come across as self-promoting and am hesitant to advise LL devs 
but, this might help out. 


https://wiki.secondlife.com/wiki/User:Nicky_Perian/Visual_Studio_10_Autobuild




From: Joshua Bell 
To: Jenn Leech 
Cc: opensource-dev@lists.secondlife.com
Sent: Tue, April 12, 2011 5:07:35 PM
Subject: Re: [opensource-dev] Windows compiling problem

I was running into that exact objidl.h issue until I updated my DirectX SDK. I 
had a 2008 SDK, I needed to uninstall and reinstall the June 2010 SDK linked 
from http://wiki.secondlife.com/wiki/Viewer_2_Microsoft_Windows_Builds

(IMHO it was probably less about the SDK version than the install order.)


On Tue, Apr 12, 2011 at 11:10 AM, Jenn Leech  wrote:

On my development machine I uninstalled the Windows SDK entirely, relying on 
the 
one that ships with VS2010, to resolve a similar conflict. If a similar tactic 
works for you, let us know!
>
>
>Thx,
>- Jenn
>
>On Fri, Apr 8, 2011 at 11:34 AM, Jonathan Welch  wrote:
>
>I've tried all the suggestions that people have suggested, but to no
>>avail.  I still get messages like the one below.
>>
>>Anyone with more ideas?
>>
>>
>>-- Build started: Project: llwindow, Configuration: Release Win32 --
>> llwindowwin32.cpp
>> lldxhardware.cpp
>>e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11280): error C2061:
>>syntax error : identifier '__RPC__out_xcount_part'
>>e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): error C2059:
>>syntax error : ')'
>>e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): fatal error
>>C1903: unable to recover from previous error(s); stopping compilation
>>
>>___
>>Policies and (un)subscribe information available here:
>>http://wiki.secondlife.com/wiki/OpenSource-Dev
>>Please read the policies before posting to keep unmoderated posting privileges
>>
>
>___
>Policies and (un)subscribe information available here:
>http://wiki.secondlife.com/wiki/OpenSource-Dev
>Please read the policies before posting to keep unmoderated posting privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Windows compiling problem

[Monty Brandenberg]

On 4/12/2011 6:53 PM, Nicky Perian wrote:
> Dont' want to come across as self-promoting and am hesitant to advise LL
> devs

Don't be shy  how are we ever going to learn?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges