[opensource-dev] Daily Scrum Summary - IMPORTANT - Thursday, may 31st.

2011-04-01 Thread Anya Kanevsky 
Sprint 13, ends 04.11.11 Thursday, March 31 General Notes
--

   - NOTE: New meeting time starting 4/1. 9:30am PST. See you there!
   - please remember to move issues to current sprint from bug-queue when
   you're working on them!
   - MMOTD: Oz

Team Status
--
 Merov Linden
--

*PAST*

   - STORM-1121 : llimage_libtest on Linux : Simplified dependencies solved
   the problem. Moved to review swim lane.
   - STORM-746 : Use KDU precincts : Looked into the Kakadu doc (found
   interesting info in there). Thought about a test plan that makes sense.
   Starting conversation with some folks internally about perf.

*FUTURE*

   - STORM-746 : Use KDU precincts : Experiment with various precincts
   scheme (using llimage_libtest)
   - STORM-954 : People above 1000m : clean up and resubmit
   - STORM-1087 : viewer-autobuild2010 : Get ready for the big merge
   - STORM-1051 : merge request (testing hooks added) : merge test with
   autobuild

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Many merges (mostly in autobuild branch)
  - buid problems on TeamCity
   - Updating several wiki pages
   - PO review build
   - meetings

*FUTURE*

   - More merging
   - Beta release meeting

*IMPEDIMENTS*

   - none

Grumpity ProductEngine
--

*PAST*

   - VWR triage and related process changes
   - STORM-1033 went to Rand to fix, no help link exists
   - STORM-1031 Ben meant hint, clarified comment

*FUTURE*

   - STORM-1065 still waiting for Stone
   - STORM-721 fix - Richard?
   - STORM-1071 - server side fix?
   - test PO build

*IMPEDIMENTS*

   - time


Paul ProductEngine
--

*PAST*

   - STORY STORM-1110 (Remove old 1.23 purple text from alerts, anywhere
   else it appears)
  - Fixed and sent for review
   - BUG STORM-1109 (Check box resizes incorrectly if applying word wrap to
   its label.)
  - WIP. Investigating reshaping code. Estimate: at least one more
  working day.

*FUTURE*

   - BUG STORM-1109 (Check box resizes incorrectly if applying word wrap to
   its label.)

*IMPEDIMENTS*

   - STORM-399 (Users that has chatted within chat range of the user
   in-world are not added to Recent tab)
  - Needs to be re-integrated.

Seth ProductEngine
--

*PAST*

   - BUG (STORM-380) There is a little delay in sound when gesture first
   time played
  - Fixed, published the patch at the review board.
   - BUG (STORM-941) IM log naming should go by SL name, not DN.
  - Started investigating.

*FUTURE*

   - BUG (STORM-941) IM log naming should go by SL name, not DN.

*IMPEDIMENTS*

   - BUG (STORM-721) Information about resident is displayed incorrectly in
   mini-inspector if there are any resident or group SLURLs
  - Waiting for more info on the fix Richard has proposed.
   - BUG (STORM-1071) Switching language in preferences creates new calling
   cards folders for each language
  - Looks like it needs a server side fix.

Vadim ProductEngine
--

*PAST*

   - Story STORM-1126 (Windlight Region Settings):
  - Completed port to 2.x codebase, made things more or less stable and
  published the code on an internal repo.

*FUTURE*

   - Bug STORM-1028 (Speak button label not displaying at default window
   size):
  - Proceed with my refactoring needed to properly fix the issue.

*IMPEDIMENTS*

   - Should STORM-1025 (Chat preferences > font size should affect Chat and
   IM text input boxes) be closed as a dupe of STORM-1094 and/or STORM-1095?

Andrey ProductEngine
--

*PAST*

   - proceeded with v-d regression testing
   - External Script Editor 100%
   - Web Profile 100%
   - Alerts & Notifications (in progress)
   - SLApps - 100%
   - Sharing inventory items - 100%
   - Nearby Chat - 100%
   - Instant Messaging - 100%
   - Navigation(in progress) - 100%
   - Bottom bar - 100%
   - Web Profiles(Regression Test Cases) - 100%
   - Voice (in progress)

*FUTURE*

   - continue with v-d regression testing

*IMPEDIMENTS*

   - none


Wolfpup Lowenhar
--

*PAST*

   - Working inworld(this is part of testing localy built viewers).
   - STORM-941 : Wait for contact from PE.
   - STORM-1087 : Searched for way to move the temp files that msbuild uses.
   - OPEN-50 : Talked in IRC to Oz about including this when autobuild is
   merged to viewer development.
   - Attended OH

*FUTURE*

   - RL work.
   - Working inworld(this is part of testing localy built viewers).
   - STORM-941 : Wait for contact from PE.
   - STORM-1087 : more searching to find a way to move where msbuild places
   temp files.

*IMPEDIMENTS*

   - getting VS2010 autobuild environment to work on my system better,
   VS2005 autobuild works just fine.
   - May need to upgrade personal system(CPU, System Board, and Memory) to
   work better wit

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-04-01 Thread Lance Corrimal 


> On March 17, 2011, 11:46 a.m., Jonathan Yap wrote:
> > The code that creates a ring @ 100 meters has been removed and I changed 
> > the mystery constant 20.0 to CHAT_NORMAL_RADIUS.  Struggling with the diff 
> > hence that part is not updated.
> 
> Lance Corrimal wrote:
> I found both rings quite useful.
> oh and btw I think the rings shouldn't be blue. At least not for me to 
> find them useful... for sailing.
>

here's a little snapshot taken with a slightly modified version of this patch 
in my "work in progress" version of the dolphin viewer.
observe the minimap.

http://www.flickr.com/photos/lance_corrimal/5540695054/


- Lance


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/197/#review480
---


On March 12, 2011, 8 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/197/
> ---
> 
> (Updated March 12, 2011, 8 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add optional range ring to the mini-map -- one centered on you with a radius 
> of 20m to show local chat range.
> 
> By default the range ring is off.
> 
> To turn it on you right click on the mini-map and pick the menu entry "Range 
> Ring".
> 
> 
> This addresses bug Storm-1068.
> http://jira.secondlife.com/browse/Storm-1068
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt aed94e854443 
>   indra/newview/app_settings/settings.xml aed94e854443 
>   indra/newview/llnetmap.h aed94e854443 
>   indra/newview/llnetmap.cpp aed94e854443 
>   indra/newview/skins/default/colors.xml aed94e854443 
>   indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 
> 
> Diff: http://codereview.secondlife.com/r/197/diff
> 
> 
> Testing
> ---
> 
> Tested with another avatar.  When they are outside the ring they cannot see 
> my local chat and when they are inside it they can, so the ring's radius is 
> set correctly.
> 
> Flew over various types of land to make sure my color choice (blue @10%) was 
> always visible.
> 
> Enabled range ring, logged out and back on; range ring is still present on 
> mini-map.
> 
> Panned mini-map, range ring remains centered over avatar.
> 
> Used mouse wheel to zoom in and out as far as possible.  Size of range ring 
> varied with change in zoom level.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1044 Improved message template checking.

2011-04-01 Thread Oz Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/174/#review532
---

Ship it!


- Oz


On March 3, 2011, 2:20 p.m., Kelly Washington wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/174/
> ---
> 
> (Updated March 3, 2011, 2:20 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Improved message template checking.
> * If no changes have been made to the message template the check is local 
> only and trivial.
> * If changes have been made to the message template then compatibility is 
> verified on the first build after the change instead of when they package.
> * Automated systems can use --force to force full message template 
> verification
> 
> 
> This addresses bug STORM-1044.
> http://jira.secondlife.com/browse/STORM-1044
> 
> 
> Diffs
> -
> 
>   indra/cmake/TemplateCheck.cmake 3683d7c533f9 
>   indra/newview/CMakeLists.txt 3683d7c533f9 
>   scripts/messages/message_template.msg.sha1 PRE-CREATION 
>   scripts/template_verifier.py 3683d7c533f9 
> 
> Diff: http://codereview.secondlife.com/r/174/diff
> 
> 
> Testing
> ---
> 
> * Built the viewer and verified only the hash is checked.
> * Changed the template and verified full verification happens and a new sha1 
> saved.
> 
> 
> Thanks,
> 
> Kelly
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

2011-04-01 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/#review531
---


I'm a bit worried about the loop-nesting. E.g.


indra/newview/llgesturemgr.cpp


in update, stepGesture is called in a loop



indra/newview/llgesturemgr.cpp


stepGesture calls hasLoadingAssets



indra/newview/llgesturemgr.cpp


hasLoadingAssets calls set::find in a loop (which is logarithmic in the 
set's size)

so we have N * M * log(L) behavior for update(). This might not be too bad, 
as the number of queued gestures N, the number of steps per gesture M and the 
number of loading assets L are probably all small most of the time, and the 
inner loop is exited via return once the first match has been found. But I 
still wonder whether it might pay off to e.g. make the gestures observers of 
their pending assets.





indra/newview/llgesturemgr.h


Shouldn't this be a (non-static) method of LLMulitGesture taking no 
argument, rather than a static member of LLGestureMgr taking a pointer to a 
gesture?

Also, the gesture should not be changed by that, should it? If possible, 
make the argument type pointer-to-const (or, if you make it a method of 
LLMultiGesture as suggested, make it a const method).


- Boroondas


On March 31, 2011, 10:18 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/231/
> ---
> 
> (Updated March 31, 2011, 10:18 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Added syncing animations and sounds before the gesture starts playing.
> The actual playing of animations and sounds of a gesture starts only when all 
> needed animations and sound files are loaded into viewer cache. This reduces 
> the delay between animations and sounds meant to be played simultaneously but 
> may increase the delay between the moment a gesture is triggered and the 
> moment it starts playing.
> 
> Fixed calling assets callback to clean up the void pointer in getAssetData() 
> and avoid potential memory leaks.
> 
> 
> This addresses bug STORM-380.
> http://jira.secondlife.com/browse/STORM-380
> 
> 
> Diffs
> -
> 
>   indra/llmessage/llassetstorage.cpp d30636c2a83a 
>   indra/newview/llgesturemgr.h d30636c2a83a 
>   indra/newview/llgesturemgr.cpp d30636c2a83a 
> 
> Diff: http://codereview.secondlife.com/r/231/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Press release that affects us all!

2011-04-01 Thread Erin Mallory 

Im pretty sure that's an april fools joke...  

> Date: Thu, 31 Mar 2011 23:13:45 -0700
> From: a...@skyhighway.com
> To: xot...@gmail.com
> CC: opensource-dev@lists.secondlife.com
> Subject: [opensource-dev]  Press release that affects us all!
> 
> Like, i thought we'd know if LL was being bought or for sale or anything,
> but still - Not Funny.  i mean, maybe i just don't have a sense of humor
> or something.  But y'know, Not Funny.
> 
> - AK
> -
> DCS has just finished Acquiring Linden labs.
> The Linden Lab staff will be laid off and replaced with my own Staff from
> Xotmid Solutions.
> 
> We will also be making some major changes to Second Life to improve the
> MMORPG aspects of it.
> 
> For more information please visit http://dcsengine.com
> 
> -- 
> ---
> This email is a private and confidential communication. Any use of email
> may be subject to the laws and regulations of the United States. You may
> not Repost, Distribute nor reproduce any content of this message.
> ---
> ---
> 
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] PO build review, oz_viewer-poreview/rev/225458

2011-04-01 Thread Daniel Warren 
PO build testing..

Here are the issues addressed in that build:

STORM-399  Users that has
chatted within chat range of the user in-world are not added to Recent tab

*Chatting objects in local and IM do not show up in recent tab.
A friend chatting locally does.. an IM to another does, I did not try an IM 
un-primed or unbidden by me.

STORM-1072  [TRANSLATED
BUT IN EN] in "Monde" > "Profil du lieu" > "? propos des terrains" >
"R?glement" : "Estate / Full Region" is in english.

*c'est francaise

STORM-1094  Chat
preferences > font size should increase size of input text in IM window
STORM-1095  Chat
preferences > font size should increase size of input text in the chat box

*small, medium, and large text size reflected in group and local chat windows, 
and group and local chat text input boxes..

STORM-1108  Enable Hints
menu entry/preference is confusing

*I don't see the explicit decision, probably in the code.. I do not see hints, 
an "enable hints" option in the help menu is checked and I can't find one in 
the preferences menu.

VWR-25269  [#STORM-1106]
"Set scripts to running" on an object containing no scripts produces a
"unknown notification" error

*This is fixed. the gist of the message is "I can't run non-existent scripts.. 
choose an object that has some script.."


  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Snowstorm PO review build

2011-04-01 Thread Ima Mechanique 
> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/225458/index.html
> 
> Here are the issues addressed in that build:
> 
> STORM-399  Users that has 
> chatted within chat range of the user in-world are not added to Recent tab

not tested

> STORM-1072  [TRANSLATED 
> BUT IN EN] in "Monde" > "Profil du lieu" > "propos des terrains" > 
> "Rlement" : "Estate / Full Region" is in english.

Not tested.

> STORM-1094  Chat 
> preferences > font size should increase size of input text in IM window

Works beautifully.

> STORM-1095  Chat 
> preferences > font size should increase size of input text in the chat box

Works beautifully now.

> STORM-1108  Enable Hints 
> menu entry/preference is confusing

Still there on Help \o/ and removed from Preferences => General. \o/

> VWR-25269  [#STORM-1106] 
> "Set scripts to running" on an object containing no scripts produces a 
> "unknown notification" error

Now produces a dialogue with "Not able to set any scripts to 'running'.
Select objects with scripts"


--
Ima Mechanique
ima.mechanique(at)blueyonder.co.uk

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Way off topic, ...

2011-04-01 Thread Ponzu 
I just read a science fiction novel called

http://en.wikipedia.org/wiki/Halting_State

I enjoyed it a lot.  it makes several references to Second Life in a sort of
historical sense.  Much of the story concerns what the future of MMORPGs
might look like.  There is also a lot about how it might work on a
world-wide network of small computers (that is, it runs on our phones 8-)

Recommended, and not an April 1 joke.

lee
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] autobuild & VS 2010 support merged to viewer-development

2011-04-01 Thread Oz Linden (Scott Lawrence) 
The autobuild and Visual Studio 2010 branch has been merged to 
viewer-development

develop.py is dead, long live autobuild

We did not get the OPEN-50 changes in before this merge, but it will be 
very high priority for early next week.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Snowstorm PO review build

2011-04-01 Thread Jonathan Welch 
A note on Storm-1108, the Hints item:
Wolf wants the menu entry kept, so only where it was in Preferences
has been removed.

-Jonathan
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-20801 Implement SOCKS 5 Proxy for the viewer

2011-04-01 Thread Monty Brandenberg 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/232/#review537
---


Final pass through the code for review (I'll do this again after changes in the 
code).

Two followups that must happen from SNOWSTORM:

  1.  Some panel/GUI changes that probably need review.
  2.  Password storage in the panel almost certainly needs to be moved to the 
LLSecAPI lump (or wherever 'Remember password' gets stuffed).



indra/newview/llfloaterpreference.h


Wonder if the new GUI layout should have a review



indra/newview/llfloaterpreference.cpp


General whitespace comment applies.  I *think* we're still doing tabs, yes?



indra/newview/llfloaterpreference.cpp


We test mSocksSettingsDirty twice in this
method unnecessarily (any differently).

'untill' -> 'until'

Re:  comment.  What are we telling the user here?  It looks like we might 
not even save the settings.  Explain.



indra/newview/llfloaterpreference.cpp


I have a suspicion here that we are saving
the socks5 password to the generic settings
mechanism.  I don't think we can do that and
we must use the LLSecAPI junk.



indra/newview/llstartup.cpp


It looks like this was disabled when it needed to be moved to some location 
after the proxy setup.  Is that correct?  I didn't
see the new location in the code review tool...



indra/newview/llstartup.cpp


handleSocksProxy() seems to be setting up both standard HTTP proxies and 
Socks5 proxies.  But this code is only allowing that for Socks5 proxies.

Bad in itself but is caused by logic being replicated in several levels.  
This often indicates a design problem.




indra/newview/llstartup.cpp


There's a minor consistency problem in the
settings checking here.  If BrowserProxyEnabled and Socks5ProxyEnabled both 
are set true (accidentally, file corruption, logic error, whatever), one piece 
of code will treat this as having the BrowserProxyEnabled, another piece will 
treat it as Socks5ProxyEnabled.  When I do these things, I like to sample the 
settings values once, normalize them to valid states and then code to those 
normalized values.




indra/newview/llstartup.cpp


Only variant in all these case statements is the first argument of the 
call.  Might just set that in a stack variable and use it in one place after 
the switch.

It is soo close to being stringizable.




indra/newview/llxmlrpctransaction.cpp


It's kind of clear that the 'LLSocks' class is really misnamed.  It 
encompasses standard HTTP proxying as well as Socks5 proxying and if other 
styles come along, those as well.  A class-and-file rename looks to be in order 
here.




indra/newview/llxmlrpctransaction.cpp


This piece of logic inside the isHttpProxyEnabled() test is beginning to 
look like a common idiom.  Is it something that might be extracted into a free 
function in the LLSocks.cpp module to provide common glue between proxy 
configurations and libcurl option settings?



- Monty


On March 28, 2011, 4:46 a.m., Robin Cornelius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/232/
> ---
> 
> (Updated March 28, 2011, 4:46 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> VWR-20801 - Add ability to use SOCKS 5 proxy to the viewer. This allows the 
> UDP and/or the http requests to be sent via a SOCKS 5 proxy. This also allows 
> http proxies to be used for other http operations such as caps etc as 
> required. All the proxy settings have been unified on a single proxy floater 
> accessable from preferences. 
> 
> 
> This addresses bug VWR-20801.
> http://jira.secondlife.com/browse/VWR-20801
> 
> 
> Diffs
> -
> 
>   indra/llmessage/CMakeLists.txt 65ff7415f171 
>   indra/llmessage/llcurl.cpp 65ff7415f171 
>   indra/llmessage/llpacketring.h 65ff7415f171 
>   indra/llmessage/llpacketring.cpp 65ff7415f171 
>   indra/llmessage/llsocks5.h PRE-CREATION 
>   indra/llmessage/llsocks5.cpp PRE-CREATION 
>   indra/llmessage/net.h 65ff7415f171 
>   indra/llmessage/net.cpp 65ff7415f171 
>   indra/newview/app_settings/settings.xml 65ff7415f171 
>   ind

Re: [opensource-dev] autobuild & VS 2010 support merged to viewer-development

2011-04-01 Thread Oz Linden (Scott Lawrence) 
On 2011-04-01 18:08, Oz Linden (Scott Lawrence) wrote:
> The autobuild and Visual Studio 2010 branch has been merged to 
> viewer-development

This is a big change in the tools and many of the libraries that go into 
the viewer, so please download a Development viewer for your weekend fun 
and let us know how it works for you.



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges