[opensource-dev] Review Request: VWR-25261 URLs in Top Scripts is always 0.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/228/ --- Review request for Viewer. Summary --- Fix the top scripts floater to pull the number of URLs from the correct message block. This addresses bug vwr-25261. http://jira.secondlife.com/browse/vwr-25261 Diffs - indra/newview/llfloatertopobjects.cpp 6de4b45ab61f Diff: http://codereview.secondlife.com/r/228/diff Testing --- * Created an object with a script that requested 9 urls. * Viewed Region/Estate:Debug:Top Scripts * Verified the object showed on the list as using 9 urls. (sorted by the urls column.) Thanks, Kelly ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: VWR-25261 URLs in Top Scripts is always 0.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/228/#review492 --- Ship it! >From reading the code, nothing to add or subtract. - Merov On March 23, 2011, 9:44 a.m., Kelly Washington wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/228/ > --- > > (Updated March 23, 2011, 9:44 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Fix the top scripts floater to pull the number of URLs from the correct > message block. > > > This addresses bug vwr-25261. > http://jira.secondlife.com/browse/vwr-25261 > > > Diffs > - > > indra/newview/llfloatertopobjects.cpp 6de4b45ab61f > > Diff: http://codereview.secondlife.com/r/228/diff > > > Testing > --- > > * Created an object with a script that requested 9 urls. > * Viewed Region/Estate:Debug:Top Scripts > * Verified the object showed on the list as using 9 urls. (sorted by the urls > column.) > > > Thanks, > > Kelly > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/229/ --- Review request for Viewer. Summary --- 1) Change Voice Enabled to Speak Button when you right click on the bottom bar and get a menu. 2) Eliminate the separator bar in this menu. 3) Have a hint appear for the Speak button (see image in jira) the first time you use the viewer, have voice on (the default), and successfully connect to a voice server. This addresses bug STORM-1077. http://jira.secondlife.com/browse/STORM-1077 Diffs - doc/contributions.txt b761ed94eb26 indra/newview/app_settings/ignorable_dialogs.xml b761ed94eb26 indra/newview/llbottomtray.cpp b761ed94eb26 indra/newview/llfirstuse.h b761ed94eb26 indra/newview/llfirstuse.cpp b761ed94eb26 indra/newview/skins/default/xui/en/menu_bottomtray.xml b761ed94eb26 indra/newview/skins/default/xui/en/notifications.xml b761ed94eb26 Diff: http://codereview.secondlife.com/r/229/diff Testing --- Thanks, Jonathan ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
