Re: [opensource-dev] PO Review build
A number of people have written in saying they tested the latest PO build. I am curious about what you saw for storm-1077 -- the hint for voice chat. Did you get this hint only once or multiple times as Anya has reported? Please write back with your observation. Thank you, -jonathan ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO Review build
> A number of people have written in saying they tested the latest PO build. > > I am curious about what you saw for storm-1077 -- the hint for voice > chat. Did you get this hint only once or multiple times as Anya has > reported? Please write back with your observation. Unfortunately, I'd clicked the 'x' before I knew it was one of the things I should be checking out :-( Which is why I didn't comment on it. > Thank you, > > -jonathan > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting privileges -- Ima Mechanique ima.mechanique(at)blueyonder.co.uk ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] STORM-1090 : font size regression
On Mon, Mar 21, 2011 at 11:17 PM, Philippe (Merov) Bossut < me...@lindenlab.com> wrote: > We identified that moving from freetype 2.3.9 to 2.4.4 in > viewer-autobuild2010 produces smaller text (roughly 10% smaller). > I haven't dug into this at all, but I note that we're using FT_Set_Char_Size which sets the size in points (not pixels), relative to a DPI. Is it possible the default DPI changed? (72 vs 96 is the usual suspect, and at UI sizes that's often just 1 or 2 pixels different once you consider hinting) Should we be using FT_Set_Pixel_Sizes instead? ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] What's with those Build Numbers?
You may have noticed those build numbers attached to the viewer version numbers, and you might have heard some of us say "codeticket". So yes, there is a whole system behind these numbers, and it allows us to track precisely what is included in every build and where the changes came from. The "codeticket" tool is documented on the public wiki at http://wiki.secondlife.com/wiki/Codeticket_Service and contains some screen shots of the tool in use. As we move to autobuild, this system will receive a lot more exposure, as the relationship between the various libraries and the actual viewer build is captured in the tool. -- cg ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-1097) Empty floater created upon docking Places side panel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/219/ --- Review request for Viewer. Summary --- Fixed opening a floater containing a detached side bar tab. This addresses bug STORM-1097. http://jira.secondlife.com/browse/STORM-1097 Diffs - indra/newview/llsidetray.cpp a8639217816b Diff: http://codereview.secondlife.com/r/219/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-1097) Empty floater created upon docking Places side panel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/219/#review490 --- Ship it! Fine. :-) - Vadim On March 22, 2011, 2 p.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/219/ > --- > > (Updated March 22, 2011, 2 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed opening a floater containing a detached side bar tab. > > > This addresses bug STORM-1097. > http://jira.secondlife.com/browse/STORM-1097 > > > Diffs > - > > indra/newview/llsidetray.cpp a8639217816b > > Diff: http://codereview.secondlife.com/r/219/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: more fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/222/ --- Review request for Viewer. Summary --- additional fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *) This fix https://bitbucket.org/BaoLinden/viewer-development-storm-973/changeset/a4a06cbeb360 has to be merged together with https://bitbucket.org/BaoLinden/viewer-development-storm-973/changeset/247b4c659e7f This addresses bug STORM-973. http://jira.secondlife.com/browse/STORM-973 Diffs - Diff: http://codereview.secondlife.com/r/222/diff Testing --- Thanks, Xiaohong ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] STORM-1090 : font size regression
Hi, I received a very good hint from Ov Dos about this font rendering issue: http://lists.nongnu.org/archive/html/freetype/2011-03/msg00010.html I tried using FT_LOAD_FORCE_AUTOHINT (only 1 call to change in LLFontFreetype::renderGlyph()) and it appears to fix the problem. *However*, I'm experiencing catastrophic freeze (no crash but the whole Mac is locked, hard reboot only option) on log in or TP and a terrible frame rate when I manage to log in. I can't see the relationship between that glyph rendering change and logging in on a region and the SecondLife.log doesn't give much hint except for an inordinate amount of: WARNING: isFeatureAvailable: Feature RenderDeferred not on feature list! Question: Has anyone tried FT_LOAD_FORCE_AUTOHINT on other platform than Mac? Result? Cheers, - Merov On Mon, Mar 21, 2011 at 11:17 PM, Philippe (Merov) Bossut < me...@lindenlab.com> wrote: > Hi, > > We identified that moving from freetype 2.3.9 to 2.4.4 in > viewer-autobuild2010 produces smaller text (roughly 10% smaller). > > Looking into this this afternoon, I was able to narrow it down to > LLFontFreetype::addGlyphFromFont(): tracing the glypth width and height in > LLFontFreetype::addGlyphFromFont(), one can see that 2.4 sizes are almost > always 1 pixel smaller in height and sometimes width than the same glyph > renderer with 2.3. 1 pixel on a 10 pixel high bitmap explains why moving the > UI sixe rendering to 1.1 in preferences sort of compensate the problem. > > The underlying issue as to where this rendering difference comes from is > unclear. Searching the freetype release notes since 2.3.9 doesn't point to > anything particularly relevant to this. Diffing freetype.h and ftimage.h is > not bringing any useful information either, or at least, I haven't found > any. > > If someone has any light to shed on this freetype issue, it would be very > much appreciated. > > For the moment, the plan of record is to downgrade freetype to 2.3.9 > though, clearly, this is not the best solution. > > Cheers, > > - Merov > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] STORM-1090 : font size regression
Hi again, Scratch that. I tried on Windows and things work just perfectly: correct font size, great FPS, no crash or freeze. On Mac though, I've problems with or without the font hack... So my persistent crash issue has nothing to do with fonts but, probably, with something else in that branch (one of the newly built lib for Mac?) Still searching... - Merov On Tue, Mar 22, 2011 at 4:44 PM, Philippe (Merov) Bossut < me...@lindenlab.com> wrote: > Hi, > > I received a very good hint from Ov Dos about this font rendering issue: > http://lists.nongnu.org/archive/html/freetype/2011-03/msg00010.html > > I tried using FT_LOAD_FORCE_AUTOHINT (only 1 call to change in > LLFontFreetype::renderGlyph()) and it appears to fix the problem. *However*, > I'm experiencing catastrophic freeze (no crash but the whole Mac is locked, > hard reboot only option) on log in or TP and a terrible frame rate when I > manage to log in. I can't see the relationship between that glyph rendering > change and logging in on a region and the SecondLife.log doesn't give much > hint except for an inordinate amount of: > WARNING: isFeatureAvailable: Feature RenderDeferred not on feature > list! > > Question: Has anyone tried FT_LOAD_FORCE_AUTOHINT on other platform than > Mac? Result? > > Cheers, > - Merov > > On Mon, Mar 21, 2011 at 11:17 PM, Philippe (Merov) Bossut < > me...@lindenlab.com> wrote: > >> Hi, >> >> We identified that moving from freetype 2.3.9 to 2.4.4 in >> viewer-autobuild2010 produces smaller text (roughly 10% smaller). >> >> Looking into this this afternoon, I was able to narrow it down to >> LLFontFreetype::addGlyphFromFont(): tracing the glypth width and height in >> LLFontFreetype::addGlyphFromFont(), one can see that 2.4 sizes are almost >> always 1 pixel smaller in height and sometimes width than the same glyph >> renderer with 2.3. 1 pixel on a 10 pixel high bitmap explains why moving the >> UI sixe rendering to 1.1 in preferences sort of compensate the problem. >> >> The underlying issue as to where this rendering difference comes from is >> unclear. Searching the freetype release notes since 2.3.9 doesn't point to >> anything particularly relevant to this. Diffing freetype.h and ftimage.h is >> not bringing any useful information either, or at least, I haven't found >> any. >> >> If someone has any light to shed on this freetype issue, it would be very >> much appreciated. >> >> For the moment, the plan of record is to downgrade freetype to 2.3.9 >> though, clearly, this is not the best solution. >> >> Cheers, >> >> - Merov >> >> > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: more fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/222/#review491 --- While we can view the diff on bitbucket, please upload it here, too, so we can easily discuss aspects of it. - Boroondas On March 22, 2011, 3:58 p.m., Xiaohong Bao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/222/ > --- > > (Updated March 22, 2011, 3:58 p.m.) > > > Review request for Viewer. > > > Summary > --- > > additional fix for STORM-973: [crashhunters] crash at > LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *) > > This fix > https://bitbucket.org/BaoLinden/viewer-development-storm-973/changeset/a4a06cbeb360 > has to be merged together with > https://bitbucket.org/BaoLinden/viewer-development-storm-973/changeset/247b4c659e7f > > > This addresses bug STORM-973. > http://jira.secondlife.com/browse/STORM-973 > > > Diffs > - > > > Diff: http://codereview.secondlife.com/r/222/diff > > > Testing > --- > > > Thanks, > > Xiaohong > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] STORM-1090 : font size regression
Seems good to go, I used 2.4.4 and this FT_LOAD_FORCE_AUTOHINT in the call and it worked. win7/64 bit. From: Philippe (Merov) Bossut To: opensource-dev@lists.secondlife.com Sent: Tue, March 22, 2011 6:44:20 PM Subject: Re: [opensource-dev] STORM-1090 : font size regression Hi, I received a very good hint from Ov Dos about this font rendering issue: http://lists.nongnu.org/archive/html/freetype/2011-03/msg00010.html I tried using FT_LOAD_FORCE_AUTOHINT (only 1 call to change in LLFontFreetype::renderGlyph()) and it appears to fix the problem. *However*, I'm experiencing catastrophic freeze (no crash but the whole Mac is locked, hard reboot only option) on log in or TP and a terrible frame rate when I manage to log in. I can't see the relationship between that glyph rendering change and logging in on a region and the SecondLife.log doesn't give much hint except for an inordinate amount of: WARNING: isFeatureAvailable: Feature RenderDeferred not on feature list! Question: Has anyone tried FT_LOAD_FORCE_AUTOHINT on other platform than Mac? Result? Cheers, - Merov On Mon, Mar 21, 2011 at 11:17 PM, Philippe (Merov) Bossut wrote: Hi, > >We identified that moving from freetype 2.3.9 to 2.4.4 in viewer-autobuild2010 >produces smaller text (roughly 10% smaller). > >Looking into this this afternoon, I was able to narrow it down to >LLFontFreetype::addGlyphFromFont(): tracing the glypth width and height in >LLFontFreetype::addGlyphFromFont(), one can see that 2.4 sizes are almost >always 1 pixel smaller in height and sometimes width than the same glyph >renderer with 2.3. 1 pixel on a 10 pixel high bitmap explains why moving the >UI >sixe rendering to 1.1 in preferences sort of compensate the problem. >The underlying issue as to where this rendering difference comes from is >unclear. Searching the freetype release notes since 2.3.9 doesn't point to >anything particularly relevant to this. Diffing freetype.h and ftimage.h is >not >bringing any useful information either, or at least, I haven't found any. >If someone has any light to shed on this freetype issue, it would be very much >appreciated. >For the moment, the plan of record is to downgrade freetype to 2.3.9 though, >clearly, this is not the best solution. >Cheers, >- Merov > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
