Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

2011-03-15 Thread Seth ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---

(Updated March 15, 2011, 9:21 a.m.)


Review request for Viewer.


Changes
---

Fixed a bug in previous patch version.


Summary
---

Fixed "More" link being toggled in expandable textbox after reshaping.


This addresses bug STORM-250.
http://jira.secondlife.com/browse/STORM-250


Diffs (updated)
-

  indra/newview/llexpandabletextbox.h b761ed94eb26 
  indra/newview/llexpandabletextbox.cpp b761ed94eb26 

Diff: http://codereview.secondlife.com/r/198/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Monday, March 14

2011-03-15 Thread Anya Kanevsky 
 Sprint 12, ends 03.21.11 Monday, March 14 General Notes
--

   - MMOTD: Merov -> Oz

Team Status
--
 Merov Linden
--

*PAST*

   - MM : Pushes 5 fixes to viewer-development, created a PO build for a new
   set of fixes, had to create hg repos for 2 of them, reviewed all code that
   needed review and triaged some reopened bugs
   - STORM-1023 : fmod : modify Copy3rdPartyLibs.cmake, passes cmake
   building now but fails linking, needs to look deeper in that.

*FUTURE*

   - MM: pass the baton to Oz
   - STORM-1023 : fmod : modify Copy3rdPartyLibs.cmake to make the path
   specification work on Windows
   - Whatever needs to be done to finish viewer-autobuild

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Open Development User Group
   - lots of process work
   - merged back changes from 2.5.2 candidate to viewer-development

*FUTURE*

   - autobuild branches merges
   - beta candidate merges?

*IMPEDIMENTS*

   - none

Bao Linden
--

   - OOO

Grumpity ProductEngine
--

*PAST*

   - requested jira update in VWR - New Feature
   - reviewed with Oz - VWR-25112, STORM-496, STORM-1060, VWR-9236
  - need to follow up in jira
   - crashhunting
   - add STORM filter to dashboard

*FUTURE*

   - review with Wolf: STORM-1065, “Voice Enabled”, STORM-1068
   - reconsider Sprint 12 backlog
   - meet with Geo
   - STORM-951
   - test PO build
   - storm-1016 with Wolf

*IMPEDIMENTS*

   - none

Paul ProductEngine
--

*PAST*

   - BUG STORM-849 ('Your voice has been muted by moderator' message doesn't
   appear if moderator mutes group chat participant)
  - Resolved as cannot reproduce
   - BUG STORM-399 (Users that has chatted within chat range of the user
   in-world are not added to Recent tab)
  - Fixed and sent for review.
   - BUG STORM-659 (Viewer hangs when navigate in the Back/Fwd Teleport
   history by keyboard)
  - Fixed and sent for review.
   - BUG STORM-1030 (Main menu change: 'Me->Change Outfit' to 'Me->My
   Appearance')
  - Fixed and sent for review
   - BUG STORM-1035 (Add Search to World menu)
  - Fixed and sent for review

*FUTURE*

   - STORM-1057 ([TRUNCATION/LAYOUT] Make space larger for full strings to
   appear in the Move & View Preferences, ALL langs)
   - STORM-1066 (Top Scripts/Top Colliders filter needs to be updated for
   Display Names)

*IMPEDIMENTS*

   - Today will go home a little bit earlier. Feel bad today. Seems I've got
   a cold.

Seth ProductEngine
--

*PAST*

   - BUG (STORM-250) Unexpected "More" text appears in the About Landmark
   panel after minimizing the floater
  - Working on the problem found in the fix: the expandable text box
  does not display the text correctly after Places floater resizing.

*FUTURE*

   - BUG (STORM-250) Unexpected "More" text appears in the About Landmark
   panel after minimizing the floater
  - Estimated: 4 - 5 hours
   - BUG (STORM-380) There is a little delay in sound when gesture first
   time played
  - Estimated: 8 - 10 hours

*IMPEDIMENTS*

   - BUG (STORM-721) Information about resident is displayed incorrectly in
   mini-inspector if there are any resident or group SLURLs
  - Waiting for Richard's feedback on the review board.


 Vadim ProductEngine
--

*PAST*

   - Bug STORM-1021 (Viewer shows "L$300" instead of object IM details if
   object sends an IM from another region):
  - 
Fixed.
   - Bug STORM-971 ('Stop Tracking' after you stopped tracking in Nearby
   mini-map):
  - Took it thinking it would be an easy one, but it actually took more
  time than expected. I've got a fix, will submit it on Monday.

*FUTURE*

   - Polish and submit the STORM-971 fix.
   - Bug STORM-1016 (Crash: ctrl-shift-w hides undocked Side Bar panels if
   almost any floater is opened):
  - Re-fix according to PO feedback.

*IMPEDIMENTS*

   - What does the UsabilityStudy label mean? Source of the bug report or
   its current state?
   - Should we start working on STORM-1031 or it still needs a design
   decision?


Andrey ProductEngine
--

*PAST*

   - tested IQA-92 against Windows, Linux, and OSX
   - got familiar with Lightweight Viewer test plan
   - continued v-d regression testing

*FUTURE*

   - test IQA-93
   - v-d regression testing


*IMPEDIMENTS*

   - none

Jonathan Yap
--

*PAST*

   - Created VWR-25133 (A Display Name that is a URL is a clickable link in
   the People/Nearby panel and wrong hovertip displays.)
   - STORM-1019 (Add ability to display beacons for Media on a Prim objects)
  - Fixed beacon name display bug. Reordered beacon name displays to
  match the order they are in the beacon floater per Ardy Lay's suggestion.
  - Note to MM: a new pull from my

[opensource-dev] Review Request: a try fix and debug code for STORM-973:[crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)

2011-03-15 Thread Xiaohong Bao 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/202/
---

Review request for Viewer.


Summary
---

this is the fix including some debug code for STORM-973. The debug code will be 
removed after the fix is confirmed.


This addresses bug STORM-973.
http://jira.secondlife.com/browse/STORM-973


Diffs
-

  indra/newview/llviewertexturelist.h 27984babd61a 
  indra/newview/llviewertexturelist.cpp 27984babd61a 

Diff: http://codereview.secondlife.com/r/202/diff


Testing
---


Thanks,

Xiaohong

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs

2011-03-15 Thread Richard Nelson 


> On March 3, 2011, 11:45 a.m., Richard Nelson wrote:
> > indra/llui/lltextbase.cpp, line 604
> > 
> >
> > this will still display views that are partially outside of the visible 
> > rect
> > 
> > what you want to do iscall mDocumentView->draw() inside the block that 
> > has the clip operation and then hide the mDocumentView when calling 
> > LLUICtrl::draw.
> > 
> >
> 
> Seth ProductEngine wrote:
> The clip rect in the block with drawText() call is not enabled for the 
> editors without a scroller and even enabling it and calling 
> mDocumentView->draw() inside that block cuts off the bottom of the last 
> visible line of text (see screenshot at 
> https://jira.secondlife.com/secure/attachment/48565/clipped_text.png).
> 
> With allow_scroll="false" & clip_partial="true" settings for the editor 
> we lose one text line and if there are icons on the first line they will be 
> clipped anyway because the top of such icons exceeds the top limit of the 
> visible rect.

With allow_scroll="false" and clip_partial="true", you shouldn't lose a line of 
text, so that sounds like the bug to fix.  If icons on the first line are being 
clipped, you could increase the v_pad attribute to leave enough room, although 
the size of the icon should be accounted for in the text layout, so that is 
either another bug or related to the first bug above.

I'd strongly suggest fixing those issues instead of using your proposed fix.  
Visibility of the text and widgets embedded within the text should be handled 
in the same way if possible.

I'll let you know if I find any obvious source of these problems.


- Richard


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/#review409
---


On March 4, 2011, 10:30 a.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/169/
> ---
> 
> (Updated March 4, 2011, 10:30 a.m.)
> 
> 
> Review request for Viewer and Richard Nelson.
> 
> 
> Summary
> ---
> 
> Fixed text editor to display the embedded widgets only if they are in the 
> currently visible area of a text document.
> 
> 
> This addresses bug STORM-721.
> http://jira.secondlife.com/browse/STORM-721
> 
> 
> Diffs
> -
> 
>   indra/llui/lltextbase.cpp 767feb16f05f 
> 
> Diff: http://codereview.secondlife.com/r/169/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] A CALL FOR HHHEEELLLPPP

2011-03-15 Thread WolfPup Lowenhar 
First References:

Jira : https://jira.secondlife.com/browse/STORM-941

 

Code Snippet : http://codepad.org/9cVTMJTD

 

Now the problem:

When I compile the code I get error C2678: binary '=' : no operator found
which takes a left-hand operand of type 'const std::string' (or there is no
acceptable conversion) in reference to line 21of the code snippet. I need to
be able to force the user name in this case.

 

Here is how this case can happen:

PersonA dose not use Display Names or is on a non-Display Names viewer.

PersonB dose use Display Names and also keeps logs of all chat, Group and
P2P messages.

 

PersonA offers PersonB and inventory item after PersonA has talked to
PersonB in P2P conversation. PersonB checks their logs later to read about
item again to discover there are now two logs for the same person one log is
using the Legacy name and contains only the system message about the
inventory offer while the other log that is named using the user name
contains the conversation about that item.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges