[opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/200/ --- Review request for Viewer. Summary --- Changes: - Removed the menu from LLFloaterMap (the mini-map floater) that had conflicted with the one in the LLNetMap widget. - Fixed updating of the "Stop Tracking" menu item; moved that code out of draw() to avoid excessive updates. - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0 (BOOL is known to cause hard-to-debug side effects with values > 1 because it's essentially just an int and thus doesn't enforce any limitations on the value). Originally based on the patch by Twisted Laws: https://codereview.secondlife.com/r/133/ This addresses bug STORM-971. http://jira.secondlife.com/browse/STORM-971 Diffs - indra/newview/llfloatermap.h 439fc3a274d8 indra/newview/llfloatermap.cpp 439fc3a274d8 indra/newview/llnetmap.cpp 439fc3a274d8 indra/newview/lltracker.h 439fc3a274d8 Diff: http://codereview.secondlife.com/r/200/diff Testing --- Thanks, Vadim ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review457
---
This looks good to me and I've already made most of these changes in my own
viewer as it makes the mini-map control be more useful and able to be used
more places. One additional change I'd recommend is in
llNetMap::handleMouseDown
or you may not be able to drag the true mini-map floater around the screen.
This is to only return TRUE (or handled) when the mini-map control really is
handling the call.
BOOL LLNetMap::handleMouseDown( S32 x, S32 y, MASK mask )
{
BOOL ret = FALSE;
if (mask & MASK_SHIFT)
{
// Start panning
gFocusMgr.setMouseCapture(this);
mStartPan = mCurPan;
ret = TRUE;
}
mMouseDown.mX = x;
mMouseDown.mY = y;
return ret;
}
- Twisted
On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> ---
>
> (Updated March 14, 2011, 8:44 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
> that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
> out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
> (BOOL is known to cause hard-to-debug side effects with values > 1
> because it's essentially just an int and thus doesn't enforce
> any limitations on the value).
>
> Originally based on the patch by Twisted Laws:
> https://codereview.secondlife.com/r/133/
>
>
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
>
>
> Diffs
> -
>
> indra/newview/llfloatermap.h 439fc3a274d8
> indra/newview/llfloatermap.cpp 439fc3a274d8
> indra/newview/llnetmap.cpp 439fc3a274d8
> indra/newview/lltracker.h 439fc3a274d8
>
> Diff: http://codereview.secondlife.com/r/200/diff
>
>
> Testing
> ---
>
>
> Thanks,
>
> Vadim
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Daily Scrum Summary - Friday, March 11
Sprint 12, ends 03.21.11 Friday, March 11 General Notes -- - MMOTD: Merov - 2.5.2 is in the works to fix a bunch of crashes. Team Status -- Merov Linden -- *PAST* - MM : not much on this, Oz did the heavy lifting - Internal meeting : release process discussion, plans and triage - STORM-987 : llimage_libtest : Builds on all platforms on TC. Took comments from Vadim into account. Submitted update to RB. In review. - STORM-1073 / OPEN-44 : Use of QUIET in cmake : Checked patches build through a TC cycle, moved to STORM - OPEN-36 : COPY_IF_DIFFERENT macro : rejected patch so Boroondas can rework it - STORM-971 : "Stop tracking" in minimap : established that the patch doesn't fix the problem, rejected. - OPEN-22 : Choose local, LL or system lib : started looking into this. *FUTURE* - MM: - STORM-1023 : fmod : modify Copy3rdPartyLibs.cmake to make the path specification work on Windows - OPEN-22 : Choose local, LL or system lib : more work on that *IMPEDIMENTS* - none Oz Linden -- *PAST* - Internal process discussions - Built 2.5.2 release candidate - Open Development User Group *FUTURE* - Post wiki pointers to release candidate - Some more process issues - autobuild branches merges *IMPEDIMENTS* - none Bao Linden -- *PAST* - finished a fix for STORM-973 - a lot of meetings. *FUTURE* - OOO today and monday *IMPEDIMENTS* - none Grumpity ProductEngine -- *PAST* - Triage STORM & VWR - QA roundup & future planning - backlog & other sorting - release process discussions *FUTURE* - review with OZ - VWR-25112, STORM-496, STORM-1060, VWR-9236 - review with Wolf: STORM-1065, “Voice Enabled”, STORM-1068 - add Test Plan field to VWR New Feature - reconsider Sprint 12 backlog - crashhunting - add STORM filter to dashboard - meet with Geo *IMPEDIMENTS* - none Paul ProductEngine -- *PAST* - BUG STORM-357 (Gestures button is in the pressed state after drag-n-drop but gestures list isn't visible) - Fixed and sent for review. - BUG STORM-399 (Users that has chatted within chat range of the user in-world are not added to Recent tab) - Fixed. Some testing and if I won't find any bugs in fix will send for review. Estimate ~ 1 hour. *FUTURE* - BUG STORM-399 (Users that has chatted within chat range of the user in-world are not added to Recent tab) - Other tickets by priority *IMPEDIMENTS* - none Seth ProductEngine -- *PAST* - Experienced some hardware problems with my Linux box. - BUG (STORM-949) please remove actual usernames from XUI files - Re-checked for remaining actual usernames in XUI files. Couldn't find any in the source tree. - BUG (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater - Fixed. Fix needs review. *FUTURE* - BUG (STORM-380) There is a little delay in sound when gesture first time played - Estimated: 8 - 10 hours *IMPEDIMENTS* - BUG (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs - Waiting for Richard's feedback on the review board. Vadim ProductEngine -- *PAST* - Story STORM-326 (Persistent water/sky settings): - Published intermediate work results on a public repo. - Bug STORM-1021 (Viewer shows "L$300" instead of object IM details if object sends an IM from another region): - WIP. - Debugged a Linux build error caused by the new llimage_libtest application (STORM-987). - Code review. *FUTURE* - Finish with STORM-1021. - ETA: 2h. - Bug STORM-1016 (Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened): - Re-fix according to PO feedback. *IMPEDIMENTS* - none Andrey ProductEngine -- *PAST* - started regression cycle against v-d branch - reported issues: VWR-25114, VWR-25118, STORM-1065 - verified 7 issues *FUTURE* - proceed with regression testing of v-d *IMPEDIMENTS* - none Jonathan Yap -- *PAST* - STORM-1068 (Add optional range ring(s) to the mini-map -- one centered on you with a radius of 20m to show local chat range) - Wrote RB entry and a Test Plan. *FUTURE* *IMPEDIMENTS* - STORM - 956 - File message_template.msg needs to be pushed into viewer code tree from server code tree. Long term solution expected late March. Past ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please
Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.
> On March 14, 2011, 8:53 a.m., Twisted Laws wrote:
> > This looks good to me and I've already made most of these changes in my own
> > viewer as it makes the mini-map control be more useful and able to be used
> > more places. One additional change I'd recommend is in
> > llNetMap::handleMouseDown
> > or you may not be able to drag the true mini-map floater around the screen.
> > This is to only return TRUE (or handled) when the mini-map control really is
> > handling the call.
> >
> > BOOL LLNetMap::handleMouseDown( S32 x, S32 y, MASK mask )
> > {
> > BOOL ret = FALSE;
> > if (mask & MASK_SHIFT)
> > {
> > // Start panning
> > gFocusMgr.setMouseCapture(this);
> >
> > mStartPan = mCurPan;
> > ret = TRUE;
> > }
> > mMouseDown.mX = x;
> > mMouseDown.mY = y;
> > return ret;
> > }
> >
Twisted, I fail to see any dragging problrem with the mini-map floater. Are you
sure this change is needed?
- Vadim
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review457
---
On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> ---
>
> (Updated March 14, 2011, 8:44 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
> that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
> out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
> (BOOL is known to cause hard-to-debug side effects with values > 1
> because it's essentially just an int and thus doesn't enforce
> any limitations on the value).
>
> Originally based on the patch by Twisted Laws:
> https://codereview.secondlife.com/r/133/
>
>
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
>
>
> Diffs
> -
>
> indra/newview/llfloatermap.h 439fc3a274d8
> indra/newview/llfloatermap.cpp 439fc3a274d8
> indra/newview/llnetmap.cpp 439fc3a274d8
> indra/newview/lltracker.h 439fc3a274d8
>
> Diff: http://codereview.secondlife.com/r/200/diff
>
>
> Testing
> ---
>
>
> Thanks,
>
> Vadim
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.
> On March 14, 2011, 8:53 a.m., Twisted Laws wrote:
> > This looks good to me and I've already made most of these changes in my own
> > viewer as it makes the mini-map control be more useful and able to be used
> > more places. One additional change I'd recommend is in
> > llNetMap::handleMouseDown
> > or you may not be able to drag the true mini-map floater around the screen.
> > This is to only return TRUE (or handled) when the mini-map control really is
> > handling the call.
> >
> > BOOL LLNetMap::handleMouseDown( S32 x, S32 y, MASK mask )
> > {
> > BOOL ret = FALSE;
> > if (mask & MASK_SHIFT)
> > {
> > // Start panning
> > gFocusMgr.setMouseCapture(this);
> >
> > mStartPan = mCurPan;
> > ret = TRUE;
> > }
> > mMouseDown.mX = x;
> > mMouseDown.mY = y;
> > return ret;
> > }
> >
>
> Vadim ProductEngine wrote:
> Twisted, I fail to see any dragging problrem with the mini-map floater.
> Are you sure this change is needed?
Hmmm... maybe it was because I also removed LLFloaterMap::handleDoubleClick as
its
duplicated in LLNetMap::handleDoubleClick. I just remembered when I removed
all
the duplications that the mini-map wouldn't drag until I changed the return
from the
control (actual dragging is handled elsewhere in the class structure, llfloater
maybe).
I guess thats beyond the scope of this change tho.
- Twisted
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review457
---
On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> ---
>
> (Updated March 14, 2011, 8:44 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
> that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
> out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
> (BOOL is known to cause hard-to-debug side effects with values > 1
> because it's essentially just an int and thus doesn't enforce
> any limitations on the value).
>
> Originally based on the patch by Twisted Laws:
> https://codereview.secondlife.com/r/133/
>
>
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
>
>
> Diffs
> -
>
> indra/newview/llfloatermap.h 439fc3a274d8
> indra/newview/llfloatermap.cpp 439fc3a274d8
> indra/newview/llnetmap.cpp 439fc3a274d8
> indra/newview/lltracker.h 439fc3a274d8
>
> Diff: http://codereview.secondlife.com/r/200/diff
>
>
> Testing
> ---
>
>
> Thanks,
>
> Vadim
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.
> On March 14, 2011, 8:53 a.m., Twisted Laws wrote:
> > This looks good to me and I've already made most of these changes in my own
> > viewer as it makes the mini-map control be more useful and able to be used
> > more places. One additional change I'd recommend is in
> > llNetMap::handleMouseDown
> > or you may not be able to drag the true mini-map floater around the screen.
> > This is to only return TRUE (or handled) when the mini-map control really is
> > handling the call.
> >
> > BOOL LLNetMap::handleMouseDown( S32 x, S32 y, MASK mask )
> > {
> > BOOL ret = FALSE;
> > if (mask & MASK_SHIFT)
> > {
> > // Start panning
> > gFocusMgr.setMouseCapture(this);
> >
> > mStartPan = mCurPan;
> > ret = TRUE;
> > }
> > mMouseDown.mX = x;
> > mMouseDown.mY = y;
> > return ret;
> > }
> >
>
> Vadim ProductEngine wrote:
> Twisted, I fail to see any dragging problrem with the mini-map floater.
> Are you sure this change is needed?
>
> Twisted Laws wrote:
> Hmmm... maybe it was because I also removed
> LLFloaterMap::handleDoubleClick as its
> duplicated in LLNetMap::handleDoubleClick. I just remembered when I
> removed all
> the duplications that the mini-map wouldn't drag until I changed the
> return from the
> control (actual dragging is handled elsewhere in the class structure,
> llfloater maybe).
> I guess thats beyond the scope of this change tho.
Ok, then please approve this review request.
- Vadim
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review457
---
On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> ---
>
> (Updated March 14, 2011, 8:44 a.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
> that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
> out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
> (BOOL is known to cause hard-to-debug side effects with values > 1
> because it's essentially just an int and thus doesn't enforce
> any limitations on the value).
>
> Originally based on the patch by Twisted Laws:
> https://codereview.secondlife.com/r/133/
>
>
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
>
>
> Diffs
> -
>
> indra/newview/llfloatermap.h 439fc3a274d8
> indra/newview/llfloatermap.cpp 439fc3a274d8
> indra/newview/llnetmap.cpp 439fc3a274d8
> indra/newview/lltracker.h 439fc3a274d8
>
> Diff: http://codereview.secondlife.com/r/200/diff
>
>
> Testing
> ---
>
>
> Thanks,
>
> Vadim
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/200/#review461 --- Ship it! Looks excellent! - Twisted On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/200/ > --- > > (Updated March 14, 2011, 8:44 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Changes: > - Removed the menu from LLFloaterMap (the mini-map floater) > that had conflicted with the one in the LLNetMap widget. > - Fixed updating of the "Stop Tracking" menu item; moved that code > out of draw() to avoid excessive updates. > - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0 > (BOOL is known to cause hard-to-debug side effects with values > 1 > because it's essentially just an int and thus doesn't enforce > any limitations on the value). > > Originally based on the patch by Twisted Laws: > https://codereview.secondlife.com/r/133/ > > > This addresses bug STORM-971. > http://jira.secondlife.com/browse/STORM-971 > > > Diffs > - > > indra/newview/llfloatermap.h 439fc3a274d8 > indra/newview/llfloatermap.cpp 439fc3a274d8 > indra/newview/llnetmap.cpp 439fc3a274d8 > indra/newview/lltracker.h 439fc3a274d8 > > Diff: http://codereview.secondlife.com/r/200/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: Use of local packaged FMOD libs in viewer-autobuild
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/201/ --- Review request for Viewer. Summary --- This changes allows a local fmod package (created using 2p-fmod) to be used to build viewer-autobuild. It allows also local paths to be specified as an alternative though that option doesn't work for Windows due to further complications in manifest and libraries being copied around. LLKDU.cmake has also be modified to use the same logic as fmod since it could be in the same category (assuming a TPV dev has a local kdu package and wants to build with USE_KDU). The Prebuilt.cmake change is a simple refactorization no-op, making the code more clear: the USE_PROPRIETARY "if/else" code differences related to scp where commented out. This addresses bugs STORM-1022 and STORM-1023. http://jira.secondlife.com/browse/STORM-1022 http://jira.secondlife.com/browse/STORM-1023 Diffs - indra/cmake/FMOD.cmake c9556a1645f3 indra/cmake/FindFMOD.cmake c9556a1645f3 indra/cmake/LLKDU.cmake c9556a1645f3 indra/cmake/Prebuilt.cmake c9556a1645f3 indra/newview/CMakeLists.txt c9556a1645f3 Diff: http://codereview.secondlife.com/r/201/diff Testing --- Build commands tested (use autobuild.cmd on Windows): - autobuild configure -c OpenSourceRelWithDebInfo : Builds on both Mac and Windows, builds a viewer with no sound capability - autobuild configure -c OpenSourceRelWithDebInfo -- -DFMOD:BOOL=ON -DFMOD_LIBRARY:PATH= -DFMOD_INCLUDE_DIR : BuildsWorks on Mac but not on Windows. - autobuild configure -c OpenSourceRelWithDebInfo -- -DFMOD:BOOL=ON: Builds on both Mac and Windows if path to fmod package in autobuild.xml is changed to point to a local file:///.tar.gz Linux builds: not tested Thanks, Merov ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] PO Test Build (223545)
Erin, STORM-357: please elaborate. seems to work perfectly for me. thanks! anya 2011/3/12 Erin Mallory > storm- 28: seems to work okay > storm-357: fail > Storm-399: fail object names do not seem to work properly if DN is on > storm-1019: fail: see ardy's comments > storm-1021: seems to work so far > storm-1064: seems alright... > > > > ___ > Policies and (un)subscribe information available here: > http://wiki.secondlife.com/wiki/OpenSource-Dev > Please read the policies before posting to keep unmoderated posting > privileges > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
