[opensource-dev] Range ring on mini-map -- VWR-25117

[Jonathan Welch]

Hi,

Having a range ring on the mini-map came up at a Linden User Group
meeting this week so I wrote up VWR-25117
 and did a bit of
coding.

Right now there is only 1 ring with a radius of 20m.  If you are on
more or less the same level as the green/yellow dots in your mini-map
you will see who is in chat range.

You can right click on the map to enable it (it is off by default) and
I've picked a light color so it is not too intrusive.

Comments / design suggestions in the jira are welcome.

-Jonathan
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Wednesday, March 9

[Anya Kanevsky]

 Sprint 12, ends 03.21.11 Wednesday, March 9 General Notes
--

   - MMOTD: Merov

Team Status
--
 Merov Linden
--

*PAST*

   - MM : pulled 8 issues in
   - Attended Viewer triage
   - Hosted "Viewer Coding and Design" IW meeting
   - STORM-987 : llimage_libtest: added --logmetrics and
   --analyzeperformance arguments, posted first draft of doc on wiki (
   https://wiki.secondlife.com/wiki/Llimage_libtest)

*FUTURE*

   - MM:
   - STORM-1023 : fmod : modify Copy3rdPartyLibs.cmake to make the path
   specification work on Windows
   - STORM-987 : llimage_libtest: Add image stats output

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Internal process discussions
   - Viewer Evolution User Group
   - Looked at STORM-941 with Wolfpup
   - Got new icons for test (developer), development, project, and beta
   viewers [XD-29]

*FUTURE*

   - Autobuild integration and testing
   - follow up on STORM-941
   - Next release discussions
   - TPV surfing

*IMPEDIMENTS*

   - none

Bao Linden
--

*PAST*

   - fixed STORM-1052, STORM-1053, STORM-1049
   - worked on STORM-973

*FUTURE*

   - continue on STORM-973, STORM-948
   - may ask ooo for a while.

*IMPEDIMENTS*

   - none


Grumpity ProductEngine
--

*PAST*

   - triage VWR
   - triage unscheduled issues in STORM.

*FUTURE*

   - review fixes reopened by QA
   - Wolf - review STORM-323
   - review new PO build
   - meet with Geo

*IMPEDIMENTS*

   - none

Paul ProductEngine
--

*PAST*

   - BUG STORM-357 (Gestures button is in the pressed state after
   drag-n-drop but gestures list isn't visible)
  - Fixed and fix is working good, but during code review Sergey advised
  to use a little bit different way. Will try tomorrow and if it won't work
  will apply my today's fix and send for review. Estimate ~ 2 hours.

*FUTURE*

   - BUG STORM-357 (Gestures button is in the pressed state after
   drag-n-drop but gestures list isn't visible)
   - BUG STORM-399 (Users that has chatted within chat range of the user
   in-world are not added to Recent tab)

*IMPEDIMENTS*

   - none


Wolfpup Lowenhar
--

*PAST*

   - RL work.
   - Trying to earn $L's inworld.
   - OPEN-37 : finally got a full build with working viewer but had to
   restart build process once do to other issues in build system timing.
   - STORM-941 : Had meeting with Oz discussing the possible causes and he
   said he is going to bug Leyla to get a response from her about what was
   discussed.
   - STORM-1023 : work on my system using file:/// method.

*FUTURE*

   - RL work.
   - Trying to earn $L's inworld.
   - OPEN-37 : Work more on this to get it working better so that the build
   time reduces as it takes 3.5 hours to do a full build with at least one
   restart due to timing issues in the msbuild system its self.

*IMPEDIMENTS*

   - OPEN-37 : getting VS2010 autobuild environment to work proplery on my
   system Vs2005 autobuild works just fine.
   - May need to upgrade personal system(CPU, System Board, and Memory) to
   work better with autobuid system.(hopes do not have to do this as would
   prefer to not switch

Cummere Mayo
--

*PAST*

   - jira
   - derby
   - privacy stuff

*FUTURE*

   - jira
   - privacy stuff

*IMPEDIMENTS*

   - twisted/steam hunts
   - privacy stuff
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

[Vadim ProductEngine]

> On March 7, 2011, 10:31 p.m., Merov Linden wrote:
> > I like the intent. In the code though, I don't really understand why the 
> > EC_NOT_SPECIFIED case is treated differently than other error messages. I 
> > fail to understand why this needs a "custom" message (in the panel xml 
> > instead of strings.xml) and why having it in the panel xml has any 
> > advantage.
> 
> Vadim ProductEngine wrote:
> It's because the XUI preview tool and script editing provide different 
> ways to specify external editor.
> 
> Script editing: ExternalEditor setting, which can be overriden with 
> LL_SCRIPT_EDITOR environment variable.
> 
> XUI preview tool: ExternalEditor settings, which can be overriden with 
> LL_XUI_EDITOR that, in turn, is overridable with the Editor Path input field 
> of the floater.
> 
> Thus we need different warning messages for the two cases.
> 
> Merov Linden wrote:
> I see. I understand the need for the 2 different warning messages. Still, 
> the implementation is rather inelegant:
> - LLExternalEditor::getErrorMessage(LLExternalEditor::EC_NOT_SPECIFIED) 
> though specified is actually never used
> - the whole "if / else" switch to extract the message string in 
> indra/newview/llfloateruipreview.cpp is actually useless since 
> ExternalEditorNotSet is used
> - the string ExternalEditorNotSet is defined twice (once in 
> en/floater_ui_preview.xml and once in en/strings.xml)
> 
> It just feels like lots of code to just get an error message from an 
> error status.
> 
> I'd rather create an additional error for preview 
> (EC_NOT_SPECIFIED_PREVIEW) and overwritte the status in the preview tool 
> using something like:
> status = (status == LLExternalEditor::EC_NOT_SPECIFIED ? 
> LLExternalEditor::EC_NOT_SPECIFIED_PREVIEW : status);
> 
> Then put all the messages in one place, use one call to get the msg from 
> the status and avoid all this "if / else" on message extracting.
>

1. Right, the getErrorMessage() is never called with EC_NOT_SPECIFIED. I just 
added a generic error message for consistency.
2. The if/else statement isn't useless because LLPanel::getString() and 
LLTrans::getString() actually look up the string in different files: the 
panel/floater XML and strings.xml respectively.
3. Yes, the "not specified" messages have similar keys in strings.xml and in 
floater_ui_preview.xml, but is as harmless as having similarly named 
local variables in different methods. However I can change the name if you find 
it confusing.

I agree that the code implementing custom messages is not very elegant, but I'd 
still prefer it to embedding caller-specific error codes to the generic 
LLExternalEditor class.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/179/#review432
---


On March 7, 2011, 9:16 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/179/
> ---
> 
> (Updated March 7, 2011, 9:16 a.m.)
> 
> 
> Review request for Viewer and Seth ProductEngine.
> 
> 
> Summary
> ---
> 
> Let the user know what's wrong with external editor.
> 
> Added meaningful messages for the following errors:
> * Editor not specified.
> * Error parsing command line.
> * Specified binary not found.
> * Editor failed to run.
> 
> All the messages are translatable.
> 
> 
> This addresses bug STORM-1018.
> http://jira.secondlife.com/browse/STORM-1018
> 
> 
> Diffs
> -
> 
>   indra/newview/llexternaleditor.h ef2df52563bb 
>   indra/newview/llexternaleditor.cpp ef2df52563bb 
>   indra/newview/llfloateruipreview.cpp ef2df52563bb 
>   indra/newview/llpreviewscript.cpp ef2df52563bb 
>   indra/newview/skins/default/xui/en/floater_ui_preview.xml ef2df52563bb 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml ef2df52563bb 
>   indra/newview/skins/default/xui/en/strings.xml ef2df52563bb 
> 
> Diff: http://codereview.secondlife.com/r/179/diff
> 
> 
> Testing
> ---
> 
> Test cases:
> 1. Use a path containing spaces without enclosing it with double quotes 
> (/path to/editor).
>Expected: the "not found" message.
> 2. Specify empty path ().
>Expected: the "not found" message.
> 3. Try using an odd number of double quotes ("/path to/editor "%s").
>Expected: the "parse error" message.
> 4. Specifying a nonexistent editor (/non/existent/editor).
>Expected: the "not found" message.
> 5. Specify a valid editor path (/usr/bin/editor).
>Expected: the editor is executed.
> 
> The command can be specified with the ExternalEditor debug setting or an 
> environment variable: LL_SCRIPT_EDITOR for script editor and LL_XUI_EDITOR 
> for the XUI preview tool. I

[opensource-dev] VWR-25120 - viewer_manifest.py has incorrect case for "Rez" command on case-sensitive Macs

[Ricky]

As I've again found a few more moments to try compiling the viewer
again, this time on my Mac, I ran across an issue that was trivial to
take care of: incorrect command name case on the Apple-specific
command "Rez".
Here's the link: https://jira.secondlife.com/browse/VWR-25120

Ricky
Cron Stardust
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Corrected a call to the Mac-specific command "Rez" that had the wrong case.

[Cron Stardust]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/196/
---

Review request for Viewer.


Summary
---

Simple change from a lower-case "r" to an upper case "R" in the run_command 
call to the Rez command.

Should have no effect on case-insensitive Macs.  As this is, I believe, a 
Mac-specific command call, there should be no effect on other OSs.


This addresses bug VWR-25120.
http://jira.secondlife.com/browse/VWR-25120


Diffs
-

  doc/contributions.txt aed94e854443 
  indra/newview/viewer_manifest.py aed94e854443 

Diff: http://codereview.secondlife.com/r/196/diff


Testing
---

Built using a case-sensitive root partition on Mac OS 10.6


Thanks,

Cron

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/197/
---

Review request for Viewer.


Summary
---

Add optional range ring to the mini-map -- one centered on you with a radius of 
20m to show local chat range.

By default the range ring is off.

To turn it on you right click on the mini-map and pick the menu entry "Range 
Ring".


This addresses bug Storm-1068.
http://jira.secondlife.com/browse/Storm-1068


Diffs
-

  doc/contributions.txt aed94e854443 
  indra/newview/app_settings/settings.xml aed94e854443 
  indra/newview/llnetmap.cpp aed94e854443 
  indra/newview/skins/default/colors.xml aed94e854443 
  indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 

Diff: http://codereview.secondlife.com/r/197/diff


Testing
---

Tested with another avatar.  When they are outside the ring they cannot see my 
local chat and when they are inside it they can, so the ring's radius is set 
correctly.

Flew over various types of land to make sure my color choice (blue @10%) was 
always visible.

Enabled range ring, logged out and back on; range ring is still present on 
mini-map.

Panned mini-map, range ring remains centered over avatar.

Used mouse wheel to zoom in and out as far as possible.  Size of range ring 
varied with change in zoom level.


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/133/#review442
---



indra/newview/llnetmap.cpp


Why is a 0 (or in some other places of the code, a NULL) being passed here? 
 It seems the definition of isTracking() does nothing with this and it could be 
eliminated from the definition in the .h file and the code that calls it.


- Jonathan


On Feb. 3, 2011, 12:43 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/133/
> ---
> 
> (Updated Feb. 3, 2011, 12:43 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Sets "Stop Tracking" enabled based on tracking if true or false instead of 
> only when true.  Also made it check for menu pointer validity to remove a 
> remote crash possiblity.
> 
> 
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -
> 
>   indra/newview/llnetmap.cpp ec4a9fd30688 
> 
> Diff: http://codereview.secondlife.com/r/133/diff
> 
> 
> Testing
> ---
> 
> My testing was to open the side panel nearby, and verify that the state of 
> the menu was correct when tracking by the different methods and disabled.   
> Then leaving that open, openned a mini-map instance and repeated testing its 
> state tracking and not.  Also tried the reverse. Verified that every 
> possibility I could think of, the state of both menus was always correct.  
> 
> Correct state is Stop Tracking is enabled anytime tracking is on for avatars 
> or landmarks and is not enabled when Tracking has been stopped no matter 
> where you stopped tracking (i.e, clicking on red arrow in view window, and 
> using the various menues).
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

[Twisted Laws]

> On March 10, 2011, 2:57 p.m., Jonathan Yap wrote:
> > indra/newview/llnetmap.cpp, line 514
> > 
> >
> > Why is a 0 (or in some other places of the code, a NULL) being passed 
> > here?  It seems the definition of isTracking() does nothing with this and 
> > it could be eliminated from the definition in the .h file and the code that 
> > calls it.

it would have been beyond the scope of the change to have modified that.  just 
following the style of existing code.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/133/#review442
---


On Feb. 3, 2011, 12:43 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/133/
> ---
> 
> (Updated Feb. 3, 2011, 12:43 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Sets "Stop Tracking" enabled based on tracking if true or false instead of 
> only when true.  Also made it check for menu pointer validity to remove a 
> remote crash possiblity.
> 
> 
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -
> 
>   indra/newview/llnetmap.cpp ec4a9fd30688 
> 
> Diff: http://codereview.secondlife.com/r/133/diff
> 
> 
> Testing
> ---
> 
> My testing was to open the side panel nearby, and verify that the state of 
> the menu was correct when tracking by the different methods and disabled.   
> Then leaving that open, openned a mini-map instance and repeated testing its 
> state tracking and not.  Also tried the reverse. Verified that every 
> possibility I could think of, the state of both menus was always correct.  
> 
> Correct state is Stop Tracking is enabled anytime tracking is on for avatars 
> or landmarks and is not enabled when Tracking has been stopped no matter 
> where you stopped tracking (i.e, clicking on red arrow in view window, and 
> using the various menues).
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

[Ibrew Meads]

Would'nt it be better to put the color and alpha in a debug value?
On Mar 10, 2011 2:29 PM, "Jonathan Yap"  wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/197/
> ---
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> Add optional range ring to the mini-map -- one centered on you with a
radius of 20m to show local chat range.
>
> By default the range ring is off.
>
> To turn it on you right click on the mini-map and pick the menu entry
"Range Ring".
>
>
> This addresses bug Storm-1068.
> http://jira.secondlife.com/browse/Storm-1068
>
>
> Diffs
> -
>
> doc/contributions.txt aed94e854443
> indra/newview/app_settings/settings.xml aed94e854443
> indra/newview/llnetmap.cpp aed94e854443
> indra/newview/skins/default/colors.xml aed94e854443
> indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443
>
> Diff: http://codereview.secondlife.com/r/197/diff
>
>
> Testing
> ---
>
> Tested with another avatar. When they are outside the ring they cannot see
my local chat and when they are inside it they can, so the ring's radius is
set correctly.
>
> Flew over various types of land to make sure my color choice (blue @10%)
was always visible.
>
> Enabled range ring, logged out and back on; range ring is still present on
mini-map.
>
> Panned mini-map, range ring remains centered over avatar.
>
> Used mouse wheel to zoom in and out as far as possible. Size of range ring
varied with change in zoom level.
>
>
> Thanks,
>
> Jonathan
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---

Review request for Viewer.


Summary
---

Fixed "More" link being toggled in expandable textbox after reshaping.


This addresses bug STORM-250.
http://jira.secondlife.com/browse/STORM-250


Diffs
-

  indra/newview/llexpandabletextbox.h aed94e854443 
  indra/newview/llexpandabletextbox.cpp aed94e854443 

Diff: http://codereview.secondlife.com/r/198/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Thursday, March 10

[Anya Kanevsky]

 Sprint 12, ends 03.21.11 Thursday, March 10 General Notes
--

   - MMOTD: Merov
   - 2.5.2 is in the works to fix a bunch of crashes.

Team Status
--
 Merov Linden
--

*PAST*

   - MM : pulled 3 issues in, code reviews, worked on related release
   management issues
   - STORM-987 : llimage_libtest: added --image-stats argument, cleaned up
   argument passing code, fixed wiki doc, posted to RB, submitted for review. I
   got to a point I have all the data I need from this tool so will wrap that
   up and move to STORM-746.
   - Internal meeting

*FUTURE*

   - MM:
   - Triage and act on JIRAs related to viewer-autobuild
   - STORM-1023 : fmod : modify Copy3rdPartyLibs.cmake to make the path
   specification work on Windows
   - STORM-987 : llimage_libtest: Test that it builds on all platforms

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Internal process discussions
   - followed up on STORM-941
   - Open Development User Group

*FUTURE*

   - Pull together patch release for some crashes
   - Some more process issues

*IMPEDIMENTS*

   - none

Bao Linden
--

*PAST*

   - worked on STORM-973
   - ooo for babysitting
   - learn repo structure and code merging process in snowstorm

*FUTURE*

   - continue on STORM-973
   - ooo for several hours.

*IMPEDIMENTS*

   - none


Grumpity ProductEngine
--

*PAST*

   - reviewed fixes reopened by QA, closed one
   - reviewed outstanding items with Wolf
   - reviewed PO build, rejected 1 issue

*FUTURE*

   - triages
   - reconsider Sprint 12 backlog
   - QA roundup
   - meet with Geo

*IMPEDIMENTS*

   - none

Paul ProductEngine
--

*PAST*

   - BUG STORM-357 (Gestures button is in the pressed state after
   drag-n-drop but gestures list isn't visible)
  - Fixed and sent for review.
   - BUG STORM-399 (Users that has chatted within chat range of the user
   in-world are not added to Recent tab)
  - Fixed. Some testing and if I won't find any bugs in fix will send
  for review. Estimate ~ 1 hour.

*FUTURE*

   - BUG STORM-399 (Users that has chatted within chat range of the user
   in-world are not added to Recent tab)
   - Other tickets by priority

*IMPEDIMENTS*

   - none

Seth ProductEngine
--

*PAST*

   - STORY (STORM-28) As a User, I want the ability to send my calling card
   to others.
  - Fixed a bug found in implementation.
   - BUG (STORM-250) Unexpected "More" text appears in the About Landmark
   panel after minimising the floater
  - Investigating.
   - Code review.

*FUTURE*

   - BUG (STORM-250) Unexpected "More" text appears in the About Landmark
   panel after minimising the floater
  - Estimated: 6 - 8 hours

*IMPEDIMENTS*

   - none

Andrey ProductEngine
--

*PAST*

   - integrated tickets verification:
  - Passed QA: 8 issues
  - Re-opened: STORM-236, STORM-949, STORM-28


   - continued with I18N testing
   - reported 2 issues


*FUTURE*

   - start new regression cycle against v-d branch

*IMPEDIMENTS*

   - none

Jonathan Yap
--

*PAST*

   - STORM-1064 (People sidebar panel elements have inconsistent widths and
   map is slightly too tall)
  - Done.
   - Created VWR-25117 (Add optional range ring(s) to the mini-map -- one
   centered on you with a radius of 20m to show local chat range)
  - Done. See jira for a sample image of what this looks like. Will see
  if this is something that might be taken into Storm.

*FUTURE*

*IMPEDIMENTS*

   - STORM - 956
  - File message_template.msg needs to be pushed into viewer code tree
  from server code tree. Long term solution expected late March.
   - Cannot create a test plan for a VWR New Feature items -- is this a
   known condition?
  - Is there some other field I should use instead as a work-around?


Wolfpup Lowenhar
--

*PAST*

   - RL work.
   - Trying to earn $L's inworld.
   - OPEN-37: NickyP boost files work but need to find ways to reduce build
   time, noticed that the precompiled header file is not being use will test by
   forcing flag for this on)
   - STORM-941 : Discussed with Oz in IRC some more after receiving reply
   from Leyla.( need to need to make a build with some extra logging to
   determine exact location of bug)
   - STORM-1023 : created personal Fmod tarbal and tested repository to see
   if it would pull it in this did work. will be doing a full test build as
   more testing of this.

*FUTURE*

   - RL work.
   - Trying to earn $L's inworld.
   - OPEN-37: Run more local tests using NickyP's boost files

*IMPEDIMENTS*

   - getting VS2010 autobuild environment to work on my system Vs2005
   autobuild works just fine.
   - HDD that I do my coding work on is starting to give failure noticed
   need to back u

Re: [opensource-dev] Review Request: STORM-987 : llimage_libtest : create an independent executable to exercise llimage outside the viewer

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/195/
---

(Updated March 10, 2011, 10:15 p.m.)


Review request for Viewer.


Changes
---

Took Vadim's private comments into account:
- added more arguments consistency checking
- flushed perf data when done with images so that there's something in the slp 
file, even for small amount of data analyzed


Summary
---

This creates a new independent executable that exercise the entire llimage 
libray, loading and saving all supported image file formats, gathering perf 
data and outputting basic image info.

The use of the application itself is documented in the wiki: 
https://wiki.secondlife.com/wiki/Llimage_libtest

>From a code standpoint, the main things done are:
- Add a new test application in indra/integration_tests/llimage_libtest/
- Move some perf amalyzing code from indra/newview/llfasttimerview.cpp to 
indra/llcommon/llmetricperformancetester so that it can be used outside the 
newview context (as it should...)
- Small cleanup in llimage.h


This addresses bug STORM-987.
http://jira.secondlife.com/browse/STORM-987


Diffs (updated)
-

  indra/integration_tests/CMakeLists.txt 344d4c6d7d7e 
  indra/integration_tests/llimage_libtest/CMakeLists.txt PRE-CREATION 
  indra/integration_tests/llimage_libtest/llimage_libtest.h PRE-CREATION 
  indra/integration_tests/llimage_libtest/llimage_libtest.cpp PRE-CREATION 
  indra/llcommon/llmetricperformancetester.h 344d4c6d7d7e 
  indra/llcommon/llmetricperformancetester.cpp 344d4c6d7d7e 
  indra/llimage/llimage.h 344d4c6d7d7e 
  indra/llimage/llimagej2c.cpp 344d4c6d7d7e 
  indra/newview/llfasttimerview.h 344d4c6d7d7e 
  indra/newview/llfasttimerview.cpp 344d4c6d7d7e 

Diff: http://codereview.secondlife.com/r/195/diff


Testing
---

So far, testing has been done on Mac only. Tests on Windows and Linux are 
planned and will likely result in cmake tweaks here and there. We're not 
planning however to alter dramatically this code further at this point.


Thanks,

Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges