Re: [opensource-dev] Review Request: the fix for STORM-1026: Viewer crahes while trying to reset Graphics quality

2011-03-08 Thread Merov Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/180/#review434
---

Ship it!


Seems correct.

- Merov


On March 7, 2011, 9:33 p.m., Xiaohong Bao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/180/
> ---
> 
> (Updated March 7, 2011, 9:33 p.m.)
> 
> 
> Review request for Viewer and Merov Linden.
> 
> 
> Summary
> ---
> 
> The changeset: 781a5ad220e3
> 
> 
> This addresses bug STORM-1026.
> http://jira.secondlife.com/browse/STORM-1026
> 
> 
> Diffs
> -
> 
>   indra/llrender/llvertexbuffer.cpp 767feb16f05f 
> 
> Diff: http://codereview.secondlife.com/r/180/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Xiaohong
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: fix for STORM-1046:[crashhunters] crash in LWorld::removeRegion STORM-1014: Viewer crash in LLSurface::getWaterHeight STORM-1047:[crashhunters] crash at LLViewerOb

2011-03-08 Thread Merov Linden 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/189/#review435
---

Ship it!


I reviewed the changeset and it seems correct. I'll transplant the changeset 
and do the merge. 

- Merov


On March 7, 2011, 9:30 p.m., Xiaohong Bao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/189/
> ---
> 
> (Updated March 7, 2011, 9:30 p.m.)
> 
> 
> Review request for Viewer and Merov Linden.
> 
> 
> Summary
> ---
> 
> changeset: e4c78fbe827f
> 
> Merov: sorry I can not upload the diff because the parent of this changeset 
> is still in the queue of the codereview.
> 
> 
> This addresses bugs STORM-1014, STORM-1046 and STORM-1047.
> http://jira.secondlife.com/browse/STORM-1014
> http://jira.secondlife.com/browse/STORM-1046
> http://jira.secondlife.com/browse/STORM-1047
> 
> 
> Diffs
> -
> 
> 
> Diff: http://codereview.secondlife.com/r/189/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Xiaohong
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-03-08 Thread Ima Mechanique 
> > On 2011-03-03 1:45, Philippe (Merov) Bossut wrote:
> > >
> > > Dropping privately built 3rd party libs though was always a bit of a 
> > > black art. Now that most 3rd party libs have a public repo available 
> > > at lindenlab/3p- though, you have another possibility which 
> > > is to build the package yourself and point autobuild.xml to it using a 
> > > "file:///" url (don't forget to also change the md5 hash...). 
> > > That will extract libs and includes and drop them in 
> > > build-/packages. I experimented with that in OPEN-6 and it works 
> > > fine.
> > 
> > I'd really like to some experiences from open devs trying to use this 
> > method.  Essentially, it means maintaining your own version of the 
> > autobuild configuration file (either in autobuild.xml, being careful not 
> > to include those changes in any changeset meant to be merged to 
> > viewer-development, or by using a copy and pointing to the copy either 
> > with a --config-file option to autobuild or with the 
> > AUTOBUILD_CONFIG_FILE environment variable).
> > 
> > Even if you build your own prebuilds, you probably won't need to do it 
> > very often - check them all out once, build each one, construct the 
> > packages portion of the autobuild.xml file and then copy it into any 
> > working copy you've got for doing viewer work.  The only time you should 
> > need to rebuild any of them is when a package is modified either by you 
> > or from upstream.
> 
> I spent 3-4 hours playing with this today. I started by updating local
> copies of the 3p repoes,and was encouraged to see several commits for
> VS2010 compatibility. That didn't last long though, as when I checked
> the autobuild.xml files there was nothing in them for Windows users :-(
> There are entries under platform claiming to be windows, but in reality
> all but one appear to be for cygwin only, and I'm not sure about the
> last. Cygwin really needs to be treated as a platform in its own right
> here. Otherwise when the OS community creates *real* windows
> configurations you will not be able to accept them because of a naming
> conflict.
> Not to mention it annoys Windows users to see a window entry and it
> doesn't work. ;-)
> 
> I tried using the cygwin configs, but was unable to get any of them
> working because of errors calling python scripts. Pretty sure the path
> isn't being translated back into MSDOS style. I tried the note on the
> https://wiki.secondlife.com/wiki/Autobuild page, installing the module
> and including the Script directory in path, but that didn't work either.

The note on https://wiki.secondlife.com/wiki/Autobuild about installing
autobuild in cygwin led to a total misunderstanding on my part. After
someone pointed out to me that using cygwin directly was a no-go, I
tried again with this yesterday. This time using a command prompt 
(Windows SDK 7.1, currently the latest version).

Things went somewhat better. Several of the build-cmd.sh script had a
"pass: unknown command" error, the "pass" command being at the end of
the script. Those scripts that didn't have this problem couldn't perform
a build as they use "devenv" to start building, which is not available
on VCExpress. I was able to open some of the solutions in the IDE, which
complained that parts were corrupt.  However, despite the corruption I
was able to build a few libs from within the IDE.

I intend to continue some more with this to see if I can get it working
better.

> --
> Ima Mechanique
> ima.mechanique(at)blueyonder.co.uk
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

--
Ima Mechanique
ima.mechanique(at)blueyonder.co.uk


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-03-08 Thread Ima Mechanique 
> > > On 2011-03-03 1:45, Philippe (Merov) Bossut wrote:
> > > >
> > > > Dropping privately built 3rd party libs though was always a bit of a 
> > > > black art. Now that most 3rd party libs have a public repo available 
> > > > at lindenlab/3p- though, you have another possibility which 
> > > > is to build the package yourself and point autobuild.xml to it using a 
> > > > "file:///" url (don't forget to also change the md5 hash...). 
> > > > That will extract libs and includes and drop them in 
> > > > build-/packages. I experimented with that in OPEN-6 and it works 
> > > > fine.
> > > 
> > > I'd really like to some experiences from open devs trying to use this 
> > > method.  Essentially, it means maintaining your own version of the 
> > > autobuild configuration file (either in autobuild.xml, being careful not 
> > > to include those changes in any changeset meant to be merged to 
> > > viewer-development, or by using a copy and pointing to the copy either 
> > > with a --config-file option to autobuild or with the 
> > > AUTOBUILD_CONFIG_FILE environment variable).
> > > 
> > > Even if you build your own prebuilds, you probably won't need to do it 
> > > very often - check them all out once, build each one, construct the 
> > > packages portion of the autobuild.xml file and then copy it into any 
> > > working copy you've got for doing viewer work.  The only time you should 
> > > need to rebuild any of them is when a package is modified either by you 
> > > or from upstream.
> > 
> > I spent 3-4 hours playing with this today. I started by updating local
> > copies of the 3p repoes,and was encouraged to see several commits for
> > VS2010 compatibility. That didn't last long though, as when I checked
> > the autobuild.xml files there was nothing in them for Windows users :-(
> > There are entries under platform claiming to be windows, but in reality
> > all but one appear to be for cygwin only, and I'm not sure about the
> > last. Cygwin really needs to be treated as a platform in its own right
> > here. Otherwise when the OS community creates *real* windows
> > configurations you will not be able to accept them because of a naming
> > conflict.
> > Not to mention it annoys Windows users to see a window entry and it
> > doesn't work. ;-)
> > 
> > I tried using the cygwin configs, but was unable to get any of them
> > working because of errors calling python scripts. Pretty sure the path
> > isn't being translated back into MSDOS style. I tried the note on the
> > https://wiki.secondlife.com/wiki/Autobuild page, installing the module
> > and including the Script directory in path, but that didn't work either.
> 
> The note on https://wiki.secondlife.com/wiki/Autobuild about installing
> autobuild in cygwin led to a total misunderstanding on my part. After
> someone pointed out to me that using cygwin directly was a no-go, I
> tried again with this yesterday. This time using a command prompt 
> (Windows SDK 7.1, currently the latest version).
> 
> Things went somewhat better. Several of the build-cmd.sh script had a
> "pass: unknown command" error, the "pass" command being at the end of
> the script. Those scripts that didn't have this problem couldn't perform
> a build as they use "devenv" to start building, which is not available
> on VCExpress. I was able to open some of the solutions in the IDE, which
> complained that parts were corrupt.  However, despite the corruption I
> was able to build a few libs from within the IDE.

To clarify, devenv.com is called in the
autobuild_tool_source_environment.py file.at lines 216, 233, and 235.


> I intend to continue some more with this to see if I can get it working
> better.
> 
> > --
> > Ima Mechanique
> > ima.mechanique(at)blueyonder.co.uk
> > 
> > 
> > ___
> > Policies and (un)subscribe information available here:
> > http://wiki.secondlife.com/wiki/OpenSource-Dev
> > Please read the policies before posting to keep unmoderated posting 
> > privileges
> 
> --
> Ima Mechanique
> ima.mechanique(at)blueyonder.co.uk
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

--
Ima Mechanique
ima.mechanique(at)blueyonder.co.uk


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] PO Test build (222938)

2011-03-08 Thread Erin Mallory 


* STORM-1016 : Crash: ctrl-shift-w hides undocked Side Bar panels if almost any 
floater is opened
No longer crashes the viewer...  DOES dock panels  which is annoying 

* STORM-1038 : Viewer crash in texture cache pruning on startup
not sure how to test for this? 

* STORM-1040 : Text that shows what Beacons you are viewing is always in English


haven't tested yet...  

Still in there but not yet merge since no usable feedback:
* STORM-1020 : It is sometimes necessary to press ALT+CTRL+D twice to get the 
Debug menu on the login screen
seems fixed  

* STORM-1036 : Remove the unused "How to create a new Classified ad" 
notification from XUI


seems gone but haven't been able to totally verify 


~Cummere 

  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] STORM-1038 & VWR-24337 (was: PO Test build (222938))

2011-03-08 Thread Boroondas Gupte 
On 03/08/2011 06:14 AM, Philippe (Merov) Bossut wrote:
> * STORM-1038 : Viewer crash in texture cache pruning on startup
Might be a duplicate of VWR-24337
, the fix
 of which has a "Ship it!" for
over one month now, but for some reason didn't get pulled into a test
build, yet.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

2011-03-08 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/182/#review436
---


Discarding my fix, as I didn't properly investigate the situation. See my 
comment at 
https://jira.secondlife.com/browse/OPEN-36?focusedCommentId=247669&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-247669

- Boroondas


On March 7, 2011, 4:44 p.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/182/
> ---
> 
> (Updated March 7, 2011, 4:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Searched all uses of the copy_if_different CMake macro, and where variables 
> were passed as arguments, double-quoted them.
> 
> 
> This addresses bug OPEN-36.
> http://jira.secondlife.com/browse/OPEN-36
> 
> 
> Diffs
> -
> 
>   indra/cmake/Copy3rdPartyLibs.cmake ed35dc91644b 
>   indra/copy_win_scripts/CMakeLists.txt ed35dc91644b 
>   indra/test_apps/llplugintest/CMakeLists.txt ed35dc91644b 
> 
> Diff: http://codereview.secondlife.com/r/182/diff
> 
> 
> Testing
> ---
> 
> Successfully configured with
> autobuild configure -c OpenSourceStandAloneRelWithDebInfo
> 
> (Building still fails due to unrelated issues.)
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges