Re: [opensource-dev] Review Request: STORM-680 (Avaline callers are added to the Recent list)

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/146/#review349
---

Ship it!


- Seth


On Feb. 8, 2011, 11:26 a.m., Paul ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/146/
> ---
> 
> (Updated Feb. 8, 2011, 11:26 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> - When accepting an avaline call, add a caller to the recent list as 
> AvalineListItem
> 
> - When adding item to the LLRecentPeople, check whether item with the same 
> phone number exists and delete it if exists. This is need to avoid 
> duplication in the Recent list of the panel People.
> 
> 
> This addresses bug STORM-680.
> http://jira.secondlife.com/browse/STORM-680
> 
> 
> Diffs
> -
> 
>   indra/newview/llavatarlist.h 33fc9ed99d29 
>   indra/newview/llavatarlist.cpp 33fc9ed99d29 
>   indra/newview/llrecentpeople.h 33fc9ed99d29 
>   indra/newview/llrecentpeople.cpp 33fc9ed99d29 
>   indra/newview/llvoicechannel.h 33fc9ed99d29 
>   indra/newview/llvoicechannel.cpp 33fc9ed99d29 
> 
> Diff: http://codereview.secondlife.com/r/146/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Paul
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test build

[Boroondas Gupte]

Downloaded the Linux build.

On 02/08/2011 09:15 PM, Philippe (Merov) Bossut wrote:
> - STORM-955 : Massively duplicated objects
Tested that with the long command line Aleric gave on RB. Much less
multiple occurrences than in build 219680. Remaining multiple ones are:

  2 COLLAPSED_BY_USER
  2 FTM_CREATE_OBJECT
  2 FTM_CULL_REBOUND
  2 FTM_GEO_SKY
  2 FTM_PROCESS_OBJECTS
  2 FTM_REBUILD_VBO
  2 FTM_UPDATE_WLPARAM
  2 LSCRIPTDataSize
  2 LSCRIPTStateBitField
  2 LSCRIPTTypeNames
  2 MANIPULATOR_IDS
  2 NEW_LINE
  2 PANEL_PICKS
  2 PANEL_PROFILE
  2 PREVIEW_HPAD
  2 PREVIEW_TEXTURE_HEIGHT
  2 WEARABLE_NAME_COMPARATOR
  2 simd_w97_rem
  2 simd_w97_preoff
  2 initialize_transition_table()::C.36
  2 aanscalefactor.106
  2 aanscales.105
  2 deferred_render
  2 extend_offset
  2 extend_test
  2 icon_m
  2 icon_pg
  2 icon_r
  2 sTesterName
  2 shader
  2 t_panel_group_general
  2 t_places
  3 empty_string
  3 gDirOpposite
  3 t2
  3 t_inventory
  4 r3
  5 t1
  8 OGL_TO_CFR_ROTATION
  8 r2
  8 rcsid
 10 boost::tuples::ignore
 12 r1
 52 r
804 std::__ioinit

Except for rcsid and boost::tuples::ignore, all the ones with a count of
3 or above also show in the list of remaining duplicate names /after/
the patch in Aleric's comment on RB
, so I guess
they are OK. I don't know if something should be done about rcsid and
boost::tuples::ignore.

Cheers,
Boroondas
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test build

[Anya Kanevsky]

Merov, I was running the mac build during yesterday's meeting, and just
tried it again - I don't freeze.

2011/2/8 Philippe (Merov) Bossut 

> Hi again,
>
> Has anyone tested that Mac build? I'm experiencing freeze on login with
> that version. Nothing clear in the log. Seems to happen just after launching
> SLVoice and before rendering the world (so could be related to rendering,
> GPU, etc...). All other versions of 2.6 do work fine. Only *that* build.
> Scary...
>
> I'm holding off merging those patches in case one of them is triggering the
> problem. Feedback from others testing on Mac appreciated.
>
> Cheers,
> - Merov
>
>
> On Tue, Feb 8, 2011 at 12:15 PM, Philippe (Merov) Bossut <
> me...@lindenlab.com> wrote:
>
>> Hi,
>>
>> I created a test build for a handful of JIRAs waiting for PO reviews. The
>> binaries can be found here:
>>
>> http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/220558/index.html
>>
>> The fixes this includes are:
>> - STORM-433 : Friendship offer shifted up and placed over "Second Life"
>> text
>> - STORM-601 : Colour swatches don't receive focus if click on them in
>> Preference -> Colors
>> - STORM-953 : Clarify what happens when you uncheck Allow Public Access
>> - STORM-955 : Massively duplicated objects
>> - STORM-960 : Descriptive text missing next to first checkbox in About
>> Land/Access
>>
>> Cheers,
>>  - Merov
>>
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test build

[Oz Linden (Scott Lawrence)]

On 2011-02-09 12:46, Anya Kanevsky wrote:
> Merov, I was running the mac build during yesterday's meeting, and 
> just tried it again - I don't freeze.

Me too.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test build

[Philippe (Merov) Bossut]

Hi,

On Wed, Feb 9, 2011 at 9:50 AM, Oz Linden (Scott Lawrence)  wrote:

> On 2011-02-09 12:46, Anya Kanevsky wrote:
> > Merov, I was running the mac build during yesterday's meeting, and
> > just tried it again - I don't freeze.
>
> Me too.
>
>
Thanks for the tests. It's still freezing my machine though with perfect
regularity. Local RelWithDebInfo and Release builds though do *not* freeze
so I'm thinking this has nothing to do with the code but with some settings
being used in one case and not the other.

I'm going to push the 6 changes then but will keep an eye on that. In the
meantime, if anyone is experience hard freeze on Mac (one that requires a
hard boot), please let us know here asap.

Cheers,
- Merov
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/129/
---

(Updated Feb. 9, 2011, 3:33 p.m.)


Review request for Viewer.


Changes
---

Took comments into account:
- Changed to use the #!/usr/bin/env python shebang line
- Add license info to python files that were missing one
- Reformatted some license header for consistency
- Updated wiki http://wiki.secondlife.com/wiki/Coding_standard#Python to make 
those aspects (shebang and licensing) clear


Summary
---

Simple consistency change, using "#!/usr/bin/python" in all python script.


This addresses bug STORM-937.
http://jira.secondlife.com/browse/STORM-937


Diffs (updated)
-

  indra/cmake/run_build_test.py 0ca239e469b3 
  indra/copy_win_scripts/start-client.py 0ca239e469b3 
  indra/develop.py 0ca239e469b3 
  indra/lib/python/indra/util/llperformance.py 0ca239e469b3 
  indra/lib/python/indra/util/simperf_proc_interface.py 0ca239e469b3 
  indra/lib/python/indra/util/test_win32_manifest.py 0ca239e469b3 
  indra/llmessage/tests/test_llsdmessage_peer.py 0ca239e469b3 
  indra/llmessage/tests/testrunner.py 0ca239e469b3 
  indra/newview/generate_breakpad_symbols.py 0ca239e469b3 
  indra/newview/tests/test_llxmlrpc_peer.py 0ca239e469b3 
  indra/newview/viewer_manifest.py 0ca239e469b3 
  indra/test/test_llmanifest.py 0ca239e469b3 
  scripts/build_version.py 0ca239e469b3 
  scripts/md5check.py 0ca239e469b3 
  scripts/setup-path.py 0ca239e469b3 
  scripts/template_verifier.py 0ca239e469b3 
  scripts/update_version_files.py 0ca239e469b3 

Diff: http://codereview.secondlife.com/r/129/diff


Testing
---

Pulled into a test repo and build successfully on all platforms on TC so I 
guess no bad surprise here.


Thanks,

Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Prduct/Business Lead for Snowstorm

[Hitomi Tiponi]

Is there any news on when Snowstorm will be getting a new Product/Business Lead 
(it is still listed as Esbee on the wiki) or who is dealing with such matters 
in 
the interim?

Hitomi


  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Prduct/Business Lead for Snowstorm

[Kent Quirk (Q Linden)]

On Feb 9, 2011, at 10:37 PM, Hitomi Tiponi wrote:

> Is there any news on when Snowstorm will be getting a new Product/Business 
> Lead (it is still listed as Esbee on the wiki) or who is dealing with such 
> matters in the interim?
> 

For the time being, it's me. We'll let you know when that changes. 


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: CMAKE_EXE_LINKER_FLAGS not honored when linking the viewer binary if -DLL_TESTS:BOOL=ON

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/147/
---

Review request for Viewer.


Summary
---

>From Aleric's patch:

Setting CMAKE_EXE_LINKER_FLAGS to "" because the tests "need" that is pretty 
hard measure.  Not only is it not necessary to do so, it also changes how the 
viewer is linked depending on a whether or not the tests are compiled and that 
is not good.

The reason that this was needed is that libgmock is underlinked (see 
http://wiki.mandriva.com/en/Underlinking), which is not compatible with 
-Wl,--as-needed that is being used on linux. libgmock.so.0 needs a symbol that 
is defined in libgtest.so.o, but -lgtest was not passed to the linker when 
creating libgmock.so.0:

Underlinked (no libgtest.so.o):
$ objdump -p /usr/lib/libgmock.so.0 | grep NEEDED
  NEEDED   libstdc++.so.6
  NEEDED   libm.so.6
  NEEDED   libc.so.6
  NEEDED   libgcc_s.so.1

The solution is to wrap between -Wl,--no-as-needed -lgtest -Wl,--as-needed 
causing it to be added again. This is only needed on linux, since that the only 
platform that we use -Wl,--as-needed on. Moreover, we can just set 
GOOGLEMOCK_LIBRARIES to "gmock -Wl,--no-as-needed gtest -Wl,--as-needed" since 
that is only passed to TARGET_LINK_LIBRARIES which only adds -l in front of 
'things' that don't start with '-', to allow you do pass special flags like 
this.


This addresses bug STORM-981.
http://jira.secondlife.com/browse/STORM-981


Diffs
-

  doc/contributions.txt 27dae7b01a81 
  indra/cmake/GoogleMock.cmake 27dae7b01a81 
  indra/cmake/LLAddBuildTest.cmake 27dae7b01a81 

Diff: http://codereview.secondlife.com/r/147/diff


Testing
---


Thanks,

Merov

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges